RFR: 7455: Add support for jolokia JMX service connection [v26]
Alex Macdonald
aptmac at openjdk.org
Fri Jun 14 19:34:21 UTC 2024
On Mon, 3 Jun 2024 17:42:46 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:
>> @aptmac : Marked it as ready for review. You may see from the last commits that when I tried to get test coverage it broke the regular test run. Hence I reverted back. I see you are working on that in #562 .
>
>> @skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
>
> Bah, sorry for the delay in the review. Trying to run JMC through the Eclipse IDE has been a dreadful experience the last little while, but looks to be fixed with: https://github.com/openjdk/jmc/pull/566
>
> Once that is in I should have a much better time testing out this PR.
> @aptmac I believe the comments should be addressed now.
Excellent. I'm off today but will take a look on Monday!
-------------
PR Comment: https://git.openjdk.org/jmc/pull/548#issuecomment-2168639169
More information about the jmc-dev
mailing list