RFR: 8204 : Keyboard traps in flamegraph view for search option [v4]

[Brice Dutheil]

On Fri, 1 Mar 2024 14:40:57 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8204: Keyboard traps in flamegraph view for search option
>
> application/org.openjdk.jmc.flightrecorder.flamegraph/src/main/java/org/openjdk/jmc/flightrecorder/flamegraph/views/FlamegraphSwingView.java line 603:
> 
>> 601: 		Display.getDefault().syncExec(new Runnable() {
>> 602: 			public void run() {
>> 603: 				IWorkbenchPage activePage = PlatformUI.getWorkbench().getWorkbenchWindows()[0].getActivePage();
> 
> Minor syntax nit, but I think this could be replaced with `PlatformUI.getWorkbench().getActiveWorkbenchWindow().getActivePage()`  ?

Interesting, I think Eclipse workbench allows for multiple windows (or detached one), could that be an issue for `PlatformUI.getWorkbench().getWorkbenchWindows()[0]` ?

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/554#discussion_r1509237283