RFR: 8204 : Keyboard traps in flamegraph view for search option [v4]

[Virag Purnam]

On Fri, 1 Mar 2024 14:45:46 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8204: Keyboard traps in flamegraph view for search option
>
> application/org.openjdk.jmc.flightrecorder.flamegraph/src/main/java/org/openjdk/jmc/flightrecorder/flamegraph/views/FlamegraphSwingView.java line 622:
> 
>> 620: 	 * Adding key listener to transfer focus forward or backward based on 'TAB' or 'Shift + TAB'
>> 621: 	 * 
>> 622: 	 * @param comp
> 
> This and the following 3 methods have a `@param` but no extra details, I think maybe either remove it or just add what comp is.

I have removed all `@param`

> application/org.openjdk.jmc.flightrecorder.flamegraph/src/main/java/org/openjdk/jmc/flightrecorder/flamegraph/views/FlamegraphSwingView.java line 835:
> 
>> 833: 			var fileName = fd.getFileName().toLowerCase();
>> 834: 			// FIXME: FileDialog filterIndex returns -1
>> 835: 			// (https://bugs.eclipse.org/bugs/show_bug.cgi?id=546256)
> 
> As a side note, it would be nice to see if this is still an issue. The bug mentions that it was not an Eclipse issue, but rather a gtk 3 issue from 2019.

Currently I have only Mac and Windows. We can check on Linux later. (9.1.0)

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/554#discussion_r1510246508
PR Review Comment: https://git.openjdk.org/jmc/pull/554#discussion_r1510246802