Integrated: 8204 : Keyboard traps in flamegraph view for search option

[Virag Purnam]

On Fri, 23 Feb 2024 11:03:53 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> Focus Trapped Issue. Keyboard focus is trapped in three specific scenarios mentioned below:
> 
> 1. Focus is trapped in JMC Agent Preset Manager
> 
> Select Window -> JMC Agent Preset Manager
> Click on "Import Fils..."/ "Export File" button
> Press Esc button when dialog is displayed
> Press "Tab" button for multi times
> 
> 2. Focus is trapped in Description of Template Manager
> 
> Select JVM Browser
> Start Flight Recording
> Template Manager
> Click New
> Click Edit
> Focus to Description
> 
> 3. Focus is trapped in search tool in Flame Graph  (Mostly on Windows)
> 
> Launch JDK Mission Control
> Open any JFR file
> Navigate to "Outline" tab
> In Java Application, choose "Threads"
> Move focus to search tool in Flame Graph
> 
> Solution:
> 1. PresetManagerPage.java : Setting the focus back to tableInspector.
> 2. TemplateEditPage.java : Added TraverseListener() for description field.
> 3. FlamegraphSwingView.java : Fix is not straight forward as SWT to Swing and back to SWT traversal is creating issue here. I have just implemented work around for this. I have added KeyListener() to all the swing components. Once it traverse through all the components, I am setting the Focus back to SWT.  With this there is no keyboard focus trap. 
>  
> These issues are kind of blocker with respect to accessibility. Could someone please review the changes.

This pull request has now been integrated.

Changeset: d0fb28ff
Author:    Virag Purnam <vpurnam at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/d0fb28ffb5a22fad4e33b02abfd782a5caa89ab8
Stats:     202 lines in 3 files changed: 170 ins; 15 del; 17 mod

8204: Keyboard traps in flamegraph view for search option

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/554