RFR: 7455: Add support for jolokia JMX service connection [v4]

[Alex Macdonald]

On Fri, 26 Jan 2024 13:16:07 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> Martin Skarsaune has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - JMC-7455: Ensure that jolokia version is set
>>  - JMC-7455: Fix copy paste and outdated errors in Jolokia plugin manifest
>>  - JMC-7455: Fixed whitespace of feature declaration
>>  - JMC-7455: Fix copyright notices (change year) in Jolokia plugin
>
> pom.xml line 112:
> 
>> 110: 		<spotbugs.version>4.7.3.5</spotbugs.version>
>> 111: 		<jacoco.plugin.version>0.8.7</jacoco.plugin.version>
>> 112: 		<jolokia.version>1.7.2</jolokia.version>
> 
> Wondering whether this was too high up in the chain. I was hoping to have a way to keep versions consistent among third-party and internally in plugins. Then again, due to manifests etc. there is a question on to what extent managing versions centrally is a point at all. 
> 
> When it comes to the actual version. 1.7.2 has the needed features. I should probably retest with 2.0.1 and check to what extent the 2.0 stream works well enough. Is there a way to put PR in draft mode while we test?

Just noticed this comment, there should be away to mark the PR as draft, I believe the option should be in the right-side column at the top of: https://github.com/openjdk/jmc/pull/548

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1516367742