RFR: 8202: JMC 9 release notes
Alex Macdonald
aptmac at openjdk.org
Tue Mar 12 13:49:21 UTC 2024
On Mon, 11 Mar 2024 20:37:13 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
> First draft! Please let me know what I missed. :)
Looks good! I left a couple comments inline.
I think it's a comprehensive list of features, but if you want to pad it a bit more there is the Dark Mode feature that could look nice in there, as well as the File Force Rule from https://github.com/openjdk/jmc/commit/f7ee5856528f474936b032361cc46a5ccfc6d4a7
releng/tools/org.openjdk.jmc.util.releasenotes/notes/9.0/notes.xml line 12:
> 10: several new features, enhancements, and bug fixes. This version continues to support connecting to, and parsing
> 11: JFR recordings from, OpenJDK 8u272+ and Oracle JDK 7u40+, and can open and visualize flight recordings from JDK 7
> 12: and 8. JDK Mission Control is available for Windows (x86_64), Mac OS X (ARM and x86_64), and Linux (x86_64).
The Linux part should mention ARM
releng/tools/org.openjdk.jmc.util.releasenotes/notes/9.0/notes.xml line 47:
> 45: <title>Add user configuration for local JVM refresh interval</title>
> 46: <description>
> 47: Previously the JVM Browser checked every 5000 ms [0] for new JVMs. This can now be configured.
Doesn't need the `[0]` here
releng/tools/org.openjdk.jmc.util.releasenotes/notes/9.0/notes.xml line 77:
> 75: <title>Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common</title>
> 76: <description>
> 77: There are a number of classes currently in jmc.ui.common that would be a great asset to the core distribution (and the
Since the refactoring has happened, I think the first part of this sentence should probably be put in the past tense, something like:
There were a number of classes previously in jmc.ui.common that are a great asset to the core distribution (and the third-party applications that consume jmc core libraries), and these classes now live in jmc.common.
releng/tools/org.openjdk.jmc.util.releasenotes/notes/9.0/notes.xml line 95:
> 93: <description>
> 94: The org.openjdk.jmc.flightrecorder.configuration bundle contains many classes useful for working with jfr,
> 95: and would be a great asset to have in core. Please see JMC-7307 for further information.
Maybe re-word the last part of that first sentence to something like:
s/and would be a great asset to have in core./and are now made available in core./
-------------
PR Review: https://git.openjdk.org/jmc/pull/555#pullrequestreview-1931080499
PR Review Comment: https://git.openjdk.org/jmc/pull/555#discussion_r1521475025
PR Review Comment: https://git.openjdk.org/jmc/pull/555#discussion_r1521475596
PR Review Comment: https://git.openjdk.org/jmc/pull/555#discussion_r1521479779
PR Review Comment: https://git.openjdk.org/jmc/pull/555#discussion_r1521481955
More information about the jmc-dev
mailing list