RFR: 7506: Incorrect numeric formatting of PID by JMC [v4]
Suchita Chaturvedi
schaturvedi at openjdk.org
Wed May 22 18:04:41 UTC 2024
> This PR is to fix the formatting issue of the JVM PID on JVM information screen. JVM PID attribute is received as NUMBER from JFR and hence the JMC application is treating is as number. When the number is smaller , the PID is displayed using commas and when the number is larger, its converted to exponential format. This is a long pending bug in product.
>
> As part of this PR we have introduced a new aggregator JVM_PID_ID which will contain the value of Identifier in plain text format instead of number format. This new aggregator is displayed on JVM Information page so that formatting is not applied as per NUMBER formatting rules.
>
> JVM PID before the change:
> <img width="359" alt="image" src="https://github.com/openjdk/jmc/assets/11155712/2e2a238c-8160-4bd1-8285-fb2a7a4fb85c">
>
> JVM PID after the change:
> <img width="355" alt="image" src="https://github.com/openjdk/jmc/assets/11155712/92668a9d-6053-4fa1-bcd0-7face596bc15">
>
> The issue is more prominent when the identifier value is converted to exponential.
Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
Implemented the new content type approach
Co-authored-by: Marcus Hirt <hirt at openjdk.org>
-------------
Changes:
- all: https://git.openjdk.org/jmc/pull/557/files
- new: https://git.openjdk.org/jmc/pull/557/files/43abce3a..ac80167c
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jmc&pr=557&range=03
- incr: https://webrevs.openjdk.org/?repo=jmc&pr=557&range=02-03
Stats: 78 lines in 6 files changed: 40 ins; 30 del; 8 mod
Patch: https://git.openjdk.org/jmc/pull/557.diff
Fetch: git fetch https://git.openjdk.org/jmc.git pull/557/head:pull/557
PR: https://git.openjdk.org/jmc/pull/557
More information about the jmc-dev
mailing list