RFR: 7263: JMC displaying long value in scientific notation [v4]

Alex Macdonald aptmac at openjdk.org
Thu May 23 18:44:09 UTC 2024


On Wed, 22 May 2024 17:45:34 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR addresses the formatting issue for the certificate Ids for X509 Certificate events.
>> 
>> Before the fix:
>> <img width="960" alt="image (3)" src="https://github.com/openjdk/jmc/assets/11155712/01abcc9d-7834-4587-9b51-48422953edd2">
>> 
>> After the fix:
>> <img width="960" alt="Screenshot 2024-04-01 222303" src="https://github.com/openjdk/jmc/assets/11155712/8a095e19-9022-4a15-8982-63b2dec78720">
>
> Suchita Chaturvedi has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert "Corrected the content type from Long to String for certificate Id."
>    
>    This reverts commit 4da9005c4974596eb04ac9a5833ba81a08980bcb.
>  - Revert "Adding check for jdk.X509Validation event also where certificateId exists"
>    
>    This reverts commit 8c1ee1af56bfca0d3a471349709bfd6a18560d1b.

This looks okay to me, there is a comment about changing the variable name, I believe it should be `CERTIFICATE_ID_ID` going off of similar variables.

I took a quick look at the check copyright script, if you rebase your changes on top of master then it will pass. Basically the script at the moment compares all of your changes against the upstream/master branch using a git diff, so if your branch is not up-to-date you may throw off the script with files that it already expects to have.

-------------

PR Review: https://git.openjdk.org/jmc/pull/559#pullrequestreview-2074754106


More information about the jmc-dev mailing list