RFR: 7506: Incorrect numeric formatting of PID by JMC

[Brice Dutheil]

On Tue, 28 May 2024 06:11:10 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAggregators.java line 118:
>> 
>>> 116: 	// VM Info
>>> 117: 	public static final IAggregator<String, ?> JVM_NAME = distinctAsString(VM_INFO, JdkAttributes.JVM_NAME);
>>> 118: 	public static final IAggregator<IQuantity, ?> JVM_PID = min(JdkAttributes.JVM_PID.getName(), null, VM_INFO,
>> 
>> Part of the public API. Perhaps better to deprecate?
>
> Do you mean to use @deprecated tag here instead of deleting it completely?

Yeh otherwise, this would be a breaking change for consumer of the flight recorder libraries.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/565#discussion_r1616830005