RFR: 8215: Update platform to 2024-03

Alex Macdonald aptmac at openjdk.org
Tue May 28 13:19:08 UTC 2024


On Tue, 28 May 2024 11:28:08 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Platform update.

Left a few comments, I'll give it a more in-depth look but functionally it works well.

releng/platform-definitions/pom.xml line 47:

> 45: 	</properties>
> 46: 	<modules>
> 47: 		<module>platform-definition-2024-03</module>

Should any of the older platforms be removed at this time as well? Or save that for another PR?

releng/third-party/pom.xml line 124:

> 122: 								<artifact>
> 123: 									<id>org.eclipse.jetty.ee9:jetty-ee9-servlet:${jetty.version}</id>
> 124: 								</artifact>

There's some interesting formatting going on in this file, some empty lines and incorrectly tabbing

releng/tools/org.openjdk.jmc.util.listversions/src/org/openjdk/jmc/util/listversions/ListVersions.java line 107:

> 105: 						case "org.eclipse.pde.feature.group":
> 106: 						case "org.eclipse.platform.sdk":
> 107: 						case "org.eclipse.equinox.p2.ui.sdk.scheduler":

This file will need it's license header updated

-------------

PR Review: https://git.openjdk.org/jmc/pull/566#pullrequestreview-2082760575
PR Review Comment: https://git.openjdk.org/jmc/pull/566#discussion_r1617228821
PR Review Comment: https://git.openjdk.org/jmc/pull/566#discussion_r1617227275
PR Review Comment: https://git.openjdk.org/jmc/pull/566#discussion_r1617227744


More information about the jmc-dev mailing list