RFR: 8215: Update platform to 2024-03 [v3]

Virag Purnam vpurnam at openjdk.org
Fri May 31 11:14:07 UTC 2024


On Fri, 31 May 2024 10:57:06 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

>> releng/third-party/pom.xml line 62:
>> 
>>> 60: 		<hdrhistogram.version>2.1.12</hdrhistogram.version>
>>> 61: 		<jemmy.version>2.0.0</jemmy.version>
>>> 62: 		<jetty.version>12.0.6</jetty.version>
>> 
>> This is where I think it gets a bit difficult for backwards compatibility. Because we're putting the jetty dependencies into the p2 repository, the changes to this pom affect all the platform definitions we use. So now that this is updated to use 12.0.6 and pull in the jetty ee9 dependencies (which are the 12.X.X), 2023-12/2023-09/2023-03 can't build because it's unable to find the 10.0.18 versions of the jetty-related dependencies.
>> 
>> This is where I was originally taking a look but didn't get too far, but would it be possible to use the jetty dependencies that are shipped by Eclipse instead ([link](https://download.eclipse.org/releases/2024-03/202403131000/plugins/))? And this way each platform-definition we have could just reference the same version that is shipped by that Eclipse release?
>
>> This is where I think it gets a bit difficult for backwards compatibility. Because we're putting the jetty dependencies into the p2 repository, the changes to this pom affect all the platform definitions we use. So now that this is updated to use 12.0.6 and pull in the jetty ee9 dependencies (which are the 12.X.X), 2023-12/2023-09/2023-03 can't build because it's unable to find the 10.0.18 versions of the jetty-related dependencies.
>> 
>> This is where I was originally taking a look but didn't get too far, but would it be possible to use the jetty dependencies that are shipped by Eclipse instead ([link](https://download.eclipse.org/releases/2024-03/202403131000/plugins/))? And this way each platform-definition we have could just reference the same version that is shipped by that Eclipse release?
> 
> 
> 
> For the class **WebsocketServer.java**, we need **org.eclipse.jetty.websocket.servlet (Jetty 10.0.18)** or **org.eclipse.jetty.ee9.websocket.servlet (Jetty 12.0.6)**. These are not present in https://download.eclipse.org/releases/2024-03/202403131000/plugins/.

And I think this problem was there from the beginning not only for jetty but for other libraries too. Or may be we can have separate **third-party/pom.xml** for each **target platform**.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/566#discussion_r1622266022


More information about the jmc-dev mailing list