From hirt at openjdk.org Fri Nov 1 00:41:02 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 1 Nov 2024 00:41:02 GMT Subject: RFR: 8274: Add thread counts to the Java Application page Message-ID: Added all of them, but perhaps only having active and daemon would be good enough. ------------- Commit messages: - 8274: Adding thread counts to the Java Application page Changes: https://git.openjdk.org/jmc/pull/600/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=600&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8274 Stats: 56 lines in 6 files changed: 54 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/600.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/600/head:pull/600 PR: https://git.openjdk.org/jmc/pull/600 From hirt at openjdk.org Fri Nov 1 00:56:50 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 1 Nov 2024 00:56:50 GMT Subject: RFR: 8286: Fix broken launcher Message-ID: The launcher for launching JMC from within the development environment in Eclipse is broken. Going by features and adding some additional plug-ins solve it for me. Let me know if it works better for you too. ------------- Commit messages: - 8286: Fix launcher Changes: https://git.openjdk.org/jmc/pull/601/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=601&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8286 Stats: 88 lines in 1 file changed: 19 ins; 0 del; 69 mod Patch: https://git.openjdk.org/jmc/pull/601.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/601/head:pull/601 PR: https://git.openjdk.org/jmc/pull/601 From duke at openjdk.org Fri Nov 1 08:53:47 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Fri, 1 Nov 2024 08:53:47 GMT Subject: RFR: 8261: Use test flag to skip JDP multicast tests in JolokiaTest [v2] In-Reply-To: References: Message-ID: > I just became aware that there is a new flag used to skip JDP tests. > I previously added some env checking to skip similar multicast tests for Jolokia. > Hence it would be a lot cleaner to use the new standardized mechanism for this. > Trying out whether this fixes [JMC-8261](https://bugs.openjdk.org/browse/JMC-8261) Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into use_new_test_flag_to_avoid_jolokia_discovery - Try to use new test flag to decide whether multicast is supported ------------- Changes: - all: https://git.openjdk.org/jmc/pull/588/files - new: https://git.openjdk.org/jmc/pull/588/files/9f8dd613..5b20ff65 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=588&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=588&range=00-01 Stats: 2268 lines in 291 files changed: 1716 ins; 95 del; 457 mod Patch: https://git.openjdk.org/jmc/pull/588.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/588/head:pull/588 PR: https://git.openjdk.org/jmc/pull/588 From duke at openjdk.org Fri Nov 1 09:49:08 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Fri, 1 Nov 2024 09:49:08 GMT Subject: RFR: 8261: Use test flag to skip JDP multicast tests in JolokiaTest [v3] In-Reply-To: References: Message-ID: > I just became aware that there is a new flag used to skip JDP tests. > I previously added some env checking to skip similar multicast tests for Jolokia. > Hence it would be a lot cleaner to use the new standardized mechanism for this. > Trying out whether this fixes [JMC-8261](https://bugs.openjdk.org/browse/JMC-8261) Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: JMC-8261: Spotless fix ------------- Changes: - all: https://git.openjdk.org/jmc/pull/588/files - new: https://git.openjdk.org/jmc/pull/588/files/5b20ff65..89e34aaf Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=588&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=588&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/588.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/588/head:pull/588 PR: https://git.openjdk.org/jmc/pull/588 From duke at openjdk.org Fri Nov 1 12:10:35 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Fri, 1 Nov 2024 12:10:35 GMT Subject: RFR: 8261: Use test flag to skip JDP multicast tests in JolokiaTest [v3] In-Reply-To: References: Message-ID: On Fri, 1 Nov 2024 09:49:08 GMT, Martin Skarsaune wrote: >> I just became aware that there is a new flag used to skip JDP tests. >> I previously added some env checking to skip similar multicast tests for Jolokia. >> Hence it would be a lot cleaner to use the new standardized mechanism for this. >> Trying out whether this fixes [JMC-8261](https://bugs.openjdk.org/browse/JMC-8261) > > Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: > > JMC-8261: Spotless fix Hmm, since there seems to be problems with multicast on Mac OS in the pipeline, I assumed that the flag to avoid JDP multicast tests was set in the pipeline, but I assume that that is not the case ? ------------- PR Comment: https://git.openjdk.org/jmc/pull/588#issuecomment-2451770587 From aptmac at openjdk.org Fri Nov 1 14:07:43 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Nov 2024 14:07:43 GMT Subject: RFR: 8287: Fix the JMX protocol extenders Message-ID: This PR addresses [JMC-8287](https://bugs.openjdk.org/browse/JMC-8287), in which the JMX protocol extenders were not running due to rjmx.ext not being visible by rjmx.common. This bug would have originated from the movement of rjmx code from application to core last year. Making rjmx.ext specify Fragment-Host on rjmx.common fixes the visiblity issue, and the protocol extenders both run as expected. This also fixes use-cases where plugins were expecting to have their protocols used but were failing due to the protocols not being picked up properly: org.openjdk.jmc.rjmx.common.ConnectionException caused by java.net.MalformedURLException: Unsupported protocol: ------------- Commit messages: - 8287: Fix the JMX protocol extenders Changes: https://git.openjdk.org/jmc/pull/602/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=602&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8287 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/602.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/602/head:pull/602 PR: https://git.openjdk.org/jmc/pull/602 From aptmac at openjdk.org Fri Nov 1 14:21:35 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Nov 2024 14:21:35 GMT Subject: RFR: 8286: Fix broken launcher In-Reply-To: References: Message-ID: <-dDZpZKaPuydF5YOD4MHmtaZfx72Ekto48Vjrugt788=.91c2de38-2402-4a2a-86af-d64e84899afd@github.com> On Fri, 1 Nov 2024 00:53:06 GMT, Marcus Hirt wrote: > The launcher for launching JMC from within the development environment in Eclipse is broken. Going by features and adding some additional plug-ins solve it for me. Let me know if it works better for you too. configuration/ide/eclipse/launchers/JMC-RCP.launch line 34: > 32: WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > 33: --> > 34: The presence of this line is preventing me from importing and using the launcher. Otherwise it seems to be working okay. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/601#discussion_r1825875083 From aptmac at openjdk.org Fri Nov 1 14:48:40 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Nov 2024 14:48:40 GMT Subject: RFR: 8274: Add thread counts to the Java Application page In-Reply-To: References: Message-ID: <8pxZe2Be9878bLI6ahxTNmXzf0Cy_7TRT54OqvC-7MI=.9d06bea6-57af-4434-a635-e4e699d2192e@github.com> On Fri, 1 Nov 2024 00:36:33 GMT, Marcus Hirt wrote: > Added all of them, but perhaps only having active and daemon would be good enough. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JavaApplicationPage.java line 266: > 264: this::isAttributeEnabled, UnitLookup.PERCENT.quantity(0), UnitLookup.PERCENT.quantity(100)) > 265: .ifPresent(rows::add); > 266: DataPageToolkit.buildLinesRow("Threads", "Various thread counts", allItems, true, Do you think this might be better left as not filled? At least on Linux, the filled versions aren't transparent so overlaying a couple of these new values quickly covers up whatever is behind it. And with peak and total being the 3rd and 4th options, combining those with either of the first two and it gets hard to read. example: With two enabled: ![Screenshot from 2024-11-01 10-33-11](https://github.com/user-attachments/assets/0f63615c-ac5d-4eff-8376-cb3bb8cca0a3) Peak threads covers up the first two: ![Screenshot from 2024-11-01 10-33-18](https://github.com/user-attachments/assets/f8fb4169-46a9-426b-8774-5e06e4bf171c) And then total threads covers everything: ![Screenshot from 2024-11-01 10-33-24](https://github.com/user-attachments/assets/4affba34-9b87-4820-b151-d97c132b6def) ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/600#discussion_r1825906721 From aptmac at openjdk.org Fri Nov 1 14:50:17 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Nov 2024 14:50:17 GMT Subject: RFR: 8287: Fix the JMX protocol extenders [v2] In-Reply-To: References: Message-ID: > This PR addresses [JMC-8287](https://bugs.openjdk.org/browse/JMC-8287), in which the JMX protocol extenders were not running due to rjmx.ext not being visible by rjmx.common. > > This bug would have originated from the movement of rjmx code from application to core last year. > > Making rjmx.ext specify Fragment-Host on rjmx.common fixes the visiblity issue, and the protocol extenders both run as expected. This also fixes use-cases where plugins were expecting to have their protocols used but were failing due to the protocols not being picked up properly: > > org.openjdk.jmc.rjmx.common.ConnectionException caused by java.net.MalformedURLException: Unsupported protocol: Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8287: Fix the JMX protocol extenders ------------- Changes: https://git.openjdk.org/jmc/pull/602/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=602&range=01 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/602.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/602/head:pull/602 PR: https://git.openjdk.org/jmc/pull/602 From aptmac at openjdk.org Fri Nov 1 14:50:17 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Nov 2024 14:50:17 GMT Subject: RFR: 8287: Fix the JMX protocol extenders In-Reply-To: References: Message-ID: On Fri, 1 Nov 2024 14:04:04 GMT, Alex Macdonald wrote: > This PR addresses [JMC-8287](https://bugs.openjdk.org/browse/JMC-8287), in which the JMX protocol extenders were not running due to rjmx.ext not being visible by rjmx.common. > > This bug would have originated from the movement of rjmx code from application to core last year. > > Making rjmx.ext specify Fragment-Host on rjmx.common fixes the visiblity issue, and the protocol extenders both run as expected. This also fixes use-cases where plugins were expecting to have their protocols used but were failing due to the protocols not being picked up properly: > > org.openjdk.jmc.rjmx.common.ConnectionException caused by java.net.MalformedURLException: Unsupported protocol: Forgot to bring in the latest changes that fixed the Mac spotbugs, this force rebase gets it ontop of master ------------- PR Comment: https://git.openjdk.org/jmc/pull/602#issuecomment-2451999246 From aptmac at openjdk.org Fri Nov 1 14:50:45 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Nov 2024 14:50:45 GMT Subject: RFR: 8284: Fix Jolokia discovery issues In-Reply-To: References: Message-ID: On Wed, 30 Oct 2024 18:47:30 GMT, Martin Skarsaune wrote: > This fixes two bugs with Jolokia discovery: > 1. serious : repeated discovery runs crash. Runing repeatedly in the background is the whole point > 2. more of an annoyance: the PR disables JMC agent by omitting JVM info in the descriptor (as presence is interpreted as a local JVM) > Both tested OK. There's a fix to the spotbugs config that will fix the Mac tests just an fyi ------------- PR Comment: https://git.openjdk.org/jmc/pull/597#issuecomment-2452001071 From aptmac at openjdk.org Fri Nov 1 15:05:40 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Nov 2024 15:05:40 GMT Subject: RFR: 6683: Mouse over for Event Thread should show the various thread IDs In-Reply-To: References: Message-ID: On Fri, 18 Oct 2024 09:41:18 GMT, Virag Purnam wrote: > Added "Thread Id" information for Mouse Hover on Event Thread as well as in properties view. > > **Before:** No information on Hover > EventThread_Before > > **After:** Thread Id shown on Hover > EventThread_After > > **Before:** Only Thread Description shown in properties view > Properties_Before > > > **After:** Along with Thread Description, Thread Id also shown in properties view > Properties_After > > Could you please review the changes? Please suggest if anything more is needed with this enhancement request. Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/593#pullrequestreview-2410247876 From aptmac at openjdk.org Fri Nov 1 15:23:32 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Nov 2024 15:23:32 GMT Subject: RFR: 6626: The halt rule result should have a table of the VM operations In-Reply-To: References: Message-ID: <3aVpkXL0tbQUKQOoEXrLY6fQCLRzxBxRDwwsebClryA=.3c775369-fe1c-4a34-b270-408932a46c0e@github.com> On Wed, 30 Oct 2024 07:14:01 GMT, Suchita Chaturvedi wrote: > Added top 5 vm operations (ordered by max time), including the thread that initiated them. > Since the halt rule was pointing to VM operation rule in its description, hence i have added the table to vm opertion rule itself where it was more related to. > > The rule looks something like this now. > image lgtm, to get the ci runs green you'll need to rebase ontop of master to bring in the spotbugs fix ------------- Marked as reviewed by aptmac (Reviewer). PR Review: https://git.openjdk.org/jmc/pull/596#pullrequestreview-2410284810 From aptmac at openjdk.org Fri Nov 1 15:51:47 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Nov 2024 15:51:47 GMT Subject: RFR: 8219: Missing coverage in application reports [v10] In-Reply-To: References: Message-ID: <9O-EjTtEu6FuNn3JeQytNKj9A6iDPxjcRYwgPOe8u8k=.84e8a435-ffa9-4fb2-8908-44a34e3933c8@github.com> > This PR fixes (&cleans up) the coverage reports under jmc/application. > > The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage. > > Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well. > > The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated. Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - fix test argLine - Add tycho.testArgLine.local to Jolokia test argLine - adjust the argline for tycho-maven-plugin - 8219: Missing coverage in application reports ------------- Changes: https://git.openjdk.org/jmc/pull/562/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=562&range=09 Stats: 117 lines in 7 files changed: 10 ins; 88 del; 19 mod Patch: https://git.openjdk.org/jmc/pull/562.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/562/head:pull/562 PR: https://git.openjdk.org/jmc/pull/562 From aptmac at openjdk.org Fri Nov 1 16:20:35 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Nov 2024 16:20:35 GMT Subject: RFR: 8219: Missing coverage in application reports [v10] In-Reply-To: <9O-EjTtEu6FuNn3JeQytNKj9A6iDPxjcRYwgPOe8u8k=.84e8a435-ffa9-4fb2-8908-44a34e3933c8@github.com> References: <9O-EjTtEu6FuNn3JeQytNKj9A6iDPxjcRYwgPOe8u8k=.84e8a435-ffa9-4fb2-8908-44a34e3933c8@github.com> Message-ID: On Fri, 1 Nov 2024 15:51:47 GMT, Alex Macdonald wrote: >> This PR fixes (&cleans up) the coverage reports under jmc/application. >> >> The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage. >> >> Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well. >> >> The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated. > > Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - fix test argLine > - Add tycho.testArgLine.local to Jolokia test argLine > - adjust the argline for tycho-maven-plugin > - 8219: Missing coverage in application reports Figured it out, there was a change after I had opened the PR that didn't get fixed when pulling in new changes. The tests work okay now. ------------- PR Comment: https://git.openjdk.org/jmc/pull/562#issuecomment-2452157346 From schaturvedi at openjdk.org Mon Nov 4 03:43:15 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Mon, 4 Nov 2024 03:43:15 GMT Subject: RFR: 6626: The halt rule result should have a table of the VM operations [v2] In-Reply-To: References: Message-ID: > Added top 5 vm operations (ordered by max time), including the thread that initiated them. > Since the halt rule was pointing to VM operation rule in its description, hence i have added the table to vm opertion rule itself where it was more related to. > > The rule looks something like this now. > image Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into 6626 - 6626: The halt rule result should have a table of the VM operations ------------- Changes: - all: https://git.openjdk.org/jmc/pull/596/files - new: https://git.openjdk.org/jmc/pull/596/files/3182ea5e..9ebceb0e Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=596&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=596&range=00-01 Stats: 98 lines in 2 files changed: 89 ins; 3 del; 6 mod Patch: https://git.openjdk.org/jmc/pull/596.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/596/head:pull/596 PR: https://git.openjdk.org/jmc/pull/596 From schaturvedi at openjdk.org Mon Nov 4 04:06:33 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Mon, 4 Nov 2024 04:06:33 GMT Subject: Integrated: 6626: The halt rule result should have a table of the VM operations In-Reply-To: References: Message-ID: <9FjT_zSB7FLis4qHRfimtLw7RWbzETZecGYroMwPkIM=.34aed8f6-060f-4902-b2ea-c65b2aaa0928@github.com> On Wed, 30 Oct 2024 07:14:01 GMT, Suchita Chaturvedi wrote: > Added top 5 vm operations (ordered by max time), including the thread that initiated them. > Since the halt rule was pointing to VM operation rule in its description, hence i have added the table to vm opertion rule itself where it was more related to. > > The rule looks something like this now. > image This pull request has now been integrated. Changeset: 7135063b Author: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/7135063b969e65035e369255a602fb1a10f31d2e Stats: 43 lines in 3 files changed: 42 ins; 0 del; 1 mod 6626: The halt rule result should have a table of the VM operations Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/596 From duke at openjdk.org Mon Nov 4 12:22:49 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Mon, 4 Nov 2024 12:22:49 GMT Subject: RFR: 8284: Fix Jolokia discovery issues [v2] In-Reply-To: References: Message-ID: > This fixes two bugs with Jolokia discovery: > 1. serious : repeated discovery runs crash. Runing repeatedly in the background is the whole point > 2. more of an annoyance: the PR disables JMC agent by omitting JVM info in the descriptor (as presence is interpreted as a local JVM) > Both tested OK. Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into jolokia_discovery_issues - reverted file that was committed by error - Remove JVM info on discovered Jolokia VMs in order to disable JMC Agent functionality - Fix bug where repeated runs of discovery crashes (kind of a showstopper) ------------- Changes: - all: https://git.openjdk.org/jmc/pull/597/files - new: https://git.openjdk.org/jmc/pull/597/files/b29d9841..21515ce8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=597&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=597&range=00-01 Stats: 141 lines in 5 files changed: 131 ins; 3 del; 7 mod Patch: https://git.openjdk.org/jmc/pull/597.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/597/head:pull/597 PR: https://git.openjdk.org/jmc/pull/597 From duke at openjdk.org Mon Nov 4 12:44:34 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Mon, 4 Nov 2024 12:44:34 GMT Subject: RFR: 8284: Fix Jolokia discovery issues In-Reply-To: References: Message-ID: On Fri, 1 Nov 2024 14:48:35 GMT, Alex Macdonald wrote: > There's a fix to the spotbugs config that will fix the Mac tests just an fyi Indeed, the test passed after merging in master ? ------------- PR Comment: https://git.openjdk.org/jmc/pull/597#issuecomment-2454618711 From aptmac at openjdk.org Mon Nov 4 14:30:36 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 4 Nov 2024 14:30:36 GMT Subject: Integrated: 8219: Missing coverage in application reports In-Reply-To: References: Message-ID: On Fri, 3 May 2024 15:10:53 GMT, Alex Macdonald wrote: > This PR fixes (&cleans up) the coverage reports under jmc/application. > > The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage. > > Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well. > > The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated. This pull request has now been integrated. Changeset: 9370abed Author: Alex Macdonald URL: https://git.openjdk.org/jmc/commit/9370abed09c5995b5fc522a4cd2472104060133c Stats: 117 lines in 7 files changed: 10 ins; 88 del; 19 mod 8219: Missing coverage in application reports Reviewed-by: clanger, hirt ------------- PR: https://git.openjdk.org/jmc/pull/562 From hirt at openjdk.org Mon Nov 4 14:42:36 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 4 Nov 2024 14:42:36 GMT Subject: RFR: 8287: Fix the JMX protocol extenders [v2] In-Reply-To: References: Message-ID: On Fri, 1 Nov 2024 14:50:17 GMT, Alex Macdonald wrote: >> This PR addresses [JMC-8287](https://bugs.openjdk.org/browse/JMC-8287), in which the JMX protocol extenders were not running due to rjmx.ext not being visible by rjmx.common. >> >> This bug would have originated from the movement of rjmx code from application to core last year. >> >> Making rjmx.ext specify Fragment-Host on rjmx.common fixes the visiblity issue, and the protocol extenders both run as expected. This also fixes use-cases where plugins were expecting to have their protocols used but were failing due to the protocols not being picked up properly: >> >> org.openjdk.jmc.rjmx.common.ConnectionException caused by java.net.MalformedURLException: Unsupported protocol: > > Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8287: Fix the JMX protocol extenders Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/602#pullrequestreview-2413252319 From aptmac at openjdk.org Mon Nov 4 14:47:35 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 4 Nov 2024 14:47:35 GMT Subject: Integrated: 8287: Fix the JMX protocol extenders In-Reply-To: References: Message-ID: On Fri, 1 Nov 2024 14:04:04 GMT, Alex Macdonald wrote: > This PR addresses [JMC-8287](https://bugs.openjdk.org/browse/JMC-8287), in which the JMX protocol extenders were not running due to rjmx.ext not being visible by rjmx.common. > > This bug would have originated from the movement of rjmx code from application to core last year. > > Making rjmx.ext specify Fragment-Host on rjmx.common fixes the visiblity issue, and the protocol extenders both run as expected. This also fixes use-cases where plugins were expecting to have their protocols used but were failing due to the protocols not being picked up properly: > > org.openjdk.jmc.rjmx.common.ConnectionException caused by java.net.MalformedURLException: Unsupported protocol: This pull request has now been integrated. Changeset: 92fe6812 Author: Alex Macdonald URL: https://git.openjdk.org/jmc/commit/92fe6812699c842bd30451872b1cb0948d204333 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8287: Fix the JMX protocol extenders Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/602 From hirt at openjdk.org Mon Nov 4 15:59:10 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 4 Nov 2024 15:59:10 GMT Subject: RFR: 8286: Fix broken launcher [v2] In-Reply-To: References: Message-ID: > The launcher for launching JMC from within the development environment in Eclipse is broken. Going by features and adding some additional plug-ins solve it for me. Let me know if it works better for you too. Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: Fixing cut-and-paste problem ------------- Changes: - all: https://git.openjdk.org/jmc/pull/601/files - new: https://git.openjdk.org/jmc/pull/601/files/ed548be8..953b2fdb Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=601&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=601&range=00-01 Stats: 122 lines in 1 file changed: 0 ins; 1 del; 121 mod Patch: https://git.openjdk.org/jmc/pull/601.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/601/head:pull/601 PR: https://git.openjdk.org/jmc/pull/601 From hirt at openjdk.org Mon Nov 4 15:30:35 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 4 Nov 2024 15:30:35 GMT Subject: RFR: 6683: Mouse over for Event Thread should show the various thread IDs In-Reply-To: References: Message-ID: On Fri, 18 Oct 2024 09:41:18 GMT, Virag Purnam wrote: > Added "Thread Id" information for Mouse Hover on Event Thread as well as in properties view. > > **Before:** No information on Hover > EventThread_Before > > **After:** Thread Id shown on Hover > EventThread_After > > **Before:** Only Thread Description shown in properties view > Properties_Before > > > **After:** Along with Thread Description, Thread Id also shown in properties view > Properties_After > > Could you please review the changes? Please suggest if anything more is needed with this enhancement request. Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/593#pullrequestreview-2413383470 From aptmac at openjdk.org Mon Nov 4 15:48:33 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 4 Nov 2024 15:48:33 GMT Subject: RFR: 8288: Clean up warnings In-Reply-To: <2QO6gtthZM2JjiPNWQ_ctcjEWuGpZKryGcYirDhy9sA=.d19e4f4f-9560-49c1-85af-c96c8abd4c0c@github.com> References: <2QO6gtthZM2JjiPNWQ_ctcjEWuGpZKryGcYirDhy9sA=.d19e4f4f-9560-49c1-85af-c96c8abd4c0c@github.com> Message-ID: <-ZwAlAf72GZxM99tdL9tqWndM4zCR65ohdSv8AwyQps=.30e99a61-f71e-42c6-bc7b-a1312a9aa7db@github.com> On Mon, 4 Nov 2024 15:27:19 GMT, Marcus Hirt wrote: > Cleaning up some of the warnings in core in preparation for hack-commit-push (https://switzerland2024.hack-commit-pu.sh/). The ones related to the security manager being deprecated will be taken care of in JMC 10 (https://bugs.openjdk.org/browse/JMC-8289). Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/604#pullrequestreview-2413429538 From hirt at openjdk.org Mon Nov 4 15:31:43 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 4 Nov 2024 15:31:43 GMT Subject: RFR: 8288: Clean up warnings Message-ID: <2QO6gtthZM2JjiPNWQ_ctcjEWuGpZKryGcYirDhy9sA=.d19e4f4f-9560-49c1-85af-c96c8abd4c0c@github.com> Cleaning up some of the warnings in core in preparation for hack-commit-push (https://switzerland2024.hack-commit-pu.sh/). The ones related to the security manager being deprecated will be taken care of in JMC 10 (https://bugs.openjdk.org/browse/JMC-8289). ------------- Commit messages: - 8288: Cleaning up warnings Changes: https://git.openjdk.org/jmc/pull/604/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=604&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8288 Stats: 81 lines in 29 files changed: 1 ins; 27 del; 53 mod Patch: https://git.openjdk.org/jmc/pull/604.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/604/head:pull/604 PR: https://git.openjdk.org/jmc/pull/604 From hirt at openjdk.org Mon Nov 4 23:09:16 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 4 Nov 2024 23:09:16 GMT Subject: RFR: 8288: Clean up warnings [v2] In-Reply-To: <2QO6gtthZM2JjiPNWQ_ctcjEWuGpZKryGcYirDhy9sA=.d19e4f4f-9560-49c1-85af-c96c8abd4c0c@github.com> References: <2QO6gtthZM2JjiPNWQ_ctcjEWuGpZKryGcYirDhy9sA=.d19e4f4f-9560-49c1-85af-c96c8abd4c0c@github.com> Message-ID: > Cleaning up some of the warnings in core in preparation for hack-commit-push (https://switzerland2024.hack-commit-pu.sh/). The ones related to the security manager being deprecated will be taken care of in JMC 10 (https://bugs.openjdk.org/browse/JMC-8289). Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: Forgot a copyright ------------- Changes: - all: https://git.openjdk.org/jmc/pull/604/files - new: https://git.openjdk.org/jmc/pull/604/files/57110e06..ecbb36be Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=604&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=604&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/604.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/604/head:pull/604 PR: https://git.openjdk.org/jmc/pull/604 From hirt at openjdk.org Mon Nov 4 23:09:16 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 4 Nov 2024 23:09:16 GMT Subject: Integrated: 8288: Clean up warnings In-Reply-To: <2QO6gtthZM2JjiPNWQ_ctcjEWuGpZKryGcYirDhy9sA=.d19e4f4f-9560-49c1-85af-c96c8abd4c0c@github.com> References: <2QO6gtthZM2JjiPNWQ_ctcjEWuGpZKryGcYirDhy9sA=.d19e4f4f-9560-49c1-85af-c96c8abd4c0c@github.com> Message-ID: On Mon, 4 Nov 2024 15:27:19 GMT, Marcus Hirt wrote: > Cleaning up some of the warnings in core in preparation for hack-commit-push (https://switzerland2024.hack-commit-pu.sh/). The ones related to the security manager being deprecated will be taken care of in JMC 10 (https://bugs.openjdk.org/browse/JMC-8289). This pull request has now been integrated. Changeset: 45b2a4ba Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/45b2a4ba12edd54d0533221d4b09ad808057b2ba Stats: 83 lines in 29 files changed: 1 ins; 27 del; 55 mod 8288: Clean up warnings Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/604 From hirt at openjdk.org Mon Nov 4 23:15:34 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 4 Nov 2024 23:15:34 GMT Subject: RFR: 6683: Mouse over for Event Thread should show the various thread IDs In-Reply-To: References: Message-ID: On Fri, 18 Oct 2024 09:41:18 GMT, Virag Purnam wrote: > Added "Thread Id" information for Mouse Hover on Event Thread as well as in properties view. > > **Before:** No information on Hover > EventThread_Before > > **After:** Thread Id shown on Hover > EventThread_After > > **Before:** Only Thread Description shown in properties view > Properties_Before > > > **After:** Along with Thread Description, Thread Id also shown in properties view > Properties_After > > Could you please review the changes? Please suggest if anything more is needed with this enhancement request. Hi @viragpurnam! This can be integrated now! ------------- PR Comment: https://git.openjdk.org/jmc/pull/593#issuecomment-2455890943 From hirt at openjdk.org Mon Nov 4 23:18:33 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 4 Nov 2024 23:18:33 GMT Subject: RFR: 8274: Add thread counts to the Java Application page In-Reply-To: <8pxZe2Be9878bLI6ahxTNmXzf0Cy_7TRT54OqvC-7MI=.9d06bea6-57af-4434-a635-e4e699d2192e@github.com> References: <8pxZe2Be9878bLI6ahxTNmXzf0Cy_7TRT54OqvC-7MI=.9d06bea6-57af-4434-a635-e4e699d2192e@github.com> Message-ID: On Fri, 1 Nov 2024 14:46:03 GMT, Alex Macdonald wrote: >> Added all of them, but perhaps only having active and daemon would be good enough. > > application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JavaApplicationPage.java line 266: > >> 264: this::isAttributeEnabled, UnitLookup.PERCENT.quantity(0), UnitLookup.PERCENT.quantity(100)) >> 265: .ifPresent(rows::add); >> 266: DataPageToolkit.buildLinesRow("Threads", "Various thread counts", allItems, true, > > Do you think this might be better left as not filled? At least on Linux, the filled versions aren't transparent so overlaying a couple of these new values quickly covers up whatever is behind it. And with peak and total being the 3rd and 4th options, combining those with either of the first two and it gets hard to read. > > example: > With two enabled: > ![Screenshot from 2024-11-01 10-33-11](https://github.com/user-attachments/assets/0f63615c-ac5d-4eff-8376-cb3bb8cca0a3) > > Peak threads covers up the first two: > ![Screenshot from 2024-11-01 10-33-18](https://github.com/user-attachments/assets/f8fb4169-46a9-426b-8774-5e06e4bf171c) > > And then total threads covers everything: > ![Screenshot from 2024-11-01 10-33-24](https://github.com/user-attachments/assets/4affba34-9b87-4820-b151-d97c132b6def) Good point. Will just use lines. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/600#discussion_r1828523504 From hirt at openjdk.org Mon Nov 4 23:24:33 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 4 Nov 2024 23:24:33 GMT Subject: RFR: 8274: Add thread counts to the Java Application page In-Reply-To: References: <8pxZe2Be9878bLI6ahxTNmXzf0Cy_7TRT54OqvC-7MI=.9d06bea6-57af-4434-a635-e4e699d2192e@github.com> Message-ID: On Mon, 4 Nov 2024 23:15:31 GMT, Marcus Hirt wrote: >> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JavaApplicationPage.java line 266: >> >>> 264: this::isAttributeEnabled, UnitLookup.PERCENT.quantity(0), UnitLookup.PERCENT.quantity(100)) >>> 265: .ifPresent(rows::add); >>> 266: DataPageToolkit.buildLinesRow("Threads", "Various thread counts", allItems, true, >> >> Do you think this might be better left as not filled? At least on Linux, the filled versions aren't transparent so overlaying a couple of these new values quickly covers up whatever is behind it. And with peak and total being the 3rd and 4th options, combining those with either of the first two and it gets hard to read. >> >> example: >> With two enabled: >> ![Screenshot from 2024-11-01 10-33-11](https://github.com/user-attachments/assets/0f63615c-ac5d-4eff-8376-cb3bb8cca0a3) >> >> Peak threads covers up the first two: >> ![Screenshot from 2024-11-01 10-33-18](https://github.com/user-attachments/assets/f8fb4169-46a9-426b-8774-5e06e4bf171c) >> >> And then total threads covers everything: >> ![Screenshot from 2024-11-01 10-33-24](https://github.com/user-attachments/assets/4affba34-9b87-4820-b151-d97c132b6def) > > Good point. Will just use lines. Forgot to localize the strings too. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/600#discussion_r1828528480 From hirt at openjdk.org Mon Nov 4 23:41:47 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 4 Nov 2024 23:41:47 GMT Subject: RFR: 8274: Add thread counts to the Java Application page [v2] In-Reply-To: References: Message-ID: > Added all of them, but perhaps only having active and daemon would be good enough. Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: Localization and non-filled line graphs ------------- Changes: - all: https://git.openjdk.org/jmc/pull/600/files - new: https://git.openjdk.org/jmc/pull/600/files/6fdc7349..d8806ea1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=600&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=600&range=00-01 Stats: 7 lines in 3 files changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/600.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/600/head:pull/600 PR: https://git.openjdk.org/jmc/pull/600 From vpurnam at openjdk.org Tue Nov 5 04:08:33 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Tue, 5 Nov 2024 04:08:33 GMT Subject: RFR: 6683: Mouse over for Event Thread should show the various thread IDs In-Reply-To: References: Message-ID: <4zZ7ehsoW8Sa_Xu8gQnhJV2EfeJNgODKJl2sszvdbds=.b6ec3b20-6cce-40cd-956e-79a61c06963e@github.com> On Mon, 4 Nov 2024 23:13:19 GMT, Marcus Hirt wrote: > Hi @viragpurnam! This can be integrated now! Thanks @thegreystone and @aptmac for reviews. Integrating this PR. ------------- PR Comment: https://git.openjdk.org/jmc/pull/593#issuecomment-2456187573 From vpurnam at openjdk.org Tue Nov 5 04:08:34 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Tue, 5 Nov 2024 04:08:34 GMT Subject: Integrated: 6683: Mouse over for Event Thread should show the various thread IDs In-Reply-To: References: Message-ID: <1PxwivDHVB6EYGZUtqkbN4u0XEUyXTPpq-9Uk-6E2Uc=.8bcf47f3-7e5f-4bf4-9f28-7d617c19f547@github.com> On Fri, 18 Oct 2024 09:41:18 GMT, Virag Purnam wrote: > Added "Thread Id" information for Mouse Hover on Event Thread as well as in properties view. > > **Before:** No information on Hover > EventThread_Before > > **After:** Thread Id shown on Hover > EventThread_After > > **Before:** Only Thread Description shown in properties view > Properties_Before > > > **After:** Along with Thread Description, Thread Id also shown in properties view > Properties_After > > Could you please review the changes? Please suggest if anything more is needed with this enhancement request. This pull request has now been integrated. Changeset: fadc2607 Author: Virag Purnam URL: https://git.openjdk.org/jmc/commit/fadc2607b3355e39cf859445732429ebfd6355b9 Stats: 205 lines in 10 files changed: 152 ins; 35 del; 18 mod 6683: Mouse over for Event Thread should show the various thread IDs Reviewed-by: aptmac, hirt ------------- PR: https://git.openjdk.org/jmc/pull/593 From vpurnam at openjdk.org Tue Nov 5 05:22:03 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Tue, 5 Nov 2024 05:22:03 GMT Subject: RFR: 8278: Update COPYRIGHT, LICENSE.txt and THIRDPARTYREADME.txt files Message-ID: Updated COPYRIGHT, LICENSE.txt and THIRDPARTYREADME.txt files.? - Many third-party libraries have been upgraded. - Copyright years are not the current year. ------------- Commit messages: - 8278: Update COPYRIGHT, LICENSE.txt and THIRDPARTYREADME.txt files Changes: https://git.openjdk.org/jmc/pull/605/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=605&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8278 Stats: 8813 lines in 3 files changed: 1643 ins; 6248 del; 922 mod Patch: https://git.openjdk.org/jmc/pull/605.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/605/head:pull/605 PR: https://git.openjdk.org/jmc/pull/605 From hirt at openjdk.org Tue Nov 5 08:47:35 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 5 Nov 2024 08:47:35 GMT Subject: RFR: 8278: Update COPYRIGHT, LICENSE.txt and THIRDPARTYREADME.txt files In-Reply-To: References: Message-ID: On Tue, 5 Nov 2024 05:17:59 GMT, Virag Purnam wrote: > Updated COPYRIGHT, LICENSE.txt and THIRDPARTYREADME.txt files.? > > - Many third-party libraries have been upgraded. > - Copyright years are not the current year. Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/605#pullrequestreview-2414972272 From hirt at openjdk.org Tue Nov 5 08:48:36 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 5 Nov 2024 08:48:36 GMT Subject: RFR: 8274: Add thread counts to the Java Application page [v2] In-Reply-To: References: Message-ID: On Mon, 4 Nov 2024 23:41:47 GMT, Marcus Hirt wrote: >> Added all of them, but perhaps only having active and daemon would be good enough. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Localization and non-filled line graphs There is something fishy going on with the copyright script... ------------- PR Comment: https://git.openjdk.org/jmc/pull/600#issuecomment-2456567359 From hirt at openjdk.org Tue Nov 5 08:49:35 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 5 Nov 2024 08:49:35 GMT Subject: RFR: 8286: Fix broken launcher [v2] In-Reply-To: References: Message-ID: On Mon, 4 Nov 2024 15:59:10 GMT, Marcus Hirt wrote: >> The launcher for launching JMC from within the development environment in Eclipse is broken. Going by features and adding some additional plug-ins solve it for me. Let me know if it works better for you too. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Fixing cut-and-paste problem Copyright script is having a bad hair day. ------------- PR Comment: https://git.openjdk.org/jmc/pull/601#issuecomment-2456570077 From vpurnam at openjdk.org Tue Nov 5 11:03:34 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Tue, 5 Nov 2024 11:03:34 GMT Subject: Integrated: 8278: Update COPYRIGHT, LICENSE.txt and THIRDPARTYREADME.txt files In-Reply-To: References: Message-ID: On Tue, 5 Nov 2024 05:17:59 GMT, Virag Purnam wrote: > Updated COPYRIGHT, LICENSE.txt and THIRDPARTYREADME.txt files.? > > - Many third-party libraries have been upgraded. > - Copyright years are not the current year. This pull request has now been integrated. Changeset: 13cef0c5 Author: Virag Purnam URL: https://git.openjdk.org/jmc/commit/13cef0c5e377d91ce0917bc7a1f7427707b8ef8c Stats: 8813 lines in 3 files changed: 1643 ins; 6248 del; 922 mod 8278: Update COPYRIGHT, LICENSE.txt and THIRDPARTYREADME.txt files Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/605 From hirt at openjdk.org Tue Nov 5 17:14:18 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 5 Nov 2024 17:14:18 GMT Subject: RFR: 8274: Add thread counts to the Java Application page [v3] In-Reply-To: References: Message-ID: > Added all of them, but perhaps only having active and daemon would be good enough. Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch '8274-thread-counts' of https://github.com/thegreystone/jmc into 8274-thread-counts - Localization and non-filled line graphs - 8274: Adding thread counts to the Java Application page - Localization and non-filled line graphs - 8274: Adding thread counts to the Java Application page ------------- Changes: - all: https://git.openjdk.org/jmc/pull/600/files - new: https://git.openjdk.org/jmc/pull/600/files/d8806ea1..be4212fb Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=600&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=600&range=01-02 Stats: 9265 lines in 53 files changed: 1851 ins; 6398 del; 1016 mod Patch: https://git.openjdk.org/jmc/pull/600.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/600/head:pull/600 PR: https://git.openjdk.org/jmc/pull/600 From hirt at openjdk.org Tue Nov 5 17:14:18 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 5 Nov 2024 17:14:18 GMT Subject: RFR: 8274: Add thread counts to the Java Application page [v2] In-Reply-To: References: Message-ID: <5Cy-nKg5bY07KLUlVinUEw1PINdxtgeubu3UFdLYo-Q=.b1d9fe99-54e6-4cd2-944a-cba877c63d55@github.com> On Mon, 4 Nov 2024 23:41:47 GMT, Marcus Hirt wrote: >> Added all of them, but perhaps only having active and daemon would be good enough. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Localization and non-filled line graphs Rebased from master to make copyright script happy. ------------- PR Comment: https://git.openjdk.org/jmc/pull/600#issuecomment-2457736882 From aptmac at openjdk.org Tue Nov 5 18:02:34 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 5 Nov 2024 18:02:34 GMT Subject: RFR: 8286: Fix broken launcher [v2] In-Reply-To: References: Message-ID: On Mon, 4 Nov 2024 15:59:10 GMT, Marcus Hirt wrote: >> The launcher for launching JMC from within the development environment in Eclipse is broken. Going by features and adding some additional plug-ins solve it for me. Let me know if it works better for you too. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Fixing cut-and-paste problem Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/601#pullrequestreview-2416351964 From aptmac at openjdk.org Tue Nov 5 18:05:38 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 5 Nov 2024 18:05:38 GMT Subject: RFR: 8274: Add thread counts to the Java Application page [v3] In-Reply-To: References: Message-ID: On Tue, 5 Nov 2024 17:14:18 GMT, Marcus Hirt wrote: >> Added all of them, but perhaps only having active and daemon would be good enough. > > Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch '8274-thread-counts' of https://github.com/thegreystone/jmc into 8274-thread-counts > - Localization and non-filled line graphs > - 8274: Adding thread counts to the Java Application page > - Localization and non-filled line graphs > - 8274: Adding thread counts to the Java Application page The code changes here look good to go, but the rebase ontop of master doesn't look to have been so clean, the jdk bot made a comment: https://github.com/openjdk/jmc/pull/600#issuecomment-2457734533 This PR now includes a merge commit and the 9 latest commits that were put into master. I think this may have to be cleaned up prior to integrating? ------------- Marked as reviewed by aptmac (Reviewer). PR Review: https://git.openjdk.org/jmc/pull/600#pullrequestreview-2416357157 From hirt at openjdk.org Tue Nov 5 19:27:36 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 5 Nov 2024 19:27:36 GMT Subject: Integrated: 8286: Fix broken launcher In-Reply-To: References: Message-ID: On Fri, 1 Nov 2024 00:53:06 GMT, Marcus Hirt wrote: > The launcher for launching JMC from within the development environment in Eclipse is broken. Going by features and adding some additional plug-ins solve it for me. Let me know if it works better for you too. This pull request has now been integrated. Changeset: bf3aa4c1 Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/bf3aa4c1b02699952c33c8a7a4fbe8062c655fba Stats: 121 lines in 1 file changed: 18 ins; 0 del; 103 mod 8286: Fix broken launcher Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/601 From hirt at openjdk.org Tue Nov 5 19:27:36 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 5 Nov 2024 19:27:36 GMT Subject: Integrated: 8274: Add thread counts to the Java Application page In-Reply-To: References: Message-ID: <4m5QR2_-53wJjkrMpdcIUeb4HWukaFMLTsdu81oCRsA=.eb47e350-e3fe-42b8-bcbf-e18e01605c39@github.com> On Fri, 1 Nov 2024 00:36:33 GMT, Marcus Hirt wrote: > Added all of them, but perhaps only having active and daemon would be good enough. This pull request has now been integrated. Changeset: 3b96b0fe Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/3b96b0fe3b3a45928e7c7ab17bc0b41501526150 Stats: 60 lines in 8 files changed: 58 ins; 0 del; 2 mod 8274: Add thread counts to the Java Application page Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/600 From hirt at openjdk.org Tue Nov 5 22:51:43 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 5 Nov 2024 22:51:43 GMT Subject: RFR: 8290: Handle resources warnings Message-ID: Seems to be an acceptable solution across tools. ------------- Commit messages: - 8290: Fixing resources warnings Changes: https://git.openjdk.org/jmc/pull/606/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=606&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8290 Stats: 5 lines in 4 files changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/606.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/606/head:pull/606 PR: https://git.openjdk.org/jmc/pull/606 From aptmac at openjdk.org Wed Nov 6 00:18:32 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Wed, 6 Nov 2024 00:18:32 GMT Subject: RFR: 8290: Handle resources warnings In-Reply-To: References: Message-ID: <5DmNhvA-ruetCca5CNb_8FlsXYgYPMGzRlFEIHLYRzY=.636af7cf-ee38-42b4-a971-e7b8d31e8436@github.com> On Tue, 5 Nov 2024 22:48:12 GMT, Marcus Hirt wrote: > Seems to be an acceptable solution across tools. Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/606#pullrequestreview-2417022976 From hirt at openjdk.org Wed Nov 6 20:57:54 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 6 Nov 2024 20:57:54 GMT Subject: Integrated: 8290: Handle resources warnings In-Reply-To: References: Message-ID: <4oL4q9WvfAF9zHwLn7qf-jikSskrRYtaLART5WmITSw=.dd3b0005-ca1d-47d9-a2d5-b547251c8c79@github.com> On Tue, 5 Nov 2024 22:48:12 GMT, Marcus Hirt wrote: > Seems to be an acceptable solution across tools. This pull request has now been integrated. Changeset: b75d151b Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/b75d151ba2bef2026e3e716b561490ae2dd5c6aa Stats: 5 lines in 4 files changed: 2 ins; 0 del; 3 mod 8290: Handle resources warnings Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/606 From marcus at hirt.se Wed Nov 6 21:24:27 2024 From: marcus at hirt.se (Marcus Hirt) Date: Wed, 6 Nov 2024 22:24:27 +0100 Subject: CFV: New jmc Reviewer: Virag Purnam Message-ID: <09cb01db3092$426d9d40$c748d7c0$@hirt.se> I hereby nominate Virag Purnam to jmc Reviewer. Virag has been contributing to the jmc project since the 9th of February 2022, not only contributing with pull requests, but also helping jmc with various Oracle internal processes, such as the third-party approval process, and other processes required to for example publish jmc on maven central and publishing Oracle's jmc builds. Here is a list of Virag's contributions to the repo: https://github.com/openjdk/jmc/pulls?page=2&q=is%3Aclosed+is%3Apr+author%3Aviragpurnam+label%3Aintegrated Votes are due by 2024-11-21. Only current jmc Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [2]. Kind regards, Marcus [1] https://openjdk.org/census [2] https://openjdk.org/projects/#reviewer-vote From almacdon at redhat.com Wed Nov 6 21:32:12 2024 From: almacdon at redhat.com (Alex Macdonald) Date: Wed, 6 Nov 2024 16:32:12 -0500 Subject: CFV: New jmc Reviewer: Virag Purnam In-Reply-To: <09cb01db3092$426d9d40$c748d7c0$@hirt.se> References: <09cb01db3092$426d9d40$c748d7c0$@hirt.se> Message-ID: Vote: yes On Wed, Nov 6, 2024 at 4:24?PM Marcus Hirt wrote: > > I hereby nominate Virag Purnam to jmc Reviewer. > > Virag has been contributing to the jmc project since the 9th of February 2022, not only contributing with pull requests, but also helping jmc with various Oracle internal processes, such as the third-party approval process, and other processes required to for example publish jmc on maven central and publishing Oracle's jmc builds. > > Here is a list of Virag's contributions to the repo: > https://github.com/openjdk/jmc/pulls?page=2&q=is%3Aclosed+is%3Apr+author%3Aviragpurnam+label%3Aintegrated > > Votes are due by 2024-11-21. > > Only current jmc Reviewers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [2]. > > Kind regards, > Marcus > > [1] https://openjdk.org/census > [2] https://openjdk.org/projects/#reviewer-vote > From aptmac at openjdk.org Wed Nov 6 21:56:46 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Wed, 6 Nov 2024 21:56:46 GMT Subject: RFR: 8284: Fix Jolokia discovery issues [v2] In-Reply-To: References: Message-ID: On Mon, 4 Nov 2024 12:22:49 GMT, Martin Skarsaune wrote: >> This fixes two bugs with Jolokia discovery: >> 1. serious : repeated discovery runs crash. Runing repeatedly in the background is the whole point >> 2. more of an annoyance: the PR disables JMC agent by omitting JVM info in the descriptor (as presence is interpreted as a local JVM) >> Both tested OK. > > Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into jolokia_discovery_issues > - reverted file that was committed by error > - Remove JVM info on discovered Jolokia VMs in order to disable JMC Agent functionality > - Fix bug where repeated runs of discovery crashes (kind of a showstopper) Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/597#pullrequestreview-2419500153 From duke at openjdk.org Thu Nov 7 07:56:49 2024 From: duke at openjdk.org (duke) Date: Thu, 7 Nov 2024 07:56:49 GMT Subject: RFR: 8284: Fix Jolokia discovery issues [v2] In-Reply-To: References: Message-ID: <0sCBxp2o89s2uTSIpinsDns5UlakduvEdCD4_are2dE=.feb63789-99d7-4c89-b385-90099ba66f41@github.com> On Mon, 4 Nov 2024 12:22:49 GMT, Martin Skarsaune wrote: >> This fixes two bugs with Jolokia discovery: >> 1. serious : repeated discovery runs crash. Runing repeatedly in the background is the whole point >> 2. more of an annoyance: the PR disables JMC agent by omitting JVM info in the descriptor (as presence is interpreted as a local JVM) >> Both tested OK. > > Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into jolokia_discovery_issues > - reverted file that was committed by error > - Remove JVM info on discovered Jolokia VMs in order to disable JMC Agent functionality > - Fix bug where repeated runs of discovery crashes (kind of a showstopper) @skarsaune Your change (at version 21515ce8d81255f908c1a3ceadc1cdb4f715316e) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jmc/pull/597#issuecomment-2461547142 From duke at openjdk.org Thu Nov 7 15:27:58 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Thu, 7 Nov 2024 15:27:58 GMT Subject: Integrated: 8284: Fix Jolokia discovery issues In-Reply-To: References: Message-ID: On Wed, 30 Oct 2024 18:47:30 GMT, Martin Skarsaune wrote: > This fixes two bugs with Jolokia discovery: > 1. serious : repeated discovery runs crash. Runing repeatedly in the background is the whole point > 2. more of an annoyance: the PR disables JMC agent by omitting JVM info in the descriptor (as presence is interpreted as a local JVM) > Both tested OK. This pull request has now been integrated. Changeset: 19ec0200 Author: Martin Skarsaune Committer: Alex Macdonald URL: https://git.openjdk.org/jmc/commit/19ec020068d278095d03064b90d78c4d5d181a6f Stats: 115 lines in 2 files changed: 3 ins; 105 del; 7 mod 8284: Fix Jolokia discovery issues Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/597 From schaturvedi at openjdk.org Fri Nov 8 07:05:08 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Fri, 8 Nov 2024 07:05:08 GMT Subject: RFR: 6607: Better descriptions for the code cache rule Message-ID: This PR provides better description for code cache rule. Before the change: ![image](https://github.com/user-attachments/assets/487bca61-ceee-4dda-bc70-9c99316d4ee7) After the change: image ------------- Commit messages: - 6607: Better descriptions for the code cache rule Changes: https://git.openjdk.org/jmc/pull/607/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=607&range=00 Issue: https://bugs.openjdk.org/browse/JMC-6607 Stats: 14 lines in 2 files changed: 9 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jmc/pull/607.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/607/head:pull/607 PR: https://git.openjdk.org/jmc/pull/607 From hirt at openjdk.org Fri Nov 8 13:02:01 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 8 Nov 2024 13:02:01 GMT Subject: RFR: 6607: Better descriptions for the code cache rule In-Reply-To: References: Message-ID: <-41ozUpguyzhkfZ2gLsYm9DcF9Vaes1Yev_u9JbgwNg=.8ace7e80-700c-4ab8-b37e-6ce2f333a55e@github.com> On Fri, 8 Nov 2024 06:44:43 GMT, Suchita Chaturvedi wrote: > This PR provides better description for code cache rule. > > Before the change: > ![image](https://github.com/user-attachments/assets/487bca61-ceee-4dda-bc70-9c99316d4ee7) > > After the change: > image Marked as reviewed by hirt (Lead). Thanks @Suchitainf! ------------- PR Review: https://git.openjdk.org/jmc/pull/607#pullrequestreview-2423736523 PR Comment: https://git.openjdk.org/jmc/pull/607#issuecomment-2464693954 From schaturvedi at openjdk.org Mon Nov 11 03:18:29 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Mon, 11 Nov 2024 03:18:29 GMT Subject: Integrated: 6607: Better descriptions for the code cache rule In-Reply-To: References: Message-ID: On Fri, 8 Nov 2024 06:44:43 GMT, Suchita Chaturvedi wrote: > This PR provides better description for code cache rule. > > Before the change: > ![image](https://github.com/user-attachments/assets/487bca61-ceee-4dda-bc70-9c99316d4ee7) > > After the change: > image This pull request has now been integrated. Changeset: 382f8aea Author: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/382f8aea060cb482a0003bb396126b0b3055449d Stats: 14 lines in 2 files changed: 9 ins; 0 del; 5 mod 6607: Better descriptions for the code cache rule Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/607 From schaturvedi at openjdk.org Tue Nov 12 09:29:18 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Tue, 12 Nov 2024 09:29:18 GMT Subject: RFR: 8291: JVM PID is shown as N/A however the value is present in JFR Message-ID: This is a regression found during internal testing. PID issue was fixed in [JMC-7506](https://bugs.openjdk.org/browse/JMC-7506). The pid in system process was coming as string and the pid in VM information was coming as long. Hence,? to maintain the uniformity both the considered as string and changes are done to convert JVM PID from IQuantity/Long to String. [JMC-8244](https://bugs.openjdk.org/browse/JMC-8244) Turned off all the scientific notations for long attributes. Hence, JVM_PID is no longer IQuantity/Long. Its a Raw number. Both these fixes overlapped and PID on JVM Internals screen started showing as N/A. ![image](https://github.com/user-attachments/assets/25e9e370-cd53-44a6-a833-b8b24639d644) Though the value of PID is present. ![image](https://github.com/user-attachments/assets/dbf1b76a-4567-408a-9407-54e54a5b294c) After handling the datatypes properly, the issue has been fixed: image ------------- Commit messages: - 8291: JVM PID is shown as N/A however the value is present in JFR Changes: https://git.openjdk.org/jmc/pull/608/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=608&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8291 Stats: 4 lines in 2 files changed: 0 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/608.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/608/head:pull/608 PR: https://git.openjdk.org/jmc/pull/608 From aptmac at openjdk.org Tue Nov 12 14:55:32 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 12 Nov 2024 14:55:32 GMT Subject: RFR: 8291: JVM PID is shown as N/A however the value is present in JFR In-Reply-To: References: Message-ID: On Tue, 12 Nov 2024 09:25:37 GMT, Suchita Chaturvedi wrote: > This is a regression found during internal testing. > > PID issue was fixed in [JMC-7506](https://bugs.openjdk.org/browse/JMC-7506). The pid in system process was coming as string and the pid in VM information was coming as long. Hence,? to maintain the uniformity both the considered as string and changes are done to convert JVM PID from IQuantity/Long to String. > > [JMC-8244](https://bugs.openjdk.org/browse/JMC-8244) Turned off all the scientific notations for long attributes. Hence, JVM_PID is no longer IQuantity/Long. Its a Raw number. > > Both these fixes overlapped and PID on JVM Internals screen started showing as N/A. > > ![image](https://github.com/user-attachments/assets/25e9e370-cd53-44a6-a833-b8b24639d644) > > Though the value of PID is present. > ![image](https://github.com/user-attachments/assets/dbf1b76a-4567-408a-9407-54e54a5b294c) > > > After handling the datatypes properly, the issue has been fixed: > image Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/608#pullrequestreview-2429832045 From schaturvedi at openjdk.org Tue Nov 12 17:42:00 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Tue, 12 Nov 2024 17:42:00 GMT Subject: Integrated: 8291: JVM PID is shown as N/A however the value is present in JFR In-Reply-To: References: Message-ID: On Tue, 12 Nov 2024 09:25:37 GMT, Suchita Chaturvedi wrote: > This is a regression found during internal testing. > > PID issue was fixed in [JMC-7506](https://bugs.openjdk.org/browse/JMC-7506). The pid in system process was coming as string and the pid in VM information was coming as long. Hence,? to maintain the uniformity both the considered as string and changes are done to convert JVM PID from IQuantity/Long to String. > > [JMC-8244](https://bugs.openjdk.org/browse/JMC-8244) Turned off all the scientific notations for long attributes. Hence, JVM_PID is no longer IQuantity/Long. Its a Raw number. > > Both these fixes overlapped and PID on JVM Internals screen started showing as N/A. > > ![image](https://github.com/user-attachments/assets/25e9e370-cd53-44a6-a833-b8b24639d644) > > Though the value of PID is present. > ![image](https://github.com/user-attachments/assets/dbf1b76a-4567-408a-9407-54e54a5b294c) > > > After handling the datatypes properly, the issue has been fixed: > image This pull request has now been integrated. Changeset: 666b77fc Author: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/666b77fcb2d8e9d4ebe02d9026e9cf039f3119c0 Stats: 4 lines in 2 files changed: 0 ins; 1 del; 3 mod 8291: JVM PID is shown as N/A however the value is present in JFR Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/608 From vpurnam at openjdk.org Fri Nov 15 15:28:53 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Fri, 15 Nov 2024 15:28:53 GMT Subject: RFR: 8294: Missing plugins in JMC-Eclipse-plug-ins, JMC-Eclipse and JMC-RCP-plug-ins launchers Message-ID: <_nKkol2pYc0QTqk8K9O9_zvZ3ezARA6KfjQpawm0VJg=.ec242134-95aa-4964-b33c-a2eddeb4703e@github.com> Fixed the launchers, JMC-Eclipse-plug-ins, JMC-Eclipse and JMC-RCP-plug-ins ------------- Commit messages: - 8294: Missing plugins in JMC-Eclipse-plug-ins, JMC-Eclipse and JMC-RCP-plug-ins launchers Changes: https://git.openjdk.org/jmc/pull/609/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=609&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8294 Stats: 247 lines in 3 files changed: 0 ins; 32 del; 215 mod Patch: https://git.openjdk.org/jmc/pull/609.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/609/head:pull/609 PR: https://git.openjdk.org/jmc/pull/609 From hirt at openjdk.org Fri Nov 15 18:41:13 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 15 Nov 2024 18:41:13 GMT Subject: RFR: 8294: Missing plugins in JMC-Eclipse-plug-ins, JMC-Eclipse and JMC-RCP-plug-ins launchers In-Reply-To: <_nKkol2pYc0QTqk8K9O9_zvZ3ezARA6KfjQpawm0VJg=.ec242134-95aa-4964-b33c-a2eddeb4703e@github.com> References: <_nKkol2pYc0QTqk8K9O9_zvZ3ezARA6KfjQpawm0VJg=.ec242134-95aa-4964-b33c-a2eddeb4703e@github.com> Message-ID: On Fri, 15 Nov 2024 15:24:14 GMT, Virag Purnam wrote: > Fixed the launchers, JMC-Eclipse-plug-ins, JMC-Eclipse and JMC-RCP-plug-ins Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/609#pullrequestreview-2439371732 From vpurnam at openjdk.org Sat Nov 16 18:05:23 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Sat, 16 Nov 2024 18:05:23 GMT Subject: RFR: 8239: Errors installing JMC 9.0.0 as an Eclipse plugin via update site Message-ID: Added the missing plugin dependencies for newly added feature (Jolokia) and updated Jetty dependencies. With these changes, JMC 9.1.0 can be installed on Eclipse 2024-06 and 2024-09. It is not breaking Eclipse Icons and about dialog. JMC 9.0.0 can be installed on Eclipse 2024-06, but as @cimi, mentioned in JIRA issue that Eclipse branding breaks, including the actual Eclipse application icon and the about dialog. For the newer version of eclipse verification can be done after the release. ------------- Commit messages: - 8239: Errors installing JMC 9.0.0 as an Eclipse plugin via update site - 8239: Errors installing JMC 9.0.0 as an Eclipse plugin via update site - 8239: Errors installing JMC 9.0.0 as an Eclipse plugin via update site Changes: https://git.openjdk.org/jmc/pull/610/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=610&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8239 Stats: 79 lines in 5 files changed: 71 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jmc/pull/610.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/610/head:pull/610 PR: https://git.openjdk.org/jmc/pull/610 From vpurnam at openjdk.org Sun Nov 17 10:34:15 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Sun, 17 Nov 2024 10:34:15 GMT Subject: Integrated: 8294: Missing plugins in JMC-Eclipse-plug-ins, JMC-Eclipse and JMC-RCP-plug-ins launchers In-Reply-To: <_nKkol2pYc0QTqk8K9O9_zvZ3ezARA6KfjQpawm0VJg=.ec242134-95aa-4964-b33c-a2eddeb4703e@github.com> References: <_nKkol2pYc0QTqk8K9O9_zvZ3ezARA6KfjQpawm0VJg=.ec242134-95aa-4964-b33c-a2eddeb4703e@github.com> Message-ID: On Fri, 15 Nov 2024 15:24:14 GMT, Virag Purnam wrote: > Fixed the launchers, JMC-Eclipse-plug-ins, JMC-Eclipse and JMC-RCP-plug-ins This pull request has now been integrated. Changeset: f67ead33 Author: Virag Purnam URL: https://git.openjdk.org/jmc/commit/f67ead33fa3f2c16bd747907124a8d27e160085e Stats: 247 lines in 3 files changed: 0 ins; 32 del; 215 mod 8294: Missing plugins in JMC-Eclipse-plug-ins, JMC-Eclipse and JMC-RCP-plug-ins launchers Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/609 From marcus at hirt.se Mon Nov 18 22:27:25 2024 From: marcus at hirt.se (Marcus Hirt) Date: Mon, 18 Nov 2024 23:27:25 +0100 Subject: CFV: New jmc Reviewer: Virag Purnam Message-ID: <030801db3a09$0b0930f0$211b92d0$@hirt.se> Vote: yes /M -----Original Message----- From: Marcus Hirt Sent: Wednesday, 6 November 2024 22:24 To: 'jmc-dev at openjdk.org' Subject: CFV: New jmc Reviewer: Virag Purnam I hereby nominate Virag Purnam to jmc Reviewer. Virag has been contributing to the jmc project since the 9th of February 2022, not only contributing with pull requests, but also helping jmc with various Oracle internal processes, such as the third-party approval process, and other processes required to for example publish jmc on maven central and publishing Oracle's jmc builds. Here is a list of Virag's contributions to the repo: https://github.com/openjdk/jmc/pulls?page=2&q=is%3Aclosed+is%3Apr+author%3Aviragpurnam+label%3Aintegrated Votes are due by 2024-11-21. Only current jmc Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [2]. Kind regards, Marcus [1] https://openjdk.org/census [2] https://openjdk.org/projects/#reviewer-vote From christoph.langer at sap.com Tue Nov 19 05:24:16 2024 From: christoph.langer at sap.com (Langer, Christoph) Date: Tue, 19 Nov 2024 05:24:16 +0000 Subject: CFV: New jmc Reviewer: Virag Purnam In-Reply-To: References: <09cb01db3092$426d9d40$c748d7c0$@hirt.se> Message-ID: Vote:yes /Christoph PS For some reason I didn't get the original voting email. > -----Original Message----- > On Wed, Nov 6, 2024 at 4:24?PM Marcus Hirt wrote: > > > > I hereby nominate Virag Purnam to jmc Reviewer. > > > > Virag has been contributing to the jmc project since the 9th of February 2022, > not only contributing with pull requests, but also helping jmc with various > Oracle internal processes, such as the third-party approval process, and other > processes required to for example publish jmc on maven central and publishing > Oracle's jmc builds. > > > > Here is a list of Virag's contributions to the repo: > > > https://github.com/openjdk/jmc/pulls?page=2&q=is%3Aclosed+is%3Apr+autho > r%3Aviragpurnam+label%3Aintegrated > > > > Votes are due by 2024-11-21. > > > > Only current jmc Reviewers [1] are eligible to vote on this nomination. > > Votes must be cast in the open by replying to this mailing list. > > > > For Three-Vote Consensus voting instructions, see [2]. > > > > Kind regards, > > Marcus > > > > [1] https://openjdk.org/census > > [2] https://openjdk.org/projects/#reviewer-vote > > From marcus at hirt.se Fri Nov 22 09:44:40 2024 From: marcus at hirt.se (Marcus Hirt) Date: Fri, 22 Nov 2024 10:44:40 +0100 Subject: New jmc Reviewer: Virag Purnam Message-ID: <05e201db3cc3$2717c4c0$75474e40$@hirt.se> Voting for Virag Purnam [1] is now closed. Yes: 3 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus, this is sufficient to approve the nomination. Kind regards, Marcus [1] https://mail.openjdk.org/pipermail/jmc-dev/2024-November/006389.html From duke at openjdk.org Sun Nov 24 19:31:56 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Sun, 24 Nov 2024 19:31:56 GMT Subject: RFR: JMC-7539: Ensure installCore respects avoiding JDP tests Message-ID: As > JDPClientTest.testChangePacket:95 > JDPClientTest.testJDPClient:73 > JDPJMXTest.testJDPClient:71 Now reside in common, installCore should skip JDP multicast test when the build file has been called with the flag to avoid JDP multicast tests ------------- Commit messages: - JMC-7539: Ensure installCore respects avoiding JDP tests Changes: https://git.openjdk.org/jmc/pull/611/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=611&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7539 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/611.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/611/head:pull/611 PR: https://git.openjdk.org/jmc/pull/611 From clanger at openjdk.org Mon Nov 25 08:56:21 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 25 Nov 2024 08:56:21 GMT Subject: RFR: JMC-7539: Ensure installCore respects avoiding JDP tests In-Reply-To: References: Message-ID: <9uD5vG9XvOME0AtDqf9ct-eBjdjZ0jfkv97iwalorxw=.fb4a2dca-0870-492e-a696-2b8555e83e89@github.com> On Sun, 24 Nov 2024 19:20:58 GMT, Martin Skarsaune wrote: > As > >> JDPClientTest.testChangePacket:95 >> JDPClientTest.testJDPClient:73 >> JDPJMXTest.testJDPClient:71 > > Now reside in common, installCore should skip JDP multicast test when the build file has been called with the flag to avoid JDP multicast tests Hi, @skarsaune. You need to create/reference another bug but not [JMC-7539](https://bugs.openjdk.org/browse/JMC-7539) since that one is already closed. ------------- PR Comment: https://git.openjdk.org/jmc/pull/611#issuecomment-2497304706 From vpurnam at openjdk.org Mon Nov 25 16:03:38 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Mon, 25 Nov 2024 16:03:38 GMT Subject: RFR: 8298: Update to Eclipse 2024-09 Message-ID: Update to Eclipse 2024-09 ------------- Commit messages: - 8298: Update to Eclipse 2024-09 Changes: https://git.openjdk.org/jmc/pull/612/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=612&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8298 Stats: 142 lines in 7 files changed: 120 ins; 0 del; 22 mod Patch: https://git.openjdk.org/jmc/pull/612.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/612/head:pull/612 PR: https://git.openjdk.org/jmc/pull/612