RFR: 8274: Add thread counts to the Java Application page

[Marcus Hirt]

On Mon, 4 Nov 2024 23:15:31 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JavaApplicationPage.java line 266:
>> 
>>> 264: 					this::isAttributeEnabled, UnitLookup.PERCENT.quantity(0), UnitLookup.PERCENT.quantity(100))
>>> 265: 					.ifPresent(rows::add);
>>> 266: 			DataPageToolkit.buildLinesRow("Threads", "Various thread counts", allItems, true,
>> 
>> Do you think this might be better left as not filled? At least on Linux, the filled versions aren't transparent so overlaying a couple of these new values quickly covers up whatever is behind it. And with peak and total being the 3rd and 4th options, combining those with either of the first two and it gets hard to read.
>> 
>> example:
>> With two enabled:
>> ![Screenshot from 2024-11-01 10-33-11](https://github.com/user-attachments/assets/0f63615c-ac5d-4eff-8376-cb3bb8cca0a3)
>> 
>> Peak threads covers up the first two:
>> ![Screenshot from 2024-11-01 10-33-18](https://github.com/user-attachments/assets/f8fb4169-46a9-426b-8774-5e06e4bf171c)
>> 
>> And then total threads covers everything:
>> ![Screenshot from 2024-11-01 10-33-24](https://github.com/user-attachments/assets/4affba34-9b87-4820-b151-d97c132b6def)
>
> Good point. Will just use lines.

Forgot to localize the strings too.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/600#discussion_r1828528480