RFR: 8274: Add thread counts to the Java Application page [v3]
Alex Macdonald
aptmac at openjdk.org
Tue Nov 5 18:05:38 UTC 2024
On Tue, 5 Nov 2024 17:14:18 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> Added all of them, but perhaps only having active and daemon would be good enough.
>
> Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Merge branch '8274-thread-counts' of https://github.com/thegreystone/jmc into 8274-thread-counts
> - Localization and non-filled line graphs
> - 8274: Adding thread counts to the Java Application page
> - Localization and non-filled line graphs
> - 8274: Adding thread counts to the Java Application page
The code changes here look good to go, but the rebase ontop of master doesn't look to have been so clean, the jdk bot made a comment: https://github.com/openjdk/jmc/pull/600#issuecomment-2457734533
This PR now includes a merge commit and the 9 latest commits that were put into master. I think this may have to be cleaned up prior to integrating?
-------------
Marked as reviewed by aptmac (Reviewer).
PR Review: https://git.openjdk.org/jmc/pull/600#pullrequestreview-2416357157
More information about the jmc-dev
mailing list