RFR: 8284: Fix Jolokia discovery issues [v2]

Alex Macdonald aptmac at openjdk.org
Wed Nov 6 21:56:46 UTC 2024


On Mon, 4 Nov 2024 12:22:49 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> This fixes two bugs with Jolokia discovery:
>> 1. serious : repeated discovery runs crash. Runing repeatedly in the background is the whole point
>> 2. more of an annoyance: the PR disables JMC agent by omitting JVM info in the descriptor (as presence is interpreted as a local JVM)
>> Both tested OK.
>
> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into jolokia_discovery_issues
>  - reverted file that was committed by error
>  - Remove JVM info on discovered Jolokia VMs in order to disable JMC Agent functionality
>  - Fix bug where repeated runs of discovery crashes (kind of a showstopper)

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/597#pullrequestreview-2419500153


More information about the jmc-dev mailing list