From vpurnam at openjdk.org Fri Oct 11 17:46:50 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Fri, 11 Oct 2024 17:46:50 GMT Subject: RFR: 8260: Warnings and errors logged during XML processing Message-ID: We have several xml files in JMC. To remove fortify scan issue about XML Validation, **DocumentBuilderFactory.setValidating(true)** had been added. Because of that validation was triggered during the parsing of XML. We do not have **xsd files** against all the xml files and so it shows errors and warning. We can either create **xsd files** or **disable the ErrorValidator**. I think at this point disabling the default ErrorValidator is better option, and I have done the same in this PR. Could you please review the changes. Thanks. ------------- Commit messages: - 8260: Warnings and errors logged during XML processing Changes: https://git.openjdk.org/jmc/pull/592/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=592&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8260 Stats: 9 lines in 5 files changed: 7 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/592.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/592/head:pull/592 PR: https://git.openjdk.org/jmc/pull/592 From hirt at openjdk.org Fri Oct 11 17:53:18 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 11 Oct 2024 17:53:18 GMT Subject: RFR: 8219: Missing coverage in application reports [v9] In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 15:05:57 GMT, Alex Macdonald wrote: >> This PR fixes (&cleans up) the coverage reports under jmc/application. >> >> The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage. >> >> Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well. >> >> The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated. > > Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: > > - Add tycho.testArgLine.local to Jolokia test argLine > - adjust the argline for tycho-maven-plugin > - 8219: Missing coverage in application reports Marked as reviewed by hirt (Lead). Ok. Let's take it, but be prepared to follow up with a fix if the integration goes bad. ------------- PR Review: https://git.openjdk.org/jmc/pull/562#pullrequestreview-2363312905 PR Comment: https://git.openjdk.org/jmc/pull/562#issuecomment-2407877976 From hirt at openjdk.org Fri Oct 11 17:59:17 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 11 Oct 2024 17:59:17 GMT Subject: RFR: 8260: Warnings and errors logged during XML processing In-Reply-To: References: Message-ID: <3SYRl0br30vTUnyGpD3l0o9dnm23k7BMwWsY-dC1xhQ=.f026c5d8-e628-4741-9107-9e16a2f28e3f@github.com> On Fri, 11 Oct 2024 17:42:46 GMT, Virag Purnam wrote: > We have several xml files in JMC. To remove fortify scan issue about XML Validation, **DocumentBuilderFactory.setValidating(true)** had been added. Because of that validation was triggered during the parsing of XML. We do not have **xsd files** against all the xml files and so it shows errors and warning. > We can either create **xsd files** or **disable the ErrorValidator**. > I think at this point disabling the default ErrorValidator is better option, and I have done the same in this PR. > Could you please review the changes. Thanks. Marked as reviewed by hirt (Lead). Ok. Let's open a new ticket, and then we can see if someone would be interested in declaring the schemas. The ticket can link this PR and explain what needs to be done. ------------- PR Review: https://git.openjdk.org/jmc/pull/592#pullrequestreview-2363321567 PR Comment: https://git.openjdk.org/jmc/pull/592#issuecomment-2407886369 From vpurnam at openjdk.org Mon Oct 14 06:02:16 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Mon, 14 Oct 2024 06:02:16 GMT Subject: RFR: 8260: Warnings and errors logged during XML processing In-Reply-To: <3SYRl0br30vTUnyGpD3l0o9dnm23k7BMwWsY-dC1xhQ=.f026c5d8-e628-4741-9107-9e16a2f28e3f@github.com> References: <3SYRl0br30vTUnyGpD3l0o9dnm23k7BMwWsY-dC1xhQ=.f026c5d8-e628-4741-9107-9e16a2f28e3f@github.com> Message-ID: On Fri, 11 Oct 2024 17:56:50 GMT, Marcus Hirt wrote: >> We have several xml files in JMC. To remove fortify scan issue about XML Validation, **DocumentBuilderFactory.setValidating(true)** had been added. Because of that validation was triggered during the parsing of XML. We do not have **xsd files** against all the xml files and so it shows errors and warning. >> We can either create **xsd files** or **disable the ErrorValidator**. >> I think at this point disabling the default ErrorValidator is better option, and I have done the same in this PR. >> Could you please review the changes. Thanks. > > Ok. Let's open a new ticket, and then we can see if someone would be interested in declaring the schemas. The ticket can link this PR and explain what needs to be done. Thanks @thegreystone, I have created https://bugs.openjdk.org/browse/JMC-8273 and linked to JMC-8260 ------------- PR Comment: https://git.openjdk.org/jmc/pull/592#issuecomment-2410027627 From vpurnam at openjdk.org Mon Oct 14 06:02:17 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Mon, 14 Oct 2024 06:02:17 GMT Subject: Integrated: 8260: Warnings and errors logged during XML processing In-Reply-To: References: Message-ID: On Fri, 11 Oct 2024 17:42:46 GMT, Virag Purnam wrote: > We have several xml files in JMC. To remove fortify scan issue about XML Validation, **DocumentBuilderFactory.setValidating(true)** had been added. Because of that validation was triggered during the parsing of XML. We do not have **xsd files** against all the xml files and so it shows errors and warning. > We can either create **xsd files** or **disable the ErrorValidator**. > I think at this point disabling the default ErrorValidator is better option, and I have done the same in this PR. > Could you please review the changes. Thanks. This pull request has now been integrated. Changeset: cf85dbcb Author: Virag Purnam URL: https://git.openjdk.org/jmc/commit/cf85dbcb3872bd31c7d8145833eacda148455b3e Stats: 9 lines in 5 files changed: 7 ins; 0 del; 2 mod 8260: Warnings and errors logged during XML processing Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/592 From vpurnam at openjdk.org Fri Oct 18 09:46:30 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Fri, 18 Oct 2024 09:46:30 GMT Subject: RFR: 6683: Mouse over for Event Thread should show the various thread IDs Message-ID: Added "Thread Id" information for Mouse Hover on Event Thread as well as in properties view. **Before:** No information on Hover EventThread_Before **After:** Thread Id shown on Hover EventThread_After **Before:** Only Thread Description shown in properties view Properties_Before **After:** Along with Thread Description, Thread Id also shown in properties view Properties_After Could you please review the changes? Please suggest if anything more is needed with this enhancement request. ------------- Commit messages: - 6683: Mouse over for Event Thread should show the various thread IDs Changes: https://git.openjdk.org/jmc/pull/593/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=593&range=00 Issue: https://bugs.openjdk.org/browse/JMC-6683 Stats: 205 lines in 10 files changed: 152 ins; 35 del; 18 mod Patch: https://git.openjdk.org/jmc/pull/593.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/593/head:pull/593 PR: https://git.openjdk.org/jmc/pull/593 From hirt at openjdk.org Mon Oct 21 23:06:11 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 21 Oct 2024 23:06:11 GMT Subject: RFR: 8276: UI tests failing on Windows Message-ID: Ignoring failing tests for now. ------------- Commit messages: - Adding another ignore - 8276: Undoing PR #575 - 8276: Requiring JDK 21+ for anything under application Changes: https://git.openjdk.org/jmc/pull/594/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=594&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8276 Stats: 113 lines in 109 files changed: 6 ins; 0 del; 107 mod Patch: https://git.openjdk.org/jmc/pull/594.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/594/head:pull/594 PR: https://git.openjdk.org/jmc/pull/594 From aptmac at openjdk.org Tue Oct 22 20:36:15 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 22 Oct 2024 20:36:15 GMT Subject: RFR: 8276: UI tests failing on Windows In-Reply-To: References: Message-ID: <7JV6CoJ13Lb2OVIJhSn367wtBIJ7rhscwDMkuYrSsMU=.5c8700b4-ddb7-42de-b290-094d48ba171b@github.com> On Mon, 21 Oct 2024 23:02:00 GMT, Marcus Hirt wrote: > Ignoring failing tests for now. Interesting that those tests are failing, as the main fix was merged into JDK 19 and then backported to 17 (which is where I tested and un-ignored the tests). At the moment my Windows setup is not having a fun time with Jemmy so I'll try to fix my local workspace and try again soon. application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/ControlRecordingsTest.java line 251: > 249: * Verifies that recording events can be added/removed on the fly > 250: */ > 251: @Ignore("JDK-8286740 did not fix the issue on Windows") JDK-8286740 was the backport, now that we're on JDK 21 the correct issue would be: https://bugs.openjdk.org/browse/JDK-8328159 ------------- PR Review: https://git.openjdk.org/jmc/pull/594#pullrequestreview-2386241339 PR Review Comment: https://git.openjdk.org/jmc/pull/594#discussion_r1811348699 From aptmac at openjdk.org Thu Oct 24 14:07:24 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 24 Oct 2024 14:07:24 GMT Subject: RFR: 8276: UI tests failing on Windows In-Reply-To: References: Message-ID: On Mon, 21 Oct 2024 23:02:00 GMT, Marcus Hirt wrote: > Ignoring failing tests for now. I'm seeing this on my Linux machine (my Windows builds are still on fire), so the ignore statements can be updated to be non-specific to Windows. Will have to take a look at what is going on another time. ------------- Marked as reviewed by aptmac (Reviewer). PR Review: https://git.openjdk.org/jmc/pull/594#pullrequestreview-2392697463 From vpurnam at openjdk.org Thu Oct 24 14:13:14 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Thu, 24 Oct 2024 14:13:14 GMT Subject: RFR: 8276: UI tests failing on Windows In-Reply-To: References: Message-ID: On Mon, 21 Oct 2024 23:02:00 GMT, Marcus Hirt wrote: > Ignoring failing tests for now. LGTM. Branch "8276-ui-tests" has been created directly to "**openjdk/jmc**" and not on forked repo. After merging, this branch needs to be deleted. ------------- Marked as reviewed by vpurnam (Committer). PR Review: https://git.openjdk.org/jmc/pull/594#pullrequestreview-2392728310 From aptmac at openjdk.org Thu Oct 24 14:38:21 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 24 Oct 2024 14:38:21 GMT Subject: RFR: 8276: UI tests failing on Windows In-Reply-To: References: Message-ID: On Mon, 21 Oct 2024 23:02:00 GMT, Marcus Hirt wrote: > Ignoring failing tests for now. Not sure what's going on with the checks here, but it's only showing the one jcheck for me, similar to https://github.com/openjdk/jmc/pull/588. Wonder what happened to the other CI actions. ------------- PR Comment: https://git.openjdk.org/jmc/pull/594#issuecomment-2435475750 From vpurnam at openjdk.org Fri Oct 25 03:51:13 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Fri, 25 Oct 2024 03:51:13 GMT Subject: RFR: 8276: UI tests failing on Windows In-Reply-To: References: Message-ID: On Mon, 21 Oct 2024 23:02:00 GMT, Marcus Hirt wrote: > Ignoring failing tests for now. > Not sure what's going on with the checks here, but it's only showing the one jcheck for me, similar to #588. > > Wonder what happened to the other CI actions. @aptmac: Other jcheck only runs on forked repo. As this branch is directly on main repo, other jcheck is missing. ------------- PR Comment: https://git.openjdk.org/jmc/pull/594#issuecomment-2436763537 From aptmac at openjdk.org Fri Oct 25 13:51:17 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 25 Oct 2024 13:51:17 GMT Subject: RFR: 8276: UI tests failing on Windows In-Reply-To: References: Message-ID: On Fri, 25 Oct 2024 03:48:34 GMT, Virag Purnam wrote: > > Not sure what's going on with the checks here, but it's only showing the one jcheck for me, similar to #588. > > Wonder what happened to the other CI actions. > > @aptmac: Other jcheck only runs on forked repo. As this branch is directly on main repo, other jcheck is missing. Interesting, thanks for the info. Would you happen to know why they didn't run on this PR then? https://github.com/openjdk/jmc/pull/588 ------------- PR Comment: https://git.openjdk.org/jmc/pull/594#issuecomment-2437832995 From vpurnam at openjdk.org Fri Oct 25 14:05:14 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Fri, 25 Oct 2024 14:05:14 GMT Subject: RFR: 8276: UI tests failing on Windows In-Reply-To: References: Message-ID: On Mon, 21 Oct 2024 23:02:00 GMT, Marcus Hirt wrote: > Ignoring failing tests for now. I think "Martin Skarsaune" has not enabled the workflow run in his forked repo. ------------- PR Comment: https://git.openjdk.org/jmc/pull/594#issuecomment-2437866223 From aptmac at openjdk.org Fri Oct 25 14:19:11 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 25 Oct 2024 14:19:11 GMT Subject: RFR: 8276: UI tests failing on Windows In-Reply-To: References: Message-ID: On Fri, 25 Oct 2024 14:02:20 GMT, Virag Purnam wrote: > I think "Martin Skarsaune" has not enabled the workflow run in his forked repo. That might be it, I'll have to poke around a bit more. His first handful of PRs did all the workflows, but his current actions seem to be stuck on a workflow dependency that is failing for a reason not obvious to me. ------------- PR Comment: https://git.openjdk.org/jmc/pull/594#issuecomment-2437939017 From vpurnam at openjdk.org Fri Oct 25 14:26:15 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Fri, 25 Oct 2024 14:26:15 GMT Subject: RFR: 8276: UI tests failing on Windows In-Reply-To: References: Message-ID: <4Oevvc2x5jb0XkEca5fp8iFLag049vHyQoJe7xndiyU=.0a6e9fc9-4022-4fea-ba85-d7c7e98447ad@github.com> On Mon, 21 Oct 2024 23:02:00 GMT, Marcus Hirt wrote: > Ignoring failing tests for now. Oh ok. I will see the log and try. ------------- PR Comment: https://git.openjdk.org/jmc/pull/594#issuecomment-2437956509 From aptmac at openjdk.org Fri Oct 25 17:51:14 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 25 Oct 2024 17:51:14 GMT Subject: RFR: 8261: Use test flag to skip JDP multicast tests in JolokiaTest In-Reply-To: References: Message-ID: On Wed, 11 Sep 2024 19:40:23 GMT, Martin Skarsaune wrote: > I just became aware that there is a new flag used to skip JDP tests. > I previously added some env checking to skip similar multicast tests for Jolokia. > Hence it would be a lot cleaner to use the new standardized mechanism for this. > Trying out whether this fixes [JMC-8261](https://bugs.openjdk.org/browse/JMC-8261) I took this branch and ran the actions on my own fork, there's a style issue that needs to be fixed by running `mvn spotless:apply`, but the fix for Mac doesn't seem to be working as intended: https://github.com/aptmac/jmc/actions/runs/11522768181/job/32079324937#step:9:16964 ------------- PR Comment: https://git.openjdk.org/jmc/pull/588#issuecomment-2438440263 From hirt at openjdk.org Sun Oct 27 18:08:06 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Sun, 27 Oct 2024 18:08:06 GMT Subject: Integrated: 8276: UI tests failing on Windows In-Reply-To: References: Message-ID: On Mon, 21 Oct 2024 23:02:00 GMT, Marcus Hirt wrote: > Ignoring failing tests for now. This pull request has now been integrated. Changeset: 9e3bbaa5 Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/9e3bbaa55fafc9ca9a36148076428557ea008f64 Stats: 113 lines in 109 files changed: 6 ins; 0 del; 107 mod 8276: UI tests failing on Windows Reviewed-by: aptmac, vpurnam ------------- PR: https://git.openjdk.org/jmc/pull/594 From duke at openjdk.org Mon Oct 28 14:28:05 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Mon, 28 Oct 2024 14:28:05 GMT Subject: RFR: 8261: Use test flag to skip JDP multicast tests in JolokiaTest In-Reply-To: References: Message-ID: <_IyqsoTHLliiU--I5-iC1cPFnWqWTV6Y00gvx2tDjEI=.4773c4dd-a903-43b1-9eb6-2b6436c0b461@github.com> On Wed, 11 Sep 2024 19:40:23 GMT, Martin Skarsaune wrote: > I just became aware that there is a new flag used to skip JDP tests. > I previously added some env checking to skip similar multicast tests for Jolokia. > Hence it would be a lot cleaner to use the new standardized mechanism for this. > Trying out whether this fixes [JMC-8261](https://bugs.openjdk.org/browse/JMC-8261) Thanks. Mac OS was the particular case that fails. It may be something else then. As I have no simple way to reproduce the pipeline behaviour I suggest we abandon this one. Bigger fish to fry. ------------- PR Comment: https://git.openjdk.org/jmc/pull/588#issuecomment-2441743379 From hirt at openjdk.org Tue Oct 29 23:53:19 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 29 Oct 2024 23:53:19 GMT Subject: RFR: 8277: List ARM first Message-ID: ...for Mac and listing architectures in the same way as for Linux (but being a bit more concrete for Mac). Got annoyed when demoing. ------------- Commit messages: - 8277: Listing ARM first for Mac and listing archiectures in the same way as for Linux Changes: https://git.openjdk.org/jmc/pull/595/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=595&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8277 Stats: 6 lines in 1 file changed: 3 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/595.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/595/head:pull/595 PR: https://git.openjdk.org/jmc/pull/595 From schaturvedi at openjdk.org Wed Oct 30 07:18:45 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Wed, 30 Oct 2024 07:18:45 GMT Subject: RFR: 6626: The halt rule result should have a table of the VM operations Message-ID: Added top 5 vm operations (ordered by max time), including the thread that initiated them. Since the halt rule was pointing to VM operation rule in its description, hence i have added the table to vm opertion rule itself where it was more related to. The rule looks something like this now. image ------------- Commit messages: - 6626: The halt rule result should have a table of the VM operations Changes: https://git.openjdk.org/jmc/pull/596/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=596&range=00 Issue: https://bugs.openjdk.org/browse/JMC-6626 Stats: 43 lines in 3 files changed: 42 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/596.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/596/head:pull/596 PR: https://git.openjdk.org/jmc/pull/596 From hirt at openjdk.org Wed Oct 30 12:20:15 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 30 Oct 2024 12:20:15 GMT Subject: RFR: 8261: Use test flag to skip JDP multicast tests in JolokiaTest In-Reply-To: References: Message-ID: On Wed, 11 Sep 2024 19:40:23 GMT, Martin Skarsaune wrote: > I just became aware that there is a new flag used to skip JDP tests. > I previously added some env checking to skip similar multicast tests for Jolokia. > Hence it would be a lot cleaner to use the new standardized mechanism for this. > Trying out whether this fixes [JMC-8261](https://bugs.openjdk.org/browse/JMC-8261) Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/588#pullrequestreview-2404674647 From hirt at openjdk.org Wed Oct 30 20:44:51 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 30 Oct 2024 20:44:51 GMT Subject: RFR: 8277: List ARM first In-Reply-To: References: Message-ID: On Tue, 29 Oct 2024 23:48:49 GMT, Marcus Hirt wrote: > ...for Mac and listing architectures in the same way as for Linux (but being a bit more concrete for Mac). > > Got annoyed when demoing. A spot bugs fail, that only happens on Mac, and only when building in the CI? From changing the readme? Huh. ------------- PR Comment: https://git.openjdk.org/jmc/pull/595#issuecomment-2448335282 From hirt at openjdk.org Wed Oct 30 20:48:46 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 30 Oct 2024 20:48:46 GMT Subject: RFR: 6626: The halt rule result should have a table of the VM operations In-Reply-To: References: Message-ID: On Wed, 30 Oct 2024 07:14:01 GMT, Suchita Chaturvedi wrote: > Added top 5 vm operations (ordered by max time), including the thread that initiated them. > Since the halt rule was pointing to VM operation rule in its description, hence i have added the table to vm opertion rule itself where it was more related to. > > The rule looks something like this now. > image There is an unrelated spot bugs problem in master right now, that for some reason only triggers on Mac. It is unrelated to this PR. ------------- PR Comment: https://git.openjdk.org/jmc/pull/596#issuecomment-2448342190 From hirt at openjdk.org Wed Oct 30 21:09:30 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 30 Oct 2024 21:09:30 GMT Subject: RFR: 8277: List ARM first In-Reply-To: References: Message-ID: <-h6mvyyhTAJQmM7zc87raw86iJ6tBpowgji2zc-GpbU=.97b8f35d-58bf-47dc-87d5-b96235b04434@github.com> On Tue, 29 Oct 2024 23:48:49 GMT, Marcus Hirt wrote: > ...for Mac and listing architectures in the same way as for Linux (but being a bit more concrete for Mac). > > Got annoyed when demoing. https://bugs.openjdk.org/browse/JMC-8282 ------------- PR Comment: https://git.openjdk.org/jmc/pull/595#issuecomment-2448350725 From hirt at openjdk.org Wed Oct 30 21:48:19 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 30 Oct 2024 21:48:19 GMT Subject: RFR: 8282: Spotbugs errors Message-ID: Excluding spot bugs being overzealous. ------------- Commit messages: - Formatting problem - 8282: Fixing spotbugs problem Changes: https://git.openjdk.org/jmc/pull/598/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=598&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8282 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/598.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/598/head:pull/598 PR: https://git.openjdk.org/jmc/pull/598 From hirt at openjdk.org Wed Oct 30 23:09:15 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 30 Oct 2024 23:09:15 GMT Subject: RFR: 8282: Spotbugs errors [v2] In-Reply-To: References: Message-ID: > Excluding spot bugs being overzealous. Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: More excludes required ------------- Changes: - all: https://git.openjdk.org/jmc/pull/598/files - new: https://git.openjdk.org/jmc/pull/598/files/d5ffa512..d4bcb6c1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=598&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=598&range=00-01 Stats: 64 lines in 1 file changed: 63 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/598.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/598/head:pull/598 PR: https://git.openjdk.org/jmc/pull/598 From aptmac at openjdk.org Thu Oct 31 02:39:36 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 31 Oct 2024 02:39:36 GMT Subject: RFR: 8277: List ARM first In-Reply-To: References: Message-ID: On Tue, 29 Oct 2024 23:48:49 GMT, Marcus Hirt wrote: > ...for Mac and listing architectures in the same way as for Linux (but being a bit more concrete for Mac). > > Got annoyed when demoing. Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/595#pullrequestreview-2406839417 From aptmac at openjdk.org Thu Oct 31 02:39:36 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 31 Oct 2024 02:39:36 GMT Subject: RFR: 8282: Spotbugs errors [v2] In-Reply-To: References: Message-ID: On Wed, 30 Oct 2024 23:09:15 GMT, Marcus Hirt wrote: >> Excluding spot bugs being overzealous. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > More excludes required Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/598#pullrequestreview-2406839625 From hirt at openjdk.org Thu Oct 31 09:04:36 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 31 Oct 2024 09:04:36 GMT Subject: Integrated: 8282: Spotbugs errors In-Reply-To: References: Message-ID: On Wed, 30 Oct 2024 21:20:50 GMT, Marcus Hirt wrote: > Excluding spot bugs being overzealous. This pull request has now been integrated. Changeset: 10c01dc0 Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/10c01dc07fd7207339077626fe62fec5413c32f5 Stats: 70 lines in 1 file changed: 68 ins; 0 del; 2 mod 8282: Spotbugs errors Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/598 From hirt at openjdk.org Thu Oct 31 09:45:37 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 31 Oct 2024 09:45:37 GMT Subject: Integrated: 8277: List ARM first In-Reply-To: References: Message-ID: On Tue, 29 Oct 2024 23:48:49 GMT, Marcus Hirt wrote: > ...for Mac and listing architectures in the same way as for Linux (but being a bit more concrete for Mac). > > Got annoyed when demoing. This pull request has now been integrated. Changeset: 5c49e6b5 Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/5c49e6b5127d7ffe9866d96ed3d5a94c62e8ab79 Stats: 6 lines in 1 file changed: 3 ins; 2 del; 1 mod 8277: List ARM first Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/595 From duke at openjdk.org Thu Oct 31 16:08:47 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Thu, 31 Oct 2024 16:08:47 GMT Subject: RFR: 8284: Fix Jolokia discovery issues Message-ID: This fixes two bugs with Jolokia discovery: 1. serious : repeated discovery runs crash. Runing repeatedly in the background is the whole point 2. more of an annoyance: the PR disables JMC agent by omitting JVM info in the descriptor (as presence is interpreted as a local JVM) Both tested OK. ------------- Commit messages: - reverted file that was committed by error - Remove JVM info on discovered Jolokia VMs in order to disable JMC Agent functionality - Fix bug where repeated runs of discovery crashes (kind of a showstopper) Changes: https://git.openjdk.org/jmc/pull/597/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=597&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8284 Stats: 115 lines in 2 files changed: 3 ins; 105 del; 7 mod Patch: https://git.openjdk.org/jmc/pull/597.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/597/head:pull/597 PR: https://git.openjdk.org/jmc/pull/597 From duke at openjdk.org Thu Oct 31 16:08:48 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Thu, 31 Oct 2024 16:08:48 GMT Subject: RFR: 8284: Fix Jolokia discovery issues In-Reply-To: References: Message-ID: On Wed, 30 Oct 2024 18:47:30 GMT, Martin Skarsaune wrote: > This fixes two bugs with Jolokia discovery: > 1. serious : repeated discovery runs crash. Runing repeatedly in the background is the whole point > 2. more of an annoyance: the PR disables JMC agent by omitting JVM info in the descriptor (as presence is interpreted as a local JVM) > Both tested OK. @aptmac : Are you able to create a bug for this. Or two if that is preferrable. Details on the bugs: 1. SEVERE: Cannot register MBean jolokia:type=Discovery,agent=jmc: javax.management.InstanceAlreadyExistsException: jolokia:type=Discovery,agent=jmc javax.management.InstanceAlreadyExistsException: jolokia:type=Discovery,agent=jmc at java.management/com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:322) at java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerWithRepository(DefaultMBeanServerInterceptor.java:1848) at java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:945) at java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(DefaultMBeanServerInterceptor.java:880) at java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:315) at java.management/com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:523) at org.jolokia.server.core.service.impl.MBeanRegistry.registerMBeanAtServer(MBeanRegistry.java:80) at org.jolokia.server.core.service.impl.MBeanRegistry.registerMBean(MBeanRegistry.java:54) at org.jolokia.server.core.service.impl.JolokiaServiceManagerImpl.registerMBean(JolokiaServiceManagerImpl.java:409) at org.jolokia.server.core.service.impl.JolokiaContextImpl.registerMBean(JolokiaContextImpl.java:45) at org.jolokia.server.core.service.api.AbstractJolokiaService.registerJolokiaMBean(AbstractJolokiaService.java:98) at org.jolokia.service.discovery.JolokiaDiscovery.init(JolokiaDiscovery.java:45) at org.openjdk.jmc.jolokia.JolokiaDiscoveryListener.discoverJvms(JolokiaDiscoveryListener.java:70) at org.openjdk.jmc.jolokia.AbstractCachedDescriptorProvider$Scanner.scan(AbstractCachedDescriptorProvider.java:86) at org.openjdk.jmc.jolokia.AbstractCachedDescriptorProvider$Scanner.run(AbstractCachedDescriptorProvider.java:70) at java.base/java.lang.Thread.run(Thread.java:1583) 2. This option does not make sense for Jolokia: image application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaDiscoveryListener.java line 55: > 53: public JolokiaDiscoveryListener(JolokiaDiscoverySettings settings) { > 54: this.settings = settings; > 55: jolokiaDiscovery = new JolokiaDiscovery(); Ensure that only one instance is instantiated (linked to the lifecycle of this plugin). If one tries to instantiate another, it will attempt to register an MBean and sinply crash ------------- PR Comment: https://git.openjdk.org/jmc/pull/597#issuecomment-2448101768 PR Review Comment: https://git.openjdk.org/jmc/pull/597#discussion_r1824750529 From aptmac at openjdk.org Thu Oct 31 16:08:48 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 31 Oct 2024 16:08:48 GMT Subject: RFR: 8284: Fix Jolokia discovery issues In-Reply-To: References: Message-ID: <9fn61vS8qHDRHWCDwUASI2pXTJqJOXGa3TyOwxX6E2A=.2c6196ca-25f4-43b4-a7f5-2db2f5f7bb32@github.com> On Wed, 30 Oct 2024 19:00:52 GMT, Martin Skarsaune wrote: >> This fixes two bugs with Jolokia discovery: >> 1. serious : repeated discovery runs crash. Runing repeatedly in the background is the whole point >> 2. more of an annoyance: the PR disables JMC agent by omitting JVM info in the descriptor (as presence is interpreted as a local JVM) >> Both tested OK. > > @aptmac : Are you able to create a bug for this. Or two if that is preferrable. > Details on the bugs: > > 1. > > SEVERE: Cannot register MBean jolokia:type=Discovery,agent=jmc: javax.management.InstanceAlreadyExistsException: jolokia:type=Discovery,agent=jmc > javax.management.InstanceAlreadyExistsException: jolokia:type=Discovery,agent=jmc > at java.management/com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:322) > at java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerWithRepository(DefaultMBeanServerInterceptor.java:1848) > at java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:945) > at java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(DefaultMBeanServerInterceptor.java:880) > at java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:315) > at java.management/com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:523) > at org.jolokia.server.core.service.impl.MBeanRegistry.registerMBeanAtServer(MBeanRegistry.java:80) > at org.jolokia.server.core.service.impl.MBeanRegistry.registerMBean(MBeanRegistry.java:54) > at org.jolokia.server.core.service.impl.JolokiaServiceManagerImpl.registerMBean(JolokiaServiceManagerImpl.java:409) > at org.jolokia.server.core.service.impl.JolokiaContextImpl.registerMBean(JolokiaContextImpl.java:45) > at org.jolokia.server.core.service.api.AbstractJolokiaService.registerJolokiaMBean(AbstractJolokiaService.java:98) > at org.jolokia.service.discovery.JolokiaDiscovery.init(JolokiaDiscovery.java:45) > at org.openjdk.jmc.jolokia.JolokiaDiscoveryListener.discoverJvms(JolokiaDiscoveryListener.java:70) > at org.openjdk.jmc.jolokia.AbstractCachedDescriptorProvider$Scanner.scan(AbstractCachedDescriptorProvider.java:86) > at org.openjdk.jmc.jolokia.AbstractCachedDescriptorProvider$Scanner.run(AbstractCachedDescriptorProvider.java:70) > at java.base/java.lang.Thread.run(Thread.java:1583) > > 2. This option does not make sense for Jolokia: > > image @skarsaune I've rolled both of these issues into one ticket if that's okay, I think it fits with this PR that accomplishes both at once. https://bugs.openjdk.org/browse/JMC-8284 ------------- PR Comment: https://git.openjdk.org/jmc/pull/597#issuecomment-2450086793 From hirt at openjdk.org Thu Oct 31 19:54:44 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 31 Oct 2024 19:54:44 GMT Subject: Integrated: 8285: Documentation fix Message-ID: The documentation fails to mention that both JDK 17 and 21 are now needed in the toolchain. ------------- Commit messages: - 8285: Documentation fix Changes: https://git.openjdk.org/jmc/pull/599/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=599&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8285 Stats: 22 lines in 1 file changed: 18 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/599.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/599/head:pull/599 PR: https://git.openjdk.org/jmc/pull/599 From hirt at openjdk.org Thu Oct 31 19:54:45 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 31 Oct 2024 19:54:45 GMT Subject: Integrated: 8285: Documentation fix In-Reply-To: References: Message-ID: <0xUu2uQyVF8927Kryi2Y709WTycpBgMqj0ps-3P4_DE=.3db872b0-51dc-4672-8714-e5be5e1ec76d@github.com> On Thu, 31 Oct 2024 19:48:41 GMT, Marcus Hirt wrote: > The documentation fails to mention that both JDK 17 and 21 are now needed in the toolchain. This pull request has now been integrated. Changeset: 6c244aef Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/6c244aef61a5d05a74a78dfda49ce92e2aa48982 Stats: 22 lines in 1 file changed: 18 ins; 1 del; 3 mod 8285: Documentation fix Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/599 From aptmac at openjdk.org Thu Oct 31 19:54:44 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 31 Oct 2024 19:54:44 GMT Subject: Integrated: 8285: Documentation fix In-Reply-To: References: Message-ID: On Thu, 31 Oct 2024 19:48:41 GMT, Marcus Hirt wrote: > The documentation fails to mention that both JDK 17 and 21 are now needed in the toolchain. Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/599#pullrequestreview-2408954707