From vpurnam at openjdk.org Tue Sep 3 07:53:54 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Tue, 3 Sep 2024 07:53:54 GMT Subject: RFR: 7490: Trigger action does not return error message on failure. Message-ID: If trigger action encounters any exception/error, it does not display the trigger value. On failure with the failure message, trigger value also should be displayed for the user. For example, if we are writing log to the drive which does not exists. Trigger action fails with IO exception. FileWriteExceptionWithoutShowingTriggerValue With this change, trigger value has been displayed along with IO exception. FileWriteExceptionShowingTriggerValue This change has been done for all the trigger actions. Along with this, few basic path and email validation has been added. Path validation: PathValidation Email validation: EmailValidation ------------- Commit messages: - 7490: Trigger action does not return error message on failure. Changes: https://git.openjdk.org/jmc/pull/581/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=581&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7490 Stats: 239 lines in 20 files changed: 181 ins; 2 del; 56 mod Patch: https://git.openjdk.org/jmc/pull/581.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/581/head:pull/581 PR: https://git.openjdk.org/jmc/pull/581 From duke at openjdk.org Thu Sep 5 07:35:24 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Thu, 5 Sep 2024 07:35:24 GMT Subject: RFR: JMC-8236: Actually hook in the jolokia discovery mechanism Message-ID: This got left out of #570 . All the test runs fine, but the mechansim was not properly plugged in :facepalm: cc: @aptmac ------------- Commit messages: - JMC-8236: Actually hook in the discovery mechanism Changes: https://git.openjdk.org/jmc/pull/583/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=583&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8236 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/583.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/583/head:pull/583 PR: https://git.openjdk.org/jmc/pull/583 From aptmac at openjdk.org Thu Sep 5 12:53:58 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 5 Sep 2024 12:53:58 GMT Subject: RFR: JMC-8236: Add support for Jolokia discovery - hook in plugin In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 07:29:33 GMT, Martin Skarsaune wrote: > This got left out of #570 . All the test runs fine, but the mechansim was not properly plugged in :facepalm: > cc: @aptmac Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/583#pullrequestreview-2282939076 From duke at openjdk.org Thu Sep 5 12:59:58 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Thu, 5 Sep 2024 12:59:58 GMT Subject: RFR: JMC-8236: Add support for Jolokia discovery - hook in plugin In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 07:29:33 GMT, Martin Skarsaune wrote: > This got left out of #570 . All the test runs fine, but the mechansim was not properly plugged in :facepalm: > cc: @aptmac Wondering whether I need a new issue for this one. Will see if I can make it to the integration step ------------- PR Comment: https://git.openjdk.org/jmc/pull/583#issuecomment-2331614222 From aptmac at openjdk.org Thu Sep 5 13:19:59 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 5 Sep 2024 13:19:59 GMT Subject: RFR: JMC-8236: Add support for Jolokia discovery - hook in plugin In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 12:57:01 GMT, Martin Skarsaune wrote: >> This got left out of #570 . All the test runs fine, but the mechansim was not properly plugged in :facepalm: >> cc: @aptmac > > Wondering whether I need a new issue for this one. Will see if I can make it to the integration step @skarsaune I'll make a new issue for this and post it here shortly ------------- PR Comment: https://git.openjdk.org/jmc/pull/583#issuecomment-2331657681 From aptmac at openjdk.org Thu Sep 5 13:20:01 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 5 Sep 2024 13:20:01 GMT Subject: RFR: JMC-8236: Add support for Jolokia discovery - hook in plugin In-Reply-To: References: Message-ID: <2iQCDO0fzl2YXpCppH-tnvBdfYpzZowggBqqp__1Cqc=.f3bb3179-3695-42d2-93de-1a7da7c23cf8@github.com> On Thu, 5 Sep 2024 07:29:33 GMT, Martin Skarsaune wrote: > This got left out of #570 . All the test runs fine, but the mechansim was not properly plugged in :facepalm: > cc: @aptmac https://bugs.openjdk.org/browse/JMC-8251 application/org.openjdk.jmc.jolokia/plugin.xml line 59: > 57: > 58: > 59: References: Message-ID: <-r2cVzug5P4s34mNpEZ_EgpzWztyNazUYfu93jknzDw=.9e1e516e-ead3-4627-9804-1c5407b8e906@github.com> > This got left out of #570 . All the test runs fine, but the mechansim was not properly plugged in :facepalm: > cc: @aptmac Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: JMC-8251: Adjust indentation in plugin.xml ------------- Changes: - all: https://git.openjdk.org/jmc/pull/583/files - new: https://git.openjdk.org/jmc/pull/583/files/fb70cb4b..c048833f Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=583&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=583&range=00-01 Stats: 18 lines in 1 file changed: 0 ins; 0 del; 18 mod Patch: https://git.openjdk.org/jmc/pull/583.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/583/head:pull/583 PR: https://git.openjdk.org/jmc/pull/583 From duke at openjdk.org Thu Sep 5 17:43:50 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Thu, 5 Sep 2024 17:43:50 GMT Subject: RFR: 8251: Add missing hook in plugin from Jolokia discovery [v2] In-Reply-To: <2iQCDO0fzl2YXpCppH-tnvBdfYpzZowggBqqp__1Cqc=.f3bb3179-3695-42d2-93de-1a7da7c23cf8@github.com> References: <2iQCDO0fzl2YXpCppH-tnvBdfYpzZowggBqqp__1Cqc=.f3bb3179-3695-42d2-93de-1a7da7c23cf8@github.com> Message-ID: <1StWkDafG1eRB56Q4CypISiiUaQ39ZQkgkZNKcfVpEM=.fc5ec6f3-285b-494d-86c9-a5edc143f4f2@github.com> On Thu, 5 Sep 2024 13:16:12 GMT, Alex Macdonald wrote: >> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: >> >> JMC-8251: Adjust indentation in plugin.xml > > application/org.openjdk.jmc.jolokia/plugin.xml line 59: > >> 57: >> 58: >> 59: > The indenting here looks off, this tag should be back a tab Looking closer, the indentation appears to be a bit all over the place. I did look at a few other plugin.xml and that appears to be quite widespread. Have normalized this file now. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/583#discussion_r1745932794 From aptmac at openjdk.org Thu Sep 5 20:06:56 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 5 Sep 2024 20:06:56 GMT Subject: RFR: 8251: Add missing hook in plugin from Jolokia discovery [v2] In-Reply-To: <-r2cVzug5P4s34mNpEZ_EgpzWztyNazUYfu93jknzDw=.9e1e516e-ead3-4627-9804-1c5407b8e906@github.com> References: <-r2cVzug5P4s34mNpEZ_EgpzWztyNazUYfu93jknzDw=.9e1e516e-ead3-4627-9804-1c5407b8e906@github.com> Message-ID: On Thu, 5 Sep 2024 17:43:48 GMT, Martin Skarsaune wrote: >> This got left out of #570 . All the test runs fine, but the mechansim was not properly plugged in :facepalm: >> cc: @aptmac > > Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: > > JMC-8251: Adjust indentation in plugin.xml application/org.openjdk.jmc.jolokia/plugin.xml line 53: > 51: > 52: > 53: References: Message-ID: > This got left out of #570 . All the test runs fine, but the mechansim was not properly plugged in :facepalm: > cc: @aptmac Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: JMC-8251: One more indentation adjustment ------------- Changes: - all: https://git.openjdk.org/jmc/pull/583/files - new: https://git.openjdk.org/jmc/pull/583/files/c048833f..43839ffa Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=583&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=583&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/583.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/583/head:pull/583 PR: https://git.openjdk.org/jmc/pull/583 From duke at openjdk.org Fri Sep 6 07:33:56 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Fri, 6 Sep 2024 07:33:56 GMT Subject: RFR: 8251: Add missing hook in plugin from Jolokia discovery [v2] In-Reply-To: References: <-r2cVzug5P4s34mNpEZ_EgpzWztyNazUYfu93jknzDw=.9e1e516e-ead3-4627-9804-1c5407b8e906@github.com> Message-ID: On Thu, 5 Sep 2024 20:04:48 GMT, Alex Macdonald wrote: >> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: >> >> JMC-8251: Adjust indentation in plugin.xml > > application/org.openjdk.jmc.jolokia/plugin.xml line 53: > >> 51: >> 52: >> 53: > I think this line needs 1 more space I think so too .... :facepalm: ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/583#discussion_r1746638236 From duke at openjdk.org Fri Sep 6 11:08:55 2024 From: duke at openjdk.org (duke) Date: Fri, 6 Sep 2024 11:08:55 GMT Subject: RFR: 8251: Add missing hook in plugin from Jolokia discovery [v3] In-Reply-To: References: Message-ID: On Fri, 6 Sep 2024 07:30:09 GMT, Martin Skarsaune wrote: >> This got left out of #570 . All the test runs fine, but the mechansim was not properly plugged in :facepalm: >> cc: @aptmac > > Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: > > JMC-8251: One more indentation adjustment @skarsaune Your change (at version 43839ffae96df2de4e6f1d47adb174c5b0c091bb) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jmc/pull/583#issuecomment-2333816703 From duke at openjdk.org Fri Sep 6 13:25:57 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Fri, 6 Sep 2024 13:25:57 GMT Subject: Integrated: 8251: Add missing hook in plugin from Jolokia discovery In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 07:29:33 GMT, Martin Skarsaune wrote: > This got left out of #570 . All the test runs fine, but the mechansim was not properly plugged in :facepalm: > cc: @aptmac This pull request has now been integrated. Changeset: 60c48d9b Author: Martin Skarsaune Committer: Alex Macdonald URL: https://git.openjdk.org/jmc/commit/60c48d9b178dd2c853de874d7529b4335c89e708 Stats: 23 lines in 1 file changed: 6 ins; 0 del; 17 mod 8251: Add missing hook in plugin from Jolokia discovery Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/583 From aptmac at openjdk.org Fri Sep 6 13:48:28 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 6 Sep 2024 13:48:28 GMT Subject: RFR: 8219: Missing coverage in application reports [v6] In-Reply-To: References: Message-ID: <3jwRUO8Xydxql7ZomdEVO7YtAKD7F7tdU-3ylwJusKQ=.825c1853-82eb-45c5-a987-3d912b64394e@github.com> > This PR fixes (&cleans up) the coverage reports under jmc/application. > > The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage. > > Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well. > > The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated. Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Add tycho.testArgLine.local to Jolokia test argLine - adjust the argline for tycho-maven-plugin - 8219: Missing coverage in application reports ------------- Changes: https://git.openjdk.org/jmc/pull/562/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=562&range=05 Stats: 117 lines in 7 files changed: 10 ins; 88 del; 19 mod Patch: https://git.openjdk.org/jmc/pull/562.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/562/head:pull/562 PR: https://git.openjdk.org/jmc/pull/562 From aptmac at openjdk.org Fri Sep 6 14:16:47 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 6 Sep 2024 14:16:47 GMT Subject: RFR: 8238: Update to Eclipse 2024-06 In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 22:28:06 GMT, Marcus Hirt wrote: > This one got a bit interesting. Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/578#pullrequestreview-2286393038 From duke at openjdk.org Fri Sep 6 16:09:48 2024 From: duke at openjdk.org (Carter Kozak) Date: Fri, 6 Sep 2024 16:09:48 GMT Subject: RFR: 8249: Add support for the new allocation profiler in rules [v2] In-Reply-To: <8KiZNsF0w78cDxPtWi0lubrws9yWEaTHmXKpV4PC5rc=.49391215-860c-4da1-83c6-5f3bbc2e9da8@github.com> References: <8KiZNsF0w78cDxPtWi0lubrws9yWEaTHmXKpV4PC5rc=.49391215-860c-4da1-83c6-5f3bbc2e9da8@github.com> Message-ID: > ## Allocation Rules may use ObjectAllocationSample > > The allocation profiling rules (`AllocationByClassRule`, `AllocationByThreadRule`, `AutoBoxingRule`) were developed prior to the introduction of the newer and less invasive ObjectAllocationSample event. I've updated these rules to prefer the more precise events, but when those are unavailable, use the new ObjectAllocationSample events instead. This proved a bit tricky because the rules are scored based on number of events sampled, where the new events may not be emitted for every tlab based on a rate limit, so we must take into account the sample weight and estimate the number of samples as best we can. > > The `IRule#getRequiredEvents` API doesn't provide a way to declare _either_ dependencies, so I opted to remove the dependencies in favor of a similar check in the `getResult` implementation. > > ## JfrGenerator Utility > > The idea is to provide java sources with code that violates rules. We compile and execute the input sources while capturing a JFR, and execute rules against the results to verify they work as expected. > > I like having the input sources available in the test rather than only a JFR recording, because it's not clear whether most JDKs will still create the given recording, or with what configuration. However, the trade-off is that we're only testing against the JVM used to run tests, which represents a subset of all supported versions. > This type of test must also compile and execute small Java programs, which is more expensive than executing against an existing recording, and may be more likely to flake if we're not careful. > > Anyhow, I thought I would share the idea before moving forward, as always, feedback is appreciated :-) Carter Kozak has updated the pull request incrementally with one additional commit since the last revision: Fix calculateBalanceScore when large integers are provided ------------- Changes: - all: https://git.openjdk.org/jmc/pull/579/files - new: https://git.openjdk.org/jmc/pull/579/files/9f2e7c02..c525ec90 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=579&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=579&range=00-01 Stats: 22 lines in 2 files changed: 20 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/579.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/579/head:pull/579 PR: https://git.openjdk.org/jmc/pull/579 From hirt at openjdk.org Sat Sep 7 01:14:45 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Sat, 7 Sep 2024 01:14:45 GMT Subject: RFR: 8250: Should show Resident Set Size Message-ID: Makes it easier to discover native leaks. ------------- Commit messages: - Formatting - Cleaning up a bit - Adding comment - Fixing copyright years - Adding RSS graphs Changes: https://git.openjdk.org/jmc/pull/582/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=582&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8250 Stats: 81 lines in 11 files changed: 58 ins; 11 del; 12 mod Patch: https://git.openjdk.org/jmc/pull/582.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/582/head:pull/582 PR: https://git.openjdk.org/jmc/pull/582 From hirt at openjdk.org Sat Sep 7 19:05:10 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Sat, 7 Sep 2024 19:05:10 GMT Subject: RFR: 8238: Update to Eclipse 2024-06 In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 22:28:06 GMT, Marcus Hirt wrote: > This one got a bit interesting. Since we want this in sooner rather than later, I've opened https://bugs.openjdk.org/browse/JMC-8253 for the build warnings. ------------- PR Comment: https://git.openjdk.org/jmc/pull/578#issuecomment-2336407579 From hirt at openjdk.org Sat Sep 7 19:05:11 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Sat, 7 Sep 2024 19:05:11 GMT Subject: Integrated: 8238: Update to Eclipse 2024-06 In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 22:28:06 GMT, Marcus Hirt wrote: > This one got a bit interesting. This pull request has now been integrated. Changeset: 4a37a5e7 Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/4a37a5e72b5a700ce90ef27a20c633d79ecb73f2 Stats: 345 lines in 9 files changed: 299 ins; 21 del; 25 mod 8238: Update to Eclipse 2024-06 Co-authored-by: Virag Purnam Reviewed-by: vpurnam, aptmac ------------- PR: https://git.openjdk.org/jmc/pull/578 From rschmelter at openjdk.org Mon Sep 9 14:24:20 2024 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Mon, 9 Sep 2024 14:24:20 GMT Subject: RFR: 8254: Allow primitive types in converters Message-ID: This allows primitive types in converters. ------------- Commit messages: - Merge branch 'master' of https://github.com/openjdk/jmc into allow_primitives_in_converters - Update copyright - Allow converters form primitive input types too Changes: https://git.openjdk.org/jmc/pull/584/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=584&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8254 Stats: 292 lines in 4 files changed: 285 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jmc/pull/584.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/584/head:pull/584 PR: https://git.openjdk.org/jmc/pull/584 From hirt at openjdk.org Mon Sep 9 22:12:12 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 9 Sep 2024 22:12:12 GMT Subject: RFR: 8254: Allow primitive types in converters In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 14:20:35 GMT, Ralf Schmelter wrote: > This allows primitive types in converters. agent/src/test/java/org/openjdk/jmc/agent/converters/test/GurkMultiDefaultConverter.java line 81: > 79: > 80: public static String convert(char c) { > 81: return "" + c; Nit: might want to use String.valueOf(c)? agent/src/test/java/org/openjdk/jmc/agent/converters/test/GurkMultiDefaultConverter.java line 89: > 87: > 88: public static int convert(float f) { > 89: return (int) f; Nit: not that it matters much in a test, but Math.round(f) might be a nicer default conversion. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/584#discussion_r1750997007 PR Review Comment: https://git.openjdk.org/jmc/pull/584#discussion_r1750998924 From hirt at openjdk.org Mon Sep 9 22:16:09 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 9 Sep 2024 22:16:09 GMT Subject: RFR: 8254: Allow primitive types in converters In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 14:20:35 GMT, Ralf Schmelter wrote: > This allows primitive types in converters. Looks good! agent/src/test/resources/org/openjdk/jmc/agent/converters/test/jfrprobes_template.xml line 347: > 345: WRAP > 346: > 347: Might as well spell out Primitive. It's long enough of a name as it is anyways. ;) ------------- PR Review: https://git.openjdk.org/jmc/pull/584#pullrequestreview-2291042892 PR Review Comment: https://git.openjdk.org/jmc/pull/584#discussion_r1751000281 From hirt at openjdk.org Mon Sep 9 22:42:10 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 9 Sep 2024 22:42:10 GMT Subject: RFR: 8249: Add support for the new allocation profiler in rules [v2] In-Reply-To: References: <8KiZNsF0w78cDxPtWi0lubrws9yWEaTHmXKpV4PC5rc=.49391215-860c-4da1-83c6-5f3bbc2e9da8@github.com> Message-ID: On Fri, 6 Sep 2024 16:09:48 GMT, Carter Kozak wrote: >> ## Allocation Rules may use ObjectAllocationSample >> >> The allocation profiling rules (`AllocationByClassRule`, `AllocationByThreadRule`, `AutoBoxingRule`) were developed prior to the introduction of the newer and less invasive ObjectAllocationSample event. I've updated these rules to prefer the more precise events, but when those are unavailable, use the new ObjectAllocationSample events instead. This proved a bit tricky because the rules are scored based on number of events sampled, where the new events may not be emitted for every tlab based on a rate limit, so we must take into account the sample weight and estimate the number of samples as best we can. >> >> The `IRule#getRequiredEvents` API doesn't provide a way to declare _either_ dependencies, so I opted to remove the dependencies in favor of a similar check in the `getResult` implementation. >> >> ## JfrGenerator Utility >> >> The idea is to provide java sources with code that violates rules. We compile and execute the input sources while capturing a JFR, and execute rules against the results to verify they work as expected. >> >> I like having the input sources available in the test rather than only a JFR recording, because it's not clear whether most JDKs will still create the given recording, or with what configuration. However, the trade-off is that we're only testing against the JVM used to run tests, which represents a subset of all supported versions. >> This type of test must also compile and execute small Java programs, which is more expensive than executing against an existing recording, and may be more likely to flake if we're not careful. >> >> Anyhow, I thought I would share the idea before moving forward, as always, feedback is appreciated :-) > > Carter Kozak has updated the pull request incrementally with one additional commit since the last revision: > > Fix calculateBalanceScore when large integers are provided Thanks a lot for this PR Carter! Doing this is long overdue. :) core/org.openjdk.jmc.testlib/src/main/java/org/openjdk/jmc/flightrecorder/test/util/JfrGenerator.java line 108: > 106: * invokes {@code consumer} with the resulting recording. > 107: */ > 108: public void execute(RecordingConsumer consumer) throws IOException { Executing another JVM, to dynamically get recordings, seems both a bit risky and error prone to do as part of the testing. We assume that all the events have already been tested as part of the JDK testing, so this testing will be to ensure that we get the right output from the rule, given a certain input recording. I would suggest one of two ways of doing this: Either simply make or generate a little recording, or some recording, that show the behaviour you are looking for. You can generate them, for example, by adding to https://github.com/thegreystone/recgen. Using the writer to generate them will result in recordings with exactly the shape you want, and they will also be minimal. Though, perhaps a bit unrealistic perhaps. Or, if you very much want to generate them on the fly, you can do what recgen does, and use the jfr writer to generate them from within the tests themselves. ------------- Changes requested by hirt (Lead). PR Review: https://git.openjdk.org/jmc/pull/579#pullrequestreview-2291067019 PR Review Comment: https://git.openjdk.org/jmc/pull/579#discussion_r1751018434 From aptmac at openjdk.org Tue Sep 10 11:52:11 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 10 Sep 2024 11:52:11 GMT Subject: RFR: 8254: Allow primitive types in converters In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 14:20:35 GMT, Ralf Schmelter wrote: > This allows primitive types in converters. There's a typo ("primite") in the jira issue title that's causing a mismatch with the openjdk bot tooling ------------- PR Comment: https://git.openjdk.org/jmc/pull/584#issuecomment-2340448275 From rschmelter at openjdk.org Tue Sep 10 12:38:36 2024 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Tue, 10 Sep 2024 12:38:36 GMT Subject: RFR: 8254: Allow primitive types in converters [v2] In-Reply-To: References: Message-ID: > This allows primitive types in converters. Ralf Schmelter has updated the pull request incrementally with one additional commit since the last revision: Incorporated feedback ------------- Changes: - all: https://git.openjdk.org/jmc/pull/584/files - new: https://git.openjdk.org/jmc/pull/584/files/1e65bef6..76c91791 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=584&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=584&range=00-01 Stats: 18 lines in 2 files changed: 0 ins; 0 del; 18 mod Patch: https://git.openjdk.org/jmc/pull/584.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/584/head:pull/584 PR: https://git.openjdk.org/jmc/pull/584 From duke at openjdk.org Tue Sep 10 14:56:48 2024 From: duke at openjdk.org (Carter Kozak) Date: Tue, 10 Sep 2024 14:56:48 GMT Subject: RFR: 8249: Add support for the new allocation profiler in rules [v3] In-Reply-To: <8KiZNsF0w78cDxPtWi0lubrws9yWEaTHmXKpV4PC5rc=.49391215-860c-4da1-83c6-5f3bbc2e9da8@github.com> References: <8KiZNsF0w78cDxPtWi0lubrws9yWEaTHmXKpV4PC5rc=.49391215-860c-4da1-83c6-5f3bbc2e9da8@github.com> Message-ID: > ## Allocation Rules may use ObjectAllocationSample > > The allocation profiling rules (`AllocationByClassRule`, `AllocationByThreadRule`, `AutoBoxingRule`) were developed prior to the introduction of the newer and less invasive ObjectAllocationSample event. I've updated these rules to prefer the more precise events, but when those are unavailable, use the new ObjectAllocationSample events instead. This proved a bit tricky because the rules are scored based on number of events sampled, where the new events may not be emitted for every tlab based on a rate limit, so we must take into account the sample weight and estimate the number of samples as best we can. > > The `IRule#getRequiredEvents` API doesn't provide a way to declare _either_ dependencies, so I opted to remove the dependencies in favor of a similar check in the `getResult` implementation. Carter Kozak has updated the pull request incrementally with two additional commits since the last revision: - update JfrRuleBaseline.xml - Remove dynamic profiling code in favor of matching existing tests This adds four new recordings to teh set of committed resources, which include roughly equivalent recordings using allocation samples and allocation in new tlab/outside of tlab events to ensure consistency. ------------- Changes: - all: https://git.openjdk.org/jmc/pull/579/files - new: https://git.openjdk.org/jmc/pull/579/files/c525ec90..d3fe23e0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=579&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=579&range=01-02 Stats: 1445 lines in 8 files changed: 1101 ins; 314 del; 30 mod Patch: https://git.openjdk.org/jmc/pull/579.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/579/head:pull/579 PR: https://git.openjdk.org/jmc/pull/579 From hirt at openjdk.org Tue Sep 10 18:28:09 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 10 Sep 2024 18:28:09 GMT Subject: RFR: 8254: Allow primitive types in converters [v2] In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 12:38:36 GMT, Ralf Schmelter wrote: >> This allows primitive types in converters. > > Ralf Schmelter has updated the pull request incrementally with one additional commit since the last revision: > > Incorporated feedback Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/584#pullrequestreview-2293386343 From rschmelter at openjdk.org Tue Sep 10 18:28:09 2024 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Tue, 10 Sep 2024 18:28:09 GMT Subject: RFR: 8254: Allow primitive types in converters [v2] In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 12:38:36 GMT, Ralf Schmelter wrote: >> This allows primitive types in converters. > > Ralf Schmelter has updated the pull request incrementally with one additional commit since the last revision: > > Incorporated feedback Thanks for the fast review. ------------- PR Comment: https://git.openjdk.org/jmc/pull/584#issuecomment-2341719382 From hirt at openjdk.org Tue Sep 10 18:33:10 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 10 Sep 2024 18:33:10 GMT Subject: RFR: 8254: Allow primitive types in converters [v2] In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 18:25:44 GMT, Ralf Schmelter wrote: > Thanks for the fast review. Thank **_you_** for the PR! :) ------------- PR Comment: https://git.openjdk.org/jmc/pull/584#issuecomment-2341728853 From hirt at openjdk.org Tue Sep 10 19:16:10 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 10 Sep 2024 19:16:10 GMT Subject: RFR: 8254: Allow primitive types in converters [v2] In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 12:38:36 GMT, Ralf Schmelter wrote: >> This allows primitive types in converters. > > Ralf Schmelter has updated the pull request incrementally with one additional commit since the last revision: > > Incorporated feedback Don't forget to do /integrate as suggested by the bot. ------------- PR Comment: https://git.openjdk.org/jmc/pull/584#issuecomment-2341825860 From hirt at openjdk.org Tue Sep 10 19:31:09 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 10 Sep 2024 19:31:09 GMT Subject: RFR: 7490: Trigger action does not return error message on failure. In-Reply-To: References: Message-ID: <2g0_JjNZy-xrUjGAiv8auJzv7vzSHIsy0BSPAR460-Q=.6f704b4b-8f2a-42a4-8a97-c621ff3e3c01@github.com> On Tue, 3 Sep 2024 07:49:53 GMT, Virag Purnam wrote: > If trigger action encounters any exception/error, it does not display the trigger value. On failure with the failure message, trigger value also should be displayed for the user. > > For example, if we are writing log to the drive which does not exists. Trigger action fails with IO exception. > > FileWriteExceptionWithoutShowingTriggerValue > > With this change, trigger value has been displayed along with IO exception. > > FileWriteExceptionShowingTriggerValue > > > This change has been done for all the trigger actions. > > > Along with this, few basic path and email validation has been added. > > Path validation: > > PathValidation > > Email validation: > > EmailValidation application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/internal/NotificationTrigger.java line 241: > 239: - stateStore.m_lastTriggerErrorTimestamp >= TRIGGER_ERROR_HANDLING_LIMIT_TIME_MS)) { > 240: stateStore.m_lastTriggerErrorTimestamp = aspectEvent.getTimestamp(); > 241: handleException(connectionHandle, rule, e, ""); Nit: I'm one of these weird people who prefer sending null to indicate that there is no trigger message rather than having a message that happened to be empty, and then adapting the output when encountering that to something that is a bit more clear and unambiguous, e.g. "no trigger message available". If that is not what you want to go for, then perhaps maybe just set as message here something that explains why there is not trigger message. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/581#discussion_r1752611744 From duke at openjdk.org Wed Sep 11 06:54:13 2024 From: duke at openjdk.org (duke) Date: Wed, 11 Sep 2024 06:54:13 GMT Subject: RFR: 8254: Allow primitive types in converters [v2] In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 12:38:36 GMT, Ralf Schmelter wrote: >> This allows primitive types in converters. > > Ralf Schmelter has updated the pull request incrementally with one additional commit since the last revision: > > Incorporated feedback @schmelter-sap Your change (at version 76c91791de6eed489284e5eb84bcfb219119e9e8) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jmc/pull/584#issuecomment-2342804466 From vpurnam at openjdk.org Wed Sep 11 16:02:37 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Wed, 11 Sep 2024 16:02:37 GMT Subject: RFR: 8252: JMC localization does not work as expected for Chinese locale Message-ID: JMC localization was not working fine for Chinese locale. **Issue:** Issue **Fix:** We need to change the name of all properties file from ***_zh_CN.properties** to ***_zh.properties**. WIth this change JMC takes works for Chinese locale. IssueResolved ------------- Commit messages: - 8252: JMC localization does not work as expected for Chinese locale - 8252: JMC localization does not work as expected for Chinese locale Changes: https://git.openjdk.org/jmc/pull/587/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=587&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8252 Stats: 148 lines in 125 files changed: 0 ins; 0 del; 148 mod Patch: https://git.openjdk.org/jmc/pull/587.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/587/head:pull/587 PR: https://git.openjdk.org/jmc/pull/587 From rschmelter at openjdk.org Wed Sep 11 17:34:11 2024 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Wed, 11 Sep 2024 17:34:11 GMT Subject: Integrated: 8254: Allow primitive types in converters In-Reply-To: References: Message-ID: On Mon, 9 Sep 2024 14:20:35 GMT, Ralf Schmelter wrote: > This allows primitive types in converters. This pull request has now been integrated. Changeset: 4aa38c7a Author: Ralf Schmelter Committer: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/4aa38c7a555fdb71d15cf757a70ef9aada0bd347 Stats: 292 lines in 4 files changed: 285 ins; 0 del; 7 mod 8254: Allow primitive types in converters Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/584 From duke at openjdk.org Wed Sep 11 20:52:18 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Wed, 11 Sep 2024 20:52:18 GMT Subject: RFR: 8255: Update toolchain and base images to support building with Java21 in docker Message-ID: Getting this trying to build with docker from master: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-toolchains-plugin:3.2.0:toolchain (default) on project missioncontrol: Cannot find matching toolchain definitions for the following toolchain types: [ERROR] jdk [ id='JavaSE-21' version='21' ] [ERROR] Please make sure you define the required toolchains in your ~/.m2/toolchains.xml file. [ERROR] -> [Help 1] ------------- Commit messages: - Also simplify p2 a bit - Update toolchain and base images to support building with Java21 in docker Changes: https://git.openjdk.org/jmc/pull/585/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=585&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8255 Stats: 21 lines in 3 files changed: 14 ins; 2 del; 5 mod Patch: https://git.openjdk.org/jmc/pull/585.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/585/head:pull/585 PR: https://git.openjdk.org/jmc/pull/585 From duke at openjdk.org Wed Sep 11 20:52:18 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Wed, 11 Sep 2024 20:52:18 GMT Subject: RFR: 8255: Update toolchain and base images to support building with Java21 in docker In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 19:02:50 GMT, Martin Skarsaune wrote: > Getting this trying to build with docker from master: > > > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-toolchains-plugin:3.2.0:toolchain (default) on project missioncontrol: Cannot find matching toolchain definitions for the following toolchain types: > [ERROR] jdk [ id='JavaSE-21' version='21' ] > [ERROR] Please make sure you define the required toolchains in your ~/.m2/toolchains.xml file. > [ERROR] -> [Help 1] @thegreystone : Could you register an issue for this one? ------------- PR Comment: https://git.openjdk.org/jmc/pull/585#issuecomment-2341874066 From vpurnam at openjdk.org Thu Sep 12 11:23:24 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Thu, 12 Sep 2024 11:23:24 GMT Subject: RFR: 7490: Trigger action does not return error message on failure. [v2] In-Reply-To: References: Message-ID: > If trigger action encounters any exception/error, it does not display the trigger value. On failure with the failure message, trigger value also should be displayed for the user. > > For example, if we are writing log to the drive which does not exists. Trigger action fails with IO exception. > > FileWriteExceptionWithoutShowingTriggerValue > > With this change, trigger value has been displayed along with IO exception. > > FileWriteExceptionShowingTriggerValue > > > This change has been done for all the trigger actions. > > > Along with this, few basic path and email validation has been added. > > Path validation: > > PathValidation > > Email validation: > > EmailValidation Virag Purnam has updated the pull request incrementally with one additional commit since the last revision: 7490: Trigger action does not return error message on failure. ------------- Changes: - all: https://git.openjdk.org/jmc/pull/581/files - new: https://git.openjdk.org/jmc/pull/581/files/26088a86..c5551602 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=581&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=581&range=00-01 Stats: 4 lines in 2 files changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/581.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/581/head:pull/581 PR: https://git.openjdk.org/jmc/pull/581 From vpurnam at openjdk.org Thu Sep 12 11:23:25 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Thu, 12 Sep 2024 11:23:25 GMT Subject: RFR: 7490: Trigger action does not return error message on failure. [v2] In-Reply-To: <2g0_JjNZy-xrUjGAiv8auJzv7vzSHIsy0BSPAR460-Q=.6f704b4b-8f2a-42a4-8a97-c621ff3e3c01@github.com> References: <2g0_JjNZy-xrUjGAiv8auJzv7vzSHIsy0BSPAR460-Q=.6f704b4b-8f2a-42a4-8a97-c621ff3e3c01@github.com> Message-ID: On Tue, 10 Sep 2024 19:26:27 GMT, Marcus Hirt wrote: > Nit: I'm one of these weird people who prefer sending null to indicate that there is no trigger message rather than having a message that happened to be empty, and then adapting the output when encountering that to something that is a bit more clear and unambiguous, e.g. "no trigger message available". If that is not what you want to go for, then perhaps maybe just set as message here something that explains why there is not trigger message. Hi @thegreystone, Thanks for pointing this out. I have changed the empty string to null and introduced a null check in the called method. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/581#discussion_r1756661839 From hirt at openjdk.org Thu Sep 12 17:57:09 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 12 Sep 2024 17:57:09 GMT Subject: RFR: 8252: JMC localization does not work as expected for Chinese locale In-Reply-To: References: Message-ID: On Wed, 11 Sep 2024 15:56:33 GMT, Virag Purnam wrote: > JMC localization was not working fine for Chinese locale. > **Issue:** > Issue > > **Fix:** > We need to change the name of all properties file from ***_zh_CN.properties** to ***_zh.properties**. WIth this change JMC works for Chinese locale. > > IssueResolved Hm. Should still work, but it kinda makes sense to make make it TW / CN independent no matter, so looks good. ------------- PR Comment: https://git.openjdk.org/jmc/pull/587#issuecomment-2346906832 From hirt at openjdk.org Thu Sep 12 18:00:11 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 12 Sep 2024 18:00:11 GMT Subject: RFR: 8252: JMC localization does not work as expected for Chinese locale In-Reply-To: References: Message-ID: On Wed, 11 Sep 2024 15:56:33 GMT, Virag Purnam wrote: > JMC localization was not working fine for Chinese locale. > **Issue:** > Issue > > **Fix:** > We need to change the name of all properties file from ***_zh_CN.properties** to ***_zh.properties**. WIth this change JMC works for Chinese locale. > > IssueResolved Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/587#pullrequestreview-2301036702 From hirt at openjdk.org Thu Sep 12 18:03:10 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 12 Sep 2024 18:03:10 GMT Subject: RFR: 7490: Trigger action does not return error message on failure. [v2] In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 11:23:24 GMT, Virag Purnam wrote: >> If trigger action encounters any exception/error, it does not display the trigger value. On failure with the failure message, trigger value also should be displayed for the user. >> >> For example, if we are writing log to the drive which does not exists. Trigger action fails with IO exception. >> >> FileWriteExceptionWithoutShowingTriggerValue >> >> With this change, trigger value has been displayed along with IO exception. >> >> FileWriteExceptionShowingTriggerValue >> >> >> This change has been done for all the trigger actions. >> >> >> Along with this, few basic path and email validation has been added. >> >> Path validation: >> >> PathValidation >> >> Email validation: >> >> EmailValidation > > Virag Purnam has updated the pull request incrementally with one additional commit since the last revision: > > 7490: Trigger action does not return error message on failure. Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/581#pullrequestreview-2301042780 From hirt at openjdk.org Thu Sep 12 18:08:10 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 12 Sep 2024 18:08:10 GMT Subject: RFR: 8249: Add support for the new allocation profiler in rules [v3] In-Reply-To: References: <8KiZNsF0w78cDxPtWi0lubrws9yWEaTHmXKpV4PC5rc=.49391215-860c-4da1-83c6-5f3bbc2e9da8@github.com> Message-ID: On Tue, 10 Sep 2024 14:56:48 GMT, Carter Kozak wrote: >> ## Allocation Rules may use ObjectAllocationSample >> >> The allocation profiling rules (`AllocationByClassRule`, `AllocationByThreadRule`, `AutoBoxingRule`) were developed prior to the introduction of the newer and less invasive ObjectAllocationSample event. I've updated these rules to prefer the more precise events, but when those are unavailable, use the new ObjectAllocationSample events instead. This proved a bit tricky because the rules are scored based on number of events sampled, where the new events may not be emitted for every tlab based on a rate limit, so we must take into account the sample weight and estimate the number of samples as best we can. >> >> The `IRule#getRequiredEvents` API doesn't provide a way to declare _either_ dependencies, so I opted to remove the dependencies in favor of a similar check in the `getResult` implementation. > > Carter Kozak has updated the pull request incrementally with two additional commits since the last revision: > > - update JfrRuleBaseline.xml > - Remove dynamic profiling code in favor of matching existing tests > > This adds four new recordings to teh set of committed resources, > which include roughly equivalent recordings using allocation samples > and allocation in new tlab/outside of tlab events to ensure > consistency. Marked as reviewed by hirt (Lead). Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/579#pullrequestreview-2301052061 PR Review: https://git.openjdk.org/jmc/pull/579#pullrequestreview-2301053887 From duke at openjdk.org Thu Sep 12 19:18:11 2024 From: duke at openjdk.org (duke) Date: Thu, 12 Sep 2024 19:18:11 GMT Subject: RFR: 8249: Add support for the new allocation profiler in rules [v3] In-Reply-To: References: <8KiZNsF0w78cDxPtWi0lubrws9yWEaTHmXKpV4PC5rc=.49391215-860c-4da1-83c6-5f3bbc2e9da8@github.com> Message-ID: On Tue, 10 Sep 2024 14:56:48 GMT, Carter Kozak wrote: >> ## Allocation Rules may use ObjectAllocationSample >> >> The allocation profiling rules (`AllocationByClassRule`, `AllocationByThreadRule`, `AutoBoxingRule`) were developed prior to the introduction of the newer and less invasive ObjectAllocationSample event. I've updated these rules to prefer the more precise events, but when those are unavailable, use the new ObjectAllocationSample events instead. This proved a bit tricky because the rules are scored based on number of events sampled, where the new events may not be emitted for every tlab based on a rate limit, so we must take into account the sample weight and estimate the number of samples as best we can. >> >> The `IRule#getRequiredEvents` API doesn't provide a way to declare _either_ dependencies, so I opted to remove the dependencies in favor of a similar check in the `getResult` implementation. > > Carter Kozak has updated the pull request incrementally with two additional commits since the last revision: > > - update JfrRuleBaseline.xml > - Remove dynamic profiling code in favor of matching existing tests > > This adds four new recordings to teh set of committed resources, > which include roughly equivalent recordings using allocation samples > and allocation in new tlab/outside of tlab events to ensure > consistency. @carterkozak Your change (at version d3fe23e0c0098d1b37fb86c06d823596e17a50c7) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jmc/pull/579#issuecomment-2347055661 From aptmac at openjdk.org Fri Sep 13 13:39:11 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 13 Sep 2024 13:39:11 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View In-Reply-To: References: Message-ID: On Mon, 26 Aug 2024 10:20:20 GMT, Suchita Chaturvedi wrote: > This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode. > > Before the fix: > image > > After the fix: > image Brice has a good point here, applying themes can be dynamic so IS_DARK_MODE needs to be able to be updated. ------------- Changes requested by aptmac (Reviewer). PR Review: https://git.openjdk.org/jmc/pull/580#pullrequestreview-2303163558 From aptmac at openjdk.org Fri Sep 13 15:01:49 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 13 Sep 2024 15:01:49 GMT Subject: RFR: 8219: Missing coverage in application reports [v7] In-Reply-To: References: Message-ID: > This PR fixes (&cleans up) the coverage reports under jmc/application. > > The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage. > > Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well. > > The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated. Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Add tycho.testArgLine.local to Jolokia test argLine - adjust the argline for tycho-maven-plugin - 8219: Missing coverage in application reports ------------- Changes: https://git.openjdk.org/jmc/pull/562/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=562&range=06 Stats: 117 lines in 7 files changed: 10 ins; 88 del; 19 mod Patch: https://git.openjdk.org/jmc/pull/562.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/562/head:pull/562 PR: https://git.openjdk.org/jmc/pull/562 From schaturvedi at openjdk.org Sat Sep 14 21:37:40 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Sat, 14 Sep 2024 21:37:40 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v2] In-Reply-To: References: Message-ID: > This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode. > > Before the fix: > image > > After the fix: > image Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: Restart not required to apply the DARK mode appearance preference ------------- Changes: - all: https://git.openjdk.org/jmc/pull/580/files - new: https://git.openjdk.org/jmc/pull/580/files/b74d29ea..8663a808 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=580&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=580&range=00-01 Stats: 43 lines in 2 files changed: 27 ins; 8 del; 8 mod Patch: https://git.openjdk.org/jmc/pull/580.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/580/head:pull/580 PR: https://git.openjdk.org/jmc/pull/580 From schaturvedi at openjdk.org Sat Sep 14 21:41:24 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Sat, 14 Sep 2024 21:41:24 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v3] In-Reply-To: References: Message-ID: > This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode. > > Before the fix: > image > > After the fix: > image Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into 8248 - Restart not required to apply the DARK mode appearance preference - 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View Co-authored By: Marcus Hirt ------------- Changes: - all: https://git.openjdk.org/jmc/pull/580/files - new: https://git.openjdk.org/jmc/pull/580/files/8663a808..fd2bcdf3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=580&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=580&range=01-02 Stats: 664 lines in 15 files changed: 590 ins; 25 del; 49 mod Patch: https://git.openjdk.org/jmc/pull/580.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/580/head:pull/580 PR: https://git.openjdk.org/jmc/pull/580 From schaturvedi at openjdk.org Sat Sep 14 21:58:10 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Sat, 14 Sep 2024 21:58:10 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v3] In-Reply-To: References: Message-ID: On Sat, 14 Sep 2024 21:41:24 GMT, Suchita Chaturvedi wrote: >> This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode. >> >> Before the fix: >> image >> >> After the fix: >> image > > Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into 8248 > - Restart not required to apply the DARK mode appearance preference > - 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View > > Co-authored By: Marcus Hirt Hi @bric3 & @aptmac , I have implemented the suggested change. I have also added the property listener in the static block. There is no issue with the eclipse development environment. I have tried to build JMC outside also and the build is working perfectly fine. But seems like spotbugs is not happy with updating static variable isCurrentThemeDark from the listener. Hence, there are test failures due to that. Please have a look at the changes and let me know if I am missing something. Hope I understood the suggestion clearly and implemented accordingly. ------------- PR Comment: https://git.openjdk.org/jmc/pull/580#issuecomment-2351171806 From schaturvedi at openjdk.org Sun Sep 15 13:29:39 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Sun, 15 Sep 2024 13:29:39 GMT Subject: RFR: 8257: Stacktrace Percentage Column Tooltip throwing Exception Message-ID: Open Thread page. Click on any thread. Stacktrace view gets populated with the results. Mouse hover on percentage column values. The tooltip doesnt get populated. While debugging I found an exception in the console. This PR is to fix the issue. After the fix the tooltip is populating properly and there is no exception in console. 8257_TooltipFixed ------------- Commit messages: - 8257: Stacktrace Percentage Column Tooltip throwing Exception Changes: https://git.openjdk.org/jmc/pull/589/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=589&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8257 Stats: 6 lines in 2 files changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/589.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/589/head:pull/589 PR: https://git.openjdk.org/jmc/pull/589 From bdutheil at openjdk.org Mon Sep 16 07:52:13 2024 From: bdutheil at openjdk.org (Brice Dutheil) Date: Mon, 16 Sep 2024 07:52:13 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v3] In-Reply-To: References: Message-ID: On Sat, 14 Sep 2024 21:41:24 GMT, Suchita Chaturvedi wrote: >> This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode. >> >> Before the fix: >> image >> >> After the fix: >> image > > Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into 8248 > - Restart not required to apply the DARK mode appearance preference > - 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View > > Co-authored By: Marcus Hirt application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/util/ThemeUtils.java line 13: > 11: public class ThemeUtils { > 12: > 13: private static boolean isCurrentThemeDark = isDarkMode(); **suggestion:** > But seems like spotbugs is not happy with updating static variable isCurrentThemeDark from the listener I don't know if it's alright by JMC spotbug rules to write this global state like this Suggestion: private static AtomicReference isCurrentThemeDark = new AtomicReference<>(isDarkMode()); and then access it with `AtomicReference::get` / `AtomicReference::set`. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/580#discussion_r1760683381 From schaturvedi at openjdk.org Mon Sep 16 08:16:45 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Mon, 16 Sep 2024 08:16:45 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v4] In-Reply-To: References: Message-ID: > This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode. > > Before the fix: > image > > After the fix: > image Suchita Chaturvedi has updated the pull request incrementally with two additional commits since the last revision: - Merge branch '8248' of https://github.com/Suchitainf/jmc into 8248 - Resolve Spotbug error ------------- Changes: - all: https://git.openjdk.org/jmc/pull/580/files - new: https://git.openjdk.org/jmc/pull/580/files/fd2bcdf3..ef4ba472 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=580&range=03 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=580&range=02-03 Stats: 8 lines in 1 file changed: 3 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jmc/pull/580.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/580/head:pull/580 PR: https://git.openjdk.org/jmc/pull/580 From schaturvedi at openjdk.org Mon Sep 16 08:37:14 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Mon, 16 Sep 2024 08:37:14 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v3] In-Reply-To: References: Message-ID: <9TJUZuzkx7OutaEUS3qS2WlHS2IlHO07xh0qS5SX41w=.2fac555c-5909-42b0-9fb3-2cf2a7e85112@github.com> On Mon, 16 Sep 2024 07:49:59 GMT, Brice Dutheil wrote: >> Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: >> >> - Merge branch 'openjdk:master' into 8248 >> - Restart not required to apply the DARK mode appearance preference >> - 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View >> >> Co-authored By: Marcus Hirt > > application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/util/ThemeUtils.java line 13: > >> 11: public class ThemeUtils { >> 12: >> 13: private static boolean isCurrentThemeDark = isDarkMode(); > > **suggestion:** > >> But seems like spotbugs is not happy with updating static variable isCurrentThemeDark from the listener > > I don't know if it's alright by JMC spotbug rules to write this global state like this > > Suggestion: > > private static AtomicReference isCurrentThemeDark = new AtomicReference<>(isDarkMode()); > > > and then access it with `AtomicReference::get` / `AtomicReference::set`. Thanks for the suggestion. I have tried fixing it with another simple approach and updated the PR with that change. Spotbugs is also happy with that. Can you please have a look? If it doesn't look good, I will try this AtomicReference approach. Thanks in advance. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/580#discussion_r1760741149 From bdutheil at openjdk.org Mon Sep 16 08:37:15 2024 From: bdutheil at openjdk.org (Brice Dutheil) Date: Mon, 16 Sep 2024 08:37:15 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v4] In-Reply-To: References: Message-ID: <_HYHbsGYmaSKyK4CHQg7g0kIZ-VEzagbZanv-pA0HTI=.5b5471c0-0278-43f0-9c64-548d17032cac@github.com> On Mon, 16 Sep 2024 08:16:45 GMT, Suchita Chaturvedi wrote: >> This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode. >> >> Before the fix: >> image >> >> After the fix: >> image > > Suchita Chaturvedi has updated the pull request incrementally with two additional commits since the last revision: > > - Merge branch '8248' of https://github.com/Suchitainf/jmc into 8248 > - Resolve Spotbug error application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/util/ThemeUtils.java line 37: > 35: private static final double BRIGHTNESS_THRESHOLD = 0.5; > 36: > 37: private static void isDarkMode() { **nitpick:** I'd rename `isDarkMode` that better describe that it updates the state, e.g. Suggestion: private static void updateCurrentThemeDarkModeStatus() { ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/580#discussion_r1760739614 From schaturvedi at openjdk.org Mon Sep 16 08:42:43 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Mon, 16 Sep 2024 08:42:43 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v5] In-Reply-To: References: Message-ID: > This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode. > > Before the fix: > image > > After the fix: > image Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: Renaming method name ------------- Changes: - all: https://git.openjdk.org/jmc/pull/580/files - new: https://git.openjdk.org/jmc/pull/580/files/ef4ba472..7f336a75 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=580&range=04 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=580&range=03-04 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/580.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/580/head:pull/580 PR: https://git.openjdk.org/jmc/pull/580 From bdutheil at openjdk.org Mon Sep 16 08:42:44 2024 From: bdutheil at openjdk.org (Brice Dutheil) Date: Mon, 16 Sep 2024 08:42:44 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v3] In-Reply-To: <9TJUZuzkx7OutaEUS3qS2WlHS2IlHO07xh0qS5SX41w=.2fac555c-5909-42b0-9fb3-2cf2a7e85112@github.com> References: <9TJUZuzkx7OutaEUS3qS2WlHS2IlHO07xh0qS5SX41w=.2fac555c-5909-42b0-9fb3-2cf2a7e85112@github.com> Message-ID: On Mon, 16 Sep 2024 08:34:08 GMT, Suchita Chaturvedi wrote: >> application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/util/ThemeUtils.java line 13: >> >>> 11: public class ThemeUtils { >>> 12: >>> 13: private static boolean isCurrentThemeDark = isDarkMode(); >> >> **suggestion:** >> >>> But seems like spotbugs is not happy with updating static variable isCurrentThemeDark from the listener >> >> I don't know if it's alright by JMC spotbug rules to write this global state like this >> >> Suggestion: >> >> private static AtomicReference isCurrentThemeDark = new AtomicReference<>(isDarkMode()); >> >> >> and then access it with `AtomicReference::get` / `AtomicReference::set`. > > Thanks for the suggestion. I have tried fixing it with another simple approach and updated the PR with that change. Spotbugs is also happy with that. Can you please have a look? If it doesn't look good, I will try this AtomicReference approach. Thanks in advance. @Suchitainf Your alternative approach is perfectly fine :) ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/580#discussion_r1760746683 From schaturvedi at openjdk.org Mon Sep 16 08:47:45 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Mon, 16 Sep 2024 08:47:45 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v6] In-Reply-To: References: Message-ID: <3r6wSMFgCDjdW5eM_0hYb-nmF_JcGE3TUybSDtSDGrg=.cf24af38-cc70-4217-ac82-c388e36ee4a3@github.com> > This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode. > > Before the fix: > image > > After the fix: > image Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: Renaming method name again ------------- Changes: - all: https://git.openjdk.org/jmc/pull/580/files - new: https://git.openjdk.org/jmc/pull/580/files/7f336a75..c4f1aebd Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=580&range=05 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=580&range=04-05 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/580.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/580/head:pull/580 PR: https://git.openjdk.org/jmc/pull/580 From bdutheil at openjdk.org Mon Sep 16 08:47:45 2024 From: bdutheil at openjdk.org (Brice Dutheil) Date: Mon, 16 Sep 2024 08:47:45 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v6] In-Reply-To: <3r6wSMFgCDjdW5eM_0hYb-nmF_JcGE3TUybSDtSDGrg=.cf24af38-cc70-4217-ac82-c388e36ee4a3@github.com> References: <3r6wSMFgCDjdW5eM_0hYb-nmF_JcGE3TUybSDtSDGrg=.cf24af38-cc70-4217-ac82-c388e36ee4a3@github.com> Message-ID: <8Ps7XB2TOkj6hjp21qxBdHataK86StlaGRZjf5h72UQ=.b973a227-a97f-4a28-9df5-719c4457d46f@github.com> On Mon, 16 Sep 2024 08:44:42 GMT, Suchita Chaturvedi wrote: >> This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode. >> >> Before the fix: >> image >> >> After the fix: >> image > > Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: > > Renaming method name again Marked as reviewed by bdutheil (Committer). ------------- PR Review: https://git.openjdk.org/jmc/pull/580#pullrequestreview-2306056518 From schaturvedi at openjdk.org Mon Sep 16 08:47:45 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Mon, 16 Sep 2024 08:47:45 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v4] In-Reply-To: <_HYHbsGYmaSKyK4CHQg7g0kIZ-VEzagbZanv-pA0HTI=.5b5471c0-0278-43f0-9c64-548d17032cac@github.com> References: <_HYHbsGYmaSKyK4CHQg7g0kIZ-VEzagbZanv-pA0HTI=.5b5471c0-0278-43f0-9c64-548d17032cac@github.com> Message-ID: On Mon, 16 Sep 2024 08:33:02 GMT, Brice Dutheil wrote: >> Suchita Chaturvedi has updated the pull request incrementally with two additional commits since the last revision: >> >> - Merge branch '8248' of https://github.com/Suchitainf/jmc into 8248 >> - Resolve Spotbug error > > application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/util/ThemeUtils.java line 37: > >> 35: private static final double BRIGHTNESS_THRESHOLD = 0.5; >> 36: >> 37: private static void isDarkMode() { > > **nitpick:** I'd rename `isDarkMode` that better describe that it updates the state, e.g. > > Suggestion: > > private static void updateCurrentThemeDarkModeStatus() { Done. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/580#discussion_r1760753795 From schaturvedi at openjdk.org Mon Sep 16 08:59:12 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Mon, 16 Sep 2024 08:59:12 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v6] In-Reply-To: <8Ps7XB2TOkj6hjp21qxBdHataK86StlaGRZjf5h72UQ=.b973a227-a97f-4a28-9df5-719c4457d46f@github.com> References: <3r6wSMFgCDjdW5eM_0hYb-nmF_JcGE3TUybSDtSDGrg=.cf24af38-cc70-4217-ac82-c388e36ee4a3@github.com> <8Ps7XB2TOkj6hjp21qxBdHataK86StlaGRZjf5h72UQ=.b973a227-a97f-4a28-9df5-719c4457d46f@github.com> Message-ID: On Mon, 16 Sep 2024 08:44:19 GMT, Brice Dutheil wrote: >> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: >> >> Renaming method name again > > Marked as reviewed by bdutheil (Committer). Thanks @bric3 for approving the changes. @aptmac Can you please take a look now? I need one reviewer's approval before integrating the changes. Thanks in advance. ------------- PR Comment: https://git.openjdk.org/jmc/pull/580#issuecomment-2352351783 From aptmac at openjdk.org Mon Sep 16 15:05:17 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 16 Sep 2024 15:05:17 GMT Subject: RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v6] In-Reply-To: <3r6wSMFgCDjdW5eM_0hYb-nmF_JcGE3TUybSDtSDGrg=.cf24af38-cc70-4217-ac82-c388e36ee4a3@github.com> References: <3r6wSMFgCDjdW5eM_0hYb-nmF_JcGE3TUybSDtSDGrg=.cf24af38-cc70-4217-ac82-c388e36ee4a3@github.com> Message-ID: On Mon, 16 Sep 2024 08:47:45 GMT, Suchita Chaturvedi wrote: >> This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode. >> >> Before the fix: >> image >> >> After the fix: >> image > > Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: > > Renaming method name again Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/580#pullrequestreview-2306941944 From schaturvedi at openjdk.org Mon Sep 16 17:29:31 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Mon, 16 Sep 2024 17:29:31 GMT Subject: Integrated: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View In-Reply-To: References: Message-ID: On Mon, 26 Aug 2024 10:20:20 GMT, Suchita Chaturvedi wrote: > This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode. > > Before the fix: > image > > After the fix: > image This pull request has now been integrated. Changeset: 8c67664a Author: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/8c67664a0b83ad9192e8d829808cd7a90005307b Stats: 71 lines in 3 files changed: 64 ins; 0 del; 7 mod 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View Co-authored-by: Marcus Hirt Reviewed-by: aptmac, bdutheil ------------- PR: https://git.openjdk.org/jmc/pull/580 From aptmac at openjdk.org Mon Sep 16 19:28:12 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 16 Sep 2024 19:28:12 GMT Subject: RFR: 8257: Stacktrace Percentage Column Tooltip throwing Exception In-Reply-To: References: Message-ID: On Sun, 15 Sep 2024 13:24:28 GMT, Suchita Chaturvedi wrote: > Open Thread page. Click on any thread. Stacktrace view gets populated with the results. Mouse hover on percentage column values. The tooltip doesnt get populated. > > While debugging I found an exception in the console. > > This PR is to fix the issue. > > After the fix the tooltip is populating properly and there is no exception in console. > > 8257_TooltipFixed Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/589#pullrequestreview-2307590534 From aptmac at openjdk.org Mon Sep 16 19:28:12 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 16 Sep 2024 19:28:12 GMT Subject: RFR: 8255: Update toolchain and base images to support building with Java21 in docker In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 19:02:50 GMT, Martin Skarsaune wrote: > Getting this trying to build with docker from master: > > > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-toolchains-plugin:3.2.0:toolchain (default) on project missioncontrol: Cannot find matching toolchain definitions for the following toolchain types: > [ERROR] jdk [ id='JavaSE-21' version='21' ] > [ERROR] Please make sure you define the required toolchains in your ~/.m2/toolchains.xml file. > [ERROR] -> [Help 1] Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/585#pullrequestreview-2307591301 From aptmac at openjdk.org Mon Sep 16 20:07:13 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 16 Sep 2024 20:07:13 GMT Subject: RFR: 8252: JMC localization does not work as expected for Chinese locale In-Reply-To: References: Message-ID: On Wed, 11 Sep 2024 15:56:33 GMT, Virag Purnam wrote: > JMC localization was not working fine for Chinese locale. > **Issue:** > Issue > > **Fix:** > We need to change the name of all properties file from ***_zh_CN.properties** to ***_zh.properties**. WIth this change JMC works for Chinese locale. > > IssueResolved Nice catch, kind of interesting that it still requires `-nl zh_cn` in order to display all of the Chinese locale strings. Just doing `./jmc -nl zh` only changes the title for the "Outline" header. `./jmc -nl zh` ![Screenshot from 2024-09-16 16-03-54](https://github.com/user-attachments/assets/f3519362-cc6f-4569-b8cd-e64c1ff9a27a) `./jmc -nl zh_cn` ![Screenshot from 2024-09-16 16-04-15](https://github.com/user-attachments/assets/5a0bdf0f-e695-4b76-88a7-6aff523f9e8b) ------------- Marked as reviewed by aptmac (Reviewer). PR Review: https://git.openjdk.org/jmc/pull/587#pullrequestreview-2307664100 From vpurnam at openjdk.org Tue Sep 17 02:37:11 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Tue, 17 Sep 2024 02:37:11 GMT Subject: Integrated: 8252: JMC localization does not work as expected for Chinese locale In-Reply-To: References: Message-ID: On Wed, 11 Sep 2024 15:56:33 GMT, Virag Purnam wrote: > JMC localization was not working fine for Chinese locale. > **Issue:** > Issue > > **Fix:** > We need to change the name of all properties file from ***_zh_CN.properties** to ***_zh.properties**. WIth this change JMC works for Chinese locale. > > IssueResolved This pull request has now been integrated. Changeset: beeeeb06 Author: Virag Purnam URL: https://git.openjdk.org/jmc/commit/beeeeb066c607557f997e4e1887d994c406712eb Stats: 148 lines in 125 files changed: 0 ins; 0 del; 148 mod 8252: JMC localization does not work as expected for Chinese locale Reviewed-by: hirt, aptmac ------------- PR: https://git.openjdk.org/jmc/pull/587 From vpurnam at openjdk.org Tue Sep 17 02:44:10 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Tue, 17 Sep 2024 02:44:10 GMT Subject: Integrated: 7490: Trigger action does not return error message on failure. In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 07:49:53 GMT, Virag Purnam wrote: > If trigger action encounters any exception/error, it does not display the trigger value. On failure with the failure message, trigger value also should be displayed for the user. > > For example, if we are writing log to the drive which does not exists. Trigger action fails with IO exception. > > FileWriteExceptionWithoutShowingTriggerValue > > With this change, trigger value has been displayed along with IO exception. > > FileWriteExceptionShowingTriggerValue > > > This change has been done for all the trigger actions. > > > Along with this, few basic path and email validation has been added. > > Path validation: > > PathValidation > > Email validation: > > EmailValidation This pull request has now been integrated. Changeset: 1357aaa0 Author: Virag Purnam URL: https://git.openjdk.org/jmc/commit/1357aaa08e298ba3a36d40353f57a70192f90146 Stats: 241 lines in 20 files changed: 183 ins; 2 del; 56 mod 7490: Trigger action does not return error message on failure. Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/581 From schaturvedi at openjdk.org Tue Sep 17 03:05:10 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Tue, 17 Sep 2024 03:05:10 GMT Subject: Integrated: 8257: Stacktrace Percentage Column Tooltip throwing Exception In-Reply-To: References: Message-ID: On Sun, 15 Sep 2024 13:24:28 GMT, Suchita Chaturvedi wrote: > Open Thread page. Click on any thread. Stacktrace view gets populated with the results. Mouse hover on percentage column values. The tooltip doesnt get populated. > > While debugging I found an exception in the console. > > This PR is to fix the issue. > > After the fix the tooltip is populating properly and there is no exception in console. > > 8257_TooltipFixed This pull request has now been integrated. Changeset: 94130294 Author: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/941302940600981857fbd06df460b3cd408b48e6 Stats: 6 lines in 2 files changed: 4 ins; 0 del; 2 mod 8257: Stacktrace Percentage Column Tooltip throwing Exception Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/589 From duke at openjdk.org Tue Sep 17 11:02:11 2024 From: duke at openjdk.org (duke) Date: Tue, 17 Sep 2024 11:02:11 GMT Subject: RFR: 8255: Update toolchain and base images to support building with Java21 in docker In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 19:02:50 GMT, Martin Skarsaune wrote: > Getting this trying to build with docker from master: > > > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-toolchains-plugin:3.2.0:toolchain (default) on project missioncontrol: Cannot find matching toolchain definitions for the following toolchain types: > [ERROR] jdk [ id='JavaSE-21' version='21' ] > [ERROR] Please make sure you define the required toolchains in your ~/.m2/toolchains.xml file. > [ERROR] -> [Help 1] @skarsaune Your change (at version 07ba1d3d11f06b618e6cf2f4c19b2ae101e90546) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jmc/pull/585#issuecomment-2355338315 From aptmac at openjdk.org Tue Sep 17 13:36:17 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 17 Sep 2024 13:36:17 GMT Subject: RFR: 8250: Should show Resident Set Size In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 04:05:58 GMT, Marcus Hirt wrote: > Makes it easier to discover native leaks. Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/582#pullrequestreview-2309781735 From duke at openjdk.org Tue Sep 17 13:37:15 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Tue, 17 Sep 2024 13:37:15 GMT Subject: Integrated: 8255: Update toolchain and base images to support building with Java21 in docker In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 19:02:50 GMT, Martin Skarsaune wrote: > Getting this trying to build with docker from master: > > > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-toolchains-plugin:3.2.0:toolchain (default) on project missioncontrol: Cannot find matching toolchain definitions for the following toolchain types: > [ERROR] jdk [ id='JavaSE-21' version='21' ] > [ERROR] Please make sure you define the required toolchains in your ~/.m2/toolchains.xml file. > [ERROR] -> [Help 1] This pull request has now been integrated. Changeset: 49a33620 Author: Martin Skarsaune Committer: Alex Macdonald URL: https://git.openjdk.org/jmc/commit/49a336201484c869dbd1017b97b03a852af5eb4f Stats: 21 lines in 3 files changed: 14 ins; 2 del; 5 mod 8255: Update toolchain and base images to support building with Java21 in docker Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/585 From aptmac at openjdk.org Tue Sep 17 13:41:48 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 17 Sep 2024 13:41:48 GMT Subject: RFR: 8219: Missing coverage in application reports [v8] In-Reply-To: References: Message-ID: > This PR fixes (&cleans up) the coverage reports under jmc/application. > > The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage. > > Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well. > > The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated. Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Add tycho.testArgLine.local to Jolokia test argLine - adjust the argline for tycho-maven-plugin - 8219: Missing coverage in application reports ------------- Changes: https://git.openjdk.org/jmc/pull/562/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=562&range=07 Stats: 117 lines in 7 files changed: 10 ins; 88 del; 19 mod Patch: https://git.openjdk.org/jmc/pull/562.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/562/head:pull/562 PR: https://git.openjdk.org/jmc/pull/562 From duke at openjdk.org Wed Sep 18 06:47:23 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Wed, 18 Sep 2024 06:47:23 GMT Subject: RFR: 8261: Use test flag to skip JDP multicast tests in JolokiaTest Message-ID: I just became aware that there is a new flag used to skip JDP tests. I previously added some env checking to skip similar multicast tests for Jolokia. Hence it would be a lot cleaner to use the new standardized mechanism for this. Trying out whether this fixes [JMC-8261](https://bugs.openjdk.org/browse/JMC-8261) ------------- Commit messages: - Try to use new test flag to decide whether multicast is supported Changes: https://git.openjdk.org/jmc/pull/588/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=588&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8261 Stats: 5 lines in 1 file changed: 0 ins; 3 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/588.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/588/head:pull/588 PR: https://git.openjdk.org/jmc/pull/588 From aptmac at openjdk.org Wed Sep 18 06:47:23 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Wed, 18 Sep 2024 06:47:23 GMT Subject: RFR: 8261: Use test flag to skip JDP multicast tests in JolokiaTest In-Reply-To: References: Message-ID: <_25BwmaZ8DQ_V_JjeFHcF0moAWX-kgGXBVGSLMs94Qg=.3bfeed0d-5dd3-4828-aff3-852161c65350@github.com> On Wed, 11 Sep 2024 19:40:23 GMT, Martin Skarsaune wrote: > I just became aware that there is a new flag used to skip JDP tests. > I previously added some env checking to skip similar multicast tests for Jolokia. > Hence it would be a lot cleaner to use the new standardized mechanism for this. > Trying out whether this fixes [JMC-8261](https://bugs.openjdk.org/browse/JMC-8261) @skarsaune Here's a jira issue you can use for this PR, and then Skara should pick it up and run the CI. It looks like after the change to use the setup-maven action in the workflow ([link](https://github.com/openjdk/jmc/blob/master/.github/workflows/validate.yml#L87)) we cannot run CI in our forks. For example, the action that tried to run on your fork [here](https://github.com/skarsaune/jmc/actions/runs/10818437740) shows an error: `stcarolas/setup-maven at v4.5 is not allowed to be used in skarsaune/jmc. Actions in this workflow must be: within a repository owned by skarsaune, created by GitHub, verified in the GitHub Marketplace, or matching the following: openjdk/jmc.` ------------- PR Comment: https://git.openjdk.org/jmc/pull/588#issuecomment-2353862443 From duke at openjdk.org Wed Sep 18 15:03:14 2024 From: duke at openjdk.org (Carter Kozak) Date: Wed, 18 Sep 2024 15:03:14 GMT Subject: RFR: 8249: Add support for the new allocation profiler in rules [v3] In-Reply-To: References: <8KiZNsF0w78cDxPtWi0lubrws9yWEaTHmXKpV4PC5rc=.49391215-860c-4da1-83c6-5f3bbc2e9da8@github.com> Message-ID: On Thu, 12 Sep 2024 18:05:41 GMT, Marcus Hirt wrote: >> Carter Kozak has updated the pull request incrementally with two additional commits since the last revision: >> >> - update JfrRuleBaseline.xml >> - Remove dynamic profiling code in favor of matching existing tests >> >> This adds four new recordings to teh set of committed resources, >> which include roughly equivalent recordings using allocation samples >> and allocation in new tlab/outside of tlab events to ensure >> consistency. > > Marked as reviewed by hirt (Lead). @thegreystone Any chance you could sponsor this change? ------------- PR Comment: https://git.openjdk.org/jmc/pull/579#issuecomment-2358719538 From duke at openjdk.org Thu Sep 19 05:03:40 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Thu, 19 Sep 2024 05:03:40 GMT Subject: RFR: 8261: Use test flag to skip JDP multicast tests in JolokiaTest In-Reply-To: <_25BwmaZ8DQ_V_JjeFHcF0moAWX-kgGXBVGSLMs94Qg=.3bfeed0d-5dd3-4828-aff3-852161c65350@github.com> References: <_25BwmaZ8DQ_V_JjeFHcF0moAWX-kgGXBVGSLMs94Qg=.3bfeed0d-5dd3-4828-aff3-852161c65350@github.com> Message-ID: On Mon, 16 Sep 2024 20:15:45 GMT, Alex Macdonald wrote: >> I just became aware that there is a new flag used to skip JDP tests. >> I previously added some env checking to skip similar multicast tests for Jolokia. >> Hence it would be a lot cleaner to use the new standardized mechanism for this. >> Trying out whether this fixes [JMC-8261](https://bugs.openjdk.org/browse/JMC-8261) > > @skarsaune Here's a jira issue you can use for this PR, and then Skara should pick it up and run the CI. It looks like after the change to use the setup-maven action in the workflow ([link](https://github.com/openjdk/jmc/blob/master/.github/workflows/validate.yml#L87)) we cannot run CI in our forks. > > For example, the action that tried to run on your fork [here](https://github.com/skarsaune/jmc/actions/runs/10818437740) shows an error: > `stcarolas/setup-maven at v4.5 is not allowed to be used in skarsaune/jmc. Actions in this workflow must be: within a repository owned by skarsaune, created by GitHub, verified in the GitHub Marketplace, or matching the following: openjdk/jmc.` @aptmac : even after referencing the issue. it still does not appear to run the ci tests on the pr. Any way to trigger it? As the pr is speculative, it does not make sense to merge it before we have tested it. ------------- PR Comment: https://git.openjdk.org/jmc/pull/588#issuecomment-2359980095 From aptmac at openjdk.org Thu Sep 19 13:09:49 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 19 Sep 2024 13:09:49 GMT Subject: RFR: 8261: Use test flag to skip JDP multicast tests in JolokiaTest In-Reply-To: References: Message-ID: <4b1PqDcauB11_Wu91bT6um9XixbYcUG2BkvrT6ZT-hM=.e390a4ab-6d04-4ad7-851b-6e3476a59860@github.com> On Wed, 11 Sep 2024 19:40:23 GMT, Martin Skarsaune wrote: > I just became aware that there is a new flag used to skip JDP tests. > I previously added some env checking to skip similar multicast tests for Jolokia. > Hence it would be a lot cleaner to use the new standardized mechanism for this. > Trying out whether this fixes [JMC-8261](https://bugs.openjdk.org/browse/JMC-8261) I'm not sure what's happening here, will have to take a look at why the rest of the checks haven't triggered. ------------- PR Comment: https://git.openjdk.org/jmc/pull/588#issuecomment-2360937866 From hirt at openjdk.org Wed Sep 25 17:12:46 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 25 Sep 2024 17:12:46 GMT Subject: RFR: 8249: Add support for the new allocation profiler in rules [v3] In-Reply-To: References: <8KiZNsF0w78cDxPtWi0lubrws9yWEaTHmXKpV4PC5rc=.49391215-860c-4da1-83c6-5f3bbc2e9da8@github.com> Message-ID: On Tue, 10 Sep 2024 14:56:48 GMT, Carter Kozak wrote: >> ## Allocation Rules may use ObjectAllocationSample >> >> The allocation profiling rules (`AllocationByClassRule`, `AllocationByThreadRule`, `AutoBoxingRule`) were developed prior to the introduction of the newer and less invasive ObjectAllocationSample event. I've updated these rules to prefer the more precise events, but when those are unavailable, use the new ObjectAllocationSample events instead. This proved a bit tricky because the rules are scored based on number of events sampled, where the new events may not be emitted for every tlab based on a rate limit, so we must take into account the sample weight and estimate the number of samples as best we can. >> >> The `IRule#getRequiredEvents` API doesn't provide a way to declare _either_ dependencies, so I opted to remove the dependencies in favor of a similar check in the `getResult` implementation. > > Carter Kozak has updated the pull request incrementally with two additional commits since the last revision: > > - update JfrRuleBaseline.xml > - Remove dynamic profiling code in favor of matching existing tests > > This adds four new recordings to teh set of committed resources, > which include roughly equivalent recordings using allocation samples > and allocation in new tlab/outside of tlab events to ensure > consistency. Sorry about the delay! :) ------------- PR Comment: https://git.openjdk.org/jmc/pull/579#issuecomment-2374669753 From duke at openjdk.org Wed Sep 25 17:12:46 2024 From: duke at openjdk.org (Carter Kozak) Date: Wed, 25 Sep 2024 17:12:46 GMT Subject: Integrated: 8249: Add support for the new allocation profiler in rules In-Reply-To: <8KiZNsF0w78cDxPtWi0lubrws9yWEaTHmXKpV4PC5rc=.49391215-860c-4da1-83c6-5f3bbc2e9da8@github.com> References: <8KiZNsF0w78cDxPtWi0lubrws9yWEaTHmXKpV4PC5rc=.49391215-860c-4da1-83c6-5f3bbc2e9da8@github.com> Message-ID: On Thu, 22 Aug 2024 20:50:58 GMT, Carter Kozak wrote: > ## Allocation Rules may use ObjectAllocationSample > > The allocation profiling rules (`AllocationByClassRule`, `AllocationByThreadRule`, `AutoBoxingRule`) were developed prior to the introduction of the newer and less invasive ObjectAllocationSample event. I've updated these rules to prefer the more precise events, but when those are unavailable, use the new ObjectAllocationSample events instead. This proved a bit tricky because the rules are scored based on number of events sampled, where the new events may not be emitted for every tlab based on a rate limit, so we must take into account the sample weight and estimate the number of samples as best we can. > > The `IRule#getRequiredEvents` API doesn't provide a way to declare _either_ dependencies, so I opted to remove the dependencies in favor of a similar check in the `getResult` implementation. This pull request has now been integrated. Changeset: 4590de6e Author: Carter Kozak Committer: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/4590de6ed7081b1de800d03e413ef1843f8c2613 Stats: 1342 lines in 11 files changed: 1252 ins; 42 del; 48 mod 8249: Add support for the new allocation profiler in rules Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/579 From hirt at openjdk.org Wed Sep 25 17:14:43 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 25 Sep 2024 17:14:43 GMT Subject: Integrated: 8250: Should show Resident Set Size In-Reply-To: References: Message-ID: On Thu, 5 Sep 2024 04:05:58 GMT, Marcus Hirt wrote: > Makes it easier to discover native leaks. This pull request has now been integrated. Changeset: 2927e054 Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/2927e0541d2ef59e0a1debdd34aeb64263e2d1ca Stats: 81 lines in 11 files changed: 58 ins; 11 del; 12 mod 8250: Should show Resident Set Size Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/582 From duke at openjdk.org Wed Sep 25 17:39:43 2024 From: duke at openjdk.org (Carter Kozak) Date: Wed, 25 Sep 2024 17:39:43 GMT Subject: RFR: 8249: Add support for the new allocation profiler in rules [v3] In-Reply-To: References: <8KiZNsF0w78cDxPtWi0lubrws9yWEaTHmXKpV4PC5rc=.49391215-860c-4da1-83c6-5f3bbc2e9da8@github.com> Message-ID: On Tue, 10 Sep 2024 14:56:48 GMT, Carter Kozak wrote: >> ## Allocation Rules may use ObjectAllocationSample >> >> The allocation profiling rules (`AllocationByClassRule`, `AllocationByThreadRule`, `AutoBoxingRule`) were developed prior to the introduction of the newer and less invasive ObjectAllocationSample event. I've updated these rules to prefer the more precise events, but when those are unavailable, use the new ObjectAllocationSample events instead. This proved a bit tricky because the rules are scored based on number of events sampled, where the new events may not be emitted for every tlab based on a rate limit, so we must take into account the sample weight and estimate the number of samples as best we can. >> >> The `IRule#getRequiredEvents` API doesn't provide a way to declare _either_ dependencies, so I opted to remove the dependencies in favor of a similar check in the `getResult` implementation. > > Carter Kozak has updated the pull request incrementally with two additional commits since the last revision: > > - update JfrRuleBaseline.xml > - Remove dynamic profiling code in favor of matching existing tests > > This adds four new recordings to teh set of committed resources, > which include roughly equivalent recordings using allocation samples > and allocation in new tlab/outside of tlab events to ensure > consistency. Not a problem, thanks for the review :-) ------------- PR Comment: https://git.openjdk.org/jmc/pull/579#issuecomment-2374747081 From schaturvedi at openjdk.org Thu Sep 26 05:14:13 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Thu, 26 Sep 2024 05:14:13 GMT Subject: RFR: 8259: Several JFR pages throwing exceptions after JMC-8244 Message-ID: This PR is to fix the NPE issue on different screens of JMC after 8244 fix. JVM Internals Garbage Collections GC Configuration Class Loading Recording All these screens are working fine now. ------------- Commit messages: - 8259: Several JFR pages throwing exceptions after JMC-8244 Changes: https://git.openjdk.org/jmc/pull/590/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=590&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8259 Stats: 94 lines in 1 file changed: 39 ins; 35 del; 20 mod Patch: https://git.openjdk.org/jmc/pull/590.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/590/head:pull/590 PR: https://git.openjdk.org/jmc/pull/590 From vpurnam at openjdk.org Thu Sep 26 10:08:08 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Thu, 26 Sep 2024 10:08:08 GMT Subject: RFR: 8266: Upgrade third party libraries for JMC 9.1.0 Message-ID: <1i78aP35U4LMT7b1khDXOKGILxEQDI4xpQ09tfF_ziQ=.d49316d5-5190-49dc-ac06-526dc0464676@github.com> There are latest versions for many third-party libraries used in JMC. This PR updates those third-party libraries. - Angus Mail -> 2.0.1 to 2.0.3 - Angus Activation ->2.0.0 to 2.0.2 - hpcc-js-wasm -> 1.14.1 to 2.18.0 - D3 -> 7.7.0 to 7.9.0 - d3-graphviz -> 4.1.1 to 5.6.0 - Radiance -> 6.0.0 to 7.5.0 - fireplace -> 0.0.1.rc3 to 0.0.1.rc.9 - Jetty -> 12.0.6 to 12.0.9 (**To match with jetty version used in eclipse 4.32**) - jakarta-websocket-api -> 2.1.0 to 2.2.0 - jakarta.activation-api -> 2.1.1 to 2.1.3 - jakarta.annotation-api -> 1.3.5 to 3.0.0 ------------- Commit messages: - Merge branch 'openjdk:master' into 8266 - 8266: Upgrade third party libraries for JMC 9.1.0 - 8266: Upgrade third party libraries for JMC 9.1.0 Changes: https://git.openjdk.org/jmc/pull/591/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=591&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8266 Stats: 44 lines in 4 files changed: 0 ins; 0 del; 44 mod Patch: https://git.openjdk.org/jmc/pull/591.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/591/head:pull/591 PR: https://git.openjdk.org/jmc/pull/591 From aptmac at openjdk.org Thu Sep 26 15:05:58 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 26 Sep 2024 15:05:58 GMT Subject: RFR: 8219: Missing coverage in application reports [v8] In-Reply-To: References: Message-ID: <86fEDdayNLy9Vg507aPiQKPrrqcmNDQWY7sH9ZOJoG4=.300f6a90-ab29-4a4f-bb67-d3fbe8dcf8e9@github.com> On Tue, 17 Sep 2024 13:41:48 GMT, Alex Macdonald wrote: >> This PR fixes (&cleans up) the coverage reports under jmc/application. >> >> The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage. >> >> Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well. >> >> The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated. > > Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. Trying these checks again, locally it ran fine and then it ran cleanly after nuking my local m2 and starting again. ------------- PR Comment: https://git.openjdk.org/jmc/pull/562#issuecomment-2377232325 From aptmac at openjdk.org Thu Sep 26 15:05:57 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 26 Sep 2024 15:05:57 GMT Subject: RFR: 8219: Missing coverage in application reports [v9] In-Reply-To: References: Message-ID: > This PR fixes (&cleans up) the coverage reports under jmc/application. > > The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage. > > Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well. > > The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated. Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Add tycho.testArgLine.local to Jolokia test argLine - adjust the argline for tycho-maven-plugin - 8219: Missing coverage in application reports ------------- Changes: https://git.openjdk.org/jmc/pull/562/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=562&range=08 Stats: 117 lines in 7 files changed: 10 ins; 88 del; 19 mod Patch: https://git.openjdk.org/jmc/pull/562.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/562/head:pull/562 PR: https://git.openjdk.org/jmc/pull/562 From aptmac at openjdk.org Thu Sep 26 15:27:41 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 26 Sep 2024 15:27:41 GMT Subject: RFR: 8266: Upgrade third party libraries for JMC 9.1.0 In-Reply-To: <1i78aP35U4LMT7b1khDXOKGILxEQDI4xpQ09tfF_ziQ=.d49316d5-5190-49dc-ac06-526dc0464676@github.com> References: <1i78aP35U4LMT7b1khDXOKGILxEQDI4xpQ09tfF_ziQ=.d49316d5-5190-49dc-ac06-526dc0464676@github.com> Message-ID: On Thu, 26 Sep 2024 10:03:24 GMT, Virag Purnam wrote: > There are latest versions for many third-party libraries used in JMC. This PR updates those third-party libraries. > > - Angus Mail -> 2.0.1 to 2.0.3 > - Angus Activation ->2.0.0 to 2.0.2 > - hpcc-js-wasm -> 1.14.1 to 2.18.0 > - D3 -> 7.7.0 to 7.9.0 > - d3-graphviz -> 4.1.1 to 5.6.0 > - Radiance -> 6.0.0 to 7.5.0 > - fireplace -> 0.0.1.rc3 to 0.0.1.rc.9 > - Jetty -> 12.0.6 to 12.0.9 (**To match with jetty version used in eclipse 4.32**) > - jakarta-websocket-api -> 2.1.0 to 2.2.0 > - jakarta.activation-api -> 2.1.1 to 2.1.3 > - jakarta.annotation-api -> 1.3.5 to 3.0.0 Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/591#pullrequestreview-2331653978 From aptmac at openjdk.org Thu Sep 26 15:46:41 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 26 Sep 2024 15:46:41 GMT Subject: RFR: 8259: Several JFR pages throwing exceptions after JMC-8244 In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 05:10:00 GMT, Suchita Chaturvedi wrote: > This PR is to fix the NPE issue on different screens of JMC after 8244 fix. > JVM Internals > Garbage Collections > GC Configuration > Class Loading > Recording > > All these screens are working fine now. Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/590#pullrequestreview-2331706009 From aptmac at openjdk.org Thu Sep 26 15:59:39 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 26 Sep 2024 15:59:39 GMT Subject: RFR: 8261: Use test flag to skip JDP multicast tests in JolokiaTest In-Reply-To: References: Message-ID: On Wed, 11 Sep 2024 19:40:23 GMT, Martin Skarsaune wrote: > I just became aware that there is a new flag used to skip JDP tests. > I previously added some env checking to skip similar multicast tests for Jolokia. > Hence it would be a lot cleaner to use the new standardized mechanism for this. > Trying out whether this fixes [JMC-8261](https://bugs.openjdk.org/browse/JMC-8261) I took a bit more of a look around some of our forks, and I'm not seeing the issue I posted in the comment above: https://github.com/openjdk/jmc/pull/588#issuecomment-2353862443. I'm curious what happens if you manually trigger a workflow on the master branch at: https://github.com/skarsaune/jmc/actions I'm wondering if it's a mis-configuration of the workflow actions in your fork somehow. ------------- PR Comment: https://git.openjdk.org/jmc/pull/588#issuecomment-2377359711 From schaturvedi at openjdk.org Thu Sep 26 18:19:42 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Thu, 26 Sep 2024 18:19:42 GMT Subject: Integrated: 8259: Several JFR pages throwing exceptions after JMC-8244 In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 05:10:00 GMT, Suchita Chaturvedi wrote: > This PR is to fix the NPE issue on different screens of JMC after 8244 fix. > JVM Internals > Garbage Collections > GC Configuration > Class Loading > Recording > > All these screens are working fine now. This pull request has now been integrated. Changeset: f114fb50 Author: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/f114fb50d5447af55bda7c2b2a2b8e76765e0740 Stats: 94 lines in 1 file changed: 39 ins; 35 del; 20 mod 8259: Several JFR pages throwing exceptions after JMC-8244 Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/590 From vpurnam at openjdk.org Fri Sep 27 09:57:42 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Fri, 27 Sep 2024 09:57:42 GMT Subject: Integrated: 8266: Upgrade third party libraries for JMC 9.1.0 In-Reply-To: <1i78aP35U4LMT7b1khDXOKGILxEQDI4xpQ09tfF_ziQ=.d49316d5-5190-49dc-ac06-526dc0464676@github.com> References: <1i78aP35U4LMT7b1khDXOKGILxEQDI4xpQ09tfF_ziQ=.d49316d5-5190-49dc-ac06-526dc0464676@github.com> Message-ID: On Thu, 26 Sep 2024 10:03:24 GMT, Virag Purnam wrote: > There are latest versions for many third-party libraries used in JMC. This PR updates those third-party libraries. > > - Angus Mail -> 2.0.1 to 2.0.3 > - Angus Activation ->2.0.0 to 2.0.2 > - hpcc-js-wasm -> 1.14.1 to 2.18.0 > - D3 -> 7.7.0 to 7.9.0 > - d3-graphviz -> 4.1.1 to 5.6.0 > - Radiance -> 6.0.0 to 7.5.0 > - fireplace -> 0.0.1.rc3 to 0.0.1.rc.9 > - Jetty -> 12.0.6 to 12.0.9 (**To match with jetty version used in eclipse 4.32**) > - jakarta-websocket-api -> 2.1.0 to 2.2.0 > - jakarta.activation-api -> 2.1.1 to 2.1.3 > - jakarta.annotation-api -> 1.3.5 to 3.0.0 This pull request has now been integrated. Changeset: eead0934 Author: Virag Purnam URL: https://git.openjdk.org/jmc/commit/eead0934233e3d01839faf6e71bb6ae8985ee5f9 Stats: 44 lines in 4 files changed: 0 ins; 0 del; 44 mod 8266: Upgrade third party libraries for JMC 9.1.0 Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/591