RFR: 7490: Trigger action does not return error message on failure.
Virag Purnam
vpurnam at openjdk.org
Tue Sep 3 07:53:54 UTC 2024
If trigger action encounters any exception/error, it does not display the trigger value. On failure with the failure message, trigger value also should be displayed for the user.
For example, if we are writing log to the drive which does not exists. Trigger action fails with IO exception.
<img width="563" alt="FileWriteExceptionWithoutShowingTriggerValue" src="https://github.com/user-attachments/assets/9ec6b71e-ba14-432a-b51b-3865327cdeac">
With this change, trigger value has been displayed along with IO exception.
<img width="594" alt="FileWriteExceptionShowingTriggerValue" src="https://github.com/user-attachments/assets/f026e9ca-56f7-44a1-8af9-ea2d1018f34c">
This change has been done for all the trigger actions.
Along with this, few basic path and email validation has been added.
Path validation:
<img width="523" alt="PathValidation" src="https://github.com/user-attachments/assets/839c97eb-940f-4a90-ba22-bf1bc654e06c">
Email validation:
<img width="574" alt="EmailValidation" src="https://github.com/user-attachments/assets/1b99889a-4d3e-4a51-a990-10f24376a7c3">
-------------
Commit messages:
- 7490: Trigger action does not return error message on failure.
Changes: https://git.openjdk.org/jmc/pull/581/files
Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=581&range=00
Issue: https://bugs.openjdk.org/browse/JMC-7490
Stats: 239 lines in 20 files changed: 181 ins; 2 del; 56 mod
Patch: https://git.openjdk.org/jmc/pull/581.diff
Fetch: git fetch https://git.openjdk.org/jmc.git pull/581/head:pull/581
PR: https://git.openjdk.org/jmc/pull/581
More information about the jmc-dev
mailing list