RFR: 8251: Add missing hook in plugin from Jolokia discovery [v2]

Alex Macdonald aptmac at openjdk.org
Thu Sep 5 20:06:56 UTC 2024


On Thu, 5 Sep 2024 17:43:48 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> This got left out of #570 . All the test runs fine, but the mechansim was not properly plugged in :facepalm: 
>> cc: @aptmac
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JMC-8251: Adjust indentation in plugin.xml

application/org.openjdk.jmc.jolokia/plugin.xml line 53:

> 51:       </page>
> 52:    </extension>
> 53:   <extension

I think this line needs 1 more space

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/583#discussion_r1746097005


More information about the jmc-dev mailing list