RFR: 8254: Allow primitive types in converters

Marcus Hirt hirt at openjdk.org
Mon Sep 9 22:12:12 UTC 2024


On Mon, 9 Sep 2024 14:20:35 GMT, Ralf Schmelter <rschmelter at openjdk.org> wrote:

> This allows primitive types in converters.

agent/src/test/java/org/openjdk/jmc/agent/converters/test/GurkMultiDefaultConverter.java line 81:

> 79: 
> 80: 	public static String convert(char c) {
> 81: 		return "" + c;

Nit: might want to use String.valueOf(c)?

agent/src/test/java/org/openjdk/jmc/agent/converters/test/GurkMultiDefaultConverter.java line 89:

> 87: 
> 88: 	public static int convert(float f) {
> 89: 		return (int) f;

Nit: not that it matters much in a test, but Math.round(f) might be a nicer default conversion.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/584#discussion_r1750997007
PR Review Comment: https://git.openjdk.org/jmc/pull/584#discussion_r1750998924


More information about the jmc-dev mailing list