RFR: 7490: Trigger action does not return error message on failure. [v2]
Virag Purnam
vpurnam at openjdk.org
Thu Sep 12 11:23:25 UTC 2024
On Tue, 10 Sep 2024 19:26:27 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
> Nit: I'm one of these weird people who prefer sending null to indicate that there is no trigger message rather than having a message that happened to be empty, and then adapting the output when encountering that to something that is a bit more clear and unambiguous, e.g. "no trigger message available". If that is not what you want to go for, then perhaps maybe just set as message here something that explains why there is not trigger message.
Hi @thegreystone, Thanks for pointing this out. I have changed the empty string to null and introduced a null check in the called method.
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/581#discussion_r1756661839
More information about the jmc-dev
mailing list