RFR: 7490: Trigger action does not return error message on failure. [v2]

Marcus Hirt hirt at openjdk.org
Thu Sep 12 18:03:10 UTC 2024


On Thu, 12 Sep 2024 11:23:24 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

>> If trigger action encounters any exception/error, it does not display the trigger value. On failure with the failure message, trigger value also should be displayed for the user. 
>> 
>> For example, if we are writing log to the drive which does not exists. Trigger action fails with IO exception. 
>> 
>> <img width="563" alt="FileWriteExceptionWithoutShowingTriggerValue" src="https://github.com/user-attachments/assets/9ec6b71e-ba14-432a-b51b-3865327cdeac">
>> 
>> With this change, trigger value has been displayed along with IO exception.
>> 
>> <img width="594" alt="FileWriteExceptionShowingTriggerValue" src="https://github.com/user-attachments/assets/f026e9ca-56f7-44a1-8af9-ea2d1018f34c">
>> 
>> 
>> This change has been done for all the trigger actions. 
>> 
>> 
>> Along with this, few basic path and email validation has been added.
>> 
>> Path validation:
>> 
>> <img width="523" alt="PathValidation" src="https://github.com/user-attachments/assets/839c97eb-940f-4a90-ba22-bf1bc654e06c">
>> 
>> Email validation:
>> 
>> <img width="574" alt="EmailValidation" src="https://github.com/user-attachments/assets/1b99889a-4d3e-4a51-a990-10f24376a7c3">
>
> Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   7490: Trigger action does not return error message on failure.

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/581#pullrequestreview-2301042780


More information about the jmc-dev mailing list