RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View
Alex Macdonald
aptmac at openjdk.org
Fri Sep 13 13:39:11 UTC 2024
On Mon, 26 Aug 2024 10:20:20 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:
> This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode.
>
> Before the fix:
> <img width="959" alt="image" src="https://github.com/user-attachments/assets/f12f1b7d-aa8a-4cce-8e0c-7731d5f9cc96">
>
> After the fix:
> <img width="959" alt="image" src="https://github.com/user-attachments/assets/8f7be98a-206b-4758-a1c2-8971d7ab1c55">
Brice has a good point here, applying themes can be dynamic so IS_DARK_MODE needs to be able to be updated.
-------------
Changes requested by aptmac (Reviewer).
PR Review: https://git.openjdk.org/jmc/pull/580#pullrequestreview-2303163558
More information about the jmc-dev
mailing list