RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v3]

[Suchita Chaturvedi]

On Sat, 14 Sep 2024 21:41:24 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode.
>> 
>> Before the fix:
>> <img width="959" alt="image" src="https://github.com/user-attachments/assets/f12f1b7d-aa8a-4cce-8e0c-7731d5f9cc96">
>> 
>> After the fix:
>> <img width="959" alt="image" src="https://github.com/user-attachments/assets/8f7be98a-206b-4758-a1c2-8971d7ab1c55">
>
> Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 8248
>  - Restart not required to apply the DARK mode appearance preference
>  - 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View
>    
>    Co-authored By: Marcus Hirt <hirt at openjdk.org>

Hi @bric3 & @aptmac , I have implemented the suggested change. I have also added the property listener in the static block. There is no issue with the eclipse development environment. I have tried to build JMC outside also and the build is working perfectly fine. But seems like spotbugs is not happy with updating static variable isCurrentThemeDark from the listener. Hence, there are test failures due to that. Please have a look at the changes and let me know if I am missing something.

Hope I understood the suggestion clearly and implemented accordingly.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/580#issuecomment-2351171806