RFR: 8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View [v3]

[Brice Dutheil]

On Mon, 16 Sep 2024 08:34:08 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/util/ThemeUtils.java line 13:
>> 
>>> 11: public class ThemeUtils {
>>> 12: 
>>> 13: 	private static boolean isCurrentThemeDark = isDarkMode();
>> 
>> **suggestion:** 
>> 
>>> But seems like spotbugs is not happy with updating static variable isCurrentThemeDark from the listener
>> 
>> I don't know if it's alright by JMC spotbug rules to write this global state like this
>> 
>> Suggestion:
>> 
>> 	private static AtomicReference<Boolean> isCurrentThemeDark = new AtomicReference<>(isDarkMode());
>> 
>> 
>> and then access it with `AtomicReference::get` / `AtomicReference::set`.
>
> Thanks for the suggestion. I have tried fixing it with another simple approach and updated the PR with that change. Spotbugs is also happy with that. Can you please have a look? If it doesn't look good, I will try this AtomicReference approach. Thanks in advance.

@Suchitainf Your alternative approach is perfectly fine :)

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/580#discussion_r1760746683