RFR: 8252: JMC localization does not work as expected for Chinese locale

Alex Macdonald aptmac at openjdk.org
Mon Sep 16 20:07:13 UTC 2024


On Wed, 11 Sep 2024 15:56:33 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> JMC localization was not working fine for Chinese locale.
> **Issue:**
> <img width="960" alt="Issue" src="https://github.com/user-attachments/assets/efdaaae6-11c8-4ab8-aed6-e6b055051e86">
> 
> **Fix:**
> We need to change the name of all properties file from ***_zh_CN.properties** to ***_zh.properties**. WIth this change JMC works for Chinese locale.
> 
> <img width="956" alt="IssueResolved" src="https://github.com/user-attachments/assets/b92e6587-ef39-4e3a-876a-49d4f61f1dd6">

Nice catch, kind of interesting that it still requires `-nl zh_cn` in order to display all of the Chinese locale strings. Just doing `./jmc -nl zh` only changes the title for the "Outline" header.
`./jmc -nl zh`
![Screenshot from 2024-09-16 16-03-54](https://github.com/user-attachments/assets/f3519362-cc6f-4569-b8cd-e64c1ff9a27a)

`./jmc -nl zh_cn`
![Screenshot from 2024-09-16 16-04-15](https://github.com/user-attachments/assets/5a0bdf0f-e695-4b76-88a7-6aff523f9e8b)

-------------

Marked as reviewed by aptmac (Reviewer).

PR Review: https://git.openjdk.org/jmc/pull/587#pullrequestreview-2307664100


More information about the jmc-dev mailing list