RFR: 8252: JMC localization does not work as expected for Chinese locale
Alex Macdonald
aptmac at openjdk.org
Mon Sep 16 20:07:13 UTC 2024
On Wed, 11 Sep 2024 15:56:33 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:
> JMC localization was not working fine for Chinese locale.
> **Issue:**
> <img width="960" alt="Issue" src="https://github.com/user-attachments/assets/efdaaae6-11c8-4ab8-aed6-e6b055051e86">
>
> **Fix:**
> We need to change the name of all properties file from ***_zh_CN.properties** to ***_zh.properties**. WIth this change JMC works for Chinese locale.
>
> <img width="956" alt="IssueResolved" src="https://github.com/user-attachments/assets/b92e6587-ef39-4e3a-876a-49d4f61f1dd6">
Nice catch, kind of interesting that it still requires `-nl zh_cn` in order to display all of the Chinese locale strings. Just doing `./jmc -nl zh` only changes the title for the "Outline" header.
`./jmc -nl zh`

`./jmc -nl zh_cn`

-------------
Marked as reviewed by aptmac (Reviewer).
PR Review: https://git.openjdk.org/jmc/pull/587#pullrequestreview-2307664100
More information about the jmc-dev
mailing list