RFR: 8261: Use test flag to skip JDP multicast tests in JolokiaTest

Martin Skarsaune duke at openjdk.org
Thu Sep 19 05:03:40 UTC 2024


On Mon, 16 Sep 2024 20:15:45 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> I just became aware that there is a new flag used to skip JDP tests. 
>> I previously added some env checking to skip similar multicast tests for Jolokia. 
>> Hence it would be a lot cleaner to use the new standardized mechanism for this.
>> Trying out whether this fixes [JMC-8261](https://bugs.openjdk.org/browse/JMC-8261)
>
> @skarsaune Here's a jira issue you can use for this PR, and then Skara should pick it up and run the CI. It looks like after the change to use the setup-maven action in the workflow ([link](https://github.com/openjdk/jmc/blob/master/.github/workflows/validate.yml#L87)) we cannot run CI in our forks.
> 
> For example, the action that tried to run on your fork [here](https://github.com/skarsaune/jmc/actions/runs/10818437740) shows an error:
> `stcarolas/setup-maven at v4.5 is not allowed to be used in skarsaune/jmc. Actions in this workflow must be: within a repository owned by skarsaune, created by GitHub, verified in the GitHub Marketplace, or matching the following: openjdk/jmc.`

@aptmac : even after referencing the issue. it still does not appear to run the ci tests on the pr. Any way to trigger it? As the pr is speculative, it does not make sense to merge it before we have tested it.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/588#issuecomment-2359980095


More information about the jmc-dev mailing list