From hirt at openjdk.org  Tue Apr  1 23:13:16 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 1 Apr 2025 23:13:16 GMT
Subject: RFR: 8370: HDR Histogram View
Message-ID: <ihgVMfLdj-12apHAyxzGth-VoCW4DGBNHQ7AhZxC56g=.4a9b97d9-ffa5-413e-897d-190a2fce2546@github.com>

Adds a Histogram view that will work on any selected events (that have durations). Useful for looking at distributions of, for example, GC or Lock events, or for any events that have durations in the Event Browser. 

![image](https://github.com/user-attachments/assets/97e7d3a5-9be8-455f-bf1f-fc0e846ebb40)

Events in any percentile can be selected in the percentiles table and used to set the active selection in the selection store.
![image](https://github.com/user-attachments/assets/69fecbb6-6368-461b-af83-4605548e2513)

-------------

Commit messages:
 - Cleanup
 - Copyrights
 - Selection fix
 - Fixing graph
 - 8370: First test

Changes: https://git.openjdk.org/jmc/pull/636/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=636&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8370
  Stats: 464 lines in 12 files changed: 457 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jmc/pull/636.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/636/head:pull/636

PR: https://git.openjdk.org/jmc/pull/636

From duke at openjdk.org  Tue Apr  1 23:18:35 2025
From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES)
Date: Tue, 1 Apr 2025 23:18:35 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching to
 Stack Trace view
Message-ID: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>

Fix tooltip on Flamegraph not showing after switching to Stack Trace view

The bug : Open a JFR file, open the Flamegraph view, see the tooltip on Flamegraph working, activate the Stack Trace view, get back to Flamegraph ==> the tooltip is not showing anymore on Flamegraph

-------------

Commit messages:
 - Fix tooltip on Flamegraph not showing after switching to Stack Trace view

Changes: https://git.openjdk.org/jmc/pull/635/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=635&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8373
  Stats: 74 lines in 1 file changed: 32 ins; 23 del; 19 mod
  Patch: https://git.openjdk.org/jmc/pull/635.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/635/head:pull/635

PR: https://git.openjdk.org/jmc/pull/635

From duke at openjdk.org  Tue Apr  1 23:18:35 2025
From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES)
Date: Tue, 1 Apr 2025 23:18:35 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
Message-ID: <mKoLzYX4eYDLEvRWq3AFGyvOefBMizaaSI4EgTft0AQ=.772b15e4-d761-4d29-b0a1-9e5591eaf64d@github.com>

On Fri, 28 Mar 2025 12:36:55 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> Fix tooltip on Flamegraph not showing after switching to Stack Trace view
> 
> The bug : Open a JFR file, open the Flamegraph view, see the tooltip on Flamegraph working, activate the Stack Trace view, get back to Flamegraph ==> the tooltip is not showing anymore on Flamegraph

@aptmac Could you open a ticket ?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2761252927

From hirt at openjdk.org  Tue Apr  1 23:18:35 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 1 Apr 2025 23:18:35 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <mKoLzYX4eYDLEvRWq3AFGyvOefBMizaaSI4EgTft0AQ=.772b15e4-d761-4d29-b0a1-9e5591eaf64d@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
 <mKoLzYX4eYDLEvRWq3AFGyvOefBMizaaSI4EgTft0AQ=.772b15e4-d761-4d29-b0a1-9e5591eaf64d@github.com>
Message-ID: <DzYy5eNb-SalrjB26AHvIBjYbQ5i-tUEYUN-kneUjOA=.d1184c9f-3be5-4ead-8a03-849edeeb0a76@github.com>

On Fri, 28 Mar 2025 12:37:41 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> @aptmac Could you open a ticket ?

Ticket opened.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2770886390

From hirt at openjdk.org  Tue Apr  1 23:24:52 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 1 Apr 2025 23:24:52 GMT
Subject: RFR: 8370: HDR Histogram View [v2]
In-Reply-To: <ihgVMfLdj-12apHAyxzGth-VoCW4DGBNHQ7AhZxC56g=.4a9b97d9-ffa5-413e-897d-190a2fce2546@github.com>
References: <ihgVMfLdj-12apHAyxzGth-VoCW4DGBNHQ7AhZxC56g=.4a9b97d9-ffa5-413e-897d-190a2fce2546@github.com>
Message-ID: <xo6CttedtQL0E4l21PbIM_1wiQJ8TkhzJGaHUVrvPpg=.423ba43b-8dd5-4cdf-b7b8-8a3e86356cea@github.com>

> Adds a Histogram view that will work on any selected events (that have durations). Useful for looking at distributions of, for example, GC or Lock events, or for any events that have durations in the Event Browser. 
> 
> ![image](https://github.com/user-attachments/assets/97e7d3a5-9be8-455f-bf1f-fc0e846ebb40)
> 
> Events in any percentile can be selected in the percentiles table and used to set the active selection in the selection store.
> ![image](https://github.com/user-attachments/assets/69fecbb6-6368-461b-af83-4605548e2513)

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Spotbugs potential null dereference

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/636/files
  - new: https://git.openjdk.org/jmc/pull/636/files/16568f60..eafb3948

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=636&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=636&range=00-01

  Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/636.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/636/head:pull/636

PR: https://git.openjdk.org/jmc/pull/636

From duke at openjdk.org  Wed Apr  2 07:05:11 2025
From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES)
Date: Wed, 2 Apr 2025 07:05:11 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <DzYy5eNb-SalrjB26AHvIBjYbQ5i-tUEYUN-kneUjOA=.d1184c9f-3be5-4ead-8a03-849edeeb0a76@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
 <mKoLzYX4eYDLEvRWq3AFGyvOefBMizaaSI4EgTft0AQ=.772b15e4-d761-4d29-b0a1-9e5591eaf64d@github.com>
 <DzYy5eNb-SalrjB26AHvIBjYbQ5i-tUEYUN-kneUjOA=.d1184c9f-3be5-4ead-8a03-849edeeb0a76@github.com>
Message-ID: <S9CceDW7h7cIs40e30T2CcH8bAPkMhaZfoadPvrpjUA=.b93749e9-9228-43e7-833f-c23a107e4afb@github.com>

On Tue, 1 Apr 2025 23:16:00 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> > @aptmac Could you open a ticket ?
> 
> Ticket opened.

Thx.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2771521572

From bdutheil at openjdk.org  Wed Apr  2 14:55:06 2025
From: bdutheil at openjdk.org (Brice Dutheil)
Date: Wed, 2 Apr 2025 14:55:06 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
Message-ID: <BA4NtmWBJ2oCcAq2EDt7DV8XrJlUH3pNlu-IrM3IIWg=.1c5f0d68-9993-4471-8bc7-6b1edd741636@github.com>

On Fri, 28 Mar 2025 12:36:55 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> Fix tooltip on Flamegraph not showing after switching to Stack Trace view
> 
> The bug : Open a JFR file, open the Flamegraph view, see the tooltip on Flamegraph working, activate the Stack Trace view, get back to Flamegraph ==> the tooltip is not showing anymore on Flamegraph

At first glance the changes looks good to me!
About the scenario, is it just moving the mouse from the flamegraph to the click on the stack trace tab. Also, is there an a specific OS where this is happening ?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2772819569

From bdutheil at openjdk.org  Wed Apr  2 14:59:25 2025
From: bdutheil at openjdk.org (Brice Dutheil)
Date: Wed, 2 Apr 2025 14:59:25 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
Message-ID: <R2dhoEEBYio4eVUKdykjdlHLKM5ot13Y4x5Eby2PUAg=.0a1ad2cb-02ed-4fbf-9128-7df0941ef0f3@github.com>

On Fri, 28 Mar 2025 12:36:55 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> Fix tooltip on Flamegraph not showing after switching to Stack Trace view
> 
> The bug : Open a JFR file, open the Flamegraph view, see the tooltip on Flamegraph working, activate the Stack Trace view, get back to Flamegraph ==> the tooltip is not showing anymore on Flamegraph

application/org.openjdk.jmc.flightrecorder.flamegraph/src/main/java/org/openjdk/jmc/flightrecorder/flamegraph/views/FlamegraphSwingView.java line 497:

> 495: 			tooltip.setShift(new Point(10, 5));
> 496: 
> 497: 			embeddingComposite.addListener(SWT.MouseExit, event -> Display.getDefault().timerExec(300, tooltip::hide));

**question:** I wonder if this listener is still needed, in case the mouse event is not received on the swing component. E.g. in weird situations like : Alt Tab (on macOs) to change app but in the end selecting back to JMC. Not sure it's a real scenario, but i could imagine the Swing component not properly receiving mouse events.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/635#discussion_r2025015576

From duke at openjdk.org  Wed Apr  2 15:51:08 2025
From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES)
Date: Wed, 2 Apr 2025 15:51:08 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <BA4NtmWBJ2oCcAq2EDt7DV8XrJlUH3pNlu-IrM3IIWg=.1c5f0d68-9993-4471-8bc7-6b1edd741636@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
 <BA4NtmWBJ2oCcAq2EDt7DV8XrJlUH3pNlu-IrM3IIWg=.1c5f0d68-9993-4471-8bc7-6b1edd741636@github.com>
Message-ID: <y3KSj8CeOrVrbutfizKLxvQNnvfiFlGYltoQWJMy1SQ=.d1e60fe3-a945-42f4-8613-2575e47e2be8@github.com>

On Wed, 2 Apr 2025 14:52:16 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

> At first glance the changes looks good to me!
> About the scenario, is it just moving the mouse from the flamegraph to the click on the stack trace tab. Also, is there an a specific OS where this is happening ?
> 
Yes just click on the stack trace on Windows (didn't try on linux or macos).

> application/org.openjdk.jmc.flightrecorder.flamegraph/src/main/java/org/openjdk/jmc/flightrecorder/flamegraph/views/FlamegraphSwingView.java line 497:
> 
>> 495: 			tooltip.setShift(new Point(10, 5));
>> 496: 
>> 497: 			embeddingComposite.addListener(SWT.MouseExit, event -> Display.getDefault().timerExec(300, tooltip::hide));
> 
> **question:** I wonder if this listener is still needed, in case the mouse event is not received on the swing component. E.g. in weird situations like : Alt Tab (on macOs) to change app but in the end selecting back to JMC. Not sure it's a real scenario, but i could imagine the Swing component not properly receiving mouse events.

Without the listener i still have the bug.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2773013863
PR Review Comment: https://git.openjdk.org/jmc/pull/635#discussion_r2025125750

From vpurnam at openjdk.org  Thu Apr  3 14:17:19 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Thu, 3 Apr 2025 14:17:19 GMT
Subject: RFR: 8378: Update version in jcheck conf file
Message-ID: <ZHi6xGoZJ3kI43b6cnjVZf6kLLCFGOKJw3C98y8P_-8=.4a0bda91-c954-44d7-9a98-9ac4631f4029@github.com>

Updated version in jcheck conf file

-------------

Commit messages:
 - 8378: Update version in jcheck conf file

Changes: https://git.openjdk.org/jmc/pull/637/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=637&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8378
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jmc/pull/637.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/637/head:pull/637

PR: https://git.openjdk.org/jmc/pull/637

From vpurnam at openjdk.org  Thu Apr  3 16:11:00 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Thu, 3 Apr 2025 16:11:00 GMT
Subject: RFR: 8366: Jolokia - Display warning when enabling Jolokia
 discovery about only using the discovery feature in a trusted environment.
 [v2]
In-Reply-To: <L1EREaRmbU8pb32Coi63GivtT2IHNRmhF3PrAZz_L1w=.a3a83d07-b844-451c-9d4c-1d9574e494d3@github.com>
References: <8Py5DvGtFsKLcMb2NDEU5bDopeckWBR0KeKdA_y62rY=.4e0a95d5-d5f8-4d0e-8065-572584db8ac1@github.com>
 <L1EREaRmbU8pb32Coi63GivtT2IHNRmhF3PrAZz_L1w=.a3a83d07-b844-451c-9d4c-1d9574e494d3@github.com>
Message-ID: <_9JBVc92mWjRZO1inZPKSbQJwfJ5j8vjZXOmpIyQ4a8=.0d6d4329-8ed2-4659-bcdb-acace932766e@github.com>

On Thu, 13 Mar 2025 22:22:19 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> 8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment.
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JMC-8366: Fix spotless violations

Sorry for delay. I was busy with some important tasks. Changes looks good.

-------------

Marked as reviewed by vpurnam (Reviewer).

PR Review: https://git.openjdk.org/jmc/pull/631#pullrequestreview-2740451144

From hirt at openjdk.org  Fri Apr  4 15:30:59 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 4 Apr 2025 15:30:59 GMT
Subject: RFR: 8378: Update version in jcheck conf file
In-Reply-To: <ZHi6xGoZJ3kI43b6cnjVZf6kLLCFGOKJw3C98y8P_-8=.4a0bda91-c954-44d7-9a98-9ac4631f4029@github.com>
References: <ZHi6xGoZJ3kI43b6cnjVZf6kLLCFGOKJw3C98y8P_-8=.4a0bda91-c954-44d7-9a98-9ac4631f4029@github.com>
Message-ID: <gWc4SlQybKVhEW9wW3oNfANjsD2M0FyC_4nPsAhj19g=.f17ca749-20ee-4b21-ac09-9bb5d6839f54@github.com>

On Thu, 3 Apr 2025 14:12:22 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> Updated version in jcheck conf file

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/637#pullrequestreview-2743416470

From hirt at openjdk.org  Fri Apr  4 15:32:55 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 4 Apr 2025 15:32:55 GMT
Subject: RFR: 8372: Add UnitLookup.TIMESPAN to AttributeSelection to be
 able to use the attribute in FlameGraph for IO
In-Reply-To: <GxZMuiWND6DKbN8jGX_MoMSItDEL1fZ4lSxZyPFLh_0=.0adec545-2573-42d9-8d0c-068f2d0650e0@github.com>
References: <GxZMuiWND6DKbN8jGX_MoMSItDEL1fZ4lSxZyPFLh_0=.0adec545-2573-42d9-8d0c-068f2d0650e0@github.com>
Message-ID: <LhZmGROHwytF8vQH4rSShzmj-dU96CwRMLEzkAvDd28=.6bc1791b-6b8a-468f-8d55-a5a1c9ac0c07@github.com>

On Thu, 27 Mar 2025 13:36:46 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO
> 
> https://ibb.co/mrBQpYbQ

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/634#pullrequestreview-2743422074

From hirt at openjdk.org  Fri Apr  4 15:35:59 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 4 Apr 2025 15:35:59 GMT
Subject: RFR: 8366: Jolokia - Display warning when enabling Jolokia
 discovery about only using the discovery feature in a trusted environment.
 [v2]
In-Reply-To: <L1EREaRmbU8pb32Coi63GivtT2IHNRmhF3PrAZz_L1w=.a3a83d07-b844-451c-9d4c-1d9574e494d3@github.com>
References: <8Py5DvGtFsKLcMb2NDEU5bDopeckWBR0KeKdA_y62rY=.4e0a95d5-d5f8-4d0e-8065-572584db8ac1@github.com>
 <L1EREaRmbU8pb32Coi63GivtT2IHNRmhF3PrAZz_L1w=.a3a83d07-b844-451c-9d4c-1d9574e494d3@github.com>
Message-ID: <GaYyJJ3ftwhEya2yLYPn65ogqZon53F418Pg5OjGl-A=.dfd74d48-ef05-452c-8b2f-88218164df79@github.com>

On Thu, 13 Mar 2025 22:22:19 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> 8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment.
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JMC-8366: Fix spotless violations

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/631#pullrequestreview-2743426961

From hirt at openjdk.org  Fri Apr  4 15:36:00 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 4 Apr 2025 15:36:00 GMT
Subject: RFR: 8366: Jolokia - Display warning when enabling Jolokia
 discovery about only using the discovery feature in a trusted environment.
In-Reply-To: <UUCsbytYEM0Sh-9axDvd_1tRtBkqBEosmX0rclLx2DY=.2601c3b4-5b4c-4707-9d82-2a74593d3f36@github.com>
References: <8Py5DvGtFsKLcMb2NDEU5bDopeckWBR0KeKdA_y62rY=.4e0a95d5-d5f8-4d0e-8065-572584db8ac1@github.com>
 <UUCsbytYEM0Sh-9axDvd_1tRtBkqBEosmX0rclLx2DY=.2601c3b4-5b4c-4707-9d82-2a74593d3f36@github.com>
Message-ID: <eUE-_wcfy8xDtDSv3PJ0mkzhQQXXC2hFbral2JGyLuI=.721c593a-4a68-4627-8a80-fa1338d767e8@github.com>

On Thu, 13 Mar 2025 22:15:20 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> 8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment.
>
> cc: @viragpurnam

@skarsaune please /integrate

-------------

PR Comment: https://git.openjdk.org/jmc/pull/631#issuecomment-2779105754

From duke at openjdk.org  Fri Apr  4 15:38:57 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 4 Apr 2025 15:38:57 GMT
Subject: RFR: 8366: Jolokia - Display warning when enabling Jolokia
 discovery about only using the discovery feature in a trusted environment.
 [v2]
In-Reply-To: <L1EREaRmbU8pb32Coi63GivtT2IHNRmhF3PrAZz_L1w=.a3a83d07-b844-451c-9d4c-1d9574e494d3@github.com>
References: <8Py5DvGtFsKLcMb2NDEU5bDopeckWBR0KeKdA_y62rY=.4e0a95d5-d5f8-4d0e-8065-572584db8ac1@github.com>
 <L1EREaRmbU8pb32Coi63GivtT2IHNRmhF3PrAZz_L1w=.a3a83d07-b844-451c-9d4c-1d9574e494d3@github.com>
Message-ID: <KDEW0uOcj_jw3BpZz-AhTwzyEt2F5ZeAQPrwlq12gsg=.aa82e3ec-3565-4177-92d1-96cd44364fec@github.com>

On Thu, 13 Mar 2025 22:22:19 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> 8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment.
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JMC-8366: Fix spotless violations

Sorry about the late reply

-------------

PR Comment: https://git.openjdk.org/jmc/pull/631#issuecomment-2779111728

From duke at openjdk.org  Fri Apr  4 15:38:57 2025
From: duke at openjdk.org (duke)
Date: Fri, 4 Apr 2025 15:38:57 GMT
Subject: RFR: 8366: Jolokia - Display warning when enabling Jolokia
 discovery about only using the discovery feature in a trusted environment.
 [v2]
In-Reply-To: <L1EREaRmbU8pb32Coi63GivtT2IHNRmhF3PrAZz_L1w=.a3a83d07-b844-451c-9d4c-1d9574e494d3@github.com>
References: <8Py5DvGtFsKLcMb2NDEU5bDopeckWBR0KeKdA_y62rY=.4e0a95d5-d5f8-4d0e-8065-572584db8ac1@github.com>
 <L1EREaRmbU8pb32Coi63GivtT2IHNRmhF3PrAZz_L1w=.a3a83d07-b844-451c-9d4c-1d9574e494d3@github.com>
Message-ID: <ra2KqxORmuNJbG5fNR6MQMG0AmKa6SCRBtPAheIgq5c=.ebfe07b3-6a49-47e4-ab0f-63aaf963f430@github.com>

On Thu, 13 Mar 2025 22:22:19 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> 8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment.
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JMC-8366: Fix spotless violations

@skarsaune 
Your change (at version 1a8021958761cafeccd0626d38c8657a1fd003c2) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/631#issuecomment-2779113376

From duke at openjdk.org  Fri Apr  4 16:45:55 2025
From: duke at openjdk.org (duke)
Date: Fri, 4 Apr 2025 16:45:55 GMT
Subject: RFR: 8372: Add UnitLookup.TIMESPAN to AttributeSelection to be
 able to use the attribute in FlameGraph for IO
In-Reply-To: <GxZMuiWND6DKbN8jGX_MoMSItDEL1fZ4lSxZyPFLh_0=.0adec545-2573-42d9-8d0c-068f2d0650e0@github.com>
References: <GxZMuiWND6DKbN8jGX_MoMSItDEL1fZ4lSxZyPFLh_0=.0adec545-2573-42d9-8d0c-068f2d0650e0@github.com>
Message-ID: <XEI03MKACCvCitrBh4aoZ075C60mzuFbz3wZsA3vY3Y=.b0821ca7-080d-409a-926f-00c60fa93b7f@github.com>

On Thu, 27 Mar 2025 13:36:46 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO
> 
> https://ibb.co/mrBQpYbQ

@RoiSoleil 
Your change (at version edf1e3e9f6e542bed25a008290c607e76df79938) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/634#issuecomment-2779264209

From duke at openjdk.org  Fri Apr  4 16:49:54 2025
From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES)
Date: Fri, 4 Apr 2025 16:49:54 GMT
Subject: RFR: 8372: Add UnitLookup.TIMESPAN to AttributeSelection to be
 able to use the attribute in FlameGraph for IO
In-Reply-To: <LhZmGROHwytF8vQH4rSShzmj-dU96CwRMLEzkAvDd28=.6bc1791b-6b8a-468f-8d55-a5a1c9ac0c07@github.com>
References: <GxZMuiWND6DKbN8jGX_MoMSItDEL1fZ4lSxZyPFLh_0=.0adec545-2573-42d9-8d0c-068f2d0650e0@github.com>
 <LhZmGROHwytF8vQH4rSShzmj-dU96CwRMLEzkAvDd28=.6bc1791b-6b8a-468f-8d55-a5a1c9ac0c07@github.com>
Message-ID: <-6pvA2QmJ-WQUqCnV9YyL9H6sbc_fLC75wjkwp0iOsQ=.a072829d-f14e-4b5a-ba1c-494ddb277876@github.com>

On Fri, 4 Apr 2025 15:30:47 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO
>> 
>> https://ibb.co/mrBQpYbQ
>
> Marked as reviewed by hirt (Lead).

@thegreystone could you sponsor ?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/634#issuecomment-2779272007

From vpurnam at openjdk.org  Sun Apr  6 15:52:53 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Sun, 6 Apr 2025 15:52:53 GMT
Subject: Integrated: 8378: Update version in jcheck conf file
In-Reply-To: <ZHi6xGoZJ3kI43b6cnjVZf6kLLCFGOKJw3C98y8P_-8=.4a0bda91-c954-44d7-9a98-9ac4631f4029@github.com>
References: <ZHi6xGoZJ3kI43b6cnjVZf6kLLCFGOKJw3C98y8P_-8=.4a0bda91-c954-44d7-9a98-9ac4631f4029@github.com>
Message-ID: <5mpEo0FqoLaAPxbsiN196zk8u5UeRKCL6Ak5ePIw79U=.713b6be8-a4bf-465d-ba4e-60c26d64c729@github.com>

On Thu, 3 Apr 2025 14:12:22 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> Updated version in jcheck conf file

This pull request has now been integrated.

Changeset: 6d310d9e
Author:    Virag Purnam <vpurnam at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/6d310d9e31061743654e41f54e1f6191bc78eb15
Stats:     3 lines in 1 file changed: 0 ins; 0 del; 3 mod

8378: Update version in jcheck conf file

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/637

From hirt at openjdk.org  Mon Apr  7 22:02:18 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 7 Apr 2025 22:02:18 GMT
Subject: RFR: 8372: Add UnitLookup.TIMESPAN to AttributeSelection to be
 able to use the attribute in FlameGraph for IO
In-Reply-To: <GxZMuiWND6DKbN8jGX_MoMSItDEL1fZ4lSxZyPFLh_0=.0adec545-2573-42d9-8d0c-068f2d0650e0@github.com>
References: <GxZMuiWND6DKbN8jGX_MoMSItDEL1fZ4lSxZyPFLh_0=.0adec545-2573-42d9-8d0c-068f2d0650e0@github.com>
Message-ID: <6KisRAOlWwpKW9IDMvF_M-C2kODBRRI4IfugcFAHVjM=.2410c440-9dc0-44af-9aa3-58804bb64d84@github.com>

On Thu, 27 Mar 2025 13:36:46 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO
> 
> https://ibb.co/mrBQpYbQ

Done!

-------------

PR Comment: https://git.openjdk.org/jmc/pull/634#issuecomment-2784725229

From duke at openjdk.org  Mon Apr  7 22:02:18 2025
From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES)
Date: Mon, 7 Apr 2025 22:02:18 GMT
Subject: Integrated: 8372: Add UnitLookup.TIMESPAN to AttributeSelection to be
 able to use the attribute in FlameGraph for IO
In-Reply-To: <GxZMuiWND6DKbN8jGX_MoMSItDEL1fZ4lSxZyPFLh_0=.0adec545-2573-42d9-8d0c-068f2d0650e0@github.com>
References: <GxZMuiWND6DKbN8jGX_MoMSItDEL1fZ4lSxZyPFLh_0=.0adec545-2573-42d9-8d0c-068f2d0650e0@github.com>
Message-ID: <MC3FNvch8G9HV8WdO3973XgsvNgh6pR8ut7lGEZRbLA=.19f51a97-a5cf-49c4-b2cd-e0cf5208b551@github.com>

On Thu, 27 Mar 2025 13:36:46 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO
> 
> https://ibb.co/mrBQpYbQ

This pull request has now been integrated.

Changeset: da6e38e4
Author:    H?lios GILLES <h-gilles at efluid.fr>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/da6e38e42c18254f524f40de246bd7ef9632e8ee
Stats:     2 lines in 1 file changed: 1 ins; 0 del; 1 mod

8372: Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/634

From duke at openjdk.org  Mon Apr  7 22:03:17 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Mon, 7 Apr 2025 22:03:17 GMT
Subject: Integrated: 8366: Jolokia - Display warning when enabling Jolokia
 discovery about only using the discovery feature in a trusted environment.
In-Reply-To: <8Py5DvGtFsKLcMb2NDEU5bDopeckWBR0KeKdA_y62rY=.4e0a95d5-d5f8-4d0e-8065-572584db8ac1@github.com>
References: <8Py5DvGtFsKLcMb2NDEU5bDopeckWBR0KeKdA_y62rY=.4e0a95d5-d5f8-4d0e-8065-572584db8ac1@github.com>
Message-ID: <FA7TdN6MtpnKKYXJq-LgIVXlQ7PxHIPaoD-1IOnUBeE=.2cfaaf1c-be61-4d93-a10e-05be688298b0@github.com>

On Thu, 13 Mar 2025 22:09:33 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> 8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment.

This pull request has now been integrated.

Changeset: 7510a163
Author:    Martin Skarsaune <martin at skarsaune.net>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/7510a16347fd42f6b2144c161bbc78049f96cb1d
Stats:     12 lines in 3 files changed: 10 ins; 0 del; 2 mod

8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment.

Reviewed-by: vpurnam, hirt

-------------

PR: https://git.openjdk.org/jmc/pull/631

From duke at openjdk.org  Tue Apr  8 09:09:23 2025
From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES)
Date: Tue, 8 Apr 2025 09:09:23 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <BA4NtmWBJ2oCcAq2EDt7DV8XrJlUH3pNlu-IrM3IIWg=.1c5f0d68-9993-4471-8bc7-6b1edd741636@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
 <BA4NtmWBJ2oCcAq2EDt7DV8XrJlUH3pNlu-IrM3IIWg=.1c5f0d68-9993-4471-8bc7-6b1edd741636@github.com>
Message-ID: <3mMkW4THgJcTVYWyIrGqLllaFNzWvwfSUXlw0IPXP_o=.92bdb286-ae37-4521-9149-09313032a6e8@github.com>

On Wed, 2 Apr 2025 14:52:16 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>> Fix tooltip on Flamegraph not showing after switching to Stack Trace view
>> 
>> The bug : Open a JFR file, open the Flamegraph view, see the tooltip on Flamegraph working, activate the Stack Trace view, get back to Flamegraph ==> the tooltip is not showing anymore on Flamegraph
>
> At first glance the changes looks good to me!
> About the scenario, is it just moving the mouse from the flamegraph to the click on the stack trace tab. Also, is there an a specific OS where this is happening ?

@bric3 it's ok for you ?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2785751963

From bdutheil at openjdk.org  Tue Apr  8 10:38:39 2025
From: bdutheil at openjdk.org (Brice Dutheil)
Date: Tue, 8 Apr 2025 10:38:39 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
Message-ID: <QG_sOnGaLOLmBXshUfm61ykaJUWFp359U9CDZkT20nY=.676eef06-bc70-4df1-aefe-ef55b14a2028@github.com>

On Fri, 28 Mar 2025 12:36:55 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> Fix tooltip on Flamegraph not showing after switching to Stack Trace view
> 
> The bug : Open a JFR file, open the Flamegraph view, see the tooltip on Flamegraph working, activate the Stack Trace view, get back to Flamegraph ==> the tooltip is not showing anymore on Flamegraph

Marked as reviewed by bdutheil (Committer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/635#pullrequestreview-2749498428

From bdutheil at openjdk.org  Tue Apr  8 10:38:40 2025
From: bdutheil at openjdk.org (Brice Dutheil)
Date: Tue, 8 Apr 2025 10:38:40 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <3mMkW4THgJcTVYWyIrGqLllaFNzWvwfSUXlw0IPXP_o=.92bdb286-ae37-4521-9149-09313032a6e8@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
 <BA4NtmWBJ2oCcAq2EDt7DV8XrJlUH3pNlu-IrM3IIWg=.1c5f0d68-9993-4471-8bc7-6b1edd741636@github.com>
 <3mMkW4THgJcTVYWyIrGqLllaFNzWvwfSUXlw0IPXP_o=.92bdb286-ae37-4521-9149-09313032a6e8@github.com>
Message-ID: <vdu0F-mYOMHbnBrV4klj96x8oqWk5-o7chlfp5rZAu4=.97e80a96-e194-4826-bece-04b469d9c5b6@github.com>

On Tue, 8 Apr 2025 09:06:15 GMT, H?lios GILLES <duke at openjdk.org> wrote:

>> At first glance the changes looks good to me!
>> About the scenario, is it just moving the mouse from the flamegraph to the click on the stack trace tab. Also, is there an a specific OS where this is happening ?
>
> @bric3 it's ok for you ?

@RoiSoleil I tested on macos this morning. The chat get looks good.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2785991517

From duke at openjdk.org  Tue Apr  8 10:50:29 2025
From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES)
Date: Tue, 8 Apr 2025 10:50:29 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <3mMkW4THgJcTVYWyIrGqLllaFNzWvwfSUXlw0IPXP_o=.92bdb286-ae37-4521-9149-09313032a6e8@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
 <BA4NtmWBJ2oCcAq2EDt7DV8XrJlUH3pNlu-IrM3IIWg=.1c5f0d68-9993-4471-8bc7-6b1edd741636@github.com>
 <3mMkW4THgJcTVYWyIrGqLllaFNzWvwfSUXlw0IPXP_o=.92bdb286-ae37-4521-9149-09313032a6e8@github.com>
Message-ID: <nAfHAXR46iXRLM5aceHenLu_22qhZJAfd-_hLDH58lM=.9b7200a0-760b-4346-b603-1f05502e5f06@github.com>

On Tue, 8 Apr 2025 09:06:15 GMT, H?lios GILLES <duke at openjdk.org> wrote:

>> At first glance the changes looks good to me!
>> About the scenario, is it just moving the mouse from the flamegraph to the click on the stack trace tab. Also, is there an a specific OS where this is happening ?
>
> @bric3 it's ok for you ?

> @RoiSoleil I tested on macos this morning. The chat get looks good.

Thx
@aptmac it's ok for you ?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2786023282

From aptmac at openjdk.org  Tue Apr  8 14:10:32 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 8 Apr 2025 14:10:32 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
Message-ID: <I1Muss-XG_YqHUppTRUpiw8E203PO-gQG7ZCUa1TKlE=.78bb6c08-ba1f-445b-ba43-6ebef7b2b4f9@github.com>

On Fri, 28 Mar 2025 12:36:55 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> Fix tooltip on Flamegraph not showing after switching to Stack Trace view
> 
> The bug : Open a JFR file, open the Flamegraph view, see the tooltip on Flamegraph working, activate the Stack Trace view, get back to Flamegraph ==> the tooltip is not showing anymore on Flamegraph

LGTM, but I noticed that not all of the usual checks are happening on the PR. IIRC these were enabled in the actions tab of the user's fork, @RoiSoleil could you see if there's anything for you to enabled at: https://github.com/RoiSoleil/jmc/actions ?

-------------

PR Review: https://git.openjdk.org/jmc/pull/635#pullrequestreview-2750136113

From aptmac at openjdk.org  Tue Apr  8 14:22:24 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 8 Apr 2025 14:22:24 GMT
Subject: RFR: 8370: HDR Histogram View [v2]
In-Reply-To: <xo6CttedtQL0E4l21PbIM_1wiQJ8TkhzJGaHUVrvPpg=.423ba43b-8dd5-4cdf-b7b8-8a3e86356cea@github.com>
References: <ihgVMfLdj-12apHAyxzGth-VoCW4DGBNHQ7AhZxC56g=.4a9b97d9-ffa5-413e-897d-190a2fce2546@github.com>
 <xo6CttedtQL0E4l21PbIM_1wiQJ8TkhzJGaHUVrvPpg=.423ba43b-8dd5-4cdf-b7b8-8a3e86356cea@github.com>
Message-ID: <CXILqjFpdjS1sd70W9UcnV9LNqUbdYpdvJCcU4SRppM=.e4cd1d76-5ab0-4bbf-aa1b-e67c795792d5@github.com>

On Tue, 1 Apr 2025 23:24:52 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Adds a Histogram view that will work on any selected events (that have durations). Useful for looking at distributions of, for example, GC or Lock events, or for any events that have durations in the Event Browser. 
>> 
>> ![image](https://github.com/user-attachments/assets/97e7d3a5-9be8-455f-bf1f-fc0e846ebb40)
>> 
>> Events in any percentile can be selected in the percentiles table and used to set the active selection in the selection store.
>> ![image](https://github.com/user-attachments/assets/69fecbb6-6368-461b-af83-4605548e2513)
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Spotbugs potential null dereference

LGTM, it would be nice to have some sort of empty state or message that pops up if there aren't any duration events to display, the UI has a bunch of unexplained whitespace if there isn't anything to show

![Screenshot from 2025-04-08 10-15-24](https://github.com/user-attachments/assets/b19b0af7-c41e-4491-88e7-2e4cdf9c8188)

-------------

Marked as reviewed by aptmac (Reviewer).

PR Review: https://git.openjdk.org/jmc/pull/636#pullrequestreview-2750177317

From duke at openjdk.org  Tue Apr  8 15:34:19 2025
From: duke at openjdk.org (duke)
Date: Tue, 8 Apr 2025 15:34:19 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
Message-ID: <cjyVr7JrsBssVL-6rA4_GD1VH6ObNFfLTYPBAmW-3W4=.a2588d87-a0d2-4bff-8acd-c9bbf1adb135@github.com>

On Fri, 28 Mar 2025 12:36:55 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> Fix tooltip on Flamegraph not showing after switching to Stack Trace view
> 
> The bug : Open a JFR file, open the Flamegraph view, see the tooltip on Flamegraph working, activate the Stack Trace view, get back to Flamegraph ==> the tooltip is not showing anymore on Flamegraph

@RoiSoleil 
Your change (at version abb43905d6e45efd8bd2f5fc009a1e0a408cc8f2) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2786839114

From duke at openjdk.org  Tue Apr  8 15:34:19 2025
From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES)
Date: Tue, 8 Apr 2025 15:34:19 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <I1Muss-XG_YqHUppTRUpiw8E203PO-gQG7ZCUa1TKlE=.78bb6c08-ba1f-445b-ba43-6ebef7b2b4f9@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
 <I1Muss-XG_YqHUppTRUpiw8E203PO-gQG7ZCUa1TKlE=.78bb6c08-ba1f-445b-ba43-6ebef7b2b4f9@github.com>
Message-ID: <Ope6bJ_TXcAX1QwRyDNpuMWy3KImsIr87zpG7L3oe04=.2f1782d8-5515-45e1-ad34-50104e899be5@github.com>

On Tue, 8 Apr 2025 14:07:56 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Fix tooltip on Flamegraph not showing after switching to Stack Trace view
>> 
>> The bug : Open a JFR file, open the Flamegraph view, see the tooltip on Flamegraph working, activate the Stack Trace view, get back to Flamegraph ==> the tooltip is not showing anymore on Flamegraph
>
> LGTM, but I noticed that not all of the usual checks are happening on the PR. IIRC these were enabled in the actions tab of the user's fork, @RoiSoleil could you see if there's anything for you to enabled at: https://github.com/RoiSoleil/jmc/actions ?

@aptmac could you sponsor ?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2786847584

From duke at openjdk.org  Tue Apr  8 15:34:19 2025
From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES)
Date: Tue, 8 Apr 2025 15:34:19 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
Message-ID: <DEsE3SrIsQcKyUylBTxGOP2jSJT5S62D84kY6lCJKpA=.4de18feb-48ec-4e3a-80cb-7ae5c24858fd@github.com>

On Fri, 28 Mar 2025 12:36:55 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> Fix tooltip on Flamegraph not showing after switching to Stack Trace view
> 
> The bug : Open a JFR file, open the Flamegraph view, see the tooltip on Flamegraph working, activate the Stack Trace view, get back to Flamegraph ==> the tooltip is not showing anymore on Flamegraph

On https://github.com/RoiSoleil/jmc/actions :

Workflows aren?t being run on this forked repository
Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2786834026

From aptmac at openjdk.org  Tue Apr  8 15:51:19 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 8 Apr 2025 15:51:19 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <DEsE3SrIsQcKyUylBTxGOP2jSJT5S62D84kY6lCJKpA=.4de18feb-48ec-4e3a-80cb-7ae5c24858fd@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
 <DEsE3SrIsQcKyUylBTxGOP2jSJT5S62D84kY6lCJKpA=.4de18feb-48ec-4e3a-80cb-7ae5c24858fd@github.com>
Message-ID: <OD8_cyFnp0YtkidUnKcOm_kqmslg1ZSmPmoqy7XxryM=.c1a33c16-43ca-4eff-9110-7be2a6d88827@github.com>

On Tue, 8 Apr 2025 15:27:30 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> On https://github.com/RoiSoleil/jmc/actions :
> 
> Workflows aren?t being run on this forked repository Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.

Ah, would you be able to try and enable the actions? If the enable option isn't on that page, it may be here: https://github.com/RoiSoleil/jmc/settings/actions

I'm not sure if when enabled Skara will kick off the other actions for this PR, but it would be nice to make sure you're set up for any PRs in the future.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2786896025

From duke at openjdk.org  Tue Apr  8 16:16:35 2025
From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES)
Date: Tue, 8 Apr 2025 16:16:35 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <OD8_cyFnp0YtkidUnKcOm_kqmslg1ZSmPmoqy7XxryM=.c1a33c16-43ca-4eff-9110-7be2a6d88827@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
 <DEsE3SrIsQcKyUylBTxGOP2jSJT5S62D84kY6lCJKpA=.4de18feb-48ec-4e3a-80cb-7ae5c24858fd@github.com>
 <OD8_cyFnp0YtkidUnKcOm_kqmslg1ZSmPmoqy7XxryM=.c1a33c16-43ca-4eff-9110-7be2a6d88827@github.com>
Message-ID: <Sa8XM5mcUj9snzF-8u6700NsNK8sW-_mpwF6PdmfoK4=.05401d6e-d374-49a0-8a44-97d73c6688e8@github.com>

On Tue, 8 Apr 2025 15:48:31 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> > On https://github.com/RoiSoleil/jmc/actions :
> > Workflows aren?t being run on this forked repository Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.
> 
> Ah, would you be able to try and enable the actions? If the enable option isn't on that page, it may be here: https://github.com/RoiSoleil/jmc/settings/actions
> 
> I'm not sure if when enabled Skara will kick off the other actions for this PR, but it would be nice to make sure you're set up for any PRs in the future.

I did it and run validate.yml

-------------

PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2786977466

From aptmac at openjdk.org  Tue Apr  8 16:26:23 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 8 Apr 2025 16:26:23 GMT
Subject: RFR: 8373: Fix tooltip on Flamegraph not showing after switching
 to Stack Trace view
In-Reply-To: <Sa8XM5mcUj9snzF-8u6700NsNK8sW-_mpwF6PdmfoK4=.05401d6e-d374-49a0-8a44-97d73c6688e8@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
 <DEsE3SrIsQcKyUylBTxGOP2jSJT5S62D84kY6lCJKpA=.4de18feb-48ec-4e3a-80cb-7ae5c24858fd@github.com>
 <OD8_cyFnp0YtkidUnKcOm_kqmslg1ZSmPmoqy7XxryM=.c1a33c16-43ca-4eff-9110-7be2a6d88827@github.com>
 <Sa8XM5mcUj9snzF-8u6700NsNK8sW-_mpwF6PdmfoK4=.05401d6e-d374-49a0-8a44-97d73c6688e8@github.com>
Message-ID: <p6wmy4qSsgto3SvWmJW89kObp4oNuyGeydZJz5SMFeg=.5329d2d5-1c24-4009-ba02-03fca95406db@github.com>

On Tue, 8 Apr 2025 16:13:51 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> > > On https://github.com/RoiSoleil/jmc/actions :
> > > Workflows aren?t being run on this forked repository Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.
> > 
> > 
> > Ah, would you be able to try and enable the actions? If the enable option isn't on that page, it may be here: https://github.com/RoiSoleil/jmc/settings/actions
> > I'm not sure if when enabled Skara will kick off the other actions for this PR, but it would be nice to make sure you're set up for any PRs in the future.
> 
> I did it and run validate.yml

Great, thanks! I see they are running on the PR, I'll sponsor once the runs complete

-------------

PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2787005192

From duke at openjdk.org  Tue Apr  8 16:41:24 2025
From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES)
Date: Tue, 8 Apr 2025 16:41:24 GMT
Subject: Integrated: 8373: Fix tooltip on Flamegraph not showing after
 switching to Stack Trace view
In-Reply-To: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
References: <XNNCAUEhDzcEmTFhDlHxEOMgJCWnVUzqBJp7zb2ca00=.2b7d1148-cc7b-41a9-b4a2-cc844a344ea2@github.com>
Message-ID: <FiMFh8V_oEq-Q_5Hd-nX0ZHwNHYY9l0aS21DY3kEj3E=.96594f02-9ee6-49c5-8e58-425114fbba80@github.com>

On Fri, 28 Mar 2025 12:36:55 GMT, H?lios GILLES <duke at openjdk.org> wrote:

> Fix tooltip on Flamegraph not showing after switching to Stack Trace view
> 
> The bug : Open a JFR file, open the Flamegraph view, see the tooltip on Flamegraph working, activate the Stack Trace view, get back to Flamegraph ==> the tooltip is not showing anymore on Flamegraph

This pull request has now been integrated.

Changeset: 6a048a8f
Author:    H?lios GILLES <h-gilles at efluid.fr>
Committer: Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/6a048a8f9a004f739fc472752ca2f4907ef28798
Stats:     74 lines in 1 file changed: 32 ins; 23 del; 19 mod

8373: Fix tooltip on Flamegraph not showing after switching to Stack Trace view

Reviewed-by: bdutheil

-------------

PR: https://git.openjdk.org/jmc/pull/635

From hirt at openjdk.org  Wed Apr  9 15:14:50 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 9 Apr 2025 15:14:50 GMT
Subject: Integrated: 8370: HDR Histogram View
In-Reply-To: <ihgVMfLdj-12apHAyxzGth-VoCW4DGBNHQ7AhZxC56g=.4a9b97d9-ffa5-413e-897d-190a2fce2546@github.com>
References: <ihgVMfLdj-12apHAyxzGth-VoCW4DGBNHQ7AhZxC56g=.4a9b97d9-ffa5-413e-897d-190a2fce2546@github.com>
Message-ID: <zUzD7U93l10loIZ8d1b7wNvDql17fanXkJmlmZJEKyk=.0161f90e-ce92-4922-ada7-37a85a53059b@github.com>

On Tue, 1 Apr 2025 23:08:59 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Adds a Histogram view that will work on any selected events (that have durations). Useful for looking at distributions of, for example, GC or Lock events, or for any events that have durations in the Event Browser. 
> 
> ![image](https://github.com/user-attachments/assets/97e7d3a5-9be8-455f-bf1f-fc0e846ebb40)
> 
> Events in any percentile can be selected in the percentiles table and used to set the active selection in the selection store.
> ![image](https://github.com/user-attachments/assets/69fecbb6-6368-461b-af83-4605548e2513)

This pull request has now been integrated.

Changeset: 688063ad
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/688063ad4c2187cd36221635a532ac821224bd93
Stats:     464 lines in 12 files changed: 457 ins; 0 del; 7 mod

8370: HDR Histogram View

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/636

From hirt at openjdk.org  Wed Apr  9 15:14:50 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 9 Apr 2025 15:14:50 GMT
Subject: RFR: 8370: HDR Histogram View [v2]
In-Reply-To: <xo6CttedtQL0E4l21PbIM_1wiQJ8TkhzJGaHUVrvPpg=.423ba43b-8dd5-4cdf-b7b8-8a3e86356cea@github.com>
References: <ihgVMfLdj-12apHAyxzGth-VoCW4DGBNHQ7AhZxC56g=.4a9b97d9-ffa5-413e-897d-190a2fce2546@github.com>
 <xo6CttedtQL0E4l21PbIM_1wiQJ8TkhzJGaHUVrvPpg=.423ba43b-8dd5-4cdf-b7b8-8a3e86356cea@github.com>
Message-ID: <xgBMOV9Ml5JA6vpbH57pE8UhfCxYhbYWhtgUhW7O1fA=.3aa9cd1d-8d30-4701-a62d-8a398b4d1380@github.com>

On Tue, 1 Apr 2025 23:24:52 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Adds a Histogram view that will work on any selected events (that have durations). Useful for looking at distributions of, for example, GC or Lock events, or for any events that have durations in the Event Browser. 
>> 
>> ![image](https://github.com/user-attachments/assets/97e7d3a5-9be8-455f-bf1f-fc0e846ebb40)
>> 
>> Events in any percentile can be selected in the percentiles table and used to set the active selection in the selection store.
>> ![image](https://github.com/user-attachments/assets/69fecbb6-6368-461b-af83-4605548e2513)
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Spotbugs potential null dereference

Added a PR for it here:
https://bugs.openjdk.org/browse/JMC-8383

Will go back for it in a bit - want to get a proper dark mode finished up first. :)

-------------

PR Comment: https://git.openjdk.org/jmc/pull/636#issuecomment-2790069077

From schaturvedi at openjdk.org  Fri Apr 11 10:51:28 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Fri, 11 Apr 2025 10:51:28 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames [v2]
In-Reply-To: <M5DHZ4xosLSMZnPb7jpkjqChkRXMPVXboyGCSZm3aPM=.31fcc88e-afe2-432e-bf2a-1781b202c886@github.com>
References: <M5DHZ4xosLSMZnPb7jpkjqChkRXMPVXboyGCSZm3aPM=.31fcc88e-afe2-432e-bf2a-1781b202c886@github.com>
Message-ID: <zwZUXIU-_LWmwHZlqjzKBXnPHxnDTlRNiNUz3OX2in0=.df89bdb5-7077-4139-b64b-180596284375@github.com>

> JFR tool is hiding all the hidden frames. But in JMC, Stacktrace view is still showing lot of hidden methods which is not required from the users point of view. Hence, we will be hiding all the hidden frames as part of this enhancement.
> 
> Also, we have updated some test cases also in order to get rid of hidden frames which were expected by the test cases.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Removed ArrayList and replaced FOR-loop implementation with Streams

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/632/files
  - new: https://git.openjdk.org/jmc/pull/632/files/4db62bbf..7adc0782

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=632&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=632&range=00-01

  Stats: 12 lines in 1 file changed: 0 ins; 6 del; 6 mod
  Patch: https://git.openjdk.org/jmc/pull/632.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/632/head:pull/632

PR: https://git.openjdk.org/jmc/pull/632

From vpurnam at openjdk.org  Tue Apr 15 05:17:22 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Tue, 15 Apr 2025 05:17:22 GMT
Subject: RFR: 8382: Update to Eclipse 2025-03
Message-ID: <mS2uRLjP2Sc9icxWw_XmrUEQW81eionYm78t8yHBGEU=.f9c5289c-5418-4221-b975-5fc82bbc611d@github.com>

Eclipse platform upgrade.

- Upgraded to 2025-03.
- Updated jetty.project to version 12.0.16 to make it same as the version used in latest eclipse.
- All the views (Dependency View, Heatmap View etc) works fine.

-------------

Commit messages:
 - 8382: Update to Eclipse 2025-03

Changes: https://git.openjdk.org/jmc/pull/638/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=638&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8382
  Stats: 257 lines in 10 files changed: 99 ins; 116 del; 42 mod
  Patch: https://git.openjdk.org/jmc/pull/638.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/638/head:pull/638

PR: https://git.openjdk.org/jmc/pull/638

From duke at openjdk.org  Tue Apr 15 21:34:58 2025
From: duke at openjdk.org (duke)
Date: Tue, 15 Apr 2025 21:34:58 GMT
Subject: Withdrawn: 8237: Add support for Jolokia over Kubernetes proxy
In-Reply-To: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
Message-ID: <jcEt2E2naxeQ79DCWcYM3wfTe7yECj38DCYnGmbKMUo=.14c66922-cd9f-43ae-9fb2-dde0cd0013e7@github.com>

On Sun, 4 Aug 2024 12:05:24 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.
> 
> Testing connectivity:
> - [x]  Docker desktop kubernetes 
> - [x]  Azure AKS
> - [x]  Amazon EKS
> - [x]  Google GKE
> 
> Other things observed:
> 
> - [x] * Option to install agent should be disabled (debug difference with jolokia) - ***see below****
> - [x] * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
> - [x] * SLF4J(W): No SLF4J providers were found. ***OK for now, can investigate more later***
> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
> - [x] Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jmc/pull/576

From hirt at openjdk.org  Wed Apr 16 18:37:46 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 16 Apr 2025 18:37:46 GMT
Subject: RFR: 8382: Update to Eclipse 2025-03
In-Reply-To: <mS2uRLjP2Sc9icxWw_XmrUEQW81eionYm78t8yHBGEU=.f9c5289c-5418-4221-b975-5fc82bbc611d@github.com>
References: <mS2uRLjP2Sc9icxWw_XmrUEQW81eionYm78t8yHBGEU=.f9c5289c-5418-4221-b975-5fc82bbc611d@github.com>
Message-ID: <vIBq9mC2ZaHQ7ph-ZRRZ-M4mLIbBg6YRSofb97wVr9A=.3ba660c1-534d-4e92-96b8-427403d2d1da@github.com>

On Tue, 15 Apr 2025 05:12:15 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> Eclipse platform upgrade.
> 
> - Upgraded to 2025-03.
> - Deleted 2024-03.
> - Updated jetty.project to version 12.0.16 to make it same as the version used in latest eclipse.
> - All the views (Dependency View, Heatmap View etc) works fine.

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/638#pullrequestreview-2773472745

From vpurnam at openjdk.org  Thu Apr 17 07:37:57 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Thu, 17 Apr 2025 07:37:57 GMT
Subject: Integrated: 8382: Update to Eclipse 2025-03
In-Reply-To: <mS2uRLjP2Sc9icxWw_XmrUEQW81eionYm78t8yHBGEU=.f9c5289c-5418-4221-b975-5fc82bbc611d@github.com>
References: <mS2uRLjP2Sc9icxWw_XmrUEQW81eionYm78t8yHBGEU=.f9c5289c-5418-4221-b975-5fc82bbc611d@github.com>
Message-ID: <uKJ0Y_23yiN7-xwrlc_Z1733w3V90ig99tu7inaIy4I=.dc82137c-8bcd-40dc-a997-8d71f0407901@github.com>

On Tue, 15 Apr 2025 05:12:15 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> Eclipse platform upgrade.
> 
> - Upgraded to 2025-03.
> - Deleted 2024-03.
> - Updated jetty.project to version 12.0.16 to make it same as the version used in latest eclipse.
> - All the views (Dependency View, Heatmap View etc) works fine.

This pull request has now been integrated.

Changeset: c83c0786
Author:    Virag Purnam <vpurnam at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/c83c078659692e4deaf54f55b75932bc493a5888
Stats:     257 lines in 10 files changed: 99 ins; 116 del; 42 mod

8382: Update to Eclipse 2025-03

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/638

From hirt at openjdk.org  Thu Apr 17 21:51:05 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 17 Apr 2025 21:51:05 GMT
Subject: RFR: 8380: Support dark mode in graphs
Message-ID: <3-KqzhW4mOWnrVZJAKBRxbTZGI190FzmxdV3ABsH6Ko=.7015bf59-3f18-4879-aba7-bb7eeb47aa1e@github.com>

Also added dark mode support in the Automated Analysis page, and fixed wrong version in a few properties files along the way. 

Added a simple debug console for the next person needing to do something in the Automated Analysis page. I can't wait for the IE based WebView used by default by the SWT Browser component on Windows to die a well deserved death...

-------------

Commit messages:
 - Dark mode Analysis Overview plus version fixes
 - Quality of life...
 - Spotless and checkstyle
 - 8380: Fixing dark mode for graphs

Changes: https://git.openjdk.org/jmc/pull/639/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=639&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8380
  Stats: 385 lines in 19 files changed: 332 ins; 4 del; 49 mod
  Patch: https://git.openjdk.org/jmc/pull/639.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/639/head:pull/639

PR: https://git.openjdk.org/jmc/pull/639

From hirt at openjdk.org  Thu Apr 17 21:55:16 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 17 Apr 2025 21:55:16 GMT
Subject: RFR: 8380: Support dark mode in graphs [v2]
In-Reply-To: <3-KqzhW4mOWnrVZJAKBRxbTZGI190FzmxdV3ABsH6Ko=.7015bf59-3f18-4879-aba7-bb7eeb47aa1e@github.com>
References: <3-KqzhW4mOWnrVZJAKBRxbTZGI190FzmxdV3ABsH6Ko=.7015bf59-3f18-4879-aba7-bb7eeb47aa1e@github.com>
Message-ID: <gMoPyhmrVP6egG-QtBuMWrRKaz2aTinvcOixl5oGghE=.ced161d0-8ace-4e03-bc44-5c05396ff665@github.com>

> Also added dark mode support in the Automated Analysis page, and fixed wrong version in a few properties files along the way. 
> 
> Added a simple debug console for the next person needing to do something in the Automated Analysis page. I can't wait for the IE based WebView used by default by the SWT Browser component on Windows to die a well deserved death...

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Import fix

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/639/files
  - new: https://git.openjdk.org/jmc/pull/639/files/7e365816..62d21be6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=639&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=639&range=00-01

  Stats: 4 lines in 1 file changed: 2 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/639.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/639/head:pull/639

PR: https://git.openjdk.org/jmc/pull/639

From hirt at openjdk.org  Thu Apr 17 22:36:26 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 17 Apr 2025 22:36:26 GMT
Subject: RFR: 8289: Remove security manager related code
Message-ID: <Spp80SCq5XA15An52c0ZsHjejGj6-y8qC5tDeaZe8oA=.a85862b1-7e15-4a59-a539-0ae1a994e9f4@github.com>

Also fixing a deprecation.

-------------

Commit messages:
 - Removing permission class
 - 8289: Removing security manager related code

Changes: https://git.openjdk.org/jmc/pull/640/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=640&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8289
  Stats: 93 lines in 4 files changed: 0 ins; 90 del; 3 mod
  Patch: https://git.openjdk.org/jmc/pull/640.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/640/head:pull/640

PR: https://git.openjdk.org/jmc/pull/640

From schaturvedi at openjdk.org  Mon Apr 21 10:23:02 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Mon, 21 Apr 2025 10:23:02 GMT
Subject: RFR: 8385: Upgrade hashing algorithm
Message-ID: <MzYZu9QbK6VUFUgDHTjhZmqiwqr6CvgPOATLupIO1yY=.6e8d60c3-8a22-401d-b4d7-9a53180b45b4@github.com>

Upgrading hashing algorithm as part of this PR.

-------------

Commit messages:
 - 8385: Upgrade hashing algorithm

Changes: https://git.openjdk.org/jmc/pull/641/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=641&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8385
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/641.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/641/head:pull/641

PR: https://git.openjdk.org/jmc/pull/641

From aptmac at openjdk.org  Tue Apr 22 14:18:49 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 22 Apr 2025 14:18:49 GMT
Subject: RFR: 8380: Support dark mode in graphs [v2]
In-Reply-To: <gMoPyhmrVP6egG-QtBuMWrRKaz2aTinvcOixl5oGghE=.ced161d0-8ace-4e03-bc44-5c05396ff665@github.com>
References: <3-KqzhW4mOWnrVZJAKBRxbTZGI190FzmxdV3ABsH6Ko=.7015bf59-3f18-4879-aba7-bb7eeb47aa1e@github.com>
 <gMoPyhmrVP6egG-QtBuMWrRKaz2aTinvcOixl5oGghE=.ced161d0-8ace-4e03-bc44-5c05396ff665@github.com>
Message-ID: <P15ts8eXy6fGwiQ0seDT61Gp3eHkgzh43ISfq8TiTAA=.da03db22-b097-4d65-bc3d-8eab6f22c590@github.com>

On Thu, 17 Apr 2025 21:55:16 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also added dark mode support in the Automated Analysis page, and fixed wrong version in a few properties files along the way. 
>> 
>> Added a simple debug console for the next person needing to do something in the Automated Analysis page. I can't wait for the IE based WebView (used by default by the SWT Browser component on Windows) to die a well deserved death...
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Import fix

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/639#pullrequestreview-2784281724

From aptmac at openjdk.org  Tue Apr 22 14:31:48 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 22 Apr 2025 14:31:48 GMT
Subject: RFR: 8380: Support dark mode in graphs [v2]
In-Reply-To: <gMoPyhmrVP6egG-QtBuMWrRKaz2aTinvcOixl5oGghE=.ced161d0-8ace-4e03-bc44-5c05396ff665@github.com>
References: <3-KqzhW4mOWnrVZJAKBRxbTZGI190FzmxdV3ABsH6Ko=.7015bf59-3f18-4879-aba7-bb7eeb47aa1e@github.com>
 <gMoPyhmrVP6egG-QtBuMWrRKaz2aTinvcOixl5oGghE=.ced161d0-8ace-4e03-bc44-5c05396ff665@github.com>
Message-ID: <t18QHMCFBABICX7KfRt0JCrCeaBTykXXocfDzT4Knxw=.bc665e85-061b-4d6d-aec3-a438dea916fb@github.com>

On Thu, 17 Apr 2025 21:55:16 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also added dark mode support in the Automated Analysis page, and fixed wrong version in a few properties files along the way. 
>> 
>> Added a simple debug console for the next person needing to do something in the Automated Analysis page. I can't wait for the IE based WebView (used by default by the SWT Browser component on Windows) to die a well deserved death...
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Import fix

> Added a simple debug console for the next person needing to do something in the Automated Analysis page. I can't wait for the IE based WebView (used by default by the SWT Browser component on Windows) to die a well deserved death...

Seeing as how some of the web views don't do anything when using IE, maybe we should force Edge or display a warning if IE is detected? I think "SWT.EDGE" can be passed as the style parameter when creating the browser object, maybe we could have a quick check for OS and default browser and set Edge accordingly. Or have a basic HTML display if using IE instructing users how to switch over to Edge.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/639#issuecomment-2821525234

From hirt at openjdk.org  Tue Apr 22 15:16:47 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 22 Apr 2025 15:16:47 GMT
Subject: RFR: 8380: Support dark mode in graphs [v2]
In-Reply-To: <t18QHMCFBABICX7KfRt0JCrCeaBTykXXocfDzT4Knxw=.bc665e85-061b-4d6d-aec3-a438dea916fb@github.com>
References: <3-KqzhW4mOWnrVZJAKBRxbTZGI190FzmxdV3ABsH6Ko=.7015bf59-3f18-4879-aba7-bb7eeb47aa1e@github.com>
 <gMoPyhmrVP6egG-QtBuMWrRKaz2aTinvcOixl5oGghE=.ced161d0-8ace-4e03-bc44-5c05396ff665@github.com>
 <t18QHMCFBABICX7KfRt0JCrCeaBTykXXocfDzT4Knxw=.bc665e85-061b-4d6d-aec3-a438dea916fb@github.com>
Message-ID: <IveHnd0Zxu9Te4-7wrGE1A9zn9q6QBjQQizeXo1MJCE=.d7a7b2fa-fd32-42b2-9e7f-5eb0303b4714@github.com>

On Tue, 22 Apr 2025 14:28:36 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> > Added a simple debug console for the next person needing to do something in the Automated Analysis page. I can't wait for the IE based WebView (used by default by the SWT Browser component on Windows) to die a well deserved death...
> 
> Seeing as how some of the web views don't do anything when using IE, maybe we should force Edge or display a warning if IE is detected? I think "SWT.EDGE" can be passed as the style parameter when creating the browser object, maybe we could have a quick check for OS and default browser and set Edge accordingly. Or have a basic HTML display if using IE instructing users how to switch over to Edge.

Sounds like a good idea. Please open a ticket! :)

-------------

PR Comment: https://git.openjdk.org/jmc/pull/639#issuecomment-2821658004

From hirt at openjdk.org  Tue Apr 22 15:16:48 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 22 Apr 2025 15:16:48 GMT
Subject: Integrated: 8380: Support dark mode in graphs
In-Reply-To: <3-KqzhW4mOWnrVZJAKBRxbTZGI190FzmxdV3ABsH6Ko=.7015bf59-3f18-4879-aba7-bb7eeb47aa1e@github.com>
References: <3-KqzhW4mOWnrVZJAKBRxbTZGI190FzmxdV3ABsH6Ko=.7015bf59-3f18-4879-aba7-bb7eeb47aa1e@github.com>
Message-ID: <KuYiqo9cecWZEBzK9DAIhhrDNt7xiL7cesnZRttzq9s=.841da07a-2ae0-4281-94f7-dd76f1227e3d@github.com>

On Thu, 17 Apr 2025 21:46:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also added dark mode support in the Automated Analysis page, and fixed wrong version in a few properties files along the way. 
> 
> Added a simple debug console for the next person needing to do something in the Automated Analysis page. I can't wait for the IE based WebView (used by default by the SWT Browser component on Windows) to die a well deserved death...

This pull request has now been integrated.

Changeset: fb4fb067
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/fb4fb0670fb67df05f0856c0957fd0d91b79f044
Stats:     386 lines in 19 files changed: 333 ins; 4 del; 49 mod

8380: Support dark mode in graphs

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/639

From egahlin at openjdk.org  Wed Apr 23 08:10:52 2025
From: egahlin at openjdk.org (Erik Gahlin)
Date: Wed, 23 Apr 2025 08:10:52 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames [v2]
In-Reply-To: <zwZUXIU-_LWmwHZlqjzKBXnPHxnDTlRNiNUz3OX2in0=.df89bdb5-7077-4139-b64b-180596284375@github.com>
References: <M5DHZ4xosLSMZnPb7jpkjqChkRXMPVXboyGCSZm3aPM=.31fcc88e-afe2-432e-bf2a-1781b202c886@github.com>
 <zwZUXIU-_LWmwHZlqjzKBXnPHxnDTlRNiNUz3OX2in0=.df89bdb5-7077-4139-b64b-180596284375@github.com>
Message-ID: <eG4MN8EkpVbwMGhos5y_X7UsNibOC-oKun1ZWgCGO0Q=.01695bbb-e513-4531-9e35-e435dbae664d@github.com>

On Fri, 11 Apr 2025 10:51:28 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> JFR tool is hiding all the hidden frames. But in JMC, Stacktrace view is still showing lot of hidden methods which is not required from the users point of view. Hence, we will be hiding all the hidden frames as part of this enhancement.
>> 
>> Also, we have updated some test cases also in order to get rid of hidden frames which were expected by the test cases.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed ArrayList and replaced FOR-loop implementation with Streams

Using stream() instead of new ArrayList doesn't change much.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/632#issuecomment-2823426130

From hirt at openjdk.org  Wed Apr 23 16:50:40 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 23 Apr 2025 16:50:40 GMT
Subject: RFR: 8289: Remove security manager related code [v2]
In-Reply-To: <Spp80SCq5XA15An52c0ZsHjejGj6-y8qC5tDeaZe8oA=.a85862b1-7e15-4a59-a539-0ae1a994e9f4@github.com>
References: <Spp80SCq5XA15An52c0ZsHjejGj6-y8qC5tDeaZe8oA=.a85862b1-7e15-4a59-a539-0ae1a994e9f4@github.com>
Message-ID: <3ZzLrO0ZpVULw2d2VWRAylId-XOQkJwq3wI5nbeuJkE=.d8749c0c-c9ad-4de8-aa0e-6097acd04b67@github.com>

> Also fixing a deprecation.

Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch '8289-remove-security-manager' of https://github.com/thegreystone/jmc into 8289-remove-security-manager
 - Removing permission class
 - 8289: Removing security manager related code
 - Removing permission class
 - 8289: Removing security manager related code

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/640/files
  - new: https://git.openjdk.org/jmc/pull/640/files/0d702097..05be8787

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=640&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=640&range=00-01

  Stats: 1265 lines in 51 files changed: 962 ins; 143 del; 160 mod
  Patch: https://git.openjdk.org/jmc/pull/640.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/640/head:pull/640

PR: https://git.openjdk.org/jmc/pull/640

From hdafgard at openjdk.org  Wed Apr 23 17:00:55 2025
From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Wed, 23 Apr 2025 17:00:55 GMT
Subject: RFR: 8289: Remove security manager related code [v2]
In-Reply-To: <3ZzLrO0ZpVULw2d2VWRAylId-XOQkJwq3wI5nbeuJkE=.d8749c0c-c9ad-4de8-aa0e-6097acd04b67@github.com>
References: <Spp80SCq5XA15An52c0ZsHjejGj6-y8qC5tDeaZe8oA=.a85862b1-7e15-4a59-a539-0ae1a994e9f4@github.com>
 <3ZzLrO0ZpVULw2d2VWRAylId-XOQkJwq3wI5nbeuJkE=.d8749c0c-c9ad-4de8-aa0e-6097acd04b67@github.com>
Message-ID: <HMFKhLw639_CqlUXEjzEYMiehVOHT7vvTHzx0KP3BeE=.06159d08-bd17-425c-80e2-0bc56bad4d6c@github.com>

On Wed, 23 Apr 2025 16:50:40 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also fixing a deprecation.
>
> Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch '8289-remove-security-manager' of https://github.com/thegreystone/jmc into 8289-remove-security-manager
>  - Removing permission class
>  - 8289: Removing security manager related code
>  - Removing permission class
>  - 8289: Removing security manager related code

TBQH this seems like 3-4 different PRs worth of changes, but if it's too much of a hassle to cherry pick them that might be ok. But we should fix the warnings before merging.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/overview/ResultReportUi.java line 261:

> 259: 			DisplayToolkit.safeAsyncExec(() -> {
> 260: 				try {
> 261: 					browser.execute(String.format("overview.setTheme(%b);", ThemeUtils.isDarkTheme()));

Missing non-nls comment here

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/overview/ResultReportUi.java line 486:

> 484: 					browser.execute(String.format("overview.showOk(%b);", showOk)); //$NON-NLS-1$
> 485: 					browser.execute(String.format("overview.showIgnore(%b);", showIgnore)); //$NON-NLS-1$
> 486: 					browser.execute(String.format("overview.setTheme(%b);", isDarkTheme));

and here

core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/html/internal/RulesHtmlToolkit.java line 159:

> 157: 
> 158: 	private static String getHtmlTemplate(boolean isDarkTheme) {
> 159: 		String themeClass = isDarkTheme ? " class=\"dark-theme\"" : " class=\"light-theme\"";

and here

-------------

PR Review: https://git.openjdk.org/jmc/pull/640#pullrequestreview-2788093151
PR Review Comment: https://git.openjdk.org/jmc/pull/640#discussion_r2056501139
PR Review Comment: https://git.openjdk.org/jmc/pull/640#discussion_r2056500557
PR Review Comment: https://git.openjdk.org/jmc/pull/640#discussion_r2056507206

From hirt at openjdk.org  Wed Apr 23 17:52:47 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 23 Apr 2025 17:52:47 GMT
Subject: Withdrawn: 8289: Remove security manager related code
In-Reply-To: <Spp80SCq5XA15An52c0ZsHjejGj6-y8qC5tDeaZe8oA=.a85862b1-7e15-4a59-a539-0ae1a994e9f4@github.com>
References: <Spp80SCq5XA15An52c0ZsHjejGj6-y8qC5tDeaZe8oA=.a85862b1-7e15-4a59-a539-0ae1a994e9f4@github.com>
Message-ID: <3VdV-Okzv-3m-IQsvXOyh8y3I9H5A-mBANvgEd47UUA=.17789692-bbf3-4925-929d-dc7959aeae67@github.com>

On Thu, 17 Apr 2025 22:29:43 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also fixing a deprecation.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jmc/pull/640

From hirt at openjdk.org  Wed Apr 23 17:57:57 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 23 Apr 2025 17:57:57 GMT
Subject: RFR: 8289: Remove security manager related code
Message-ID: <_HXKfS656UiGK8FO6u05InNZUlTZIImgt7eNkVbqdlU=.be160d3a-79ee-460d-b2bf-0f34a8f37594@github.com>

Cherry picked my changes into a new branch.

-------------

Commit messages:
 - Removing permission class
 - 8289: Removing security manager related code

Changes: https://git.openjdk.org/jmc/pull/642/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=642&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8289
  Stats: 93 lines in 4 files changed: 0 ins; 90 del; 3 mod
  Patch: https://git.openjdk.org/jmc/pull/642.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/642/head:pull/642

PR: https://git.openjdk.org/jmc/pull/642

From hirt at openjdk.org  Wed Apr 23 23:56:37 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 23 Apr 2025 23:56:37 GMT
Subject: RFR: 8289: Remove security manager related code [v2]
In-Reply-To: <_HXKfS656UiGK8FO6u05InNZUlTZIImgt7eNkVbqdlU=.be160d3a-79ee-460d-b2bf-0f34a8f37594@github.com>
References: <_HXKfS656UiGK8FO6u05InNZUlTZIImgt7eNkVbqdlU=.be160d3a-79ee-460d-b2bf-0f34a8f37594@github.com>
Message-ID: <pLFrUfoaWP3B_86didr9XDKnyyge6qjjXTO5fK5fsRE=.d477593e-8adc-472b-bf6f-75f7b1ce3137@github.com>

> Cherry picked my changes into a new branch.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Fixing unused imports

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/642/files
  - new: https://git.openjdk.org/jmc/pull/642/files/0d4eed70..b299ee38

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=642&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=642&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/642.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/642/head:pull/642

PR: https://git.openjdk.org/jmc/pull/642

From aptmac at openjdk.org  Thu Apr 24 14:29:49 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 24 Apr 2025 14:29:49 GMT
Subject: RFR: 8289: Remove security manager related code [v2]
In-Reply-To: <pLFrUfoaWP3B_86didr9XDKnyyge6qjjXTO5fK5fsRE=.d477593e-8adc-472b-bf6f-75f7b1ce3137@github.com>
References: <_HXKfS656UiGK8FO6u05InNZUlTZIImgt7eNkVbqdlU=.be160d3a-79ee-460d-b2bf-0f34a8f37594@github.com>
 <pLFrUfoaWP3B_86didr9XDKnyyge6qjjXTO5fK5fsRE=.d477593e-8adc-472b-bf6f-75f7b1ce3137@github.com>
Message-ID: <pYCqb-D89yOsj10OWV_1g1ugsf_BcouJ58_qZHZSu_4=.c589dfd5-5a6d-44cf-b4db-42835e4620fe@github.com>

On Wed, 23 Apr 2025 23:56:37 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Cherry picked my changes into a new branch.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing unused imports

Looks okay to me, just needs a `mvn spotlesss:apply` run to clean up the checkstyle warnings

-------------

PR Review: https://git.openjdk.org/jmc/pull/642#pullrequestreview-2791429249

From hirt at openjdk.org  Thu Apr 24 17:19:51 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 24 Apr 2025 17:19:51 GMT
Subject: RFR: 8289: Remove security manager related code [v3]
In-Reply-To: <_HXKfS656UiGK8FO6u05InNZUlTZIImgt7eNkVbqdlU=.be160d3a-79ee-460d-b2bf-0f34a8f37594@github.com>
References: <_HXKfS656UiGK8FO6u05InNZUlTZIImgt7eNkVbqdlU=.be160d3a-79ee-460d-b2bf-0f34a8f37594@github.com>
Message-ID: <URTwaz5uQcYj2iWJYsMsy4-iFeatL96L7pxvoU3I41c=.96893d9e-4a5a-4cec-88ff-2c2a93a7af24@github.com>

> Cherry picked my changes into a new branch.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Spotless

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/642/files
  - new: https://git.openjdk.org/jmc/pull/642/files/b299ee38..9a4ee1a4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=642&range=02
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=642&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/642.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/642/head:pull/642

PR: https://git.openjdk.org/jmc/pull/642

From aptmac at openjdk.org  Thu Apr 24 17:59:55 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 24 Apr 2025 17:59:55 GMT
Subject: RFR: 8289: Remove security manager related code [v3]
In-Reply-To: <URTwaz5uQcYj2iWJYsMsy4-iFeatL96L7pxvoU3I41c=.96893d9e-4a5a-4cec-88ff-2c2a93a7af24@github.com>
References: <_HXKfS656UiGK8FO6u05InNZUlTZIImgt7eNkVbqdlU=.be160d3a-79ee-460d-b2bf-0f34a8f37594@github.com>
 <URTwaz5uQcYj2iWJYsMsy4-iFeatL96L7pxvoU3I41c=.96893d9e-4a5a-4cec-88ff-2c2a93a7af24@github.com>
Message-ID: <tKjFLDK0L5RGmz99A39AEcbbrKUplC5AaVIm1Owcbhs=.d3b71a53-21d8-4d98-9406-41cb80c1d4d0@github.com>

On Thu, 24 Apr 2025 17:19:51 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Cherry picked my changes into a new branch.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Spotless

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/642#pullrequestreview-2792049437

From hirt at openjdk.org  Thu Apr 24 17:59:55 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 24 Apr 2025 17:59:55 GMT
Subject: Integrated: 8289: Remove security manager related code
In-Reply-To: <_HXKfS656UiGK8FO6u05InNZUlTZIImgt7eNkVbqdlU=.be160d3a-79ee-460d-b2bf-0f34a8f37594@github.com>
References: <_HXKfS656UiGK8FO6u05InNZUlTZIImgt7eNkVbqdlU=.be160d3a-79ee-460d-b2bf-0f34a8f37594@github.com>
Message-ID: <JVb-PML9s1n7hobgfQttGyXC2MlXkz9VleRmnFyFZxY=.8835d1b5-7783-47f4-bdc7-17570c6ec6ac@github.com>

On Wed, 23 Apr 2025 17:55:00 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Cherry picked my changes into a new branch.

This pull request has now been integrated.

Changeset: bf8342e1
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/bf8342e1b77497c900b5fd923c0b95f529b0548e
Stats:     94 lines in 4 files changed: 0 ins; 92 del; 2 mod

8289: Remove security manager related code

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/642

From hirt at openjdk.org  Thu Apr 24 18:56:18 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 24 Apr 2025 18:56:18 GMT
Subject: RFR: 8390: Wrong target platform name
Message-ID: <_SzxIzXBQSFzPywLJOEow3y7k4TOh5du9wqnCDN-Rgo=.d1043b40-a044-435b-8551-917c14debc55@github.com>

The 2025-03 target platform has the wrong name.

-------------

Commit messages:
 - 8390: Wrong target platform name in 2025-03

Changes: https://git.openjdk.org/jmc/pull/643/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=643&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8390
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/643.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/643/head:pull/643

PR: https://git.openjdk.org/jmc/pull/643

From aptmac at openjdk.org  Thu Apr 24 19:38:50 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 24 Apr 2025 19:38:50 GMT
Subject: RFR: 8390: Wrong target platform name
In-Reply-To: <_SzxIzXBQSFzPywLJOEow3y7k4TOh5du9wqnCDN-Rgo=.d1043b40-a044-435b-8551-917c14debc55@github.com>
References: <_SzxIzXBQSFzPywLJOEow3y7k4TOh5du9wqnCDN-Rgo=.d1043b40-a044-435b-8551-917c14debc55@github.com>
Message-ID: <OXjFSM6xWbZmcjo0o1Gd0Vio1jmzA2PgrBHtUs8KeZw=.5a1422e0-dc61-4559-8e35-2c5ca7d3b02f@github.com>

On Thu, 24 Apr 2025 18:38:44 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> The 2025-03 target platform has the wrong name.

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/643#pullrequestreview-2792294721

From hirt at openjdk.org  Thu Apr 24 21:29:52 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 24 Apr 2025 21:29:52 GMT
Subject: Integrated: 8390: Wrong target platform name
In-Reply-To: <_SzxIzXBQSFzPywLJOEow3y7k4TOh5du9wqnCDN-Rgo=.d1043b40-a044-435b-8551-917c14debc55@github.com>
References: <_SzxIzXBQSFzPywLJOEow3y7k4TOh5du9wqnCDN-Rgo=.d1043b40-a044-435b-8551-917c14debc55@github.com>
Message-ID: <sl0eCOv9GjFWrNhRpD3MmS7uvkMJ9grfc8zuVtMG5Cc=.b32d9a48-c116-40ad-b8da-55db382e5dce@github.com>

On Thu, 24 Apr 2025 18:38:44 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> The 2025-03 target platform has the wrong name.

This pull request has now been integrated.

Changeset: c20efe31
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/c20efe311cbf65c3b25b426a32fd2aa4ae435984
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8390: Wrong target platform name

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/643

From hirt at openjdk.org  Thu Apr 24 23:29:11 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 24 Apr 2025 23:29:11 GMT
Subject: RFR: 8391: Dark theme support for dials
Message-ID: <qvt9V5ukzp3QW7SC_bh0Vf9URlccQgRsa8Jwc467JqA=.9a49a1cb-d7fd-4dbe-af95-f2c11d464303@github.com>

Dark mode for the JMC console dials.

![image](https://github.com/user-attachments/assets/869020a3-b714-4672-918b-07bccbf5c72e)

-------------

Commit messages:
 - 8391: Dark mode for JMC dials

Changes: https://git.openjdk.org/jmc/pull/644/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=644&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8391
  Stats: 87 lines in 11 files changed: 72 ins; 1 del; 14 mod
  Patch: https://git.openjdk.org/jmc/pull/644.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/644/head:pull/644

PR: https://git.openjdk.org/jmc/pull/644

From aptmac at openjdk.org  Fri Apr 25 14:20:01 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 25 Apr 2025 14:20:01 GMT
Subject: RFR: 8391: Dark theme support for dials
In-Reply-To: <qvt9V5ukzp3QW7SC_bh0Vf9URlccQgRsa8Jwc467JqA=.9a49a1cb-d7fd-4dbe-af95-f2c11d464303@github.com>
References: <qvt9V5ukzp3QW7SC_bh0Vf9URlccQgRsa8Jwc467JqA=.9a49a1cb-d7fd-4dbe-af95-f2c11d464303@github.com>
Message-ID: <-c5EicThaZNkkx5cWs_igVLtV4ne5epvRb2RjRfEGl8=.9cd9a344-127b-45f8-8459-3e9a0c71f18f@github.com>

On Thu, 24 Apr 2025 23:22:32 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Dark mode for the JMC console dials.
> 
> ![image](https://github.com/user-attachments/assets/869020a3-b714-4672-918b-07bccbf5c72e)

application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/dial/Dial.java line 70:

> 68: 	 *            the dial configuration to use
> 69: 	 */
> 70: 	public Dial(Composite parent, FormToolkit formToolkit, DialConfiguration dialConfiguration) {

Looking at the usage of the Dial and DialViewer constructors, should the old ones be removed? I don't see them being used anywhere

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/644#discussion_r2060334112

From bdutheil at openjdk.org  Fri Apr 25 16:43:55 2025
From: bdutheil at openjdk.org (Brice Dutheil)
Date: Fri, 25 Apr 2025 16:43:55 GMT
Subject: RFR: 8391: Dark theme support for dials
In-Reply-To: <qvt9V5ukzp3QW7SC_bh0Vf9URlccQgRsa8Jwc467JqA=.9a49a1cb-d7fd-4dbe-af95-f2c11d464303@github.com>
References: <qvt9V5ukzp3QW7SC_bh0Vf9URlccQgRsa8Jwc467JqA=.9a49a1cb-d7fd-4dbe-af95-f2c11d464303@github.com>
Message-ID: <TD98CIXXO4XrnurgR4jM2GMFFuC1Cxir6-W6AYY1jK0=.0abb4706-fc1c-4507-87dc-1f84e8228221@github.com>

On Thu, 24 Apr 2025 23:22:32 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Dark mode for the JMC console dials.
> 
> ![image](https://github.com/user-attachments/assets/869020a3-b714-4672-918b-07bccbf5c72e)

I believe this is OK, I don't have a strong opinion on the constructor

-------------

Marked as reviewed by bdutheil (Committer).

PR Review: https://git.openjdk.org/jmc/pull/644#pullrequestreview-2794715408

From bdutheil at openjdk.org  Fri Apr 25 16:47:53 2025
From: bdutheil at openjdk.org (Brice Dutheil)
Date: Fri, 25 Apr 2025 16:47:53 GMT
Subject: RFR: 8385: Upgrade hashing algorithm
In-Reply-To: <MzYZu9QbK6VUFUgDHTjhZmqiwqr6CvgPOATLupIO1yY=.6e8d60c3-8a22-401d-b4d7-9a53180b45b4@github.com>
References: <MzYZu9QbK6VUFUgDHTjhZmqiwqr6CvgPOATLupIO1yY=.6e8d60c3-8a22-401d-b4d7-9a53180b45b4@github.com>
Message-ID: <2uKj5HitnFi0ZTtBnbzuqkepffw_bs_PS3RZjGYH8yU=.18d9f29d-b44f-4d92-b955-725ebe7004db@github.com>

On Mon, 21 Apr 2025 10:18:49 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Upgrading hashing algorithm as part of this PR.

I lack context on this, but what about older HmacSHA1 backward compat.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/641#issuecomment-2830910925

From hirt at openjdk.org  Fri Apr 25 18:00:04 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 25 Apr 2025 18:00:04 GMT
Subject: Integrated: 8391: Dark theme support for dials
In-Reply-To: <qvt9V5ukzp3QW7SC_bh0Vf9URlccQgRsa8Jwc467JqA=.9a49a1cb-d7fd-4dbe-af95-f2c11d464303@github.com>
References: <qvt9V5ukzp3QW7SC_bh0Vf9URlccQgRsa8Jwc467JqA=.9a49a1cb-d7fd-4dbe-af95-f2c11d464303@github.com>
Message-ID: <iMNzAkvcHlldb0YRSNpTSB_ndSt5bnSCI7BReACyt64=.12ec23b7-2c2e-49da-b851-49b477765626@github.com>

On Thu, 24 Apr 2025 23:22:32 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Dark mode for the JMC console dials.
> 
> ![image](https://github.com/user-attachments/assets/869020a3-b714-4672-918b-07bccbf5c72e)

This pull request has now been integrated.

Changeset: 612df4b1
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/612df4b11eb65bd6e1666c6e774dc6c9c7bed60b
Stats:     87 lines in 11 files changed: 72 ins; 1 del; 14 mod

8391: Dark theme support for dials

Reviewed-by: bdutheil

-------------

PR: https://git.openjdk.org/jmc/pull/644