RFR: 8373: Fix tooltip on Flamegraph not showing after switching to Stack Trace view
Hélios GILLES
duke at openjdk.org
Wed Apr 2 15:51:08 UTC 2025
On Wed, 2 Apr 2025 14:52:16 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:
> At first glance the changes looks good to me!
> About the scenario, is it just moving the mouse from the flamegraph to the click on the stack trace tab. Also, is there an a specific OS where this is happening ?
>
Yes just click on the stack trace on Windows (didn't try on linux or macos).
> application/org.openjdk.jmc.flightrecorder.flamegraph/src/main/java/org/openjdk/jmc/flightrecorder/flamegraph/views/FlamegraphSwingView.java line 497:
>
>> 495: tooltip.setShift(new Point(10, 5));
>> 496:
>> 497: embeddingComposite.addListener(SWT.MouseExit, event -> Display.getDefault().timerExec(300, tooltip::hide));
>
> **question:** I wonder if this listener is still needed, in case the mouse event is not received on the swing component. E.g. in weird situations like : Alt Tab (on macOs) to change app but in the end selecting back to JMC. Not sure it's a real scenario, but i could imagine the Swing component not properly receiving mouse events.
Without the listener i still have the bug.
-------------
PR Comment: https://git.openjdk.org/jmc/pull/635#issuecomment-2773013863
PR Review Comment: https://git.openjdk.org/jmc/pull/635#discussion_r2025125750
More information about the jmc-dev
mailing list