RFR: 8370: HDR Histogram View [v2]

Alex Macdonald aptmac at openjdk.org
Tue Apr 8 14:22:24 UTC 2025


On Tue, 1 Apr 2025 23:24:52 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Adds a Histogram view that will work on any selected events (that have durations). Useful for looking at distributions of, for example, GC or Lock events, or for any events that have durations in the Event Browser. 
>> 
>> ![image](https://github.com/user-attachments/assets/97e7d3a5-9be8-455f-bf1f-fc0e846ebb40)
>> 
>> Events in any percentile can be selected in the percentiles table and used to set the active selection in the selection store.
>> ![image](https://github.com/user-attachments/assets/69fecbb6-6368-461b-af83-4605548e2513)
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Spotbugs potential null dereference

LGTM, it would be nice to have some sort of empty state or message that pops up if there aren't any duration events to display, the UI has a bunch of unexplained whitespace if there isn't anything to show

![Screenshot from 2025-04-08 10-15-24](https://github.com/user-attachments/assets/b19b0af7-c41e-4491-88e7-2e4cdf9c8188)

-------------

Marked as reviewed by aptmac (Reviewer).

PR Review: https://git.openjdk.org/jmc/pull/636#pullrequestreview-2750177317


More information about the jmc-dev mailing list