RFR: 8380: Support dark mode in graphs [v2]
Alex Macdonald
aptmac at openjdk.org
Tue Apr 22 14:31:48 UTC 2025
On Thu, 17 Apr 2025 21:55:16 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> Also added dark mode support in the Automated Analysis page, and fixed wrong version in a few properties files along the way.
>>
>> Added a simple debug console for the next person needing to do something in the Automated Analysis page. I can't wait for the IE based WebView (used by default by the SWT Browser component on Windows) to die a well deserved death...
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>
> Import fix
> Added a simple debug console for the next person needing to do something in the Automated Analysis page. I can't wait for the IE based WebView (used by default by the SWT Browser component on Windows) to die a well deserved death...
Seeing as how some of the web views don't do anything when using IE, maybe we should force Edge or display a warning if IE is detected? I think "SWT.EDGE" can be passed as the style parameter when creating the browser object, maybe we could have a quick check for OS and default browser and set Edge accordingly. Or have a basic HTML display if using IE instructing users how to switch over to Edge.
-------------
PR Comment: https://git.openjdk.org/jmc/pull/639#issuecomment-2821525234
More information about the jmc-dev
mailing list