RFR: 8289: Remove security manager related code [v2]

[Henrik Dafgård]

On Wed, 23 Apr 2025 16:50:40 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also fixing a deprecation.
>
> Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch '8289-remove-security-manager' of https://github.com/thegreystone/jmc into 8289-remove-security-manager
>  - Removing permission class
>  - 8289: Removing security manager related code
>  - Removing permission class
>  - 8289: Removing security manager related code

TBQH this seems like 3-4 different PRs worth of changes, but if it's too much of a hassle to cherry pick them that might be ok. But we should fix the warnings before merging.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/overview/ResultReportUi.java line 261:

> 259: 			DisplayToolkit.safeAsyncExec(() -> {
> 260: 				try {
> 261: 					browser.execute(String.format("overview.setTheme(%b);", ThemeUtils.isDarkTheme()));

Missing non-nls comment here

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/overview/ResultReportUi.java line 486:

> 484: 					browser.execute(String.format("overview.showOk(%b);", showOk)); //$NON-NLS-1$
> 485: 					browser.execute(String.format("overview.showIgnore(%b);", showIgnore)); //$NON-NLS-1$
> 486: 					browser.execute(String.format("overview.setTheme(%b);", isDarkTheme));

and here

core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/html/internal/RulesHtmlToolkit.java line 159:

> 157: 
> 158: 	private static String getHtmlTemplate(boolean isDarkTheme) {
> 159: 		String themeClass = isDarkTheme ? " class=\"dark-theme\"" : " class=\"light-theme\"";

and here

-------------

PR Review: https://git.openjdk.org/jmc/pull/640#pullrequestreview-2788093151
PR Review Comment: https://git.openjdk.org/jmc/pull/640#discussion_r2056501139
PR Review Comment: https://git.openjdk.org/jmc/pull/640#discussion_r2056500557
PR Review Comment: https://git.openjdk.org/jmc/pull/640#discussion_r2056507206