RFR: 8391: Dark theme support for dials

Alex Macdonald aptmac at openjdk.org
Fri Apr 25 14:20:01 UTC 2025


On Thu, 24 Apr 2025 23:22:32 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Dark mode for the JMC console dials.
> 
> ![image](https://github.com/user-attachments/assets/869020a3-b714-4672-918b-07bccbf5c72e)

application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/dial/Dial.java line 70:

> 68: 	 *            the dial configuration to use
> 69: 	 */
> 70: 	public Dial(Composite parent, FormToolkit formToolkit, DialConfiguration dialConfiguration) {

Looking at the usage of the Dial and DialViewer constructors, should the old ones be removed? I don't see them being used anywhere

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/644#discussion_r2060334112


More information about the jmc-dev mailing list