From duke at openjdk.org Mon Aug 4 18:41:31 2025 From: duke at openjdk.org (Huang Xiao) Date: Mon, 4 Aug 2025 18:41:31 GMT Subject: RFR: 8406: Chinese Rule strings are out of date Message-ID: Originally reported in [https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147](https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147). The corresponding synchronization has been performed based on "[https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties](https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties)", but the source file "messages.properties" also contains cases where parameters have not been replaced. This may require your attention. ![image](https://github.com/user-attachments/assets/238e991f-99b4-48df-bd4c-43db71a22f30) Additionally, I have found that there exist other documents that are in dire need of translation as well, and I would follow up by suggesting that these things could be handled with some AI tools. ------------- Commit messages: - Update L10N translation for JMC. Changes: https://git.openjdk.org/jmc/pull/662/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=662&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8406 Stats: 679 lines in 1 file changed: 150 ins; 2 del; 527 mod Patch: https://git.openjdk.org/jmc/pull/662.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/662/head:pull/662 PR: https://git.openjdk.org/jmc/pull/662 From aptmac at openjdk.org Mon Aug 4 18:41:32 2025 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 4 Aug 2025 18:41:32 GMT Subject: RFR: 8406: Chinese Rule strings are out of date In-Reply-To: References: Message-ID: <6ScvFiQ7HRsIKkP2UvJZ4HwvzWDhQ3cWL8KCA_BS9sk=.ac2a4a50-ddc3-409d-b6ce-1f616e5665f1@github.com> On Tue, 8 Jul 2025 01:55:39 GMT, Huang Xiao wrote: > Originally reported in [https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147](https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147). > > The corresponding synchronization has been performed based on "[https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties](https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties)", but the source file "messages.properties" also contains cases where parameters have not been replaced. This may require your attention. > > ![image](https://github.com/user-attachments/assets/238e991f-99b4-48df-bd4c-43db71a22f30) > > Additionally, I have found that there exist other documents that are in dire need of translation as well, and I would follow up by suggesting that these things could be handled with some AI tools. @youngledo Thanks for the PR! Just a couple of housekeeping items: - I had opened a ticket for this issue (https://bugs.openjdk.org/browse/JMC-8406), if you could change the title of this PR to "8406: Chinese Rule strings are out of date" it will satisfy one of the jcheck requirements - Contributing to JMC requires completion of the Oracle Contributor Agreement, please follow the instructions listed in this automatic comment from the openjdk bot: https://github.com/openjdk/jmc/pull/662#issuecomment-3047095278 ------------- PR Comment: https://git.openjdk.org/jmc/pull/662#issuecomment-3049067483 From duke at openjdk.org Wed Aug 6 02:33:10 2025 From: duke at openjdk.org (Huang Xiao) Date: Wed, 6 Aug 2025 02:33:10 GMT Subject: RFR: 8406: Chinese Rule strings are out of date In-Reply-To: <6ScvFiQ7HRsIKkP2UvJZ4HwvzWDhQ3cWL8KCA_BS9sk=.ac2a4a50-ddc3-409d-b6ce-1f616e5665f1@github.com> References: <6ScvFiQ7HRsIKkP2UvJZ4HwvzWDhQ3cWL8KCA_BS9sk=.ac2a4a50-ddc3-409d-b6ce-1f616e5665f1@github.com> Message-ID: <6dejvCr84JVe2s5bWYLKko0eBOuLI5k0lGN7dZTEfzU=.09f95282-f79d-427f-aa66-f2562e4a2ab7@github.com> On Tue, 8 Jul 2025 13:54:19 GMT, Alex Macdonald wrote: >> Originally reported in [https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147](https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147). >> >> The corresponding synchronization has been performed based on "[https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties](https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties)", but the source file "messages.properties" also contains cases where parameters have not been replaced. This may require your attention. >> >> ![image](https://github.com/user-attachments/assets/238e991f-99b4-48df-bd4c-43db71a22f30) >> >> Additionally, I have found that there exist other documents that are in dire need of translation as well, and I would follow up by suggesting that these things could be handled with some AI tools. > > @youngledo Thanks for the PR! Just a couple of housekeeping items: > > - I had opened a ticket for this issue (https://bugs.openjdk.org/browse/JMC-8406), if you could change the title of this PR to "8406: Chinese Rule strings are out of date" it will satisfy one of the jcheck requirements > > - Contributing to JMC requires completion of the Oracle Contributor Agreement, please follow the instructions listed in this automatic comment from the openjdk bot: https://github.com/openjdk/jmc/pull/662#issuecomment-3047095278 Hi @aptmac , just checking in to see if there's anything else needed for this PR. Thanks! ------------- PR Comment: https://git.openjdk.org/jmc/pull/662#issuecomment-3157206875 From thomas.stuefe at gmail.com Fri Aug 15 05:24:08 2025 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Fri, 15 Aug 2025 07:24:08 +0200 Subject: Question about Event Filters from multiple Event Types Message-ID: Hi, one JMC question: One feature I use very often in JMC is building graphs on the fly from my event filters. This means I can expose any metric from the JVM and see it immediately as a graph; I don't need JMC developers to change JMC for me. Even better, I can select several metrics and display them in one graph. But the latter functionality is stunted because it only works as long as the metrics are from the same Event. So, for example, I can create a filter from "jdk.G1HeapSummary" and build myself a nice view of the different G1 generation sizes. But I cannot correlate that e.g., with Metrics from "jdk.MetaspaceSummary" and "jdk.ResidentSetSize" to display class space size, heap generation sizes, and RSS in the same graph (when I try to do this - build up a filter from multiple event types - the "Show In Line Chart" Sub menu is empty). Is there a way to select metrics from different Events into a chart that I don't see? I have a similar problem with the Table view of Events in Event Filters that are formed from multiple Event Types. It only shows the set of fields present in all events, so it is an inner join. I would like to see an outer join - show me all fields from all events, and leave those fields blank that don't match a given event type. Is that possible? Am I doing something wrong? Thank you! Thomas -------------- next part -------------- An HTML attachment was scrubbed... URL: From aptmac at openjdk.org Wed Aug 20 11:09:49 2025 From: aptmac at openjdk.org (Alex Macdonald) Date: Wed, 20 Aug 2025 11:09:49 GMT Subject: RFR: 8406: Chinese Rule strings are out of date In-Reply-To: References: Message-ID: On Tue, 8 Jul 2025 01:55:39 GMT, Huang Xiao wrote: > Originally reported in [https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147](https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147). > > The corresponding synchronization has been performed based on "[https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties](https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties)", but the source file "messages.properties" also contains cases where parameters have not been replaced. This may require your attention. > > ![image](https://github.com/user-attachments/assets/238e991f-99b4-48df-bd4c-43db71a22f30) > > Additionally, I have found that there exist other documents that are in dire need of translation as well, and I would follow up by suggesting that these things could be handled with some AI tools. Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/662#pullrequestreview-3136052614 From aptmac at openjdk.org Wed Aug 20 11:09:49 2025 From: aptmac at openjdk.org (Alex Macdonald) Date: Wed, 20 Aug 2025 11:09:49 GMT Subject: RFR: 8406: Chinese Rule strings are out of date In-Reply-To: <6ScvFiQ7HRsIKkP2UvJZ4HwvzWDhQ3cWL8KCA_BS9sk=.ac2a4a50-ddc3-409d-b6ce-1f616e5665f1@github.com> References: <6ScvFiQ7HRsIKkP2UvJZ4HwvzWDhQ3cWL8KCA_BS9sk=.ac2a4a50-ddc3-409d-b6ce-1f616e5665f1@github.com> Message-ID: On Tue, 8 Jul 2025 13:54:19 GMT, Alex Macdonald wrote: >> Originally reported in [https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147](https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147). >> >> The corresponding synchronization has been performed based on "[https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties](https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties)", but the source file "messages.properties" also contains cases where parameters have not been replaced. This may require your attention. >> >> ![image](https://github.com/user-attachments/assets/238e991f-99b4-48df-bd4c-43db71a22f30) >> >> Additionally, I have found that there exist other documents that are in dire need of translation as well, and I would follow up by suggesting that these things could be handled with some AI tools. > > @youngledo Thanks for the PR! Just a couple of housekeeping items: > > - I had opened a ticket for this issue (https://bugs.openjdk.org/browse/JMC-8406), if you could change the title of this PR to "8406: Chinese Rule strings are out of date" it will satisfy one of the jcheck requirements > > - Contributing to JMC requires completion of the Oracle Contributor Agreement, please follow the instructions listed in this automatic comment from the openjdk bot: https://github.com/openjdk/jmc/pull/662#issuecomment-3047095278 > Hi @aptmac , just checking in to see if there's anything else needed for this PR. Thanks! Sorry for the delay here, I was out of office for a bit. The PR looks good to me, and it's nice to see that the OCA went through. I forgot to mention previously, but if you could enable the GitHub actions on your fork then the testing workflow should run on this PR. See: https://wiki.openjdk.org/display/SKARA/Testing#Testing-Configuringworkflowstorun ------------- PR Comment: https://git.openjdk.org/jmc/pull/662#issuecomment-3205670897 From duke at openjdk.org Thu Aug 21 02:59:33 2025 From: duke at openjdk.org (Huang Xiao) Date: Thu, 21 Aug 2025 02:59:33 GMT Subject: RFR: 8406: Chinese Rule strings are out of date [v2] In-Reply-To: References: Message-ID: > Originally reported in [https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147](https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147). > > The corresponding synchronization has been performed based on "[https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties](https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties)", but the source file "messages.properties" also contains cases where parameters have not been replaced. This may require your attention. > > ![image](https://github.com/user-attachments/assets/238e991f-99b4-48df-bd4c-43db71a22f30) > > Additionally, I have found that there exist other documents that are in dire need of translation as well, and I would follow up by suggesting that these things could be handled with some AI tools. Huang Xiao has updated the pull request incrementally with one additional commit since the last revision: trigger CI ------------- Changes: - all: https://git.openjdk.org/jmc/pull/662/files - new: https://git.openjdk.org/jmc/pull/662/files/b47a912c..71b64ad4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=662&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=662&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/662.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/662/head:pull/662 PR: https://git.openjdk.org/jmc/pull/662 From aptmac at openjdk.org Thu Aug 21 13:07:58 2025 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 21 Aug 2025 13:07:58 GMT Subject: RFR: 8406: Chinese Rule strings are out of date [v2] In-Reply-To: References: Message-ID: On Thu, 21 Aug 2025 02:59:33 GMT, Huang Xiao wrote: >> Originally reported in [https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147](https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147). >> >> The corresponding synchronization has been performed based on "[https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties](https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties)", but the source file "messages.properties" also contains cases where parameters have not been replaced. This may require your attention. >> >> ![image](https://github.com/user-attachments/assets/238e991f-99b4-48df-bd4c-43db71a22f30) >> >> Additionally, I have found that there exist other documents that are in dire need of translation as well, and I would follow up by suggesting that these things could be handled with some AI tools. > > Huang Xiao has updated the pull request incrementally with one additional commit since the last revision: > > trigger CI Thanks for running the CI, it looks like there are some formatting failures at the moment. These failures are old, and were fixed in: https://github.com/openjdk/jmc/commit/87860cee6a54e2b8de1dcd29490513988d48521c If you rebase ontop of current HEAD then those errors should go away. ------------- PR Comment: https://git.openjdk.org/jmc/pull/662#issuecomment-3210527139 From duke at openjdk.org Tue Aug 26 03:41:49 2025 From: duke at openjdk.org (Huang Xiao) Date: Tue, 26 Aug 2025 03:41:49 GMT Subject: RFR: 8406: Chinese Rule strings are out of date [v3] In-Reply-To: References: Message-ID: > Originally reported in [https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147](https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147). > > The corresponding synchronization has been performed based on "[https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties](https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties)", but the source file "messages.properties" also contains cases where parameters have not been replaced. This may require your attention. > > ![image](https://github.com/user-attachments/assets/238e991f-99b4-48df-bd4c-43db71a22f30) > > Additionally, I have found that there exist other documents that are in dire need of translation as well, and I would follow up by suggesting that these things could be handled with some AI tools. Huang Xiao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into L10N - trigger CI - Update L10N translation for JMC. ------------- Changes: - all: https://git.openjdk.org/jmc/pull/662/files - new: https://git.openjdk.org/jmc/pull/662/files/71b64ad4..46bf609a Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=662&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=662&range=01-02 Stats: 2181940 lines in 223 files changed: 2180870 ins; 560 del; 510 mod Patch: https://git.openjdk.org/jmc/pull/662.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/662/head:pull/662 PR: https://git.openjdk.org/jmc/pull/662 From aptmac at openjdk.org Tue Aug 26 13:06:47 2025 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 26 Aug 2025 13:06:47 GMT Subject: RFR: 8406: Chinese Rule strings are out of date In-Reply-To: <6dejvCr84JVe2s5bWYLKko0eBOuLI5k0lGN7dZTEfzU=.09f95282-f79d-427f-aa66-f2562e4a2ab7@github.com> References: <6ScvFiQ7HRsIKkP2UvJZ4HwvzWDhQ3cWL8KCA_BS9sk=.ac2a4a50-ddc3-409d-b6ce-1f616e5665f1@github.com> <6dejvCr84JVe2s5bWYLKko0eBOuLI5k0lGN7dZTEfzU=.09f95282-f79d-427f-aa66-f2562e4a2ab7@github.com> Message-ID: On Wed, 6 Aug 2025 02:30:35 GMT, Huang Xiao wrote: >> @youngledo Thanks for the PR! Just a couple of housekeeping items: >> >> - I had opened a ticket for this issue (https://bugs.openjdk.org/browse/JMC-8406), if you could change the title of this PR to "8406: Chinese Rule strings are out of date" it will satisfy one of the jcheck requirements >> >> - Contributing to JMC requires completion of the Oracle Contributor Agreement, please follow the instructions listed in this automatic comment from the openjdk bot: https://github.com/openjdk/jmc/pull/662#issuecomment-3047095278 > > Hi @aptmac , just checking in to see if there's anything else needed for this PR. Thanks! @youngledo Great, looks like it's all working now. The bot added the instructions here: https://github.com/openjdk/jmc/pull/662#issuecomment-3047096405 You'll have to type `/integrate` and then the PR should be ready for sponsoring afterwards. ------------- PR Comment: https://git.openjdk.org/jmc/pull/662#issuecomment-3224095536 From duke at openjdk.org Wed Aug 27 01:19:48 2025 From: duke at openjdk.org (duke) Date: Wed, 27 Aug 2025 01:19:48 GMT Subject: RFR: 8406: Chinese Rule strings are out of date [v3] In-Reply-To: References: Message-ID: On Tue, 26 Aug 2025 03:41:49 GMT, Huang Xiao wrote: >> Originally reported in [https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147](https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147). >> >> The corresponding synchronization has been performed based on "[https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties](https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties)", but the source file "messages.properties" also contains cases where parameters have not been replaced. This may require your attention. >> >> ![image](https://github.com/user-attachments/assets/238e991f-99b4-48df-bd4c-43db71a22f30) >> >> Additionally, I have found that there exist other documents that are in dire need of translation as well, and I would follow up by suggesting that these things could be handled with some AI tools. > > Huang Xiao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into L10N > - trigger CI > - Update L10N translation for JMC. @youngledo Your change (at version 46bf609ae23dc4e826a1d54e4f97d9cdbf64c9ad) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jmc/pull/662#issuecomment-3226366594 From duke at openjdk.org Wed Aug 27 02:22:50 2025 From: duke at openjdk.org (Huang Xiao) Date: Wed, 27 Aug 2025 02:22:50 GMT Subject: Integrated: 8406: Chinese Rule strings are out of date In-Reply-To: References: Message-ID: On Tue, 8 Jul 2025 01:55:39 GMT, Huang Xiao wrote: > Originally reported in [https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147](https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147). > > The corresponding synchronization has been performed based on "[https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties](https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties)", but the source file "messages.properties" also contains cases where parameters have not been replaced. This may require your attention. > > ![image](https://github.com/user-attachments/assets/238e991f-99b4-48df-bd4c-43db71a22f30) > > Additionally, I have found that there exist other documents that are in dire need of translation as well, and I would follow up by suggesting that these things could be handled with some AI tools. This pull request has now been integrated. Changeset: b120bc4c Author: Huang Xiao Committer: Alex Macdonald URL: https://git.openjdk.org/jmc/commit/b120bc4c54d11c2dd6160dfb5f3e76638c68efc7 Stats: 679 lines in 1 file changed: 150 ins; 2 del; 527 mod 8406: Chinese Rule strings are out of date Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/662 From duke at openjdk.org Wed Aug 27 14:03:00 2025 From: duke at openjdk.org (Martin Skarsaune) Date: Wed, 27 Aug 2025 14:03:00 GMT Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility 3rd party artefact In-Reply-To: References: Message-ID: <1QRS1e6dthI0effmMHF0QQzIvTrthY0ddtDoUagw-VI=.9054b6bd-3752-4b3f-be5c-c5a8d61c0846@github.com> On Tue, 29 Jul 2025 15:35:46 GMT, Virag Purnam wrote: > Hi @skarsaune, this plugin needs to be added to all target platforms as well under local p2 repository. @viragpurnam : Hmm, this is a test requirement, only needed by a test plugin. So it should not be shipped as part of the product. If it works like this it is fine, if not we have to look at some other mechanism. ------------- PR Comment: https://git.openjdk.org/jmc/pull/668#issuecomment-3228338922 From duke at openjdk.org Wed Aug 27 14:10:51 2025 From: duke at openjdk.org (Martin Skarsaune) Date: Wed, 27 Aug 2025 14:10:51 GMT Subject: RFR: 8365: Jolokia - Additional support for security mechanisms related to SSL / authentication, discovery restrictions [v3] In-Reply-To: References: Message-ID: <0cTmBd6n3RD7X1MKU5Jswj6tRs_pyvsmYC2--8zlGEA=.ad12923b-756a-414e-a65e-974ef57916cd@github.com> On Tue, 29 Jul 2025 11:21:02 GMT, Martin Skarsaune wrote: >> Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https. > > Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: > > JMC-8365: Make secure button updating null safe Is this perhaps something you might have a look at @aptmac ? ------------- PR Comment: https://git.openjdk.org/jmc/pull/665#issuecomment-3228365609 From hirt at openjdk.org Wed Aug 27 20:17:56 2025 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 27 Aug 2025 20:17:56 GMT Subject: RFR: 6203: Add ZGC allocation stall rule [v3] In-Reply-To: References: Message-ID: On Sat, 19 Jul 2025 08:12:25 GMT, Suchita Chaturvedi wrote: >> This enhancement is to add new rule for ZGC Allocation Stall events. >> >> The default configuration: >> >> image >> >> Here are few screenshots for reference: >> >> image >> >> image >> >> image >> >> image >> >> image >> >> Ignored >> >> image >> >> If we change default configuration as below: >> >> image >> >> image >> >> image >> >> image > > Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: > > - Resolving merge conflict > - Updated the rule as per new metric allocation stall rate > - 6203: Add ZGC allocation stall rule Changes requested by hirt (Lead). core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/ZGCAllocationStallRule.java line 2: > 1: /* > 2: * Copyright (c) 2020, 2025, Oracle and/or its affiliates. All rights reserved. New file - only 2025. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/ZGCAllocationStallRule.java line 139: > 137: > 138: //Calculate time after JVM Start > 139: IQuantity timeAfterJVMStart = RulesToolkit.getEarliestStartTime(items) Come to think of it - this will not work well for OldObjectSample events. They are a bit special and may be timestamped far earlier than the current recording period. I think we might want to add a RulesToolkit function that explicitly avoid the OldObjectSample events for this... core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 756: > 754: ZGCAllocationStall_RULE_NAME=ZGC Allocation Stall Rate > 755: ZgcAllocationStall_TEXT_INFO=In ZGC, a type of concurrent Garbage Collection (GC) algorithm, GC threads run concurrently with application threads, resulting in minimal stop-the-world pauses. However application threads can overrun the GC threads, allocating objects faster than GC threads can reclaim memory. in such cases, the JVM temporarily stops allocating application threads. This is called "Allocation Stall".\n Allocation Stalls occurs due to the following reasons:\n 1. High Object Allocation Rate: if your application creates objects at a very high rate, it can overwhelm the GC's ability to reclaim memory quickly enough, leading to stalls\n 2. Java Heap size is not sufficient: Having more free room in the heap can give more time for GC threads to perform their GC cycle and reclaim memory to satisfy new allocations happening concurrently.\n 3. Insufficient resources available for the GC threads: number of GC threads or the CPU allocated for them is not enough to finish the GC cycle and reclaim the memory compared to allocations done by application threads.\n > 756: ZgcAllocationStall_TEXT_WARN=\nThere are {zgcAllocationStallCount} occurrence of Allocation Stall Events. Total time spent in waiting for memory to become available is {zgcAllocationStallTotalDuration} and the maximum duration is {zgcAllocationStallLongestDuration}. The rate of allocation stall per minute is {zgcAllocationStallPerMinute}. Perhaps simplify this - "There are {zgcAllocationStallCount} Allocation Stall events" Also, "Stall time rate per minute is {zgcAllocationStallPerMinute}" core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 759: > 757: ZgcAllocationStall_TEXT_OK=There are no occurrence of Allocation Stall Events. > 758: ZGCAllocationStallRule_CONFIG_INFO_LIMIT=ZGC Allocation Stall Rate info limit > 759: ZGCAllocationStallRule_CONFIG_INFO_LIMIT_LONG=The rate of ZGC Allocation Stall events needed to trigger an info notice The ZGC allocation stall time per minute needed to trigger an info notice core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 761: > 759: ZGCAllocationStallRule_CONFIG_INFO_LIMIT_LONG=The rate of ZGC Allocation Stall events needed to trigger an info notice > 760: ZGCAllocationStallRule_CONFIG_WARN_LIMIT=ZGC Allocation Stall Rate warning limit > 761: ZGCAllocationStallRule_CONFIG_WARN_LIMIT_LONG=The rate of ZGC Allocation Stall events needed to trigger a warning The ZGC allocation stall time per minute needed to trigger a warning core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 762: > 760: ZGCAllocationStallRule_CONFIG_WARN_LIMIT=ZGC Allocation Stall Rate warning limit > 761: ZGCAllocationStallRule_CONFIG_WARN_LIMIT_LONG=The rate of ZGC Allocation Stall events needed to trigger a warning > 762: ZGCAllocationStallRule_RATE=Allocation Stall per minute Perhaps "Allocation stall time per minute". core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties line 472: > 470: AGGR_ALL_COLLECTION_GC_COUNT_DESC=The count of GC for all garbage collection. > 471: AGGR_ZGC_ALLOCATION_STALL_COUNT=ZGC Allocation Stall Count > 472: AGGR_ZGC_ALLOCATION_STALL_COUNT_DESC=The count of ZGC Allocation Stall. The number of ZGC allocation stalls ------------- PR Review: https://git.openjdk.org/jmc/pull/664#pullrequestreview-3161556961 PR Review Comment: https://git.openjdk.org/jmc/pull/664#discussion_r2305180306 PR Review Comment: https://git.openjdk.org/jmc/pull/664#discussion_r2305194969 PR Review Comment: https://git.openjdk.org/jmc/pull/664#discussion_r2305159468 PR Review Comment: https://git.openjdk.org/jmc/pull/664#discussion_r2305165104 PR Review Comment: https://git.openjdk.org/jmc/pull/664#discussion_r2305163035 PR Review Comment: https://git.openjdk.org/jmc/pull/664#discussion_r2305161765 PR Review Comment: https://git.openjdk.org/jmc/pull/664#discussion_r2305203704