RFR: 8406: Chinese Rule strings are out of date [v2]

Alex Macdonald aptmac at openjdk.org
Thu Aug 21 13:07:58 UTC 2025


On Thu, 21 Aug 2025 02:59:33 GMT, Huang Xiao <duke at openjdk.org> wrote:

>> Originally reported in [https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147](https://github.com/adoptium/jmc-build/issues/102#issuecomment-3017636147).
>> 
>> The corresponding synchronization has been performed based on "[https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties](https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties)", but the source file "messages.properties" also contains cases where parameters have not been replaced. This may require your attention.
>> 
>> ![image](https://github.com/user-attachments/assets/238e991f-99b4-48df-bd4c-43db71a22f30)
>> 
>> Additionally, I have found that there exist other documents that are in dire need of translation as well, and I would follow up by suggesting that these things could be handled with some AI tools.
>
> Huang Xiao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   trigger CI

Thanks for running the CI, it looks like there are some formatting failures at the moment.

These failures are old, and were fixed in: https://github.com/openjdk/jmc/commit/87860cee6a54e2b8de1dcd29490513988d48521c

If you rebase ontop of current HEAD then those errors should go away.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/662#issuecomment-3210527139


More information about the jmc-dev mailing list