From aharmaz at openjdk.org  Tue Dec  2 15:48:26 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Tue, 2 Dec 2025 15:48:26 GMT
Subject: Integrated: 8335: Duplicate values in tooltip for RSS and RSS (Peak)
 in memory tab
In-Reply-To: <JXskYDGb2Rz7V7jKfhF3cP9TJBb5F2zez7AGkaA3MOA=.a65d86c5-19e0-4293-81f2-81991022190b@github.com>
References: <JXskYDGb2Rz7V7jKfhF3cP9TJBb5F2zez7AGkaA3MOA=.a65d86c5-19e0-4293-81f2-81991022190b@github.com>
Message-ID: <_W4e8n4DVZpxJvQt9iUR05c7J2hU7arHe71dbMQ7snI=.67d527e9-9788-42d6-8928-1a4e49917bb4@github.com>

On Wed, 12 Nov 2025 09:38:16 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR makes sure, we do not add attributes twice to the same renderer on the memory page
> 
> The issue : 
> - The supplier used for merging events was having a side effect (calls to methods adding attributes to the same renderer) 
> - The supplier was consumed twice leading to the side effect being executed twice and that is mainly what causes the tooltip to contain duplicated attributes on the memory page 
> 
> The following screenshots respectively show the tooltips before and after the change
> 
> <img width="1082" height="375" alt="tooltip-before" src="https://github.com/user-attachments/assets/824b883d-6941-4100-9d90-54bb4e184aaa" />
> 
> <img width="1308" height="277" alt="tooltip-fixed" src="https://github.com/user-attachments/assets/505cdcf3-1d70-4c6d-a195-325614e405d0" />

This pull request has now been integrated.

Changeset: 1e4c82b0
Author:    Aymane Harmaz <aharmaz at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/1e4c82b0c3b95b553d5af42052b56fba3c6163f0
Stats:     6 lines in 1 file changed: 4 ins; 1 del; 1 mod

8335: Duplicate values in tooltip for RSS and RSS (Peak) in memory tab

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.org/jmc/pull/685

From hirt at openjdk.org  Tue Dec  2 15:49:45 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 2 Dec 2025 15:49:45 GMT
Subject: RFR: 6004: Should add tenuring summary to the GC visualization
 [v2]
In-Reply-To: <ZjwWIY4cpzIrcP-q5_WSoSMhlYJzw1H4M0b6vAz2N38=.8d2b93fa-dc14-4a9b-8ed4-1616ffa19ac3@github.com>
References: <xJDBMcDqNzHZCxOBLHYoMxbd7OiV-YbT9RW5w01Ss94=.57626599-d845-4426-935d-63438bfb72a4@github.com>
 <ZjwWIY4cpzIrcP-q5_WSoSMhlYJzw1H4M0b6vAz2N38=.8d2b93fa-dc14-4a9b-8ed4-1616ffa19ac3@github.com>
Message-ID: <z4IPB_F6I-_WP0Tk0t3CiFj31mmvbwOhv0vsd9SnHg4=.661d19d7-b818-4383-a836-628a089fe773@github.com>

On Thu, 23 Oct 2025 14:35:54 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

>> This change adds a new tab to display the tenuring distribution for GC cycles.
>> 
>> There are 3 case scenarios:
>> - Single GC cycle selected: A histogram chart is shown representing the tenuring distribution (total size across ages) for the selected cycle.
>> - No GC cycle selected: An informational message is displayed to prompt the user to select a cycle.
>> - Multiple GC cycles selected: An informational message is displayed indicating that only a single cycle can be viewed at a time.
>> This enhancement improves visibility into object tenuring during individual GC cycles. 
>> 
>> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 19" src="https://github.com/user-attachments/assets/76ce69c2-60eb-48c8-be9f-6387cbfa7c42" />
>> 
>> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 34" src="https://github.com/user-attachments/assets/a5fc9bc9-fa72-42c9-aeb2-ecad21e4ac66" />
>> 
>> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 57" src="https://github.com/user-attachments/assets/63ffba47-8e08-430a-9a28-11473b59e6dc" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/679#pullrequestreview-3530851144

From hirt at openjdk.org  Tue Dec  2 15:51:00 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 2 Dec 2025 15:51:00 GMT
Subject: RFR: 8451: Should make the Event Type the first column of event
 types tree table
In-Reply-To: <Oq4DVq2qFBXMvBSJC2JICk4zR1j_2niB92wR8nCHm30=.cc75c06a-a8cd-4037-b286-f26137fd1a7d@github.com>
References: <Oq4DVq2qFBXMvBSJC2JICk4zR1j_2niB92wR8nCHm30=.cc75c06a-a8cd-4037-b286-f26137fd1a7d@github.com>
Message-ID: <jDATLRD-tZRqBoi6YRGJ3YFczZkmmxg_OZF4gHXB-5w=.a5c682cb-56e7-487b-96bb-c7b83586a5f5@github.com>

On Mon, 27 Oct 2025 12:08:21 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR made sure to display the event type column as the first column in the table related to event types tree view to make it easier for the user to identify the event type of the rows he will be looking at when multiple event types are selected.

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/681#pullrequestreview-3530856397

From aharmaz at openjdk.org  Tue Dec  2 15:52:15 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Tue, 2 Dec 2025 15:52:15 GMT
Subject: Integrated: 8470: Unresolved placeholders shown in JFR result
 overview's table mode
In-Reply-To: <c7zl7XGwAV724GtPPo9Nnj-sxiZI5qcLs4fD5BCd-4E=.9d8cc377-745e-4c71-b255-6a0b3b2a4aa9@github.com>
References: <c7zl7XGwAV724GtPPo9Nnj-sxiZI5qcLs4fD5BCd-4E=.9d8cc377-745e-4c71-b255-6a0b3b2a4aa9@github.com>
Message-ID: <GEIp4GecAEGytbiZWKOegr-ga97lWpMzG8KfTLMXPF4=.fe1f436b-4b6d-499d-8289-92833da01691@github.com>

On Mon, 10 Nov 2025 08:51:46 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR populates the summary, explanation, and solution fields of a rule displayed in the result overview table with the actual evaluated values.
> 
> The following screenshots show the state before and after the change.
> 
> <img width="1106" height="220" alt="unmapped-placeholders" src="https://github.com/user-attachments/assets/af4faee4-4e97-456a-b4a7-3e51fdc5e6a6" />
> 
> <img width="1085" height="206" alt="resolved placeholders" src="https://github.com/user-attachments/assets/3df6354a-39de-44c0-8a8d-5aa0e8687f0f" />

This pull request has now been integrated.

Changeset: 2c9ad544
Author:    Aymane Harmaz <aharmaz at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/2c9ad5444289980c083f00bfe50e147b14edd188
Stats:     4 lines in 1 file changed: 1 ins; 0 del; 3 mod

8470: Unresolved placeholders shown in JFR result overview's table mode

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.org/jmc/pull/684

From aharmaz at openjdk.org  Tue Dec  2 15:52:16 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Tue, 2 Dec 2025 15:52:16 GMT
Subject: Integrated: 8427: Text getting overlapped on graph of Processes screen
In-Reply-To: <Fp5vHlVBkRz7Pmx-99XASmwNY0uGTxnw8ZpRb9J1Df0=.ac28473b-d9c2-4e0b-bdb3-da15343c9460@github.com>
References: <Fp5vHlVBkRz7Pmx-99XASmwNY0uGTxnw8ZpRb9J1Df0=.ac28473b-d9c2-4e0b-bdb3-da15343c9460@github.com>
Message-ID: <h0bo9AxglbeAM7H8gnXKR2LUbVcJSuv44Lma3PJunQs=.2247b4b2-5e54-445c-b997-69d65b281183@github.com>

On Fri, 10 Oct 2025 16:09:39 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> When the width of the chart title label exceeds the left margin ( xOffset) reserved for it, the label is truncated without taking into account the width of the y-axis tick labels. This can potentially lead to overlapping between the chart title and the y-axis tick labels.
> 
> Currently, the width of the y-axis tick labels is determined at the formatter level and is not dynamically available during chart label truncation.
> 
> Two potential workarounds are :
> 
> - Increase the xOffset size for the affected chart, allocating enough space to display both the chart title and the tick labels without overlap.
> (This impacts only the chart in question.)
> - Base Chart title label truncation on a default value for y-axis tick labels, even without access to exact tick widths.
> (This impacts all charts.)
> 
> I followed the first strategy.
> 
> Screenshot of processes page post change : 
> 
> <img width="1173" height="343" alt="Screenshot 2025-10-10 at 17 02 40" src="https://github.com/user-attachments/assets/c490525f-b816-4bce-b242-621439ccf22e" />

This pull request has now been integrated.

Changeset: a7813947
Author:    Aymane Harmaz <aharmaz at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/a7813947a380af6e707a0ddcb5ef9b686e334b99
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8427: Text getting overlapped on graph of Processes screen

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/678

From duke at openjdk.org  Tue Dec  2 15:57:57 2025
From: duke at openjdk.org (viragpurnam123)
Date: Tue, 2 Dec 2025 15:57:57 GMT
Subject: RFR: 8474: Eclipse platform upgrade to 2025_09
Message-ID: <FkyoA99Z_5pQekKX56EeFVugfZQZ0QmRnTFQD126wRg=.16ae4828-40a4-4058-92bb-427a700c5358@github.com>

Upgraded Eclipse Traget Platform to 2025-09.
Upgraded Jetty version to 12.1.0 to keep the same jetty version as presnt in eclipse.

-------------

Commit messages:
 - Eclipse platform upgrade to 2025_09

Changes: https://git.openjdk.org/jmc/pull/687/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=687&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8474
  Stats: 407 lines in 11 files changed: 100 ins; 268 del; 39 mod
  Patch: https://git.openjdk.org/jmc/pull/687.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/687/head:pull/687

PR: https://git.openjdk.org/jmc/pull/687

From duke at openjdk.org  Tue Dec  2 15:57:57 2025
From: duke at openjdk.org (viragpurnam123)
Date: Tue, 2 Dec 2025 15:57:57 GMT
Subject: RFR: 8474: Eclipse platform upgrade to 2025_09
In-Reply-To: <FkyoA99Z_5pQekKX56EeFVugfZQZ0QmRnTFQD126wRg=.16ae4828-40a4-4058-92bb-427a700c5358@github.com>
References: <FkyoA99Z_5pQekKX56EeFVugfZQZ0QmRnTFQD126wRg=.16ae4828-40a4-4058-92bb-427a700c5358@github.com>
Message-ID: <DksbkUur1C75nGGQmnBfDOhgirecJl3KatxVBIwzvYg=.43812599-c611-49d5-b6d3-6d2205901156@github.com>

On Mon, 24 Nov 2025 14:28:10 GMT, viragpurnam123 <duke at openjdk.org> wrote:

> Upgraded Eclipse Traget Platform to 2025-09.
> Upgraded Jetty version to 12.1.0 to keep the same jetty version as presnt in eclipse.

Hi @thegreystone, Could you please create a JIRA issue as I do not have access. Thanks.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/687#issuecomment-3571100890

From hirt at openjdk.org  Tue Dec  2 15:57:58 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 2 Dec 2025 15:57:58 GMT
Subject: RFR: 8474: Eclipse platform upgrade to 2025_09
In-Reply-To: <FkyoA99Z_5pQekKX56EeFVugfZQZ0QmRnTFQD126wRg=.16ae4828-40a4-4058-92bb-427a700c5358@github.com>
References: <FkyoA99Z_5pQekKX56EeFVugfZQZ0QmRnTFQD126wRg=.16ae4828-40a4-4058-92bb-427a700c5358@github.com>
Message-ID: <KEKNHx4IB1PPtSAoOXIFk5cDz1wqweulWCR_pJ9gbQE=.b521f61c-0e87-4c12-9d62-1d8f7fb435b4@github.com>

On Mon, 24 Nov 2025 14:28:10 GMT, viragpurnam123 <duke at openjdk.org> wrote:

> Upgraded Eclipse Traget Platform to 2025-09.
> Upgraded Jetty version to 12.1.0 to keep the same jetty version as presnt in eclipse.

Done!

How come you do not have access to Jira? You are a jmc reviewer! You should contact @Suchitainf or someone other at Oracle to see how to re-establish access.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/687#issuecomment-3602738335
PR Comment: https://git.openjdk.org/jmc/pull/687#issuecomment-3602746305

From hirt at openjdk.org  Tue Dec  2 18:03:04 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 2 Dec 2025 18:03:04 GMT
Subject: RFR: 5561: Support for Crypto Events in JMC
In-Reply-To: <L3Wlpr7zk0rQE9qSVzkTehMZtHUwr141I2ZFjOF0060=.7ceacbf6-67d0-462d-a35e-7d135046ec42@github.com>
References: <L3Wlpr7zk0rQE9qSVzkTehMZtHUwr141I2ZFjOF0060=.7ceacbf6-67d0-462d-a35e-7d135046ec42@github.com>
Message-ID: <aw4KbJLS3mCifxk3ArClTtDTM77UPBDUdzNNrSVWFDk=.5ada4aea-3747-4345-8936-ef18b3900a91@github.com>

On Mon, 17 Nov 2025 10:44:40 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR enhances the JMC UI for adding new information related to crypto events: specifically X509CertificateEvent.
> 
> This PR adds a new rule with respect to X509CertificateEvent which provides alert related to expired/expiring certificates and weak signature algorithms or weak key length or key type. The rule gives a basic overview of all the certificate ids which needs action or attention, however complete details are provided as part of a new screen - Security.
> 
> Attaching the screenshots here for better reference:
> 
> Rule Page:
> 
> <img width="362" height="373" alt="image" src="https://github.com/user-attachments/assets/4707e6b2-76be-4b1e-9f32-c6139851d86c" />
> 
> Security Screen Page:
> 
> <img width="959" height="385" alt="image" src="https://github.com/user-attachments/assets/5026e2b7-2754-47bc-a42d-5672f9f087d7" />

Changes requested by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.ui/org.openjdk.jmc.flightrecorder.ui_contexts.xml line 151:

> 149:    <context id="security">
> 150:       <description></description>
> 151:       <topic href="PLUGINS_ROOT/org.openjdk.jmc.docs/html/GUID-4F885E48-A548-4140-B985-74B1685BEDEA.htm" label="Using the Security Page" />

This seems to link to the exact same page as Using the TLAB Allocations Page. Copy/Paste error?

-------------

PR Review: https://git.openjdk.org/jmc/pull/686#pullrequestreview-3531432535
PR Review Comment: https://git.openjdk.org/jmc/pull/686#discussion_r2582248094

From hirt at openjdk.org  Tue Dec  2 18:07:15 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 2 Dec 2025 18:07:15 GMT
Subject: RFR: 5561: Support for Crypto Events in JMC
In-Reply-To: <aw4KbJLS3mCifxk3ArClTtDTM77UPBDUdzNNrSVWFDk=.5ada4aea-3747-4345-8936-ef18b3900a91@github.com>
References: <L3Wlpr7zk0rQE9qSVzkTehMZtHUwr141I2ZFjOF0060=.7ceacbf6-67d0-462d-a35e-7d135046ec42@github.com>
 <aw4KbJLS3mCifxk3ArClTtDTM77UPBDUdzNNrSVWFDk=.5ada4aea-3747-4345-8936-ef18b3900a91@github.com>
Message-ID: <jZ8fDJdzeUXRPRe4AqVOkD6unbW398bUwgbHRWgNpPU=.d967cac4-1687-4353-9a3a-0088e7bfad92@github.com>

On Tue, 2 Dec 2025 17:53:55 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> This PR enhances the JMC UI for adding new information related to crypto events: specifically X509CertificateEvent.
>> 
>> This PR adds a new rule with respect to X509CertificateEvent which provides alert related to expired/expiring certificates and weak signature algorithms or weak key length or key type. The rule gives a basic overview of all the certificate ids which needs action or attention, however complete details are provided as part of a new screen - Security.
>> 
>> Attaching the screenshots here for better reference:
>> 
>> Rule Page:
>> 
>> <img width="362" height="373" alt="image" src="https://github.com/user-attachments/assets/4707e6b2-76be-4b1e-9f32-c6139851d86c" />
>> 
>> Security Screen Page:
>> 
>> <img width="959" height="385" alt="image" src="https://github.com/user-attachments/assets/5026e2b7-2754-47bc-a42d-5672f9f087d7" />
>
> application/org.openjdk.jmc.flightrecorder.ui/org.openjdk.jmc.flightrecorder.ui_contexts.xml line 151:
> 
>> 149:    <context id="security">
>> 150:       <description></description>
>> 151:       <topic href="PLUGINS_ROOT/org.openjdk.jmc.docs/html/GUID-4F885E48-A548-4140-B985-74B1685BEDEA.htm" label="Using the Security Page" />
> 
> This seems to link to the exact same page as Using the TLAB Allocations Page. Copy/Paste error?

Should perhaps the messages be more action oriented? 

* Certificate with id x expired t days ago. It should be replaced.
* Certificate with id y is using SHA-1. It should be updated to use SHA-256 or SHA-512.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/686#discussion_r2582282660

From hirt at openjdk.org  Tue Dec  2 18:13:20 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 2 Dec 2025 18:13:20 GMT
Subject: RFR: 8450: Improve usability of selectable action items by
 supporting keyboard and double-click interactions
In-Reply-To: <-Ek8pTmlYneSm3pS00SQtgVdoTe2IrnvEaXP9cWf8jE=.9fc2ebc1-aa75-4654-826d-b54bb76be3d1@github.com>
References: <-Ek8pTmlYneSm3pS00SQtgVdoTe2IrnvEaXP9cWf8jE=.9fc2ebc1-aa75-4654-826d-b54bb76be3d1@github.com>
Message-ID: <AOvAq1JYJp5DPCpRHnfArXqKXtEu0M6FQSg10TRSJxI=.6782a30b-9a58-4ae8-ba03-4299c8feca7c@github.com>

On Wed, 29 Oct 2025 14:21:03 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR adds more interaction capabilities to tree items and checkbox tables:
> 
> - Tree items: Added support for expanding/collapsing via double-click and Enter key press.
> - Checkbox table: Added support for enabling/disabling via Enter key press.

Nice!

-------------

Marked as reviewed by hirt (Lead).

PR Review: https://git.openjdk.org/jmc/pull/682#pullrequestreview-3531509228

From hirt at openjdk.org  Tue Dec  2 18:19:29 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 2 Dec 2025 18:19:29 GMT
Subject: RFR: 8474: Eclipse platform upgrade to 2025_09
In-Reply-To: <FkyoA99Z_5pQekKX56EeFVugfZQZ0QmRnTFQD126wRg=.16ae4828-40a4-4058-92bb-427a700c5358@github.com>
References: <FkyoA99Z_5pQekKX56EeFVugfZQZ0QmRnTFQD126wRg=.16ae4828-40a4-4058-92bb-427a700c5358@github.com>
Message-ID: <WTzuHicHyg2oAoetQC7qM4cJqbWb6d4kLKvC03GGrC4=.4372048d-d344-45c8-973b-4d25c71c1def@github.com>

On Mon, 24 Nov 2025 14:28:10 GMT, viragpurnam123 <duke at openjdk.org> wrote:

> Upgraded Eclipse Traget Platform to 2025-09.
> Upgraded Jetty version to 12.1.0 to keep the same jetty version as presnt in eclipse.

Marked as reviewed by hirt (Lead).

releng/platform-definitions/platform-definition-2025-09/platform-definition-2025-09.target line 4:

> 2: <!--
> 3:    Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
> 4:    Copyright (c) 2025, Datadog, Inc. All rights reserved.

A Datadog copyright is not required for individual contributions by contributors not working for Datadog ? only the Oracle one is required.

-------------

PR Review: https://git.openjdk.org/jmc/pull/687#pullrequestreview-3531529447
PR Review Comment: https://git.openjdk.org/jmc/pull/687#discussion_r2582319473

From schaturvedi at openjdk.org  Wed Dec  3 05:50:14 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Wed, 3 Dec 2025 05:50:14 GMT
Subject: RFR: 5561: Support for Crypto Events in JMC
In-Reply-To: <jZ8fDJdzeUXRPRe4AqVOkD6unbW398bUwgbHRWgNpPU=.d967cac4-1687-4353-9a3a-0088e7bfad92@github.com>
References: <L3Wlpr7zk0rQE9qSVzkTehMZtHUwr141I2ZFjOF0060=.7ceacbf6-67d0-462d-a35e-7d135046ec42@github.com>
 <aw4KbJLS3mCifxk3ArClTtDTM77UPBDUdzNNrSVWFDk=.5ada4aea-3747-4345-8936-ef18b3900a91@github.com>
 <jZ8fDJdzeUXRPRe4AqVOkD6unbW398bUwgbHRWgNpPU=.d967cac4-1687-4353-9a3a-0088e7bfad92@github.com>
Message-ID: <Ez5qBFwXF_0pOMOdutPuxCMdfyWcif-StHMa5xEgkZc=.c9b3c1b2-7b49-45fb-aa04-0ca65c6d0385@github.com>

On Tue, 2 Dec 2025 18:04:21 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> application/org.openjdk.jmc.flightrecorder.ui/org.openjdk.jmc.flightrecorder.ui_contexts.xml line 151:
>> 
>>> 149:    <context id="security">
>>> 150:       <description></description>
>>> 151:       <topic href="PLUGINS_ROOT/org.openjdk.jmc.docs/html/GUID-4F885E48-A548-4140-B985-74B1685BEDEA.htm" label="Using the Security Page" />
>> 
>> This seems to link to the exact same page as Using the TLAB Allocations Page. Copy/Paste error?
>
> Should perhaps the messages be more action oriented? 
> 
> * Certificate with id x expired t days ago. It should be replaced.
> * Certificate with id y is using SHA-1. It should be updated to use SHA-256 or SHA-512.

> This seems to link to the exact same page as Using the TLAB Allocations Page. Copy/Paste error?

Yes, I have added that link as placeholder for the respective html help page then forgot to update it. Is there any tool to generate the html help page or any other easy way? OR we need to write that completely from scratch.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/686#discussion_r2583710506

From aharmaz at openjdk.org  Wed Dec  3 07:52:14 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Wed, 3 Dec 2025 07:52:14 GMT
Subject: RFR: 8450: Improve usability of selectable action items by
 supporting keyboard and double-click interactions
In-Reply-To: <-Ek8pTmlYneSm3pS00SQtgVdoTe2IrnvEaXP9cWf8jE=.9fc2ebc1-aa75-4654-826d-b54bb76be3d1@github.com>
References: <-Ek8pTmlYneSm3pS00SQtgVdoTe2IrnvEaXP9cWf8jE=.9fc2ebc1-aa75-4654-826d-b54bb76be3d1@github.com>
Message-ID: <xny7HmdzqyNW1PKIhN37i24ydjQqWTr76t4Gv8veXvM=.f15d96dc-8a7d-4f03-9467-b5a4662f389b@github.com>

On Wed, 29 Oct 2025 14:21:03 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR adds more interaction capabilities to tree items and checkbox tables:
> 
> - Tree items: Added support for expanding/collapsing via double-click and Enter key press.
> - Checkbox table: Added support for enabling/disabling via Enter key press.

Thanks for the review

-------------

PR Comment: https://git.openjdk.org/jmc/pull/682#issuecomment-3605519858

From duke at openjdk.org  Wed Dec  3 07:52:14 2025
From: duke at openjdk.org (duke)
Date: Wed, 3 Dec 2025 07:52:14 GMT
Subject: RFR: 8450: Improve usability of selectable action items by
 supporting keyboard and double-click interactions
In-Reply-To: <-Ek8pTmlYneSm3pS00SQtgVdoTe2IrnvEaXP9cWf8jE=.9fc2ebc1-aa75-4654-826d-b54bb76be3d1@github.com>
References: <-Ek8pTmlYneSm3pS00SQtgVdoTe2IrnvEaXP9cWf8jE=.9fc2ebc1-aa75-4654-826d-b54bb76be3d1@github.com>
Message-ID: <AG_GgGEjc2HXOF_xMQNFt09UiviXnpsvPuKf8cA6AXg=.9c8a8068-80ae-4b36-b3af-3509db181a0b@github.com>

On Wed, 29 Oct 2025 14:21:03 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR adds more interaction capabilities to tree items and checkbox tables:
> 
> - Tree items: Added support for expanding/collapsing via double-click and Enter key press.
> - Checkbox table: Added support for enabling/disabling via Enter key press.

@aymane-harmaz 
Your change (at version bb29cd5f82e9815141dff3654648e49f64fcf148) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/682#issuecomment-3605521357

From aharmaz at openjdk.org  Wed Dec  3 07:53:16 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Wed, 3 Dec 2025 07:53:16 GMT
Subject: RFR: 6004: Should add tenuring summary to the GC visualization
 [v2]
In-Reply-To: <ZjwWIY4cpzIrcP-q5_WSoSMhlYJzw1H4M0b6vAz2N38=.8d2b93fa-dc14-4a9b-8ed4-1616ffa19ac3@github.com>
References: <xJDBMcDqNzHZCxOBLHYoMxbd7OiV-YbT9RW5w01Ss94=.57626599-d845-4426-935d-63438bfb72a4@github.com>
 <ZjwWIY4cpzIrcP-q5_WSoSMhlYJzw1H4M0b6vAz2N38=.8d2b93fa-dc14-4a9b-8ed4-1616ffa19ac3@github.com>
Message-ID: <tnHWGISvz0CdYPi2bMWxo1chQhtio0q56XDDomHtoWo=.16b2d2cd-6336-4e3f-a27e-eb1cc786f463@github.com>

On Thu, 23 Oct 2025 14:35:54 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

>> This change adds a new tab to display the tenuring distribution for GC cycles.
>> 
>> There are 3 case scenarios:
>> - Single GC cycle selected: A histogram chart is shown representing the tenuring distribution (total size across ages) for the selected cycle.
>> - No GC cycle selected: An informational message is displayed to prompt the user to select a cycle.
>> - Multiple GC cycles selected: An informational message is displayed indicating that only a single cycle can be viewed at a time.
>> This enhancement improves visibility into object tenuring during individual GC cycles. 
>> 
>> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 19" src="https://github.com/user-attachments/assets/76ce69c2-60eb-48c8-be9f-6387cbfa7c42" />
>> 
>> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 34" src="https://github.com/user-attachments/assets/a5fc9bc9-fa72-42c9-aeb2-ecad21e4ac66" />
>> 
>> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 57" src="https://github.com/user-attachments/assets/63ffba47-8e08-430a-9a28-11473b59e6dc" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments

Thanks for the reviews

-------------

PR Comment: https://git.openjdk.org/jmc/pull/679#issuecomment-3605518675

From duke at openjdk.org  Wed Dec  3 07:53:16 2025
From: duke at openjdk.org (duke)
Date: Wed, 3 Dec 2025 07:53:16 GMT
Subject: RFR: 8451: Should make the Event Type the first column of event
 types tree table
In-Reply-To: <Oq4DVq2qFBXMvBSJC2JICk4zR1j_2niB92wR8nCHm30=.cc75c06a-a8cd-4037-b286-f26137fd1a7d@github.com>
References: <Oq4DVq2qFBXMvBSJC2JICk4zR1j_2niB92wR8nCHm30=.cc75c06a-a8cd-4037-b286-f26137fd1a7d@github.com>
Message-ID: <_4Z1KRwk9EpowXp9z44xdFGSzt6xQR6afxY9GCROUz0=.15ab4bc5-09ef-4232-accf-5de8439cb35a@github.com>

On Mon, 27 Oct 2025 12:08:21 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR made sure to display the event type column as the first column in the table related to event types tree view to make it easier for the user to identify the event type of the rows he will be looking at when multiple event types are selected.

@aymane-harmaz 
Your change (at version 0ad27c309b798ad8ec89e70f6993e80cda2974ab) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/681#issuecomment-3605522080

From aharmaz at openjdk.org  Wed Dec  3 07:53:16 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Wed, 3 Dec 2025 07:53:16 GMT
Subject: RFR: 8451: Should make the Event Type the first column of event
 types tree table
In-Reply-To: <Oq4DVq2qFBXMvBSJC2JICk4zR1j_2niB92wR8nCHm30=.cc75c06a-a8cd-4037-b286-f26137fd1a7d@github.com>
References: <Oq4DVq2qFBXMvBSJC2JICk4zR1j_2niB92wR8nCHm30=.cc75c06a-a8cd-4037-b286-f26137fd1a7d@github.com>
Message-ID: <6gzl_d8NADcZXP3py9-BIOorW1-9VidN-rw6ASIOsCI=.e60c2bc0-0b2d-42b6-bd4d-c7b3481f7d4e@github.com>

On Mon, 27 Oct 2025 12:08:21 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR made sure to display the event type column as the first column in the table related to event types tree view to make it easier for the user to identify the event type of the rows he will be looking at when multiple event types are selected.

Thanks for the review

-------------

PR Comment: https://git.openjdk.org/jmc/pull/681#issuecomment-3605516516

From duke at openjdk.org  Wed Dec  3 07:53:17 2025
From: duke at openjdk.org (duke)
Date: Wed, 3 Dec 2025 07:53:17 GMT
Subject: RFR: 6004: Should add tenuring summary to the GC visualization
 [v2]
In-Reply-To: <ZjwWIY4cpzIrcP-q5_WSoSMhlYJzw1H4M0b6vAz2N38=.8d2b93fa-dc14-4a9b-8ed4-1616ffa19ac3@github.com>
References: <xJDBMcDqNzHZCxOBLHYoMxbd7OiV-YbT9RW5w01Ss94=.57626599-d845-4426-935d-63438bfb72a4@github.com>
 <ZjwWIY4cpzIrcP-q5_WSoSMhlYJzw1H4M0b6vAz2N38=.8d2b93fa-dc14-4a9b-8ed4-1616ffa19ac3@github.com>
Message-ID: <utPBkQ0ML18uRUBB_LegAOpmzMjYmygNSbSL8oN61Gc=.626c06c5-81d2-430c-a687-d2bd31de725b@github.com>

On Thu, 23 Oct 2025 14:35:54 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

>> This change adds a new tab to display the tenuring distribution for GC cycles.
>> 
>> There are 3 case scenarios:
>> - Single GC cycle selected: A histogram chart is shown representing the tenuring distribution (total size across ages) for the selected cycle.
>> - No GC cycle selected: An informational message is displayed to prompt the user to select a cycle.
>> - Multiple GC cycles selected: An informational message is displayed indicating that only a single cycle can be viewed at a time.
>> This enhancement improves visibility into object tenuring during individual GC cycles. 
>> 
>> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 19" src="https://github.com/user-attachments/assets/76ce69c2-60eb-48c8-be9f-6387cbfa7c42" />
>> 
>> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 34" src="https://github.com/user-attachments/assets/a5fc9bc9-fa72-42c9-aeb2-ecad21e4ac66" />
>> 
>> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 57" src="https://github.com/user-attachments/assets/63ffba47-8e08-430a-9a28-11473b59e6dc" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments

@aymane-harmaz 
Your change (at version 18eeb4afafb1b8875056141fe76a322713d3fb9b) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/679#issuecomment-3605521751

From jbachorik at openjdk.org  Wed Dec  3 10:23:46 2025
From: jbachorik at openjdk.org (Jaroslav Bachorik)
Date: Wed, 3 Dec 2025 10:23:46 GMT
Subject: RFR: 8475: Writing events with fields not explicitly set can corrupt
 the recording
Message-ID: <pu1GsrnjX-UVUD6Pr_SumH9KEe2bXbKMtNEjW8YWuEo=.79e00cb5-3b0f-4d3b-bd92-cba42bf8429d@github.com>

## Summary
Fixes an issue where events written with builtin type fields that are not explicitly set could cause field misalignment during JFR recording parsing, leading to corrupted field values.

## Problem
When writing JFR events using the Writer API without explicitly setting values for builtin type fields (byte, char, short, int, long, float, double, boolean, string), the previous implementation in `Chunk.writeBuiltinType()` would skip writing null builtin values (except for strings). This caused field alignment issues during parsing, where subsequent field values would be read at incorrect offsets.

## Solution
Modified `Chunk.writeBuiltinType()` (lines 88-150) to write appropriate default values for null builtin types instead of skipping them:
- Numeric types (byte, char, short, int, long, float, double): Write `0`
- Boolean: Write `false`  
- String: Continue to write null encoding (existing behavior)

Additionally enhanced `TypedValueImpl.getDefaultImplicitFieldValue()` to provide `System.nanoTime()` as default for `@Timestamp` annotated fields in event types, ensuring valid monotonic timestamps.

## Testing
Added comprehensive test `ImplicitEventFieldsTest.eventWithAllBuiltinFieldsUnset()` that:
- Creates an event with all 9 builtin type fields
- Writes the event without setting any builtin field values
- Includes a final field with an explicit value (99999L) to verify alignment
- Verifies all default values are correct and the explicit field reads back correctly

All 277 existing tests pass with the changes.

## Files Changed
- `Chunk.java`: Fixed builtin type serialization to write defaults instead of skipping
- `TypedValueImpl.java`: Enhanced default value handling for timestamp fields
- `ImplicitEventFieldsTest.java`: Added comprehensive test for builtin defaults
- `Type.java`, `TypedValueBuilder.java`: Enhanced documentation

Fixes #8475

? Generated with [Claude Code](https://claude.com/claude-code)

-------------

Commit messages:
 - 8475: Writing events with fields not explicitly set can corrupt the recording

Changes: https://git.openjdk.org/jmc/pull/690/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=690&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8475
  Stats: 420 lines in 5 files changed: 406 ins; 4 del; 10 mod
  Patch: https://git.openjdk.org/jmc/pull/690.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/690/head:pull/690

PR: https://git.openjdk.org/jmc/pull/690

From aharmaz at openjdk.org  Wed Dec  3 12:17:48 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Wed, 3 Dec 2025 12:17:48 GMT
Subject: Integrated: 8451: Should make the Event Type the first column of event
 types tree table
In-Reply-To: <Oq4DVq2qFBXMvBSJC2JICk4zR1j_2niB92wR8nCHm30=.cc75c06a-a8cd-4037-b286-f26137fd1a7d@github.com>
References: <Oq4DVq2qFBXMvBSJC2JICk4zR1j_2niB92wR8nCHm30=.cc75c06a-a8cd-4037-b286-f26137fd1a7d@github.com>
Message-ID: <x5d7QenDc9gzER1UlIx2tXyaYau2i66Cs_RmAJTVQ1Y=.2dd8bcf0-815b-48b2-8e07-11b0c9611795@github.com>

On Mon, 27 Oct 2025 12:08:21 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR made sure to display the event type column as the first column in the table related to event types tree view to make it easier for the user to identify the event type of the rows he will be looking at when multiple event types are selected.

This pull request has now been integrated.

Changeset: e8302745
Author:    Aymane Harmaz <aharmaz at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/e8302745d255be376e55a66616d493b4732c2b61
Stats:     6 lines in 2 files changed: 1 ins; 1 del; 4 mod

8451: Should make the Event Type the first column of event types tree table

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/681

From aharmaz at openjdk.org  Wed Dec  3 12:17:52 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Wed, 3 Dec 2025 12:17:52 GMT
Subject: Integrated: 6004: Should add tenuring summary to the GC visualization
In-Reply-To: <xJDBMcDqNzHZCxOBLHYoMxbd7OiV-YbT9RW5w01Ss94=.57626599-d845-4426-935d-63438bfb72a4@github.com>
References: <xJDBMcDqNzHZCxOBLHYoMxbd7OiV-YbT9RW5w01Ss94=.57626599-d845-4426-935d-63438bfb72a4@github.com>
Message-ID: <jtviL7xPx7qC4vuobFHFYm-R7t8Pggmx1c8_8GGjZKs=.4f4c2950-c971-480c-9582-d05d72c11bc8@github.com>

On Fri, 17 Oct 2025 15:39:33 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This change adds a new tab to display the tenuring distribution for GC cycles.
> 
> There are 3 case scenarios:
> - Single GC cycle selected: A histogram chart is shown representing the tenuring distribution (total size across ages) for the selected cycle.
> - No GC cycle selected: An informational message is displayed to prompt the user to select a cycle.
> - Multiple GC cycles selected: An informational message is displayed indicating that only a single cycle can be viewed at a time.
> This enhancement improves visibility into object tenuring during individual GC cycles. 
> 
> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 19" src="https://github.com/user-attachments/assets/76ce69c2-60eb-48c8-be9f-6387cbfa7c42" />
> 
> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 34" src="https://github.com/user-attachments/assets/a5fc9bc9-fa72-42c9-aeb2-ecad21e4ac66" />
> 
> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 57" src="https://github.com/user-attachments/assets/63ffba47-8e08-430a-9a28-11473b59e6dc" />

This pull request has now been integrated.

Changeset: 589b4b09
Author:    Aymane Harmaz <aharmaz at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/589b4b097847cf2576e483efaf72bfba3d69aa21
Stats:     107 lines in 10 files changed: 107 ins; 0 del; 0 mod

6004: Should add tenuring summary to the GC visualization

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/679

From hirt at openjdk.org  Wed Dec  3 12:33:29 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 3 Dec 2025 12:33:29 GMT
Subject: RFR: 8469: Should make rules and page heading accessible through
 keyboard in JFR overview page
In-Reply-To: <nrSc_wDUvgMPzFmKmPfmINq7-chpVBOvPBM0-lMAyQI=.32fbeb18-3c21-408c-9583-e9be1144efcc@github.com>
References: <nrSc_wDUvgMPzFmKmPfmINq7-chpVBOvPBM0-lMAyQI=.32fbeb18-3c21-408c-9583-e9be1144efcc@github.com>
Message-ID: <g8FMUGPpCnwLkPEFgR6PnfMrmyd5VVD1q1nodPCYVgI=.3476fbae-e987-4518-8467-d60c8601a2a1@github.com>

On Fri, 7 Nov 2025 13:59:20 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR makes it possible to reach JFR result pages and expand / collapse rule text on the JFR result overview using keyboard enter and tab keys.
> 
> <img width="1067" height="480" alt="focused-rule" src="https://github.com/user-attachments/assets/df38672e-4882-420a-8e45-f7f3f33349cd" />
> 
> <img width="1067" height="480" alt="expanded-rule-using-enter-key" src="https://github.com/user-attachments/assets/ec45e75b-48f6-424b-a8e7-7bc5b34bae0e" />

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/683#pullrequestreview-3534825668

From aharmaz at openjdk.org  Wed Dec  3 12:33:31 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Wed, 3 Dec 2025 12:33:31 GMT
Subject: Integrated: 8450: Improve usability of selectable action items by
 supporting keyboard and double-click interactions
In-Reply-To: <-Ek8pTmlYneSm3pS00SQtgVdoTe2IrnvEaXP9cWf8jE=.9fc2ebc1-aa75-4654-826d-b54bb76be3d1@github.com>
References: <-Ek8pTmlYneSm3pS00SQtgVdoTe2IrnvEaXP9cWf8jE=.9fc2ebc1-aa75-4654-826d-b54bb76be3d1@github.com>
Message-ID: <H_1JrpIkE2s3N1gtBJELBNSuNscnLnbn87N48PLb3xc=.686bdcf8-6bd3-49b0-91ce-e09eed755ce1@github.com>

On Wed, 29 Oct 2025 14:21:03 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR adds more interaction capabilities to tree items and checkbox tables:
> 
> - Tree items: Added support for expanding/collapsing via double-click and Enter key press.
> - Checkbox table: Added support for enabling/disabling via Enter key press.

This pull request has now been integrated.

Changeset: 916c7cf0
Author:    Aymane Harmaz <aharmaz at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/916c7cf01f3c4968696e6accc0976a24472773bd
Stats:     136 lines in 6 files changed: 123 ins; 5 del; 8 mod

8450: Improve usability of selectable action items by supporting keyboard and double-click interactions

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/682

From duke at openjdk.org  Wed Dec  3 12:56:15 2025
From: duke at openjdk.org (duke)
Date: Wed, 3 Dec 2025 12:56:15 GMT
Subject: RFR: 8469: Should make rules and page heading accessible through
 keyboard in JFR overview page
In-Reply-To: <nrSc_wDUvgMPzFmKmPfmINq7-chpVBOvPBM0-lMAyQI=.32fbeb18-3c21-408c-9583-e9be1144efcc@github.com>
References: <nrSc_wDUvgMPzFmKmPfmINq7-chpVBOvPBM0-lMAyQI=.32fbeb18-3c21-408c-9583-e9be1144efcc@github.com>
Message-ID: <20pQ9t2f8vQtSbkNlSvnmDij2avc3oitP4oftn0PcH8=.f3af7d29-5bcd-40b7-91fc-393222996613@github.com>

On Fri, 7 Nov 2025 13:59:20 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR makes it possible to reach JFR result pages and expand / collapse rule text on the JFR result overview using keyboard enter and tab keys.
> 
> <img width="1067" height="480" alt="focused-rule" src="https://github.com/user-attachments/assets/df38672e-4882-420a-8e45-f7f3f33349cd" />
> 
> <img width="1067" height="480" alt="expanded-rule-using-enter-key" src="https://github.com/user-attachments/assets/ec45e75b-48f6-424b-a8e7-7bc5b34bae0e" />

@aymane-harmaz 
Your change (at version e3b3c6456b66ca72eec1275eab0de725097612ac) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/683#issuecomment-3606720421

From hirt at openjdk.org  Wed Dec  3 12:58:23 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 3 Dec 2025 12:58:23 GMT
Subject: RFR: 8473: JMC silently connects to its own runtime if target
 runtime does not include management modules
In-Reply-To: <LokbsxrQooo3HVCCJv9lBLShdxBbbKc36qOE4ZZyYd4=.cde5b7e4-31a7-446d-965d-c74d5fe50167@github.com>
References: <LokbsxrQooo3HVCCJv9lBLShdxBbbKc36qOE4ZZyYd4=.cde5b7e4-31a7-446d-965d-c74d5fe50167@github.com>
Message-ID: <iX3rbO87ucJg6g0ReWpaGun2xSJQQcDSXNg-D2b-pWM=.5b766c43-db89-42ba-9948-3aa4a902430d@github.com>

On Thu, 27 Nov 2025 17:10:59 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR addresses the fallback behavior executed when the target jvm runtime does not contain management modules.
> 
> Instead of connecting to the jvm running JMC without informing the user, we explicitly tell the user what went wrong by letting the error propagate 
> 
> The next screenshots show the new error messages for each feature when target jvm runtime does not contain management modules
> 
> JMX Console :
> <img width="534" height="419" alt="jmx-console" src="https://github.com/user-attachments/assets/57c92ba9-75a3-4383-a545-19ba1749bc35" />
> 
> 
> Flight recording : 
> <img width="534" height="419" alt="flight-recording" src="https://github.com/user-attachments/assets/65235113-6780-433f-a449-8d80e93de9f1" />
> 
> 
> Dump Heap : 
> <img width="595" height="150" alt="dump-heap" src="https://github.com/user-attachments/assets/ba11bd57-9cd5-4f51-bb0d-5c2e8c1942db" />
> 
> 
> JMC agent : 
> <img width="595" height="373" alt="jmc-agent" src="https://github.com/user-attachments/assets/9adcac52-4325-41c5-be4c-c29f3b9880ac" />
> 
> 
> 
> Control the remote jmx agent feature was behaving correctly on the right jvm process but in case of an error the root case was not clearly communicated to the user :
> <img width="595" height="373" alt="previous-control-jmx-console" src="https://github.com/user-attachments/assets/859d2bb2-93f4-4e3c-8c70-61084e385d8e" />
> 
> In this PR the error message for controlling the remote jmx agent is explicitly displayed :
> <img width="972" height="502" alt="control-jmx-agent" src="https://github.com/user-attachments/assets/e0e6f88a-99f8-43a4-80a7-95e7babbee5d" />

application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/actions/AgentEditorOpener.java line 103:

> 101: 							e);
> 102: 				});
> 103: 				return Status.OK_STATUS;

Should this perhaps be CANCEL_STATUS, as we didn't actually connect?

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/689#discussion_r2585007536

From hirt at openjdk.org  Wed Dec  3 13:27:55 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 3 Dec 2025 13:27:55 GMT
Subject: RFR: 6832: Should allow plotting line charts for all quantities
In-Reply-To: <iOjydd_VWy1O-7YOp24id9trousaAKK_WzY0lzVbmT8=.2e2acd01-b1c9-4237-82e7-2f6341f32438@github.com>
References: <iOjydd_VWy1O-7YOp24id9trousaAKK_WzY0lzVbmT8=.2e2acd01-b1c9-4237-82e7-2f6341f32438@github.com>
Message-ID: <NQ0SyXiw2ux49RHvOYys0UNXlmfOAQDkWMnzpry2PqI=.b1beb602-2cab-4ce4-a656-4ec00121276e@github.com>

On Mon, 24 Nov 2025 17:30:13 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR makes sure line charts cover all the events across multiple IItemIterables, and makes it possible for linear quantities to be represented as line charts on custom pages.

This one effectively doubles the memory usage. For solving this and the sorting, perhaps a specialized merge sort iterator could be used instead?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/688#issuecomment-3606845826

From aharmaz at openjdk.org  Wed Dec  3 13:32:07 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Wed, 3 Dec 2025 13:32:07 GMT
Subject: Integrated: 8469: Should make rules and page heading accessible
 through keyboard in JFR overview page
In-Reply-To: <nrSc_wDUvgMPzFmKmPfmINq7-chpVBOvPBM0-lMAyQI=.32fbeb18-3c21-408c-9583-e9be1144efcc@github.com>
References: <nrSc_wDUvgMPzFmKmPfmINq7-chpVBOvPBM0-lMAyQI=.32fbeb18-3c21-408c-9583-e9be1144efcc@github.com>
Message-ID: <ek4dBj5cnFNDIHwLvHvZVQJM4Vc6oMDrmvRpKrVHoE4=.1ef4212b-e964-4c90-bd63-9459db665f9c@github.com>

On Fri, 7 Nov 2025 13:59:20 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR makes it possible to reach JFR result pages and expand / collapse rule text on the JFR result overview using keyboard enter and tab keys.
> 
> <img width="1067" height="480" alt="focused-rule" src="https://github.com/user-attachments/assets/df38672e-4882-420a-8e45-f7f3f33349cd" />
> 
> <img width="1067" height="480" alt="expanded-rule-using-enter-key" src="https://github.com/user-attachments/assets/ec45e75b-48f6-424b-a8e7-7bc5b34bae0e" />

This pull request has now been integrated.

Changeset: 9c5aedab
Author:    Aymane Harmaz <aharmaz at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/9c5aedab96398e070c281fe9e1366bf3837451d4
Stats:     17 lines in 3 files changed: 15 ins; 0 del; 2 mod

8469: Should make rules and page heading accessible through keyboard in JFR overview page

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/683

From marcus.hirt at datadoghq.com  Wed Dec  3 13:40:14 2025
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Wed, 3 Dec 2025 14:40:14 +0100
Subject: CFV: New jmc Committer: Martin Skarsaune
Message-ID: <CAOpWGx2DyJAFzUY2ha2RCHkURLcnrG_m9Sb=8aJbzDDXkSAkSA@mail.gmail.com>

I hereby nominate Martin Skarsaune to jmc Committer.

Martin has, amongst other things, been very helpful in adding and
maintaining Jolokia support for JDK Mission Control.

Here are Martin's contributions so far:
https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Askarsaune+label%3Aintegrated

Votes are due by 2025-12-12.

Only current jmc Committers [1] are eligible to vote
on this nomination.  Votes must be cast in the open by replying
to this mailing list.

For Lazy Consensus voting instructions, see [2].

Kind regards,
Marcus Hirt

[1] https://openjdk.org/census
[2] https://openjdk.org/projects/#committer-vote

From marcus.hirt at datadoghq.com  Wed Dec  3 13:46:13 2025
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Wed, 3 Dec 2025 14:46:13 +0100
Subject: CFV: New jmc Committer: Aymane Harmaz
Message-ID: <CAOpWGx1CaEiOaoyqZDMCYfb=hNzxxfA4rBO_A86fxyFb5=r+Og@mail.gmail.com>

I hereby nominate Aymane Harmaz to jmc Committer.

Aymane is hired by Oracle to contribute to the jmc project, and has in
a relatively short time ramped up and is now a prolific contributor.

Here is a link to Aymane's contributions so far:
https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Aaymane-harmaz+label%3Aintegrated

Votes are due by 2025-12-12.

Only current jmc Committers [1] are eligible to vote
on this nomination.  Votes must be cast in the open by replying
to this mailing list.

For Lazy Consensus voting instructions, see [2].

Kind regards,
Marcus

[1] https://openjdk.org/census
[2] https://openjdk.org/projects/#committer-vote

From almacdon at redhat.com  Wed Dec  3 14:04:17 2025
From: almacdon at redhat.com (Alex Macdonald)
Date: Wed, 3 Dec 2025 09:04:17 -0500
Subject: CFV: New jmc Committer: Martin Skarsaune
In-Reply-To: <CAOpWGx2DyJAFzUY2ha2RCHkURLcnrG_m9Sb=8aJbzDDXkSAkSA@mail.gmail.com>
References: <CAOpWGx2DyJAFzUY2ha2RCHkURLcnrG_m9Sb=8aJbzDDXkSAkSA@mail.gmail.com>
Message-ID: <CAOsn=kqyV2ooduJqoJK7Wgc2ke-Gz-+xEOenu2r+Gc5SA1nXbw@mail.gmail.com>

Vote: yes

On Wed, Dec 3, 2025 at 8:41?AM Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
>
> I hereby nominate Martin Skarsaune to jmc Committer.
>
> Martin has, amongst other things, been very helpful in adding and
> maintaining Jolokia support for JDK Mission Control.
>
> Here are Martin's contributions so far:
> https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Askarsaune+label%3Aintegrated
>
> Votes are due by 2025-12-12.
>
> Only current jmc Committers [1] are eligible to vote
> on this nomination.  Votes must be cast in the open by replying
> to this mailing list.
>
> For Lazy Consensus voting instructions, see [2].
>
> Kind regards,
> Marcus Hirt
>
> [1] https://openjdk.org/census
> [2] https://openjdk.org/projects/#committer-vote
>


From almacdon at redhat.com  Wed Dec  3 14:04:26 2025
From: almacdon at redhat.com (Alex Macdonald)
Date: Wed, 3 Dec 2025 09:04:26 -0500
Subject: CFV: New jmc Committer: Aymane Harmaz
In-Reply-To: <CAOpWGx1CaEiOaoyqZDMCYfb=hNzxxfA4rBO_A86fxyFb5=r+Og@mail.gmail.com>
References: <CAOpWGx1CaEiOaoyqZDMCYfb=hNzxxfA4rBO_A86fxyFb5=r+Og@mail.gmail.com>
Message-ID: <CAOsn=koTWR11Q7Weomeiui7W99AoQDL5F6iorgyJJ0RQNqsLzQ@mail.gmail.com>

Vote: yes

On Wed, Dec 3, 2025 at 8:47?AM Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
>
> I hereby nominate Aymane Harmaz to jmc Committer.
>
> Aymane is hired by Oracle to contribute to the jmc project, and has in
> a relatively short time ramped up and is now a prolific contributor.
>
> Here is a link to Aymane's contributions so far:
> https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Aaymane-harmaz+label%3Aintegrated
>
> Votes are due by 2025-12-12.
>
> Only current jmc Committers [1] are eligible to vote
> on this nomination.  Votes must be cast in the open by replying
> to this mailing list.
>
> For Lazy Consensus voting instructions, see [2].
>
> Kind regards,
> Marcus
>
> [1] https://openjdk.org/census
> [2] https://openjdk.org/projects/#committer-vote
>


From marcus.hirt at datadoghq.com  Wed Dec  3 14:07:19 2025
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Wed, 3 Dec 2025 15:07:19 +0100
Subject: CFV: New jmc Committer: Jaroslav Bachorik
Message-ID: <CAOpWGx0XLK5GqgRK=qwCAsQvbxGDm5tJnOgoOU0mM5pZqP3tdg@mail.gmail.com>

I hereby nominate Jaroslav Bachorik to jmc Committer.

Jaroslav is working in the runtime team at Datadog, actively
contributing to both the jdk and the jmc projects.

Here are Jaroslav's contributions so far:
https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Ajbachorik+label%3Aintegrated+

Votes are due by 2025-12-12.

Only current jmc Committers [1] are eligible to vote
on this nomination.  Votes must be cast in the open by replying
to this mailing list.

For Lazy Consensus voting instructions, see [2].

Kind regards,
Marcus Hirt

[1] https://openjdk.org/census
[2] https://openjdk.org/projects/#committer-vote

From jbachorik at openjdk.org  Wed Dec  3 16:24:51 2025
From: jbachorik at openjdk.org (Jaroslav Bachorik)
Date: Wed, 3 Dec 2025 16:24:51 GMT
Subject: RFR: 8475: Writing events with fields not explicitly set can
 corrupt the recording [v2]
In-Reply-To: <pu1GsrnjX-UVUD6Pr_SumH9KEe2bXbKMtNEjW8YWuEo=.79e00cb5-3b0f-4d3b-bd92-cba42bf8429d@github.com>
References: <pu1GsrnjX-UVUD6Pr_SumH9KEe2bXbKMtNEjW8YWuEo=.79e00cb5-3b0f-4d3b-bd92-cba42bf8429d@github.com>
Message-ID: <HZ3o6BzgwA-V8iI4ra5tOvWEw8EKc2M4wdD3rUKGZz0=.173b7bd1-22a2-4611-827e-c9066010febc@github.com>

> ## Summary
> Fixes an issue where events written with builtin type fields that are not explicitly set could cause field misalignment during JFR recording parsing, leading to corrupted field values.
> 
> ## Problem
> When writing JFR events using the Writer API without explicitly setting values for builtin type fields (byte, char, short, int, long, float, double, boolean, string), the previous implementation in `Chunk.writeBuiltinType()` would skip writing null builtin values (except for strings). This caused field alignment issues during parsing, where subsequent field values would be read at incorrect offsets.
> 
> ## Solution
> Modified `Chunk.writeBuiltinType()` (lines 88-150) to write appropriate default values for null builtin types instead of skipping them:
> - Numeric types (byte, char, short, int, long, float, double): Write `0`
> - Boolean: Write `false`  
> - String: Continue to write null encoding (existing behavior)
> 
> Additionally enhanced `TypedValueImpl.getDefaultImplicitFieldValue()` to provide `System.nanoTime()` as default for `@Timestamp` annotated fields in event types, ensuring valid monotonic timestamps.
> 
> ## Testing
> Added comprehensive test `ImplicitEventFieldsTest.eventWithAllBuiltinFieldsUnset()` that:
> - Creates an event with all 9 builtin type fields
> - Writes the event without setting any builtin field values
> - Includes a final field with an explicit value (99999L) to verify alignment
> - Verifies all default values are correct and the explicit field reads back correctly
> 
> All 277 existing tests pass with the changes.
> 
> ## Files Changed
> - `Chunk.java`: Fixed builtin type serialization to write defaults instead of skipping
> - `TypedValueImpl.java`: Enhanced default value handling for timestamp fields
> - `ImplicitEventFieldsTest.java`: Added comprehensive test for builtin defaults
> - `Type.java`, `TypedValueBuilder.java`: Enhanced documentation
> 
> Fixes #8475
> 
> ? Generated with [Claude Code](https://claude.com/claude-code)

Jaroslav Bachorik has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  8475: Writing events with fields not explicitly set can corrupt the recording

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/690/files
  - new: https://git.openjdk.org/jmc/pull/690/files/a3918534..d6f67988

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=690&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=690&range=00-01

  Stats: 19 lines in 1 file changed: 10 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jmc/pull/690.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/690/head:pull/690

PR: https://git.openjdk.org/jmc/pull/690

From suchita.chaturvedi at oracle.com  Wed Dec  3 16:34:19 2025
From: suchita.chaturvedi at oracle.com (Suchita Chaturvedi)
Date: Wed, 3 Dec 2025 16:34:19 +0000
Subject: CFV: New jmc Committer: Aymane Harmaz
In-Reply-To: <CAOsn=koTWR11Q7Weomeiui7W99AoQDL5F6iorgyJJ0RQNqsLzQ@mail.gmail.com>
References: <CAOpWGx1CaEiOaoyqZDMCYfb=hNzxxfA4rBO_A86fxyFb5=r+Og@mail.gmail.com>
 <CAOsn=koTWR11Q7Weomeiui7W99AoQDL5F6iorgyJJ0RQNqsLzQ@mail.gmail.com>
Message-ID: <CY5PR10MB594058935FE882E6E5841ADEFBD9A@CY5PR10MB5940.namprd10.prod.outlook.com>

Vote : Yes

Get Outlook for Android<https://aka.ms/AAb9ysg>


Confidential- Oracle Internal

________________________________
From: jmc-dev <jmc-dev-retn at openjdk.org> on behalf of Alex Macdonald <almacdon at redhat.com>
Sent: Wednesday, December 3, 2025 7:34:26 PM
To: Marcus Hirt <marcus.hirt at datadoghq.com>
Cc: jmc-dev at openjdk.org <jmc-dev at openjdk.org>
Subject: Re: CFV: New jmc Committer: Aymane Harmaz

Vote: yes

On Wed, Dec 3, 2025 at 8:47?AM Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
>
> I hereby nominate Aymane Harmaz to jmc Committer.
>
> Aymane is hired by Oracle to contribute to the jmc project, and has in
> a relatively short time ramped up and is now a prolific contributor.
>
> Here is a link to Aymane's contributions so far:
> https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Aaymane-harmaz+label%3Aintegrated
>
> Votes are due by 2025-12-12.
>
> Only current jmc Committers [1] are eligible to vote
> on this nomination.  Votes must be cast in the open by replying
> to this mailing list.
>
> For Lazy Consensus voting instructions, see [2].
>
> Kind regards,
> Marcus
>
> [1] https://openjdk.org/census
> [2] https://openjdk.org/projects/#committer-vote
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jmc-dev/attachments/20251203/c3911c06/attachment-0001.htm>

From brice.dutheil at gmail.com  Wed Dec  3 18:00:10 2025
From: brice.dutheil at gmail.com (Brice Dutheil)
Date: Wed, 3 Dec 2025 19:00:10 +0100
Subject: CFV: New jmc Committer: Jaroslav Bachorik
In-Reply-To: <CAOpWGx0XLK5GqgRK=qwCAsQvbxGDm5tJnOgoOU0mM5pZqP3tdg@mail.gmail.com>
References: <CAOpWGx0XLK5GqgRK=qwCAsQvbxGDm5tJnOgoOU0mM5pZqP3tdg@mail.gmail.com>
Message-ID: <CALTMA7uJMqQuLrX75V5e0xOF1_CDxnu5A3iAkGZL-KqxbzOe-A@mail.gmail.com>

Vote: yes

-- Brice


On Wed, Dec 3, 2025 at 3:07?PM Marcus Hirt <marcus.hirt at datadoghq.com>
wrote:

> I hereby nominate Jaroslav Bachorik to jmc Committer.
>
> Jaroslav is working in the runtime team at Datadog, actively
> contributing to both the jdk and the jmc projects.
>
> Here are Jaroslav's contributions so far:
>
> https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Ajbachorik+label%3Aintegrated+
>
> Votes are due by 2025-12-12.
>
> Only current jmc Committers [1] are eligible to vote
> on this nomination.  Votes must be cast in the open by replying
> to this mailing list.
>
> For Lazy Consensus voting instructions, see [2].
>
> Kind regards,
> Marcus Hirt
>
> [1] https://openjdk.org/census
> [2] https://openjdk.org/projects/#committer-vote
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jmc-dev/attachments/20251203/fdcfa522/attachment.htm>

From brice.dutheil at gmail.com  Wed Dec  3 18:01:28 2025
From: brice.dutheil at gmail.com (Brice Dutheil)
Date: Wed, 3 Dec 2025 19:01:28 +0100
Subject: CFV: New jmc Committer: Aymane Harmaz
In-Reply-To: <CY5PR10MB594058935FE882E6E5841ADEFBD9A@CY5PR10MB5940.namprd10.prod.outlook.com>
References: <CAOpWGx1CaEiOaoyqZDMCYfb=hNzxxfA4rBO_A86fxyFb5=r+Og@mail.gmail.com>
 <CAOsn=koTWR11Q7Weomeiui7W99AoQDL5F6iorgyJJ0RQNqsLzQ@mail.gmail.com>
 <CY5PR10MB594058935FE882E6E5841ADEFBD9A@CY5PR10MB5940.namprd10.prod.outlook.com>
Message-ID: <CALTMA7usdNVi4jRB6eyUsiB0v6ucbi6S7rDYQ_o1wTc3t5fR7w@mail.gmail.com>

Vote: yes

-- Brice


On Wed, Dec 3, 2025 at 5:35?PM Suchita Chaturvedi <
suchita.chaturvedi at oracle.com> wrote:

> Vote : Yes
>
> Get Outlook for Android <https://aka.ms/AAb9ysg>
>
> Confidential- Oracle Internal
> ------------------------------
> *From:* jmc-dev <jmc-dev-retn at openjdk.org> on behalf of Alex Macdonald <
> almacdon at redhat.com>
> *Sent:* Wednesday, December 3, 2025 7:34:26 PM
> *To:* Marcus Hirt <marcus.hirt at datadoghq.com>
> *Cc:* jmc-dev at openjdk.org <jmc-dev at openjdk.org>
> *Subject:* Re: CFV: New jmc Committer: Aymane Harmaz
>
> Vote: yes
>
> On Wed, Dec 3, 2025 at 8:47?AM Marcus Hirt <marcus.hirt at datadoghq.com>
> wrote:
> >
> > I hereby nominate Aymane Harmaz to jmc Committer.
> >
> > Aymane is hired by Oracle to contribute to the jmc project, and has in
> > a relatively short time ramped up and is now a prolific contributor.
> >
> > Here is a link to Aymane's contributions so far:
> >
> https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Aaymane-harmaz+label%3Aintegrated
> >
> > Votes are due by 2025-12-12.
> >
> > Only current jmc Committers [1] are eligible to vote
> > on this nomination.  Votes must be cast in the open by replying
> > to this mailing list.
> >
> > For Lazy Consensus voting instructions, see [2].
> >
> > Kind regards,
> > Marcus
> >
> > [1] https://openjdk.org/census
> > [2] https://openjdk.org/projects/#committer-vote
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jmc-dev/attachments/20251203/333784f8/attachment.htm>

From hdafgard at gmail.com  Wed Dec  3 18:14:35 2025
From: hdafgard at gmail.com (=?UTF-8?Q?Henrik_Dafg=C3=A5rd?=)
Date: Wed, 3 Dec 2025 19:14:35 +0100
Subject: CFV: New jmc Committer: Aymane Harmaz
In-Reply-To: <CALTMA7usdNVi4jRB6eyUsiB0v6ucbi6S7rDYQ_o1wTc3t5fR7w@mail.gmail.com>
References: <CAOpWGx1CaEiOaoyqZDMCYfb=hNzxxfA4rBO_A86fxyFb5=r+Og@mail.gmail.com>
 <CAOsn=koTWR11Q7Weomeiui7W99AoQDL5F6iorgyJJ0RQNqsLzQ@mail.gmail.com>
 <CY5PR10MB594058935FE882E6E5841ADEFBD9A@CY5PR10MB5940.namprd10.prod.outlook.com>
 <CALTMA7usdNVi4jRB6eyUsiB0v6ucbi6S7rDYQ_o1wTc3t5fR7w@mail.gmail.com>
Message-ID: <CADFkdVRug7eGG+1JdzD0FLVEifEHhWmW5gi7GGuvH_Lfhv5wwg@mail.gmail.com>

Vote: yes

// Henrik Dafg?rd


On Wed, 3 Dec 2025 at 19:02, Brice Dutheil <brice.dutheil at gmail.com> wrote:

> Vote: yes
>
> -- Brice
>
>
> On Wed, Dec 3, 2025 at 5:35?PM Suchita Chaturvedi <
> suchita.chaturvedi at oracle.com> wrote:
>
>> Vote : Yes
>>
>> Get Outlook for Android <https://aka.ms/AAb9ysg>
>>
>> Confidential- Oracle Internal
>> ------------------------------
>> *From:* jmc-dev <jmc-dev-retn at openjdk.org> on behalf of Alex Macdonald <
>> almacdon at redhat.com>
>> *Sent:* Wednesday, December 3, 2025 7:34:26 PM
>> *To:* Marcus Hirt <marcus.hirt at datadoghq.com>
>> *Cc:* jmc-dev at openjdk.org <jmc-dev at openjdk.org>
>> *Subject:* Re: CFV: New jmc Committer: Aymane Harmaz
>>
>> Vote: yes
>>
>> On Wed, Dec 3, 2025 at 8:47?AM Marcus Hirt <marcus.hirt at datadoghq.com>
>> wrote:
>> >
>> > I hereby nominate Aymane Harmaz to jmc Committer.
>> >
>> > Aymane is hired by Oracle to contribute to the jmc project, and has in
>> > a relatively short time ramped up and is now a prolific contributor.
>> >
>> > Here is a link to Aymane's contributions so far:
>> >
>> https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Aaymane-harmaz+label%3Aintegrated
>> >
>> > Votes are due by 2025-12-12.
>> >
>> > Only current jmc Committers [1] are eligible to vote
>> > on this nomination.  Votes must be cast in the open by replying
>> > to this mailing list.
>> >
>> > For Lazy Consensus voting instructions, see [2].
>> >
>> > Kind regards,
>> > Marcus
>> >
>> > [1] https://openjdk.org/census
>> > [2] https://openjdk.org/projects/#committer-vote
>> >
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jmc-dev/attachments/20251203/00c917ef/attachment-0001.htm>

From hdafgard at gmail.com  Wed Dec  3 18:15:04 2025
From: hdafgard at gmail.com (=?UTF-8?Q?Henrik_Dafg=C3=A5rd?=)
Date: Wed, 3 Dec 2025 19:15:04 +0100
Subject: CFV: New jmc Committer: Jaroslav Bachorik
In-Reply-To: <CALTMA7uJMqQuLrX75V5e0xOF1_CDxnu5A3iAkGZL-KqxbzOe-A@mail.gmail.com>
References: <CAOpWGx0XLK5GqgRK=qwCAsQvbxGDm5tJnOgoOU0mM5pZqP3tdg@mail.gmail.com>
 <CALTMA7uJMqQuLrX75V5e0xOF1_CDxnu5A3iAkGZL-KqxbzOe-A@mail.gmail.com>
Message-ID: <CADFkdVTA-xux_pFPd0vrywmiyzKADsZ3089P0nMtX-chPg0-AA@mail.gmail.com>

Vote: yes

// Henrik Dafg?rd


On Wed, 3 Dec 2025 at 19:01, Brice Dutheil <brice.dutheil at gmail.com> wrote:

> Vote: yes
>
> -- Brice
>
>
> On Wed, Dec 3, 2025 at 3:07?PM Marcus Hirt <marcus.hirt at datadoghq.com>
> wrote:
>
>> I hereby nominate Jaroslav Bachorik to jmc Committer.
>>
>> Jaroslav is working in the runtime team at Datadog, actively
>> contributing to both the jdk and the jmc projects.
>>
>> Here are Jaroslav's contributions so far:
>>
>> https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Ajbachorik+label%3Aintegrated+
>>
>> Votes are due by 2025-12-12.
>>
>> Only current jmc Committers [1] are eligible to vote
>> on this nomination.  Votes must be cast in the open by replying
>> to this mailing list.
>>
>> For Lazy Consensus voting instructions, see [2].
>>
>> Kind regards,
>> Marcus Hirt
>>
>> [1] https://openjdk.org/census
>> [2] https://openjdk.org/projects/#committer-vote
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jmc-dev/attachments/20251203/ce69fb3c/attachment.htm>

From hdafgard at gmail.com  Wed Dec  3 18:15:23 2025
From: hdafgard at gmail.com (=?UTF-8?Q?Henrik_Dafg=C3=A5rd?=)
Date: Wed, 3 Dec 2025 19:15:23 +0100
Subject: CFV: New jmc Committer: Martin Skarsaune
In-Reply-To: <CAOsn=kqyV2ooduJqoJK7Wgc2ke-Gz-+xEOenu2r+Gc5SA1nXbw@mail.gmail.com>
References: <CAOpWGx2DyJAFzUY2ha2RCHkURLcnrG_m9Sb=8aJbzDDXkSAkSA@mail.gmail.com>
 <CAOsn=kqyV2ooduJqoJK7Wgc2ke-Gz-+xEOenu2r+Gc5SA1nXbw@mail.gmail.com>
Message-ID: <CADFkdVQQ9Z+Z6pQM+biPgTvZYRwD5OsBBKf792rm2SCzp5ozDQ@mail.gmail.com>

Vote: yes

// Henrik Dafg?rd


On Wed, 3 Dec 2025 at 15:06, Alex Macdonald <almacdon at redhat.com> wrote:

> Vote: yes
>
> On Wed, Dec 3, 2025 at 8:41?AM Marcus Hirt <marcus.hirt at datadoghq.com>
> wrote:
> >
> > I hereby nominate Martin Skarsaune to jmc Committer.
> >
> > Martin has, amongst other things, been very helpful in adding and
> > maintaining Jolokia support for JDK Mission Control.
> >
> > Here are Martin's contributions so far:
> >
> https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Askarsaune+label%3Aintegrated
> >
> > Votes are due by 2025-12-12.
> >
> > Only current jmc Committers [1] are eligible to vote
> > on this nomination.  Votes must be cast in the open by replying
> > to this mailing list.
> >
> > For Lazy Consensus voting instructions, see [2].
> >
> > Kind regards,
> > Marcus Hirt
> >
> > [1] https://openjdk.org/census
> > [2] https://openjdk.org/projects/#committer-vote
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jmc-dev/attachments/20251203/4197d46e/attachment.htm>

From christoph.langer at sap.com  Wed Dec  3 18:52:23 2025
From: christoph.langer at sap.com (Langer, Christoph)
Date: Wed, 3 Dec 2025 18:52:23 +0000
Subject: CFV: New jmc Committer: Jaroslav Bachorik
In-Reply-To: <CAOpWGx0XLK5GqgRK=qwCAsQvbxGDm5tJnOgoOU0mM5pZqP3tdg@mail.gmail.com>
References: <CAOpWGx0XLK5GqgRK=qwCAsQvbxGDm5tJnOgoOU0mM5pZqP3tdg@mail.gmail.com>
Message-ID: <DU0PR02MB98001E66F600197F49F2328E8AD9A@DU0PR02MB9800.eurprd02.prod.outlook.com>

Vote: yes

/Christoph

> -----Original Message-----
> From: jmc-dev <jmc-dev-retn at openjdk.org> On Behalf Of Marcus Hirt
> Sent: Mittwoch, 3. Dezember 2025 15:07
> To: jmc-dev at openjdk.org
> Subject: CFV: New jmc Committer: Jaroslav Bachorik
> 
> I hereby nominate Jaroslav Bachorik to jmc Committer.
> 
> Jaroslav is working in the runtime team at Datadog, actively contributing to
> both the jdk and the jmc projects.
> 
> Here are Jaroslav's contributions so far:
> https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Ajbac
> horik+label%3Aintegrated+
> 
> Votes are due by 2025-12-12.
> 
> Only current jmc Committers [1] are eligible to vote on this nomination.  Votes
> must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [2].
> 
> Kind regards,
> Marcus Hirt
> 
> [1] https://openjdk.org/census
> [2] https://openjdk.org/projects/#committer-vote

From christoph.langer at sap.com  Wed Dec  3 18:52:33 2025
From: christoph.langer at sap.com (Langer, Christoph)
Date: Wed, 3 Dec 2025 18:52:33 +0000
Subject: CFV: New jmc Committer: Aymane Harmaz
In-Reply-To: <CAOpWGx1CaEiOaoyqZDMCYfb=hNzxxfA4rBO_A86fxyFb5=r+Og@mail.gmail.com>
References: <CAOpWGx1CaEiOaoyqZDMCYfb=hNzxxfA4rBO_A86fxyFb5=r+Og@mail.gmail.com>
Message-ID: <DU0PR02MB9800A54F63C00179BA3E9CCB8AD9A@DU0PR02MB9800.eurprd02.prod.outlook.com>

Vote:yes

/Christoph

> -----Original Message-----
> From: jmc-dev <jmc-dev-retn at openjdk.org> On Behalf Of Marcus Hirt
> Sent: Mittwoch, 3. Dezember 2025 14:46
> To: jmc-dev at openjdk.org
> Subject: CFV: New jmc Committer: Aymane Harmaz
> 
> I hereby nominate Aymane Harmaz to jmc Committer.
> 
> Aymane is hired by Oracle to contribute to the jmc project, and has in a
> relatively short time ramped up and is now a prolific contributor.
> 
> Here is a link to Aymane's contributions so far:
> https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Aaym
> ane-harmaz+label%3Aintegrated
> 
> Votes are due by 2025-12-12.
> 
> Only current jmc Committers [1] are eligible to vote on this nomination.  Votes
> must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [2].
> 
> Kind regards,
> Marcus
> 
> [1] https://openjdk.org/census
> [2] https://openjdk.org/projects/#committer-vote

From christoph.langer at sap.com  Wed Dec  3 18:52:44 2025
From: christoph.langer at sap.com (Langer, Christoph)
Date: Wed, 3 Dec 2025 18:52:44 +0000
Subject: CFV: New jmc Committer: Martin Skarsaune
In-Reply-To: <CAOpWGx2DyJAFzUY2ha2RCHkURLcnrG_m9Sb=8aJbzDDXkSAkSA@mail.gmail.com>
References: <CAOpWGx2DyJAFzUY2ha2RCHkURLcnrG_m9Sb=8aJbzDDXkSAkSA@mail.gmail.com>
Message-ID: <DU0PR02MB9800CE6750F2694C978836378AD9A@DU0PR02MB9800.eurprd02.prod.outlook.com>

Vote:yes

/Christoph

> -----Original Message-----
> From: jmc-dev <jmc-dev-retn at openjdk.org> On Behalf Of Marcus Hirt
> Sent: Mittwoch, 3. Dezember 2025 14:40
> To: jmc-dev at openjdk.org
> Subject: CFV: New jmc Committer: Martin Skarsaune
> 
> I hereby nominate Martin Skarsaune to jmc Committer.
> 
> Martin has, amongst other things, been very helpful in adding and maintaining
> Jolokia support for JDK Mission Control.
> 
> Here are Martin's contributions so far:
> https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Askar
> saune+label%3Aintegrated
> 
> Votes are due by 2025-12-12.
> 
> Only current jmc Committers [1] are eligible to vote on this nomination.  Votes
> must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [2].
> 
> Kind regards,
> Marcus Hirt
> 
> [1] https://openjdk.org/census
> [2] https://openjdk.org/projects/#committer-vote

From brice.dutheil at gmail.com  Wed Dec  3 22:36:06 2025
From: brice.dutheil at gmail.com (Brice Dutheil)
Date: Wed, 3 Dec 2025 23:36:06 +0100
Subject: CFV: New jmc Committer: Martin Skarsaune
In-Reply-To: <DU0PR02MB9800CE6750F2694C978836378AD9A@DU0PR02MB9800.eurprd02.prod.outlook.com>
References: <CAOpWGx2DyJAFzUY2ha2RCHkURLcnrG_m9Sb=8aJbzDDXkSAkSA@mail.gmail.com>
 <DU0PR02MB9800CE6750F2694C978836378AD9A@DU0PR02MB9800.eurprd02.prod.outlook.com>
Message-ID: <CALTMA7vy4xBWGzzO82X8=w1v3V59xGYFSjs+55UmEq73+NR6CA@mail.gmail.com>

Vote: yes

-- Brice


On Wed, Dec 3, 2025 at 7:53?PM Langer, Christoph <christoph.langer at sap.com>
wrote:

> Vote:yes
>
> /Christoph
>
> > -----Original Message-----
> > From: jmc-dev <jmc-dev-retn at openjdk.org> On Behalf Of Marcus Hirt
> > Sent: Mittwoch, 3. Dezember 2025 14:40
> > To: jmc-dev at openjdk.org
> > Subject: CFV: New jmc Committer: Martin Skarsaune
> >
> > I hereby nominate Martin Skarsaune to jmc Committer.
> >
> > Martin has, amongst other things, been very helpful in adding and
> maintaining
> > Jolokia support for JDK Mission Control.
> >
> > Here are Martin's contributions so far:
> > https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Askar
> > saune+label%3Aintegrated
> >
> > Votes are due by 2025-12-12.
> >
> > Only current jmc Committers [1] are eligible to vote on this
> nomination.  Votes
> > must be cast in the open by replying to this mailing list.
> >
> > For Lazy Consensus voting instructions, see [2].
> >
> > Kind regards,
> > Marcus Hirt
> >
> > [1] https://openjdk.org/census
> > [2] https://openjdk.org/projects/#committer-vote
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jmc-dev/attachments/20251203/a559d437/attachment.htm>

From miro.wengner at gmail.com  Thu Dec  4 05:56:44 2025
From: miro.wengner at gmail.com (Miro Wengner)
Date: Thu, 4 Dec 2025 06:56:44 +0100
Subject: CFV: New jmc Committer: Aymane Harmaz
In-Reply-To: <CAOpWGx1CaEiOaoyqZDMCYfb=hNzxxfA4rBO_A86fxyFb5=r+Og@mail.gmail.com>
References: <CAOpWGx1CaEiOaoyqZDMCYfb=hNzxxfA4rBO_A86fxyFb5=r+Og@mail.gmail.com>
Message-ID: <DDD43B9B-BB02-4A41-866B-9B17CCA3351D@gmail.com>

Vote: Yes 
?Miro

> On 3. Dec 2025, at 14:46, Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
> 
> I hereby nominate Aymane Harmaz to jmc Committer.
> 
> Aymane is hired by Oracle to contribute to the jmc project, and has in
> a relatively short time ramped up and is now a prolific contributor.
> 
> Here is a link to Aymane's contributions so far:
> https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Aaymane-harmaz+label%3Aintegrated
> 
> Votes are due by 2025-12-12.
> 
> Only current jmc Committers [1] are eligible to vote
> on this nomination.  Votes must be cast in the open by replying
> to this mailing list.
> 
> For Lazy Consensus voting instructions, see [2].
> 
> Kind regards,
> Marcus
> 
> [1] https://openjdk.org/census
> [2] https://openjdk.org/projects/#committer-vote


From miro.wengner at gmail.com  Thu Dec  4 05:57:07 2025
From: miro.wengner at gmail.com (Miro Wengner)
Date: Thu, 4 Dec 2025 06:57:07 +0100
Subject: CFV: New jmc Committer: Jaroslav Bachorik
In-Reply-To: <CAOpWGx0XLK5GqgRK=qwCAsQvbxGDm5tJnOgoOU0mM5pZqP3tdg@mail.gmail.com>
References: <CAOpWGx0XLK5GqgRK=qwCAsQvbxGDm5tJnOgoOU0mM5pZqP3tdg@mail.gmail.com>
Message-ID: <B56C046B-E233-471F-848D-9B3F255CBD67@gmail.com>

Vote: Yes
? Miro

> On 3. Dec 2025, at 15:07, Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
> 
> I hereby nominate Jaroslav Bachorik to jmc Committer.
> 
> Jaroslav is working in the runtime team at Datadog, actively
> contributing to both the jdk and the jmc projects.
> 
> Here are Jaroslav's contributions so far:
> https://github.com/openjdk/jmc/pulls?q=is%3Apr+is%3Aclosed+author%3Ajbachorik+label%3Aintegrated+
> 
> Votes are due by 2025-12-12.
> 
> Only current jmc Committers [1] are eligible to vote
> on this nomination.  Votes must be cast in the open by replying
> to this mailing list.
> 
> For Lazy Consensus voting instructions, see [2].
> 
> Kind regards,
> Marcus Hirt
> 
> [1] https://openjdk.org/census
> [2] https://openjdk.org/projects/#committer-vote


From aharmaz at openjdk.org  Thu Dec  4 10:17:23 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Thu, 4 Dec 2025 10:17:23 GMT
Subject: RFR: 8473: JMC silently connects to its own runtime if target
 runtime does not include management modules [v2]
In-Reply-To: <LokbsxrQooo3HVCCJv9lBLShdxBbbKc36qOE4ZZyYd4=.cde5b7e4-31a7-446d-965d-c74d5fe50167@github.com>
References: <LokbsxrQooo3HVCCJv9lBLShdxBbbKc36qOE4ZZyYd4=.cde5b7e4-31a7-446d-965d-c74d5fe50167@github.com>
Message-ID: <M6xqy9q-2_jYWPhf8Avlpd6YeZzpAC9VYcgw5h3NeVE=.334bb930-46eb-40d8-a2c4-f1ccc0044266@github.com>

> This PR addresses the fallback behavior executed when the target jvm runtime does not contain management modules.
> 
> Instead of connecting to the jvm running JMC without informing the user, we explicitly tell the user what went wrong by letting the error propagate 
> 
> The next screenshots show the new error messages for each feature when target jvm runtime does not contain management modules
> 
> JMX Console :
> <img width="534" height="419" alt="jmx-console" src="https://github.com/user-attachments/assets/57c92ba9-75a3-4383-a545-19ba1749bc35" />
> 
> 
> Flight recording : 
> <img width="534" height="419" alt="flight-recording" src="https://github.com/user-attachments/assets/65235113-6780-433f-a449-8d80e93de9f1" />
> 
> 
> Dump Heap : 
> <img width="595" height="150" alt="dump-heap" src="https://github.com/user-attachments/assets/ba11bd57-9cd5-4f51-bb0d-5c2e8c1942db" />
> 
> 
> JMC agent : 
> <img width="595" height="373" alt="jmc-agent" src="https://github.com/user-attachments/assets/9adcac52-4325-41c5-be4c-c29f3b9880ac" />
> 
> 
> 
> Control the remote jmx agent feature was behaving correctly on the right jvm process but in case of an error the root case was not clearly communicated to the user :
> <img width="595" height="373" alt="previous-control-jmx-console" src="https://github.com/user-attachments/assets/859d2bb2-93f4-4e3c-8c70-61084e385d8e" />
> 
> In this PR the error message for controlling the remote jmx agent is explicitly displayed :
> <img width="972" height="502" alt="control-jmx-agent" src="https://github.com/user-attachments/assets/e0e6f88a-99f8-43a4-80a7-95e7babbee5d" />

Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:

  Implemented review comment

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/689/files
  - new: https://git.openjdk.org/jmc/pull/689/files/eb050da3..47cf417d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=689&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=689&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/689.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/689/head:pull/689

PR: https://git.openjdk.org/jmc/pull/689

From aharmaz at openjdk.org  Thu Dec  4 10:19:34 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Thu, 4 Dec 2025 10:19:34 GMT
Subject: RFR: 8473: JMC silently connects to its own runtime if target
 runtime does not include management modules [v2]
In-Reply-To: <iX3rbO87ucJg6g0ReWpaGun2xSJQQcDSXNg-D2b-pWM=.5b766c43-db89-42ba-9948-3aa4a902430d@github.com>
References: <LokbsxrQooo3HVCCJv9lBLShdxBbbKc36qOE4ZZyYd4=.cde5b7e4-31a7-446d-965d-c74d5fe50167@github.com>
 <iX3rbO87ucJg6g0ReWpaGun2xSJQQcDSXNg-D2b-pWM=.5b766c43-db89-42ba-9948-3aa4a902430d@github.com>
Message-ID: <qlwoOB-kLuMdOEWMrs4H3758gQVMSUCWGaihKit3IeE=.88cea9a0-4e3d-48de-84c0-4388c1089036@github.com>

On Wed, 3 Dec 2025 12:55:41 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implemented review comment
>
> application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/actions/AgentEditorOpener.java line 103:
> 
>> 101: 							e);
>> 102: 				});
>> 103: 				return Status.OK_STATUS;
> 
> Should this perhaps be CANCEL_STATUS, as we didn't actually connect?

Thanks for pointing that out. returned status is updated accordingly

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/689#discussion_r2588406937

From hirt at openjdk.org  Thu Dec  4 16:07:07 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 4 Dec 2025 16:07:07 GMT
Subject: RFR: 5561: Support for Crypto Events in JMC
In-Reply-To: <Ez5qBFwXF_0pOMOdutPuxCMdfyWcif-StHMa5xEgkZc=.c9b3c1b2-7b49-45fb-aa04-0ca65c6d0385@github.com>
References: <L3Wlpr7zk0rQE9qSVzkTehMZtHUwr141I2ZFjOF0060=.7ceacbf6-67d0-462d-a35e-7d135046ec42@github.com>
 <aw4KbJLS3mCifxk3ArClTtDTM77UPBDUdzNNrSVWFDk=.5ada4aea-3747-4345-8936-ef18b3900a91@github.com>
 <jZ8fDJdzeUXRPRe4AqVOkD6unbW398bUwgbHRWgNpPU=.d967cac4-1687-4353-9a3a-0088e7bfad92@github.com>
 <Ez5qBFwXF_0pOMOdutPuxCMdfyWcif-StHMa5xEgkZc=.c9b3c1b2-7b49-45fb-aa04-0ca65c6d0385@github.com>
Message-ID: <-48Xg6L7TVIiWM9qCogq9OFObilTvP2-xYt-1GrF-Vc=.72d6827c-5816-47cf-aeb1-1fa30566c8e7@github.com>

On Wed, 3 Dec 2025 05:47:25 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Should perhaps the messages be more action oriented? 
>> 
>> * Certificate with id x expired t days ago. It should be replaced.
>> * Certificate with id y is using SHA-1. It should be updated to use SHA-256 or SHA-512.
>
>> This seems to link to the exact same page as Using the TLAB Allocations Page. Copy/Paste error?
> 
> Yes, I have added that link as placeholder for the respective html help page then forgot to update it. Is there any tool to generate the html help page or any other easy way? OR we need to write that completely from scratch.

These were previously handled by the documentation team at Oracle, but they aren't anymore. You'll have to add a documentation page from scratch.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/686#discussion_r2589671119

From hirt at openjdk.org  Thu Dec  4 16:09:20 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 4 Dec 2025 16:09:20 GMT
Subject: RFR: 8473: JMC silently connects to its own runtime if target
 runtime does not include management modules [v2]
In-Reply-To: <M6xqy9q-2_jYWPhf8Avlpd6YeZzpAC9VYcgw5h3NeVE=.334bb930-46eb-40d8-a2c4-f1ccc0044266@github.com>
References: <LokbsxrQooo3HVCCJv9lBLShdxBbbKc36qOE4ZZyYd4=.cde5b7e4-31a7-446d-965d-c74d5fe50167@github.com>
 <M6xqy9q-2_jYWPhf8Avlpd6YeZzpAC9VYcgw5h3NeVE=.334bb930-46eb-40d8-a2c4-f1ccc0044266@github.com>
Message-ID: <ZKPr72TQssSHtutsEtpUypGPHwUdlEB-sNZ7S6IyV90=.91665ef6-6903-46c5-8788-a434a00beddd@github.com>

On Thu, 4 Dec 2025 10:17:23 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

>> This PR addresses the fallback behavior executed when the target jvm runtime does not contain management modules.
>> 
>> Instead of connecting to the jvm running JMC without informing the user, we explicitly tell the user what went wrong by letting the error propagate 
>> 
>> The next screenshots show the new error messages for each feature when target jvm runtime does not contain management modules
>> 
>> JMX Console :
>> <img width="534" height="419" alt="jmx-console" src="https://github.com/user-attachments/assets/57c92ba9-75a3-4383-a545-19ba1749bc35" />
>> 
>> 
>> Flight recording : 
>> <img width="534" height="419" alt="flight-recording" src="https://github.com/user-attachments/assets/65235113-6780-433f-a449-8d80e93de9f1" />
>> 
>> 
>> Dump Heap : 
>> <img width="595" height="150" alt="dump-heap" src="https://github.com/user-attachments/assets/ba11bd57-9cd5-4f51-bb0d-5c2e8c1942db" />
>> 
>> 
>> JMC agent : 
>> <img width="595" height="373" alt="jmc-agent" src="https://github.com/user-attachments/assets/9adcac52-4325-41c5-be4c-c29f3b9880ac" />
>> 
>> 
>> 
>> Control the remote jmx agent feature was behaving correctly on the right jvm process but in case of an error the root case was not clearly communicated to the user :
>> <img width="595" height="373" alt="previous-control-jmx-console" src="https://github.com/user-attachments/assets/859d2bb2-93f4-4e3c-8c70-61084e385d8e" />
>> 
>> In this PR the error message for controlling the remote jmx agent is explicitly displayed :
>> <img width="972" height="502" alt="control-jmx-agent" src="https://github.com/user-attachments/assets/e0e6f88a-99f8-43a4-80a7-95e7babbee5d" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comment

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/689#pullrequestreview-3540779722

From aharmaz at openjdk.org  Thu Dec  4 16:19:25 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Thu, 4 Dec 2025 16:19:25 GMT
Subject: RFR: 8473: JMC silently connects to its own runtime if target
 runtime does not include management modules [v2]
In-Reply-To: <M6xqy9q-2_jYWPhf8Avlpd6YeZzpAC9VYcgw5h3NeVE=.334bb930-46eb-40d8-a2c4-f1ccc0044266@github.com>
References: <LokbsxrQooo3HVCCJv9lBLShdxBbbKc36qOE4ZZyYd4=.cde5b7e4-31a7-446d-965d-c74d5fe50167@github.com>
 <M6xqy9q-2_jYWPhf8Avlpd6YeZzpAC9VYcgw5h3NeVE=.334bb930-46eb-40d8-a2c4-f1ccc0044266@github.com>
Message-ID: <XPQ5JA_PuhVgFGpqqmD9vzwSsS5Z_4JZFD6D1mwPPZY=.68c5d85d-a0d9-45c5-bb90-cc2f060f3e5c@github.com>

On Thu, 4 Dec 2025 10:17:23 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

>> This PR addresses the fallback behavior executed when the target jvm runtime does not contain management modules.
>> 
>> Instead of connecting to the jvm running JMC without informing the user, we explicitly tell the user what went wrong by letting the error propagate 
>> 
>> The next screenshots show the new error messages for each feature when target jvm runtime does not contain management modules
>> 
>> JMX Console :
>> <img width="534" height="419" alt="jmx-console" src="https://github.com/user-attachments/assets/57c92ba9-75a3-4383-a545-19ba1749bc35" />
>> 
>> 
>> Flight recording : 
>> <img width="534" height="419" alt="flight-recording" src="https://github.com/user-attachments/assets/65235113-6780-433f-a449-8d80e93de9f1" />
>> 
>> 
>> Dump Heap : 
>> <img width="595" height="150" alt="dump-heap" src="https://github.com/user-attachments/assets/ba11bd57-9cd5-4f51-bb0d-5c2e8c1942db" />
>> 
>> 
>> JMC agent : 
>> <img width="595" height="373" alt="jmc-agent" src="https://github.com/user-attachments/assets/9adcac52-4325-41c5-be4c-c29f3b9880ac" />
>> 
>> 
>> 
>> Control the remote jmx agent feature was behaving correctly on the right jvm process but in case of an error the root case was not clearly communicated to the user :
>> <img width="595" height="373" alt="previous-control-jmx-console" src="https://github.com/user-attachments/assets/859d2bb2-93f4-4e3c-8c70-61084e385d8e" />
>> 
>> In this PR the error message for controlling the remote jmx agent is explicitly displayed :
>> <img width="972" height="502" alt="control-jmx-agent" src="https://github.com/user-attachments/assets/e0e6f88a-99f8-43a4-80a7-95e7babbee5d" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comment

Thanks for the review

-------------

PR Comment: https://git.openjdk.org/jmc/pull/689#issuecomment-3613015941

From hirt at openjdk.org  Thu Dec  4 16:19:26 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 4 Dec 2025 16:19:26 GMT
Subject: RFR: 8473: JMC silently connects to its own runtime if target
 runtime does not include management modules [v2]
In-Reply-To: <M6xqy9q-2_jYWPhf8Avlpd6YeZzpAC9VYcgw5h3NeVE=.334bb930-46eb-40d8-a2c4-f1ccc0044266@github.com>
References: <LokbsxrQooo3HVCCJv9lBLShdxBbbKc36qOE4ZZyYd4=.cde5b7e4-31a7-446d-965d-c74d5fe50167@github.com>
 <M6xqy9q-2_jYWPhf8Avlpd6YeZzpAC9VYcgw5h3NeVE=.334bb930-46eb-40d8-a2c4-f1ccc0044266@github.com>
Message-ID: <68Ivy6X24Qdn-yNu7HhmE-XyvbWGvsXHOLHT3WvAZUg=.882ac43b-c46e-487a-b631-e1e7f3428bd2@github.com>

On Thu, 4 Dec 2025 10:17:23 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

>> This PR addresses the fallback behavior executed when the target jvm runtime does not contain management modules.
>> 
>> Instead of connecting to the jvm running JMC without informing the user, we explicitly tell the user what went wrong by letting the error propagate 
>> 
>> The next screenshots show the new error messages for each feature when target jvm runtime does not contain management modules
>> 
>> JMX Console :
>> <img width="534" height="419" alt="jmx-console" src="https://github.com/user-attachments/assets/57c92ba9-75a3-4383-a545-19ba1749bc35" />
>> 
>> 
>> Flight recording : 
>> <img width="534" height="419" alt="flight-recording" src="https://github.com/user-attachments/assets/65235113-6780-433f-a449-8d80e93de9f1" />
>> 
>> 
>> Dump Heap : 
>> <img width="595" height="150" alt="dump-heap" src="https://github.com/user-attachments/assets/ba11bd57-9cd5-4f51-bb0d-5c2e8c1942db" />
>> 
>> 
>> JMC agent : 
>> <img width="595" height="373" alt="jmc-agent" src="https://github.com/user-attachments/assets/9adcac52-4325-41c5-be4c-c29f3b9880ac" />
>> 
>> 
>> 
>> Control the remote jmx agent feature was behaving correctly on the right jvm process but in case of an error the root case was not clearly communicated to the user :
>> <img width="595" height="373" alt="previous-control-jmx-console" src="https://github.com/user-attachments/assets/859d2bb2-93f4-4e3c-8c70-61084e385d8e" />
>> 
>> In this PR the error message for controlling the remote jmx agent is explicitly displayed :
>> <img width="972" height="502" alt="control-jmx-agent" src="https://github.com/user-attachments/assets/e0e6f88a-99f8-43a4-80a7-95e7babbee5d" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comment

> Thanks for the review
> 
> /integrate

Thanks for the contribution! :)

-------------

PR Comment: https://git.openjdk.org/jmc/pull/689#issuecomment-3613031794

From aharmaz at openjdk.org  Thu Dec  4 16:19:27 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Thu, 4 Dec 2025 16:19:27 GMT
Subject: Integrated: 8473: JMC silently connects to its own runtime if target
 runtime does not include management modules
In-Reply-To: <LokbsxrQooo3HVCCJv9lBLShdxBbbKc36qOE4ZZyYd4=.cde5b7e4-31a7-446d-965d-c74d5fe50167@github.com>
References: <LokbsxrQooo3HVCCJv9lBLShdxBbbKc36qOE4ZZyYd4=.cde5b7e4-31a7-446d-965d-c74d5fe50167@github.com>
Message-ID: <qkqpqvDeD3t6iCX2gy6JKXkcxXcquCU7iTpInNAmiNQ=.4cdce24f-9e08-4c87-9f63-a39665ac8211@github.com>

On Thu, 27 Nov 2025 17:10:59 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR addresses the fallback behavior executed when the target jvm runtime does not contain management modules.
> 
> Instead of connecting to the jvm running JMC without informing the user, we explicitly tell the user what went wrong by letting the error propagate 
> 
> The next screenshots show the new error messages for each feature when target jvm runtime does not contain management modules
> 
> JMX Console :
> <img width="534" height="419" alt="jmx-console" src="https://github.com/user-attachments/assets/57c92ba9-75a3-4383-a545-19ba1749bc35" />
> 
> 
> Flight recording : 
> <img width="534" height="419" alt="flight-recording" src="https://github.com/user-attachments/assets/65235113-6780-433f-a449-8d80e93de9f1" />
> 
> 
> Dump Heap : 
> <img width="595" height="150" alt="dump-heap" src="https://github.com/user-attachments/assets/ba11bd57-9cd5-4f51-bb0d-5c2e8c1942db" />
> 
> 
> JMC agent : 
> <img width="595" height="373" alt="jmc-agent" src="https://github.com/user-attachments/assets/9adcac52-4325-41c5-be4c-c29f3b9880ac" />
> 
> 
> 
> Control the remote jmx agent feature was behaving correctly on the right jvm process but in case of an error the root case was not clearly communicated to the user :
> <img width="595" height="373" alt="previous-control-jmx-console" src="https://github.com/user-attachments/assets/859d2bb2-93f4-4e3c-8c70-61084e385d8e" />
> 
> In this PR the error message for controlling the remote jmx agent is explicitly displayed :
> <img width="972" height="502" alt="control-jmx-agent" src="https://github.com/user-attachments/assets/e0e6f88a-99f8-43a4-80a7-95e7babbee5d" />

This pull request has now been integrated.

Changeset: 39ddd133
Author:    Aymane Harmaz <aharmaz at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/39ddd1339e8fb4f231e80c137d0112415f22298a
Stats:     12 lines in 3 files changed: 0 ins; 3 del; 9 mod

8473: JMC silently connects to its own runtime if target runtime does not include management modules

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/689

From jbachorik at openjdk.org  Fri Dec  5 12:07:37 2025
From: jbachorik at openjdk.org (Jaroslav Bachorik)
Date: Fri, 5 Dec 2025 12:07:37 GMT
Subject: RFR: JMC-8477: Add opt-in memory-mapped file support for event storage
Message-ID: <BKBrpLV2ucuMhemHh8fqiATPCd4HsBIyUxCXlaO1-8Q=.c164841a-bd9b-4719-ba28-028bdbdf1c5c@github.com>

## Summary

Implements [JMC-8477](https://bugs.openjdk.org/browse/JMC-8477): Add opt-in memory-mapped file support to JFR Writer API for off-heap event storage.

## Problem

The current JFR Writer API stores all event data in on-heap byte arrays during recording creation, causing:
- **Heap pressure** from large byte array allocations
- **GC overhead** from frequent allocation/deallocation
- **Unbounded memory growth** with recording size
- **Scalability issues** for long-running or high-throughput scenarios

## Solution

This PR adds opt-in memory-mapped file support, allowing event data to be stored off-heap.

### API

Users opt in via the builder pattern:

Recording recording = Recordings.newRecording(outputStream,
    settings -> settings.withMmap(4 * 1024 * 1024)  // 4MB per thread
                        .withJdkTypeInitialization());


### Benefits

- **Reduced Heap Pressure**: Event data stored off-heap eliminates large on-heap allocations
- **Predictable Memory Usage**: Fixed memory footprint per thread regardless of recording size
- **Improved Performance**: JMH benchmarks show 8-12% throughput improvement
- **Better Scalability**: Multiple recordings can coexist without competing for heap space
- **Fully Backward Compatible**: Heap mode remains the default; opt-in only

### Performance Results

JMH benchmarks show consistent improvements across event types:
- writeSimpleEvent: +8.3% (909K ? 985K ops/s)
- writeMultiFieldEvent: +11.9% (787K ? 881K ops/s)
- writeRepeatedStringsEvent: +11.9% (793K ? 887K ops/s)
- writeStringHeavyEvent: +10.4% (801K ? 884K ops/s)

## Backward Compatibility

- ? Heap mode remains the default behavior
- ? Existing API unchanged - no breaking changes
- ? All existing tests pass without modification
- ? New functionality accessed only through explicit opt-in

## Testing

- **Unit Tests**: 850+ lines covering core functionality
- **Integration Tests**: Multi-threaded stress tests, large event tests
- **Benchmarks**: Comprehensive JMH benchmark suite with comparison tools
- **Validation**: All existing JFR Writer tests pass

## Commits

1. **Add JMH benchmark infrastructure** (44aa6377) - JMH benchmarks for performance validation
2. **Add memory-mapped file support** (5def3258) - Core mmap implementation
3. **Refactor to builder pattern** (aaddf983) - Move from system properties to builder API
4. **Fix JMH benchmark build** (7264aa4e) - Enable out-of-the-box benchmark execution
5. **Add comparison tool** (449eefdc) - Python script for benchmark result analysis

## Documentation

- README.md with comprehensive usage instructions
- JMH benchmark guide with examples
- Comparison tool for performance analysis

? Generated with [Claude Code](https://claude.com/claude-code)

-------------

Commit messages:
 - Add benchmark comparison tool and enhance documentation
 - Fix JMH benchmark build and add comprehensive documentation
 - Refactor mmap configuration from system properties to builder pattern
 - Add memory-mapped file support for JFR Writer
 - Add JMH benchmark infrastructure for JFR Writer performance analysis
 - 8475: Writing events with fields not explicitly set can corrupt the recording

Changes: https://git.openjdk.org/jmc/pull/691/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=691&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8477
  Stats: 5545 lines in 27 files changed: 5489 ins; 10 del; 46 mod
  Patch: https://git.openjdk.org/jmc/pull/691.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/691/head:pull/691

PR: https://git.openjdk.org/jmc/pull/691