RFR: 8473: JMC silently connects to its own runtime if target runtime does not include management modules [v2]

Aymane Harmaz aharmaz at openjdk.org
Thu Dec 4 10:19:34 UTC 2025


On Wed, 3 Dec 2025 12:55:41 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implemented review comment
>
> application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/actions/AgentEditorOpener.java line 103:
> 
>> 101: 							e);
>> 102: 				});
>> 103: 				return Status.OK_STATUS;
> 
> Should this perhaps be CANCEL_STATUS, as we didn't actually connect?

Thanks for pointing that out. returned status is updated accordingly

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/689#discussion_r2588406937


More information about the jmc-dev mailing list