From hirt at openjdk.org  Thu Feb  6 16:29:34 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 6 Feb 2025 16:29:34 GMT
Subject: RFR: 8349: JMC Copyright year and some http links require update
Message-ID: <HuC8YxV7HQLq3Hk6E4zu9IFkIk924oZuJtYkU7HCDs0=.c40a343f-173c-4c97-b9c7-e79cbfe48173@github.com>

Reviewed-by: vpurnam. Cherry-pick.

-------------

Commit messages:
 - 8349: JMC Copyright year and some http links require update

Changes: https://git.openjdk.org/jmc/pull/627/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=627&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8349
  Stats: 8131 lines in 3509 files changed: 67 ins; 0 del; 8064 mod
  Patch: https://git.openjdk.org/jmc/pull/627.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/627/head:pull/627

PR: https://git.openjdk.org/jmc/pull/627

From hirt at openjdk.org  Fri Feb  7 12:41:43 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 7 Feb 2025 12:41:43 GMT
Subject: RFR: 8349: JMC Copyright year and some http links require update
 [v2]
In-Reply-To: <HuC8YxV7HQLq3Hk6E4zu9IFkIk924oZuJtYkU7HCDs0=.c40a343f-173c-4c97-b9c7-e79cbfe48173@github.com>
References: <HuC8YxV7HQLq3Hk6E4zu9IFkIk924oZuJtYkU7HCDs0=.c40a343f-173c-4c97-b9c7-e79cbfe48173@github.com>
Message-ID: <0gFT0sKNYPMXJ_A5aV3rw04-J1PnhRA9jHn_MndpsNM=.a92fa7cf-d74c-4cb5-9733-0c02a6823f25@github.com>

> Reviewed-by: vpurnam. Cherry-pick.

Marcus Hirt has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available.

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/627/files
  - new: https://git.openjdk.org/jmc/pull/627/files/f50770c7..6333fd42

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=627&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=627&range=00-01

  Stats: 8131 lines in 3509 files changed: 0 ins; 67 del; 8064 mod
  Patch: https://git.openjdk.org/jmc/pull/627.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/627/head:pull/627

PR: https://git.openjdk.org/jmc/pull/627

From hirt at openjdk.org  Fri Feb  7 12:41:43 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 7 Feb 2025 12:41:43 GMT
Subject: Withdrawn: 8349: JMC Copyright year and some http links require update
In-Reply-To: <HuC8YxV7HQLq3Hk6E4zu9IFkIk924oZuJtYkU7HCDs0=.c40a343f-173c-4c97-b9c7-e79cbfe48173@github.com>
References: <HuC8YxV7HQLq3Hk6E4zu9IFkIk924oZuJtYkU7HCDs0=.c40a343f-173c-4c97-b9c7-e79cbfe48173@github.com>
Message-ID: <RK5Oln7S7XJraYhS_oUqvSDF9Kb-NuCpbnxZaPWcQPw=.a645faa6-f263-4197-8516-686cab87c966@github.com>

On Thu, 6 Feb 2025 16:24:18 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Reviewed-by: vpurnam. Cherry-pick.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jmc/pull/627

From vpurnam at openjdk.org  Fri Feb  7 12:43:18 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Fri, 7 Feb 2025 12:43:18 GMT
Subject: RFR: 8349: JMC Copyright year and some http links require update
In-Reply-To: <HuC8YxV7HQLq3Hk6E4zu9IFkIk924oZuJtYkU7HCDs0=.c40a343f-173c-4c97-b9c7-e79cbfe48173@github.com>
References: <HuC8YxV7HQLq3Hk6E4zu9IFkIk924oZuJtYkU7HCDs0=.c40a343f-173c-4c97-b9c7-e79cbfe48173@github.com>
Message-ID: <K6hGbk_qQkBwi0-QNvEf6wt4MfN9z0HL6HxKre1RpnM=.d9eb9307-4360-476d-aa7e-29047cdf6e3b@github.com>

On Thu, 6 Feb 2025 16:24:18 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Reviewed-by: vpurnam. Cherry-pick.

Hi @thegreystone, copyright jcheck was failed for some files.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/627#issuecomment-2642811245

From hirt at openjdk.org  Fri Feb  7 12:46:48 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 7 Feb 2025 12:46:48 GMT
Subject: RFR: 8356: Cherry pick copyright changes
Message-ID: <mEF1qsJ1gEQcGj6naiBlzws5Z675Jo0P5cnrjtzAs6Y=.41a88141-2e00-4749-bdeb-96a97132f53f@github.com>

Reviewed-by: vpurnam

-------------

Commit messages:
 - 8349: JMC Copyright year and some http links require update

Changes: https://git.openjdk.org/jmc/pull/628/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=628&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8356
  Stats: 8131 lines in 3509 files changed: 67 ins; 0 del; 8064 mod
  Patch: https://git.openjdk.org/jmc/pull/628.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/628/head:pull/628

PR: https://git.openjdk.org/jmc/pull/628

From vpurnam at openjdk.org  Fri Feb  7 12:56:18 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Fri, 7 Feb 2025 12:56:18 GMT
Subject: RFR: 8356: Cherry pick copyright changes
In-Reply-To: <mEF1qsJ1gEQcGj6naiBlzws5Z675Jo0P5cnrjtzAs6Y=.41a88141-2e00-4749-bdeb-96a97132f53f@github.com>
References: <mEF1qsJ1gEQcGj6naiBlzws5Z675Jo0P5cnrjtzAs6Y=.41a88141-2e00-4749-bdeb-96a97132f53f@github.com>
Message-ID: <lIM8BquWl_KcCy3TV6uaq7zXnU1phc4ZSpDiYBFsgHU=.0a04da75-8a7f-4fbf-abf7-8e99ee241e74@github.com>

On Fri, 7 Feb 2025 12:41:03 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Reviewed-by: vpurnam

Marked as reviewed by vpurnam (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/628#pullrequestreview-2601659716

From vpurnam at openjdk.org  Fri Feb  7 13:00:23 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Fri, 7 Feb 2025 13:00:23 GMT
Subject: RFR: 8356: Cherry pick copyright changes
In-Reply-To: <mEF1qsJ1gEQcGj6naiBlzws5Z675Jo0P5cnrjtzAs6Y=.41a88141-2e00-4749-bdeb-96a97132f53f@github.com>
References: <mEF1qsJ1gEQcGj6naiBlzws5Z675Jo0P5cnrjtzAs6Y=.41a88141-2e00-4749-bdeb-96a97132f53f@github.com>
Message-ID: <1iEaH91itDdNlpdIBY_F7Qmzy11yIio846RozVn0Fx0=.f604f2fd-2046-4bf0-8e85-1e626789de2f@github.com>

On Fri, 7 Feb 2025 12:41:03 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Reviewed-by: vpurnam

**Requires update: application/org.openjdk.jmc.feature.ide/pom.xml
Requires update: application/org.openjdk.jmc.feature.joverflow/pom.xml
Requires update: application/org.openjdk.jmc.feature.pde/pom.xml
Requires update: application/org.openjdk.jmc.joverflow.ui/pom.xml
Requires update: application/org.openjdk.jmc.joverflow/pom.xml
Requires update: application/org.openjdk.jmc.pde/pom.xml
Requires update: core/pom.xml
Requires update: pom.xml**

-------------

PR Review: https://git.openjdk.org/jmc/pull/628#pullrequestreview-2601667346

From hirt at openjdk.org  Fri Feb  7 13:21:46 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 7 Feb 2025 13:21:46 GMT
Subject: RFR: 8356: Cherry pick copyright changes [v2]
In-Reply-To: <mEF1qsJ1gEQcGj6naiBlzws5Z675Jo0P5cnrjtzAs6Y=.41a88141-2e00-4749-bdeb-96a97132f53f@github.com>
References: <mEF1qsJ1gEQcGj6naiBlzws5Z675Jo0P5cnrjtzAs6Y=.41a88141-2e00-4749-bdeb-96a97132f53f@github.com>
Message-ID: <iENvLdV6-W_Ojyr36oqUlurE8h7XIchfU_xJfjpXmys=.9f7c8f75-0cb7-4984-a575-e9cc20bb0ec7@github.com>

> Reviewed-by: vpurnam

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Fixing additional copyrights after merge

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/628/files
  - new: https://git.openjdk.org/jmc/pull/628/files/f50770c7..e4c1d0b9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=628&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=628&range=00-01

  Stats: 7 lines in 7 files changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jmc/pull/628.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/628/head:pull/628

PR: https://git.openjdk.org/jmc/pull/628

From hirt at openjdk.org  Fri Feb  7 13:26:02 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 7 Feb 2025 13:26:02 GMT
Subject: RFR: 8356: Cherry pick copyright changes [v3]
In-Reply-To: <mEF1qsJ1gEQcGj6naiBlzws5Z675Jo0P5cnrjtzAs6Y=.41a88141-2e00-4749-bdeb-96a97132f53f@github.com>
References: <mEF1qsJ1gEQcGj6naiBlzws5Z675Jo0P5cnrjtzAs6Y=.41a88141-2e00-4749-bdeb-96a97132f53f@github.com>
Message-ID: <CXmfHG5tAuIDOsQog3G2tp-4Vw89f6uISyr0GiFccFk=.349f86d5-88dd-4948-85f7-b83ace66eeae@github.com>

> Reviewed-by: vpurnam

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  One last copyright

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/628/files
  - new: https://git.openjdk.org/jmc/pull/628/files/e4c1d0b9..9157cd1c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=628&range=02
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=628&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/628.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/628/head:pull/628

PR: https://git.openjdk.org/jmc/pull/628

From vpurnam at openjdk.org  Fri Feb  7 14:24:16 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Fri, 7 Feb 2025 14:24:16 GMT
Subject: RFR: 8356: Cherry pick copyright changes [v3]
In-Reply-To: <CXmfHG5tAuIDOsQog3G2tp-4Vw89f6uISyr0GiFccFk=.349f86d5-88dd-4948-85f7-b83ace66eeae@github.com>
References: <mEF1qsJ1gEQcGj6naiBlzws5Z675Jo0P5cnrjtzAs6Y=.41a88141-2e00-4749-bdeb-96a97132f53f@github.com>
 <CXmfHG5tAuIDOsQog3G2tp-4Vw89f6uISyr0GiFccFk=.349f86d5-88dd-4948-85f7-b83ace66eeae@github.com>
Message-ID: <67q5w5Wd2wpgDDEUjBBorh7eohZcVG63XI9eX0Kzluo=.d9d8e61b-d37b-4853-b051-a8987ab0d004@github.com>

On Fri, 7 Feb 2025 13:26:02 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Reviewed-by: vpurnam
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   One last copyright

Marked as reviewed by vpurnam (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/628#pullrequestreview-2601866425

From hirt at openjdk.org  Fri Feb  7 15:30:17 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 7 Feb 2025 15:30:17 GMT
Subject: Integrated: 8356: Cherry pick copyright changes
In-Reply-To: <mEF1qsJ1gEQcGj6naiBlzws5Z675Jo0P5cnrjtzAs6Y=.41a88141-2e00-4749-bdeb-96a97132f53f@github.com>
References: <mEF1qsJ1gEQcGj6naiBlzws5Z675Jo0P5cnrjtzAs6Y=.41a88141-2e00-4749-bdeb-96a97132f53f@github.com>
Message-ID: <MfKX2gO3MEYilHASfqaAv8Fl_rAtA8yjgrJXTsd1rzY=.1bdcffa8-2f23-439f-b526-998d50cf1341@github.com>

On Fri, 7 Feb 2025 12:41:03 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Reviewed-by: vpurnam

This pull request has now been integrated.

Changeset: a7562f05
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/a7562f056a17ababefc621f5592bc19e4ac4b17d
Stats:     8139 lines in 3509 files changed: 67 ins; 0 del; 8072 mod

8356: Cherry pick copyright changes

Reviewed-by: vpurnam

-------------

PR: https://git.openjdk.org/jmc/pull/628

From hirt at openjdk.org  Tue Feb 11 21:09:35 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 11 Feb 2025 21:09:35 GMT
Subject: RFR: 8358: Create release notes for JMC 9.1.0
Message-ID: <uc5KYR2MZ8q-M8lqwxn5CeQxUQm1aWAw2V9tCUDJFHY=.c12084ce-a98e-4a85-9581-5edb6d70b653@github.com>

Release notes and images for JMC 9.1.0.

-------------

Commit messages:
 - 8358: 9.1.0 release notes

Changes: https://git.openjdk.org/jmc/pull/629/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=629&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8358
  Stats: 223 lines in 25 files changed: 221 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/629.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/629/head:pull/629

PR: https://git.openjdk.org/jmc/pull/629

From hirt at openjdk.org  Wed Feb 12 20:55:53 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 12 Feb 2025 20:55:53 GMT
Subject: RFR: 8358: Create release notes for JMC 9.1.0 [v2]
In-Reply-To: <uc5KYR2MZ8q-M8lqwxn5CeQxUQm1aWAw2V9tCUDJFHY=.c12084ce-a98e-4a85-9581-5edb6d70b653@github.com>
References: <uc5KYR2MZ8q-M8lqwxn5CeQxUQm1aWAw2V9tCUDJFHY=.c12084ce-a98e-4a85-9581-5edb6d70b653@github.com>
Message-ID: <OnhPT9ScDLLkPLWXYNnoV9FiCeY-vkCiO61PGJ-kDHs=.d414071b-a0a6-4c96-87c3-66df556c535d@github.com>

> Release notes and images for JMC 9.1.0.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Removing duplicate

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/629/files
  - new: https://git.openjdk.org/jmc/pull/629/files/51ec6272..c5687b75

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=629&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=629&range=00-01

  Stats: 11 lines in 1 file changed: 0 ins; 11 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/629.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/629/head:pull/629

PR: https://git.openjdk.org/jmc/pull/629

From vpurnam at openjdk.org  Thu Feb 13 05:31:17 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Thu, 13 Feb 2025 05:31:17 GMT
Subject: RFR: 8358: Create release notes for JMC 9.1.0 [v2]
In-Reply-To: <OnhPT9ScDLLkPLWXYNnoV9FiCeY-vkCiO61PGJ-kDHs=.d414071b-a0a6-4c96-87c3-66df556c535d@github.com>
References: <uc5KYR2MZ8q-M8lqwxn5CeQxUQm1aWAw2V9tCUDJFHY=.c12084ce-a98e-4a85-9581-5edb6d70b653@github.com>
 <OnhPT9ScDLLkPLWXYNnoV9FiCeY-vkCiO61PGJ-kDHs=.d414071b-a0a6-4c96-87c3-66df556c535d@github.com>
Message-ID: <DmkEp0IXcNjq6OSYrkFJjloATAenjgOjpF6uIO9uExI=.d8bb646a-6a38-4770-b1a5-59421843a650@github.com>

On Wed, 12 Feb 2025 20:55:53 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Release notes and images for JMC 9.1.0.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removing duplicate

Marked as reviewed by vpurnam (Reviewer).

releng/tools/org.openjdk.jmc.util.releasenotes/notes/9.1/notes.xml line 66:

> 64:             <image>core/agentconverters.png</image>
> 65:         </note>
> 66:         <note version="9.1">

Hi @thegreystone, this looks like a duplicate entry in release notes.
"Rule for detecting Java process with PID 1"

-------------

PR Review: https://git.openjdk.org/jmc/pull/629#pullrequestreview-2612368140
PR Review Comment: https://git.openjdk.org/jmc/pull/629#discussion_r1952903127

From duke at openjdk.org  Sun Feb 16 22:25:56 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Sun, 16 Feb 2025 22:25:56 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy
Message-ID: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>

JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.

Testing connectivity:
- [x]  Docker desktop kubernetes 
- [x]  Azure AKS
- [x]  Amazon EKS
- [x]  Google GKE

Other things observed:

- [x] * Option to install agent should be disabled (debug difference with jolokia) - ***see below****
- [x] * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
- [x] * SLF4J(W): No SLF4J providers were found. ***OK for now, can investigate more later***
SLF4J(W): Defaulting to no-operation (NOP) logger implementation
SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
- [x] Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)

-------------

Commit messages:
 - JMC-8237: Updated bundle version to 10.0.0. Updated copyright year
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - JMC-8237: Upgrade to jolokia 2.2.2
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - JMC-8237: Fixed spotbugs issue
 - JMC-8237: Remove unused message
 - JMC-8237: Removed JVM info from descriptor - follow up
 - JMC-8237: Removed JVM info from descriptor as it will be interpreted as a local JVM
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - ... and 12 more: https://git.openjdk.org/jmc/compare/ff9adf57...ca1ee0a6

Changes: https://git.openjdk.org/jmc/pull/576/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=576&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8237
  Stats: 2457 lines in 62 files changed: 2416 ins; 0 del; 41 mod
  Patch: https://git.openjdk.org/jmc/pull/576.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/576/head:pull/576

PR: https://git.openjdk.org/jmc/pull/576

From duke at openjdk.org  Sun Feb 16 22:25:56 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Sun, 16 Feb 2025 22:25:56 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy
In-Reply-To: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
Message-ID: <oo0NcnFSps1-xfntzrEulecApihG26BO0yYJzmattwk=.ffbe4451-e4b5-425c-bf51-9dce2dc1d587@github.com>

On Sun, 4 Aug 2024 12:05:24 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.
> 
> Testing connectivity:
> - [x]  Docker desktop kubernetes 
> - [x]  Azure AKS
> - [x]  Amazon EKS
> - [x]  Google GKE
> 
> Other things observed:
> 
> - [x] * Option to install agent should be disabled (debug difference with jolokia) - ***see below****
> - [x] * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
> - [x] * SLF4J(W): No SLF4J providers were found. ***OK for now, can investigate more later***
> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
> - [x] Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)

The cause for the log initialization output is calling `Utils.getSystemPropertyOrEnvVar` . That is only used very briefly for that very particular use. Can look for alternatives.

Found the "issue" with the JMC agent. 

`	public boolean isLocalJvm() {
		return connectionHandle.getServerDescriptor().getJvmInfo() != null;
	}`
Will experiment with not providing getJvmInfo for jolokia and kubernetes

Finding on the Jolokia side. When probing connection k8s API authorization is missing. This can be fixed by using fabric8 http client instead of using OK Http directly.

Have been able to fix kubernetes client in Jolokia, however basic auth for jolokia with special header fails.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/576#issuecomment-2439913142
PR Comment: https://git.openjdk.org/jmc/pull/576#issuecomment-2445352245
PR Comment: https://git.openjdk.org/jmc/pull/576#issuecomment-2568151073
PR Comment: https://git.openjdk.org/jmc/pull/576#issuecomment-2568962412

From duke at openjdk.org  Sun Feb 16 22:25:56 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Sun, 16 Feb 2025 22:25:56 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy
In-Reply-To: <oo0NcnFSps1-xfntzrEulecApihG26BO0yYJzmattwk=.ffbe4451-e4b5-425c-bf51-9dce2dc1d587@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
 <oo0NcnFSps1-xfntzrEulecApihG26BO0yYJzmattwk=.ffbe4451-e4b5-425c-bf51-9dce2dc1d587@github.com>
Message-ID: <-mZkN0Rm-orZMrtWff2G1gIaIl6X2sjlttbSdetPRA4=.53c8a46e-e630-4773-9f28-75dd489b5e9c@github.com>

On Sun, 27 Oct 2024 08:53:39 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> The cause for the log initialization output is calling `Utils.getSystemPropertyOrEnvVar` . That is only used very briefly for that very particular use. Can look for alternatives.

However, other fabric8.io methods need slf4j quite immediately after that. As the log statement states, it will default to a NOOP logger that we believe is sufficient at this point (problems scanning contexts will manifest themselves as exceptions that should be sufficient to troubleshoot).

-------------

PR Comment: https://git.openjdk.org/jmc/pull/576#issuecomment-2442236979

From duke at openjdk.org  Sun Feb 16 22:29:57 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Sun, 16 Feb 2025 22:29:57 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy [v2]
In-Reply-To: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
Message-ID: <0T9ibz6IERFA2LVMO7qSAZue7azRy3Sqj--dSTNt3Gc=.3e3bf886-befa-4ef5-83eb-b24991b09ab6@github.com>

> JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.
> 
> Testing connectivity:
> - [x]  Docker desktop kubernetes 
> - [x]  Azure AKS
> - [x]  Amazon EKS
> - [x]  Google GKE
> 
> Other things observed:
> 
> - [x] * Option to install agent should be disabled (debug difference with jolokia) - ***see below****
> - [x] * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
> - [x] * SLF4J(W): No SLF4J providers were found. ***OK for now, can investigate more later***
> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
> - [x] Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-8237: Remove unneeded changes

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/576/files
  - new: https://git.openjdk.org/jmc/pull/576/files/ca1ee0a6..3cc408ef

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=576&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=576&range=00-01

  Stats: 37 lines in 6 files changed: 0 ins; 18 del; 19 mod
  Patch: https://git.openjdk.org/jmc/pull/576.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/576/head:pull/576

PR: https://git.openjdk.org/jmc/pull/576

From hdafgard at openjdk.org  Mon Feb 17 18:50:19 2025
From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Mon, 17 Feb 2025 18:50:19 GMT
Subject: RFR: 8297: Update OptionsCheckRule for new JDK releases
In-Reply-To: <qmPbO9Ua_5pp3bzWVxs8Awl4cYa39Iw4KMixnzShVyQ=.5e139eae-3927-4c23-98d8-e68306acbcec@github.com>
References: <qmPbO9Ua_5pp3bzWVxs8Awl4cYa39Iw4KMixnzShVyQ=.5e139eae-3927-4c23-98d8-e68306acbcec@github.com>
Message-ID: <QMMexB413-KypdcHz5jel98VzDbynSoSL2LIjM-5Vlw=.2a0fa0ab-895a-45a5-88e4-3e84fd4bb136@github.com>

On Sat, 18 Jan 2025 14:04:34 GMT, Hendrik Schick <duke at openjdk.org> wrote:

> New cli-options were added for JDK release 22, 23 based on the official release notes (removed part and deprecated path)
> https://www.oracle.com/java/technologies/javase/22-relnote-issues.html
> https://www.oracle.com/java/technologies/javase/23-relnote-issues.html 
> 
> I also updated existing depcrecated options in the array based on 
> this file in the jdk https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/arguments.cpp#L516 which is regularly updated, i switched between git tags to find earlier options when they were part of the array. I did this to jdk10, but not before jdk version 10 for everything i could find. I can also update the arguments, which were obsoleted in jdk9.
> 
> Any feedback appreciated, thank you.

Marked as reviewed by hdafgard (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/625#pullrequestreview-2621792055

From duke at openjdk.org  Tue Feb 18 19:47:00 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Tue, 18 Feb 2025 19:47:00 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy [v2]
In-Reply-To: <0T9ibz6IERFA2LVMO7qSAZue7azRy3Sqj--dSTNt3Gc=.3e3bf886-befa-4ef5-83eb-b24991b09ab6@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
 <0T9ibz6IERFA2LVMO7qSAZue7azRy3Sqj--dSTNt3Gc=.3e3bf886-befa-4ef5-83eb-b24991b09ab6@github.com>
Message-ID: <rxK1pYI2zsK6WMkZ2o0sI6pktiPFNaWUyTusXhR2-xw=.2dc73e03-5c8a-467f-914f-26763fc5cb0d@github.com>

On Sun, 16 Feb 2025 22:29:57 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.
>> 
>> Testing connectivity:
>> - [x]  Docker desktop kubernetes 
>> - [x]  Azure AKS
>> - [x]  Amazon EKS
>> - [x]  Google GKE
>> 
>> Other things observed:
>> 
>> - [x] * Option to install agent should be disabled (debug difference with jolokia) - ***see below****
>> - [x] * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
>> - [x] * SLF4J(W): No SLF4J providers were found. ***OK for now, can investigate more later***
>> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
>> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
>> - [x] Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JMC-8237: Remove unneeded changes

@aptmac : At long last the pieces are falling into place here. I will consider upgrading to jolokia 2.2.3 once it is out, but it is already possible to look at it and test.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/576#issuecomment-2666780377