From duke at openjdk.org  Tue Jul  1 09:59:47 2025
From: duke at openjdk.org (duke)
Date: Tue, 1 Jul 2025 09:59:47 GMT
Subject: RFR: 8396: OptionsCheckRule has doesn't recognize
 HeapDumpOnOutOfMemoryError
In-Reply-To: <LZQBLBC3GmXV94tQHfpheeSskB7I3GjpVMj-Of4rBzk=.bc3f20a9-f3d7-4229-b8c0-bccadbb82d72@github.com>
References: <LZQBLBC3GmXV94tQHfpheeSskB7I3GjpVMj-Of4rBzk=.bc3f20a9-f3d7-4229-b8c0-bccadbb82d72@github.com>
Message-ID: <3Mhb8iQPubiVTerG3HML5A7Ygffu9huMhjWF-MVlHtM=.4f617085-129e-45db-8586-fc886ad87e1f@github.com>

On Thu, 1 May 2025 10:12:32 GMT, Ivo Anjo <duke at openjdk.org> wrote:

> I noticed that `HeapDumpOnOutOfMemoryError` was showing up as an undocumented rule, and that seemed a bit surprising.
> 
> On a closer look, it's even documented on the exact link https://docs.oracle.com/javase/8/docs/technotes/tools/windows/java.html used as the source for the `JAVA_8_DOCUMENTED_XX`.
> 
> I googled and I don't think this option ever had another name, so it looks like a copy-paste accident or something like that?
> 
> I've submitted the needed docs for the OCA so I'm opening the PR for now and hopefully that will all be in good shape soon.

@ivoanjo 
Your change (at version b5b46c862a92f14c57eee593e2f3d6647b427d32) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/646#issuecomment-3023108820

From duke at openjdk.org  Wed Jul  2 17:07:46 2025
From: duke at openjdk.org (Ivo Anjo)
Date: Wed, 2 Jul 2025 17:07:46 GMT
Subject: Integrated: 8396: OptionsCheckRule has doesn't recognize
 HeapDumpOnOutOfMemoryError
In-Reply-To: <LZQBLBC3GmXV94tQHfpheeSskB7I3GjpVMj-Of4rBzk=.bc3f20a9-f3d7-4229-b8c0-bccadbb82d72@github.com>
References: <LZQBLBC3GmXV94tQHfpheeSskB7I3GjpVMj-Of4rBzk=.bc3f20a9-f3d7-4229-b8c0-bccadbb82d72@github.com>
Message-ID: <wjLStqKvkrhPuRXjqbbEUN1rwxRTrjpJZHZIx0NGyqA=.b3e0069f-0e18-40ab-b919-e1da9f20c42e@github.com>

On Thu, 1 May 2025 10:12:32 GMT, Ivo Anjo <duke at openjdk.org> wrote:

> I noticed that `HeapDumpOnOutOfMemoryError` was showing up as an undocumented rule, and that seemed a bit surprising.
> 
> On a closer look, it's even documented on the exact link https://docs.oracle.com/javase/8/docs/technotes/tools/windows/java.html used as the source for the `JAVA_8_DOCUMENTED_XX`.
> 
> I googled and I don't think this option ever had another name, so it looks like a copy-paste accident or something like that?
> 
> I've submitted the needed docs for the OCA so I'm opening the PR for now and hopefully that will all be in good shape soon.

This pull request has now been integrated.

Changeset: dd6fd901
Author:    Ivo Anjo <ivo.anjo at datadoghq.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/dd6fd901e3ee4fdd766a2b4dfe43bcc1388fbf2a
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8396: OptionsCheckRule has doesn't recognize HeapDumpOnOutOfMemoryError

Reviewed-by: hdafgard, hirt

-------------

PR: https://git.openjdk.org/jmc/pull/646

From hirt at openjdk.org  Thu Jul  3 19:02:28 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 3 Jul 2025 19:02:28 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames
Message-ID: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>

Alternative solution.

-------------

Commit messages:
 - Always get specific test resources by name
 - Forgotten properties file
 - Cleanup and fix
 - Copyright
 - Copyright
 - Better variant, with tests
 - Slightly better variant
 - 8371: Hidden Frames, first attempt

Changes: https://git.openjdk.org/jmc/pull/657/files
  Webrev: Webrev is not available because diff is too large
  Issue: https://bugs.openjdk.org/browse/JMC-8371
  Stats: 2179085 lines in 70 files changed: 2178515 ins; 504 del; 66 mod
  Patch: https://git.openjdk.org/jmc/pull/657.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/657/head:pull/657

PR: https://git.openjdk.org/jmc/pull/657

From schaturvedi at openjdk.org  Thu Jul  3 19:02:28 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 3 Jul 2025 19:02:28 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames
In-Reply-To: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
References: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
Message-ID: <938MOIMfHNlfjQztKU8wKeF-YEaLq4JpuENEf9SbuD4=.70d2723e-1502-4ffa-9770-919b31898c86@github.com>

On Sat, 28 Jun 2025 20:23:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Alternative solution.

I have experimented with this code. 

1. I am not able to build it completely as there are test failures. I had to skip tests in order to build it successfully.
2. It seems message.properties change is missed thats why the text is not rendered properly. Attaching screenshot here:
 <img width="678" alt="JMCPreferenceScreen" src="https://github.com/user-attachments/assets/496543f0-60a9-42cd-bc68-e8e5a5fec25a" />

3. I have tested Stacktrace view (For Method Profiling Screen) and Automated Analysis Page (For a JFR which has 2 rules (Allocation class and Allocation Thread) showing hidden frames as part of their results). They worked perfectly fine with checkbox - checked and unchecked (tried changing the preference on the fly also).

Overall the code changes looks good to me. But I am not very sure about it effects (or side effects) at all other places. We would need a thorough sanity testing to avoid any regression.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/657#issuecomment-3026798702

From hirt at openjdk.org  Thu Jul  3 19:02:28 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 3 Jul 2025 19:02:28 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames
In-Reply-To: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
References: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
Message-ID: <JVxmGmPny8sat9-GtOdth-ZEMVaYuxBm4UXbyiWtUhE=.75e6e0a1-17bd-42e8-80cc-aba1f5aaf3dc@github.com>

On Sat, 28 Jun 2025 20:23:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Alternative solution.

This is very strange - the Mac tests fail on starting the p2 server. Everything passes on Linux and Windows. It is seemingly unrelated to my changes, as I haven't changed any pom files. @viragpurnam, do you have any idea?

Error: ] Some problems were encountered while processing the POMs:
Error:  'version' must be a constant version but is '${revision}${changelist}'. @ line 41, column 11
 @ 
Error:  The build could not read 1 project -> [Help 1]
Error:    
Error:    The project org.openjdk.jmc:external-dependencies:${revision}${changelist} (/Users/runner/work/jmc/jmc/releng/third-party/pom.xml) has 1 error
Error:      'version' must be a constant version but is '${revision}${changelist}'. @ line 41, column 11
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
Error: Process completed with exit code 1.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/657#issuecomment-3033216568

From hirt at openjdk.org  Thu Jul  3 20:38:22 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 3 Jul 2025 20:38:22 GMT
Subject: RFR: 8409: Create 9.1.1 release notes
Message-ID: <UwDnpi3tyzUEfYxGVg6Dwn1L-YmUdYCZN4bNTzb1qf4=.bc20fab4-7631-4f19-8803-d227760a10a2@github.com>

Release notes for the micro release.

-------------

Commit messages:
 - 8409: 9.1.1 Release Notes

Changes: https://git.openjdk.org/jmc/pull/658/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=658&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8409
  Stats: 43 lines in 8 files changed: 41 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/658.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/658/head:pull/658

PR: https://git.openjdk.org/jmc/pull/658

From vpurnam at openjdk.org  Fri Jul  4 07:49:24 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Fri, 4 Jul 2025 07:49:24 GMT
Subject: RFR: 8410: Update version for 9.1.1 release
Message-ID: <miTDP7w0AtEeTJeV0TVtKAtrlAynBChqIM0YXThHuFo=.836653bd-44b4-4f4d-bd88-25196ed55616@github.com>

Updated version from 9.1.0 to 9.1.1 for JMC micro release.

-------------

Commit messages:
 - 8410: hardcoded version in pom
 - 8410: Update version for 9.1.1 release

Changes: https://git.openjdk.org/jmc/pull/659/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=659&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8410
  Stats: 217 lines in 152 files changed: 0 ins; 0 del; 217 mod
  Patch: https://git.openjdk.org/jmc/pull/659.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/659/head:pull/659

PR: https://git.openjdk.org/jmc/pull/659

From hirt at openjdk.org  Fri Jul  4 08:02:47 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 4 Jul 2025 08:02:47 GMT
Subject: RFR: 8410: Update version for 9.1.1 release
In-Reply-To: <miTDP7w0AtEeTJeV0TVtKAtrlAynBChqIM0YXThHuFo=.836653bd-44b4-4f4d-bd88-25196ed55616@github.com>
References: <miTDP7w0AtEeTJeV0TVtKAtrlAynBChqIM0YXThHuFo=.836653bd-44b4-4f4d-bd88-25196ed55616@github.com>
Message-ID: <zFBrLhtp0wHcVpd_SFxvAw0uBHAfYWpvKllO7VSKvCA=.170bdb23-45ec-464f-a07a-cdc6459c5b43@github.com>

On Fri, 4 Jul 2025 07:44:14 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> Updated version from 9.1.0 to 9.1.1 for JMC micro release.

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/659#pullrequestreview-2986010035

From vpurnam at openjdk.org  Fri Jul  4 08:10:47 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Fri, 4 Jul 2025 08:10:47 GMT
Subject: Integrated: 8410: Update version for 9.1.1 release
In-Reply-To: <miTDP7w0AtEeTJeV0TVtKAtrlAynBChqIM0YXThHuFo=.836653bd-44b4-4f4d-bd88-25196ed55616@github.com>
References: <miTDP7w0AtEeTJeV0TVtKAtrlAynBChqIM0YXThHuFo=.836653bd-44b4-4f4d-bd88-25196ed55616@github.com>
Message-ID: <hD6blUJnqmdhcq1aZvY9Kl7cZt6_v8dFr-5vZ_SnReU=.6778f7b7-ce86-4ec4-ab7a-1198d9a2526b@github.com>

On Fri, 4 Jul 2025 07:44:14 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> Updated version from 9.1.0 to 9.1.1 for JMC micro release.

This pull request has now been integrated.

Changeset: 5d9978f0
Author:    Virag Purnam <vpurnam at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/5d9978f0741be601ed08db62d36b8f1658f264c4
Stats:     217 lines in 152 files changed: 0 ins; 0 del; 217 mod

8410: Update version for 9.1.1 release

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/659

From hirt at openjdk.org  Fri Jul  4 08:12:46 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 4 Jul 2025 08:12:46 GMT
Subject: RFR: 8409: Create 9.1.1 release notes
In-Reply-To: <UwDnpi3tyzUEfYxGVg6Dwn1L-YmUdYCZN4bNTzb1qf4=.bc20fab4-7631-4f19-8803-d227760a10a2@github.com>
References: <UwDnpi3tyzUEfYxGVg6Dwn1L-YmUdYCZN4bNTzb1qf4=.bc20fab4-7631-4f19-8803-d227760a10a2@github.com>
Message-ID: <sE50jdoZwgs0QMrW8yjt3-FEJNl6SaQ-uzFunH_Ug5Q=.ea564e15-60f7-4f93-8628-caab1f9f39ce@github.com>

On Thu, 3 Jul 2025 20:33:39 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Release notes for the micro release.

The failure is the same as in #657, which is clearly unrelated. I think it is fine to accept PRs that has this error, but which passes on both Windows and Ubuntu until we've solved it. Interim solution suggested by @viragpurnam is to hard code the version in the third party POM.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/658#issuecomment-3034921084

From hirt at openjdk.org  Fri Jul  4 08:17:46 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 4 Jul 2025 08:17:46 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames
In-Reply-To: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
References: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
Message-ID: <HgXSmDe9NMZUhr5DjfDGLUnmflmE_ekAb3BQtjTziNs=.c162ada0-87b4-4f91-89a0-051e296b7fc7@github.com>

On Sat, 28 Jun 2025 20:23:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Alternative solution.

With #658 it is clear that the failure is CI-related, and unrelated to this change.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/657#issuecomment-3034932102

From vpurnam at openjdk.org  Fri Jul  4 08:18:45 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Fri, 4 Jul 2025 08:18:45 GMT
Subject: RFR: 8409: Create 9.1.1 release notes
In-Reply-To: <UwDnpi3tyzUEfYxGVg6Dwn1L-YmUdYCZN4bNTzb1qf4=.bc20fab4-7631-4f19-8803-d227760a10a2@github.com>
References: <UwDnpi3tyzUEfYxGVg6Dwn1L-YmUdYCZN4bNTzb1qf4=.bc20fab4-7631-4f19-8803-d227760a10a2@github.com>
Message-ID: <1s7UB9VAmQDTS7jEQ-CXvcB1fjv-HKtpScCEr7xawcU=.78bc9fee-edd8-4e11-a815-b47d329b5a47@github.com>

On Thu, 3 Jul 2025 20:33:39 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Release notes for the micro release.

Looks good.

-------------

Marked as reviewed by vpurnam (Reviewer).

PR Review: https://git.openjdk.org/jmc/pull/658#pullrequestreview-2986048365

From hirt at openjdk.org  Fri Jul  4 13:30:45 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 4 Jul 2025 13:30:45 GMT
Subject: Integrated: 8409: Create 9.1.1 release notes
In-Reply-To: <UwDnpi3tyzUEfYxGVg6Dwn1L-YmUdYCZN4bNTzb1qf4=.bc20fab4-7631-4f19-8803-d227760a10a2@github.com>
References: <UwDnpi3tyzUEfYxGVg6Dwn1L-YmUdYCZN4bNTzb1qf4=.bc20fab4-7631-4f19-8803-d227760a10a2@github.com>
Message-ID: <N9ttjo9OxUGAmh8Ns_SHpHK8YRhIYH5-7ufZpEU37ro=.cea5d497-485d-494b-93ba-f5a03cdff04b@github.com>

On Thu, 3 Jul 2025 20:33:39 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Release notes for the micro release.

This pull request has now been integrated.

Changeset: 3d521484
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/3d5214841c2a78f85f64a234031239a3335f1257
Stats:     43 lines in 8 files changed: 41 ins; 0 del; 2 mod

8409: Create 9.1.1 release notes

Reviewed-by: vpurnam

-------------

PR: https://git.openjdk.org/jmc/pull/658

From duke at openjdk.org  Fri Jul  4 14:18:31 2025
From: duke at openjdk.org (duke)
Date: Fri, 4 Jul 2025 14:18:31 GMT
Subject: git: openjdk/jmc: Added tag 9.1.1-rc for changeset 3d521484
Message-ID: <b64e275f-f74d-49ab-9584-613557217220@openjdk.org>

Tagged by: thegreystone <marcus at hirt.se>
Date:      2025-07-04 16:17:11 +0000

Release candidate for JMC 9.1.1
Changeset: 3d521484
Author:    Marcus Hirt <hirt at openjdk.org>
Date:      2025-07-04 13:28:06 +0000
URL:       https://git.openjdk.org/jmc/commit/3d5214841c2a78f85f64a234031239a3335f1257


From aptmac at openjdk.org  Fri Jul  4 17:06:44 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 4 Jul 2025 17:06:44 GMT
Subject: RFR: 8400: Add more show options for JMX Console graphs [v2]
In-Reply-To: <e-PbNrq0v1duCCPuj97L5YtLn6j2haQCvKXPXdahzMA=.f3ba6e96-634f-4248-88ae-0c19ab20a9f8@github.com>
References: <PlUXb8yV51V5BufXknA-MuDQLCR47tOXQXPUZU4Zo1Q=.af52bece-24ae-45d3-a0ca-f902fbdde4d0@github.com>
 <e-PbNrq0v1duCCPuj97L5YtLn6j2haQCvKXPXdahzMA=.f3ba6e96-634f-4248-88ae-0c19ab20a9f8@github.com>
Message-ID: <eAUoPe8GE_gmYNlqUK2JU3FQnxW93oArH3ikUfdkjXY=.4554b1af-6a92-4e4a-90d6-57fc0f9b3b52@github.com>

On Sat, 31 May 2025 22:41:10 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also cleaning up a little bit. There were some assumptions around the default XY chart that should be put in code etc.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Spotless

application/org.openjdk.jmc.greychart.ui/src/main/java/org/openjdk/jmc/greychart/ui/views/ChartMenuBuilder.java line 469:

> 467: 			getShell().setText(Messages.CustomTimeRangeDialog_TITLE);
> 468: 			Control contents = super.createContents(parent);
> 469: 			contents.getShell().setSize(450, 300);

Gave this a try on my Linux machine, and the controls get cut-off horizontally a bit early. It will need another 100px on the width. 

![Screenshot From 2025-07-04 12-06-43](https://github.com/user-attachments/assets/aeed48d6-a7f9-47da-9b45-316e4f41a937)

An alternative could be to allow these dialogs to be resized. To do so, the `isResizable()` on the dialog class can be overriden as follows:

@Override
protected boolean isResizable() {
	return true;
}

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/652#discussion_r2185797626

From hirt at openjdk.org  Mon Jul  7 14:48:58 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 7 Jul 2025 14:48:58 GMT
Subject: RFR: 8415: Spotless error in the main branch
Message-ID: <W4aU_AlDR3YST5J9XV92gteUTlxqmF2McbY1djemkp4=.c840bcfb-6ba9-46f0-9207-684de21b84f8@github.com>

A spotless error snuck in with a recent commit. This is fixing it. Note that the strange Mac CI problem is still there, so I am also hard coding the version in the third-party pom until we have a proper fix.

-------------

Commit messages:
 - Fixing Mac CI problem
 - Fixing spotless problem

Changes: https://git.openjdk.org/jmc/pull/661/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=661&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8415
  Stats: 17 lines in 2 files changed: 0 ins; 0 del; 17 mod
  Patch: https://git.openjdk.org/jmc/pull/661.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/661/head:pull/661

PR: https://git.openjdk.org/jmc/pull/661

From aptmac at openjdk.org  Mon Jul  7 15:11:47 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Mon, 7 Jul 2025 15:11:47 GMT
Subject: RFR: 8415: Spotless error in the main branch
In-Reply-To: <W4aU_AlDR3YST5J9XV92gteUTlxqmF2McbY1djemkp4=.c840bcfb-6ba9-46f0-9207-684de21b84f8@github.com>
References: <W4aU_AlDR3YST5J9XV92gteUTlxqmF2McbY1djemkp4=.c840bcfb-6ba9-46f0-9207-684de21b84f8@github.com>
Message-ID: <U75QAbM46MR_cV--wcUOLrib8pEKiH5bYcm-ZsiQB6A=.ffb1acf9-309a-4cbe-8db7-14c58e1805b0@github.com>

On Mon, 7 Jul 2025 14:43:39 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> A spotless error snuck in with a recent commit. This is fixing it. Note that the strange Mac CI problem is still there, so I am also hard coding the version in the third-party pom until we have a proper fix.

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/661#pullrequestreview-2994287438

From schaturvedi at openjdk.org  Mon Jul  7 18:35:47 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Mon, 7 Jul 2025 18:35:47 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames
In-Reply-To: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
References: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
Message-ID: <3Ok6VlVNRehjLh0D_09e9OenYvTRPX3b656EtamRM2k=.39ac4ff9-7695-48e2-844c-9de73dc29c6a@github.com>

On Sat, 28 Jun 2025 20:23:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Alternative solution.

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/StructTypes.java line 779:

> 777: 		}
> 778: 	}
> 779: 

Minor nit : one extra line here. However no other change in this file.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/657#discussion_r2190790092

From hirt at openjdk.org  Tue Jul  8 21:38:00 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 8 Jul 2025 21:38:00 GMT
Subject: RFR: 8400: Add more show options for JMX Console graphs [v3]
In-Reply-To: <PlUXb8yV51V5BufXknA-MuDQLCR47tOXQXPUZU4Zo1Q=.af52bece-24ae-45d3-a0ca-f902fbdde4d0@github.com>
References: <PlUXb8yV51V5BufXknA-MuDQLCR47tOXQXPUZU4Zo1Q=.af52bece-24ae-45d3-a0ca-f902fbdde4d0@github.com>
Message-ID: <Zg2ZaBuT9-6teBBVjrthyzKyREwMvyIKIqA8ABFEeKc=.f25075ab-f303-4b8b-8fde-380460cddc42@github.com>

> Also cleaning up a little bit. There were some assumptions around the default XY chart that should be put in code etc.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  More space for Linux, resizable and grabbing existing space

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/652/files
  - new: https://git.openjdk.org/jmc/pull/652/files/8cb62f9b..45830ad9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=652&range=02
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=652&range=01-02

  Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/652.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/652/head:pull/652

PR: https://git.openjdk.org/jmc/pull/652

From hirt at openjdk.org  Tue Jul  8 21:38:00 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 8 Jul 2025 21:38:00 GMT
Subject: RFR: 8400: Add more show options for JMX Console graphs [v2]
In-Reply-To: <eAUoPe8GE_gmYNlqUK2JU3FQnxW93oArH3ikUfdkjXY=.4554b1af-6a92-4e4a-90d6-57fc0f9b3b52@github.com>
References: <PlUXb8yV51V5BufXknA-MuDQLCR47tOXQXPUZU4Zo1Q=.af52bece-24ae-45d3-a0ca-f902fbdde4d0@github.com>
 <e-PbNrq0v1duCCPuj97L5YtLn6j2haQCvKXPXdahzMA=.f3ba6e96-634f-4248-88ae-0c19ab20a9f8@github.com>
 <eAUoPe8GE_gmYNlqUK2JU3FQnxW93oArH3ikUfdkjXY=.4554b1af-6a92-4e4a-90d6-57fc0f9b3b52@github.com>
Message-ID: <PTabtoMkf3gjLrrs5hjKuhYOXri3FfuRO2MkIN81grY=.efeb5952-9b4d-4b60-aad7-b3fbad3d9d29@github.com>

On Fri, 4 Jul 2025 17:04:00 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Spotless
>
> application/org.openjdk.jmc.greychart.ui/src/main/java/org/openjdk/jmc/greychart/ui/views/ChartMenuBuilder.java line 469:
> 
>> 467: 			getShell().setText(Messages.CustomTimeRangeDialog_TITLE);
>> 468: 			Control contents = super.createContents(parent);
>> 469: 			contents.getShell().setSize(450, 300);
> 
> Gave this a try on my Linux machine, and the controls get cut-off horizontally a bit early. It will need another 100px on the width. 
> 
> ![Screenshot From 2025-07-04 12-06-43](https://github.com/user-attachments/assets/aeed48d6-a7f9-47da-9b45-316e4f41a937)
> 
> An alternative could be to allow these dialogs to be resized. To do so, the `isResizable()` on the dialog class can be overriden as follows:
> 
> @Override
> protected boolean isResizable() {
> 	return true;
> }

A combination seems right - give it a bit more space, and also allow for it to be resized. Also, it should grab the existing space, like in the Dump Recording Wizard.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/652#discussion_r2193480170

From hirt at openjdk.org  Tue Jul  8 21:44:46 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 8 Jul 2025 21:44:46 GMT
Subject: RFR: 8400: Add more show options for JMX Console graphs [v3]
In-Reply-To: <Zg2ZaBuT9-6teBBVjrthyzKyREwMvyIKIqA8ABFEeKc=.f25075ab-f303-4b8b-8fde-380460cddc42@github.com>
References: <PlUXb8yV51V5BufXknA-MuDQLCR47tOXQXPUZU4Zo1Q=.af52bece-24ae-45d3-a0ca-f902fbdde4d0@github.com>
 <Zg2ZaBuT9-6teBBVjrthyzKyREwMvyIKIqA8ABFEeKc=.f25075ab-f303-4b8b-8fde-380460cddc42@github.com>
Message-ID: <fJ5ApPk9WHbhFjhaaV51wNH7QfFVhFLiRJfoTGIcXkE=.733e2373-f209-4793-a721-8cd0402f7740@github.com>

On Tue, 8 Jul 2025 21:38:00 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also cleaning up a little bit. There were some assumptions around the default XY chart that should be put in code etc.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More space for Linux, resizable and grabbing existing space

Don't worry about the failed MacOS test - that has been fixed in the main branch. This PR was opened before #661, and all should be fine when integrated.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/652#issuecomment-3050374799

From schaturvedi at openjdk.org  Wed Jul  9 04:00:46 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Wed, 9 Jul 2025 04:00:46 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames
In-Reply-To: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
References: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
Message-ID: <KXGua9m0q1Szj31hW465oIesUohBUjtNLFsSjPAe8Uw=.41780c5f-50d5-4c6c-9865-243d81a6a4fc@github.com>

On Sat, 28 Jun 2025 20:23:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Alternative solution.

Looks good to me.

-------------

Marked as reviewed by schaturvedi (Committer).

PR Review: https://git.openjdk.org/jmc/pull/657#pullrequestreview-2999871667

From schaturvedi at openjdk.org  Wed Jul  9 14:22:04 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Wed, 9 Jul 2025 14:22:04 GMT
Subject: RFR: 6203: Add ZGC allocation stall rule
Message-ID: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>

This enhancement is to add new rule for ZGC Allocation Stall events.

The default configuration:
 
<img width="946" alt="image" src="https://github.com/user-attachments/assets/0d39ae26-fdc4-49e3-a0ed-fb7f7da8f709" />

Here are few screenshots for reference:

<img width="344" alt="image" src="https://github.com/user-attachments/assets/e7efe1e2-d6b3-4a05-8ea6-1bf2e8b8c15f" />

-------------

Commit messages:
 - 6203: Add ZGC allocation stall rule

Changes: https://git.openjdk.org/jmc/pull/664/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=664&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-6203
  Stats: 307 lines in 11 files changed: 303 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jmc/pull/664.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/664/head:pull/664

PR: https://git.openjdk.org/jmc/pull/664

From duke at openjdk.org  Fri Jul 11 17:14:59 2025
From: duke at openjdk.org (duke)
Date: Fri, 11 Jul 2025 17:14:59 GMT
Subject: git: openjdk/jmc: Added tag 9.1.1-ga for changeset 3d521484
Message-ID: <f12f1c02-5b70-4289-8883-2abf60d02143@openjdk.org>

Tagged by: thegreystone <marcus at hirt.se>
Date:      2025-07-11 19:13:44 +0000

GA source release for JMC 9.1.1
Changeset: 3d521484
Author:    Marcus Hirt <hirt at openjdk.org>
Date:      2025-07-04 13:28:06 +0000
URL:       https://git.openjdk.org/jmc/commit/3d5214841c2a78f85f64a234031239a3335f1257


From hirt at openjdk.org  Sat Jul 12 20:48:48 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Sat, 12 Jul 2025 20:48:48 GMT
Subject: Integrated: 8371: Stacktrace should hide hidden frames
In-Reply-To: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
References: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
Message-ID: <XYlpjNAKS72IXpwktanhGKXvVnGJuyceV0qrgxYpWsI=.31fbb2bc-2b45-4eac-bc84-1b82ed2eb88e@github.com>

On Sat, 28 Jun 2025 20:23:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Alternative solution.

This pull request has now been integrated.

Changeset: 1413e741
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/1413e74127d0daaedfb5dfd2019fc633cfca3f74
Stats:     2179085 lines in 70 files changed: 2178515 ins; 504 del; 66 mod

8371: Stacktrace should hide hidden frames

Reviewed-by: schaturvedi

-------------

PR: https://git.openjdk.org/jmc/pull/657

From schaturvedi at openjdk.org  Sun Jul 13 05:29:46 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sun, 13 Jul 2025 05:29:46 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames [v2]
In-Reply-To: <zwZUXIU-_LWmwHZlqjzKBXnPHxnDTlRNiNUz3OX2in0=.df89bdb5-7077-4139-b64b-180596284375@github.com>
References: <M5DHZ4xosLSMZnPb7jpkjqChkRXMPVXboyGCSZm3aPM=.31fcc88e-afe2-432e-bf2a-1781b202c886@github.com>
 <zwZUXIU-_LWmwHZlqjzKBXnPHxnDTlRNiNUz3OX2in0=.df89bdb5-7077-4139-b64b-180596284375@github.com>
Message-ID: <uvQWTOnanmWkhrvcWw8CaLIRILAV6M7tGQyUHd3Z7bE=.795c24bd-c28b-4406-8966-6c45f835bf95@github.com>

On Fri, 11 Apr 2025 10:51:28 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> JFR tool is hiding all the hidden frames. But in JMC, Stacktrace view is still showing lot of hidden methods which is not required from the users point of view. Hence, we will be hiding all the hidden frames as part of this enhancement.
>> 
>> Also, we have updated some test cases also in order to get rid of hidden frames which were expected by the test cases.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed ArrayList and replaced FOR-loop implementation with Streams

Changes integrated as part of another PR. Hence, closing this PR.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/632#issuecomment-3066613571

From schaturvedi at openjdk.org  Sun Jul 13 05:29:47 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sun, 13 Jul 2025 05:29:47 GMT
Subject: Withdrawn: 8371: Stacktrace should hide hidden frames
In-Reply-To: <M5DHZ4xosLSMZnPb7jpkjqChkRXMPVXboyGCSZm3aPM=.31fcc88e-afe2-432e-bf2a-1781b202c886@github.com>
References: <M5DHZ4xosLSMZnPb7jpkjqChkRXMPVXboyGCSZm3aPM=.31fcc88e-afe2-432e-bf2a-1781b202c886@github.com>
Message-ID: <tfftvBecnLOFW_dj-Z0lHLVvaVO7lv0bXQmLqJVGxTE=.da34ea69-5c17-4bde-8ee1-063c1d9e0534@github.com>

On Tue, 25 Mar 2025 19:27:30 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> JFR tool is hiding all the hidden frames. But in JMC, Stacktrace view is still showing lot of hidden methods which is not required from the users point of view. Hence, we will be hiding all the hidden frames as part of this enhancement.
> 
> Also, we have updated some test cases also in order to get rid of hidden frames which were expected by the test cases.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jmc/pull/632

From hirt at openjdk.org  Mon Jul 14 13:36:53 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 14 Jul 2025 13:36:53 GMT
Subject: RFR: 6203: Add ZGC allocation stall rule
In-Reply-To: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
References: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
Message-ID: <Pc7NvIRc_j2fJ1YG6ALSHpIXdccOXnrTtswIwIkcZN4=.69e46641-21f6-4ea8-a8cc-975b7691a237@github.com>

On Wed, 9 Jul 2025 14:17:10 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This enhancement is to add new rule for ZGC Allocation Stall events.
> 
> The default configuration:
>  
> <img width="946" alt="image" src="https://github.com/user-attachments/assets/0d39ae26-fdc4-49e3-a0ed-fb7f7da8f709" />
> 
> Here are few screenshots for reference:
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/e7efe1e2-d6b3-4a05-8ea6-1bf2e8b8c15f" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/a3d3862f-96d2-4292-947f-4562c7f9f3d3" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/9616eea6-bce8-4395-a846-db343fe349f2" />
> 
> <img width="341" alt="image" src="https://github.com/user-attachments/assets/376a100e-ac05-48fe-a9c3-754923c3d79e" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/cfa7c5f1-08f0-44b4-a49d-28504439a631" />
> 
> Ignored
> 
> <img width="352" alt="image" src="https://github.com/user-attachments/assets/3c00c22e-e64d-46b0-8b64-ed653ed1fc4b" />
> 
> If we change default configuration as below:
> 
> <img width="367" alt="image" src="https://github.com/user-attachments/assets/8da64985-8446-44b8-bfb4-696a726b5255" />
> 
> <img width="350" alt="image" src="https://github.com/user-attachments/assets/ad89f02e-39b4-4df4-aae7-43cec9cc9a91" />
> 
> <img width="347" alt="image" src="https://github.com/user-attachments/assets/b3ec1081-26dd-4391-9e0f-0b4c64a7e3c1" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/106a7c3e-aaaf-495a-8c6f-281c96371e6e" />

I would be wary about making the heuristic dependent on the number of stall events per recording. Perhaps we can find a better thing to look at, that is unrelated to the length of the recording? For example, how long a particular thread has been stalled per minute, or the longest time a thread was stalled (or both)?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/664#issuecomment-3069639323

From jpbempel at openjdk.org  Wed Jul 16 12:00:50 2025
From: jpbempel at openjdk.org (Jean-Philippe Bempel)
Date: Wed, 16 Jul 2025 12:00:50 GMT
Subject: RFR: 6203: Add ZGC allocation stall rule
In-Reply-To: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
References: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
Message-ID: <kPS2VOH3QyiKdT9lTi9VIGEkrx7M0LgfBLEJk1GLCmo=.1dfe7db3-5658-444d-85b0-5a27fd1f2319@github.com>

On Wed, 9 Jul 2025 14:17:10 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This enhancement is to add new rule for ZGC Allocation Stall events.
> 
> The default configuration:
>  
> <img width="946" alt="image" src="https://github.com/user-attachments/assets/0d39ae26-fdc4-49e3-a0ed-fb7f7da8f709" />
> 
> Here are few screenshots for reference:
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/e7efe1e2-d6b3-4a05-8ea6-1bf2e8b8c15f" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/a3d3862f-96d2-4292-947f-4562c7f9f3d3" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/9616eea6-bce8-4395-a846-db343fe349f2" />
> 
> <img width="341" alt="image" src="https://github.com/user-attachments/assets/376a100e-ac05-48fe-a9c3-754923c3d79e" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/cfa7c5f1-08f0-44b4-a49d-28504439a631" />
> 
> Ignored
> 
> <img width="352" alt="image" src="https://github.com/user-attachments/assets/3c00c22e-e64d-46b0-8b64-ed653ed1fc4b" />
> 
> If we change default configuration as below:
> 
> <img width="367" alt="image" src="https://github.com/user-attachments/assets/8da64985-8446-44b8-bfb4-696a726b5255" />
> 
> <img width="350" alt="image" src="https://github.com/user-attachments/assets/ad89f02e-39b4-4df4-aae7-43cec9cc9a91" />
> 
> <img width="347" alt="image" src="https://github.com/user-attachments/assets/b3ec1081-26dd-4391-9e0f-0b4c64a7e3c1" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/106a7c3e-aaaf-495a-8c6f-281c96371e6e" />

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 755:

> 753: VMOperationRuleFactory_TEXT_WARN_LONG_COMBINED_DURATION=There are long lasting blocking VM operations in this recording. The longest was created from multiple close consecutive operations that were of type {longestOperation} and lasted for {longestOperationDuration} in total. They were initiated from thread {longestOperationCaller} and started at {longestOperationStartTime}. VM operations are JVM internal operations. Some VM operations are executed synchronously (i.e. will block the calling thread), and some need to be executed at so called safe points. Safe point polling is a cooperative suspension mechanism that halts byte code execution in the JVM. A VM operation occurring at a safe point will effectively be "stopping the world", meaning that no Java code will be executing in any thread while executing VM operations at that safe point. Long lasting VM operations executing at safe points can decrease the responsiveness of an application. If you do find such VM operations, th
 en the type of operation and its caller thread provide vital information to understand why the VM operation happened. To find more details, check if there is an event in the caller thread intersecting this event time wise. Looking at the stack trace for such an event can help determining what caused it. See [Runtime Overview](http://openjdk.java.net/groups/hotspot/docs/RuntimeOverview.html) for further information.
> 754: ZGCAllocationStall_RULE_NAME=ZGC Allocation Stall
> 755: ZgcAllocationStall_TEXT_INFO=In ZGC, a type of concurrent Garbage Collection (GC) algorithm, GC threads run concurrently with application threads, resulting in minimal stop-the-world pauses. However, because these pauses are so brief, application threads may create objects faster than GC threads can reclaim memory. In such cases, the JVM temporarily stops the application threads from creating new objects. This 'stopping of object creation' is known as an "Allocation Stall." \n Allocation Stall occurs due to following reasons: \n 1. Inefficient GC Algorithm: This is often the primary cause of Allocation Stall. Using a non-optimal GC algorithm or improper GC settings for your application's workload can lead to stalling. Earlier versions of ZGC (i.e. single-generation ZGC algorithm), are more prone to Allocation Stalls. \n 2. High Object Allocation Rate: If your application creates objects at a very high rate, it can overwhelm the GC's ability to reclaim memory quickly enough, le
 ading to stalls.\n 3. Memory Fragmentation: Even if there is free memory, fragmentation in the heap can prevent large objects from being allocated, contributing to Allocation Stalls.\n

> because these pauses are so brief, application threads may create objects faster than GC threads can reclaim memory.

This is not because the pauses are brief that we have stalls. it's just because app threads can create objects faster than the GC cycle is able to release the memory. Purely technically allocating is very cheap, while reclaiming requires to traverse object graph, move objects, plus sometimes less GC threads than app threads allocating.

> Allocation Stall occurs due to following reasons: \n 1. Inefficient GC Algorithm: This is often the primary cause of Allocation Stall. Using a non-optimal GC algorithm or improper GC settings for your application's workload can lead to stalling.

I would write it like this. I prefer to say GC algorithm requires more time to reclaim, and therefore we need either more GC threads and/or more room in the JAva Heap to have more time to reclaim before reaching the heap limit.
Non-generational have a GC cycle longer than generational which contribute to having more stalls (the whole object graph needs to be scan before trying to reclaim memory, while only a fraction for generational). so improper GC settings that's true but I would suggest heap sizing, GC threads, or switching to generational.

> 3. Memory Fragmentation: Even if there is free memory, fragmentation in the heap can prevent large objects from being allocated, contributing to Allocation Stalls.

even if technically it's possible, I am not sure this is a main issue with ZGC.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/664#discussion_r2210166822

From hirt at openjdk.org  Wed Jul 16 12:32:48 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 16 Jul 2025 12:32:48 GMT
Subject: RFR: 6203: Add ZGC allocation stall rule
In-Reply-To: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
References: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
Message-ID: <np8YNZOWHYthgKZ4Xi59sHo_EPwxCFawQKTNpQfV2yc=.85d62399-e988-4bfe-93c2-aedf38a6e5e6@github.com>

On Wed, 9 Jul 2025 14:17:10 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This enhancement is to add new rule for ZGC Allocation Stall events.
> 
> The default configuration:
>  
> <img width="946" alt="image" src="https://github.com/user-attachments/assets/0d39ae26-fdc4-49e3-a0ed-fb7f7da8f709" />
> 
> Here are few screenshots for reference:
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/e7efe1e2-d6b3-4a05-8ea6-1bf2e8b8c15f" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/a3d3862f-96d2-4292-947f-4562c7f9f3d3" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/9616eea6-bce8-4395-a846-db343fe349f2" />
> 
> <img width="341" alt="image" src="https://github.com/user-attachments/assets/376a100e-ac05-48fe-a9c3-754923c3d79e" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/cfa7c5f1-08f0-44b4-a49d-28504439a631" />
> 
> Ignored
> 
> <img width="352" alt="image" src="https://github.com/user-attachments/assets/3c00c22e-e64d-46b0-8b64-ed653ed1fc4b" />
> 
> If we change default configuration as below:
> 
> <img width="367" alt="image" src="https://github.com/user-attachments/assets/8da64985-8446-44b8-bfb4-696a726b5255" />
> 
> <img width="350" alt="image" src="https://github.com/user-attachments/assets/ad89f02e-39b4-4df4-aae7-43cec9cc9a91" />
> 
> <img width="347" alt="image" src="https://github.com/user-attachments/assets/b3ec1081-26dd-4391-9e0f-0b4c64a7e3c1" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/106a7c3e-aaaf-495a-8c6f-281c96371e6e" />

As per the JMC dev slack, perhaps sum of stalled time per minute could be a good one? That one would have to be a rate to be recording length independent. Perhaps also combined with a higher score if very long individual allocation stalls are present?

I also opened https://bugs.openjdk.org/browse/JDK-8362416 to make the rule more useful in case there are a lot of stalls under the default 10ms threshold of the current ZGC Allocation Stall event. We shouldn't block this PR on that work though, but rather ensure we use the new event when available. I will open a new JMC issue to track this.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/664#issuecomment-3078363462

From duke at openjdk.org  Wed Jul 16 15:53:36 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Wed, 16 Jul 2025 15:53:36 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy [v3]
In-Reply-To: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
Message-ID: <8WB1J6rtipX1pYqIrYw7-r8eeSa-7wB2Bh9dHLXJaWA=.e655817d-310f-4764-a47a-af37ce3cae73@github.com>

> JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.
> 
> Testing connectivity:
> - [x]  Docker desktop kubernetes 
> - [x]  Azure AKS
> - [x]  Amazon EKS
> - [x]  Google GKE
> 
> Other things observed:
> 
> - [x] * Option to install agent should be disabled (debug difference with jolokia) - ***see below****
> - [x] * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
> - [x] * SLF4J(W): No SLF4J providers were found. ***OK for now, can investigate more later***
> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
> - [x] Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 27 commits:

 - JMC-8237: Upgrade jolokia 2.2.2 -> 2.2.9
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - JMC-8237: Removed dead assignment
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - JMC-8237: Remove unneeded changes
 - JMC-8237: Updated bundle version to 10.0.0. Updated copyright year
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - JMC-8237: Upgrade to jolokia 2.2.2
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - ... and 17 more: https://git.openjdk.org/jmc/compare/87860cee...690bbbb7

-------------

Changes: https://git.openjdk.org/jmc/pull/576/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=576&range=02
  Stats: 2425 lines in 59 files changed: 2399 ins; 0 del; 26 mod
  Patch: https://git.openjdk.org/jmc/pull/576.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/576/head:pull/576

PR: https://git.openjdk.org/jmc/pull/576

From schaturvedi at openjdk.org  Thu Jul 17 06:40:36 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 17 Jul 2025 06:40:36 GMT
Subject: RFR: 6515: Show virtualization information in JMC
Message-ID: <lKfjiOf42H2BdjBm28a8MMnOq-owZCGOhV6-s4I4Mpg=.6fec180f-32c3-4377-9a59-932e9d0feb91@github.com>

This PR adds Virtualization Information i.e. name (as this is the only information we have as of now) on Environment screen.

The screen looks like this:

<img width="959" height="486" alt="image" src="https://github.com/user-attachments/assets/a05ba14d-c60b-40f3-8432-c1cf57307af4" />


When jdk.VirtualizationInformation event exists:

<img width="226" height="37" alt="image" src="https://github.com/user-attachments/assets/728fc44f-d094-467c-b5b6-3946669859e6" />

When jdk.VirtualizationInformation event doesn't exists:

<img width="161" height="38" alt="image" src="https://github.com/user-attachments/assets/19299a60-ba9d-422f-b31f-894520aebe2c" />

-------------

Commit messages:
 - 6515: Show virtualization information in JMC

Changes: https://git.openjdk.org/jmc/pull/666/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=666&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-6515
  Stats: 12 lines in 8 files changed: 12 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/666.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/666/head:pull/666

PR: https://git.openjdk.org/jmc/pull/666

From aptmac at openjdk.org  Thu Jul 17 13:29:56 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 17 Jul 2025 13:29:56 GMT
Subject: RFR: 6515: Show virtualization information in JMC
In-Reply-To: <lKfjiOf42H2BdjBm28a8MMnOq-owZCGOhV6-s4I4Mpg=.6fec180f-32c3-4377-9a59-932e9d0feb91@github.com>
References: <lKfjiOf42H2BdjBm28a8MMnOq-owZCGOhV6-s4I4Mpg=.6fec180f-32c3-4377-9a59-932e9d0feb91@github.com>
Message-ID: <Y2rE2FX9JWoqejTcnVbCZgYYJumhaeZywB0C-vsEzx0=.c255abe7-d029-432c-9723-3b8aac63fd0b@github.com>

On Thu, 17 Jul 2025 06:34:48 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR adds Virtualization Information i.e. name (as this is the only information we have as of now) on Environment screen.
> 
> The screen looks like this:
> 
> <img width="959" height="486" alt="image" src="https://github.com/user-attachments/assets/a05ba14d-c60b-40f3-8432-c1cf57307af4" />
> 
> 
> When jdk.VirtualizationInformation event exists:
> 
> <img width="226" height="37" alt="image" src="https://github.com/user-attachments/assets/728fc44f-d094-467c-b5b6-3946669859e6" />
> 
> When jdk.VirtualizationInformation event doesn't exists:
> 
> <img width="161" height="38" alt="image" src="https://github.com/user-attachments/assets/19299a60-ba9d-422f-b31f-894520aebe2c" />

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/666#pullrequestreview-3029541987

From hirt at openjdk.org  Thu Jul 17 15:45:55 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 17 Jul 2025 15:45:55 GMT
Subject: RFR: 6515: Show virtualization information in JMC
In-Reply-To: <lKfjiOf42H2BdjBm28a8MMnOq-owZCGOhV6-s4I4Mpg=.6fec180f-32c3-4377-9a59-932e9d0feb91@github.com>
References: <lKfjiOf42H2BdjBm28a8MMnOq-owZCGOhV6-s4I4Mpg=.6fec180f-32c3-4377-9a59-932e9d0feb91@github.com>
Message-ID: <FL_QdBIXHTTbwjsofQMfi5C91XTyXPv333i34uMuS8U=.9a9cc196-dd16-418c-8e48-f4ba641cbaf4@github.com>

On Thu, 17 Jul 2025 06:34:48 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR adds Virtualization Information i.e. name (as this is the only information we have as of now) on Environment screen.
> 
> The screen looks like this:
> 
> <img width="959" height="486" alt="image" src="https://github.com/user-attachments/assets/a05ba14d-c60b-40f3-8432-c1cf57307af4" />
> 
> 
> When jdk.VirtualizationInformation event exists:
> 
> <img width="226" height="37" alt="image" src="https://github.com/user-attachments/assets/728fc44f-d094-467c-b5b6-3946669859e6" />
> 
> When jdk.VirtualizationInformation event doesn't exists:
> 
> <img width="161" height="38" alt="image" src="https://github.com/user-attachments/assets/19299a60-ba9d-422f-b31f-894520aebe2c" />

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/666#pullrequestreview-3030082566

From schaturvedi at openjdk.org  Thu Jul 17 18:40:55 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 17 Jul 2025 18:40:55 GMT
Subject: Integrated: 6515: Show virtualization information in JMC
In-Reply-To: <lKfjiOf42H2BdjBm28a8MMnOq-owZCGOhV6-s4I4Mpg=.6fec180f-32c3-4377-9a59-932e9d0feb91@github.com>
References: <lKfjiOf42H2BdjBm28a8MMnOq-owZCGOhV6-s4I4Mpg=.6fec180f-32c3-4377-9a59-932e9d0feb91@github.com>
Message-ID: <UEKI2ZHqFO0H0CGfd53baM1XyaspYazXEMpp5JjV8f8=.761a59f0-ac73-45ec-ae45-8eb61be1125f@github.com>

On Thu, 17 Jul 2025 06:34:48 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR adds Virtualization Information i.e. name (as this is the only information we have as of now) on Environment screen.
> 
> The screen looks like this:
> 
> <img width="959" height="486" alt="image" src="https://github.com/user-attachments/assets/a05ba14d-c60b-40f3-8432-c1cf57307af4" />
> 
> 
> When jdk.VirtualizationInformation event exists:
> 
> <img width="226" height="37" alt="image" src="https://github.com/user-attachments/assets/728fc44f-d094-467c-b5b6-3946669859e6" />
> 
> When jdk.VirtualizationInformation event doesn't exists:
> 
> <img width="161" height="38" alt="image" src="https://github.com/user-attachments/assets/19299a60-ba9d-422f-b31f-894520aebe2c" />

This pull request has now been integrated.

Changeset: 8f276a9f
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/8f276a9fbda451eec2dc171618403c1c407ef1f8
Stats:     12 lines in 8 files changed: 12 ins; 0 del; 0 mod

6515: Show virtualization information in JMC

Reviewed-by: aptmac, hirt

-------------

PR: https://git.openjdk.org/jmc/pull/666

From hirt at openjdk.org  Thu Jul 17 21:24:07 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 17 Jul 2025 21:24:07 GMT
Subject: RFR: 8400: Add more show options for JMX Console graphs [v4]
In-Reply-To: <PlUXb8yV51V5BufXknA-MuDQLCR47tOXQXPUZU4Zo1Q=.af52bece-24ae-45d3-a0ca-f902fbdde4d0@github.com>
References: <PlUXb8yV51V5BufXknA-MuDQLCR47tOXQXPUZU4Zo1Q=.af52bece-24ae-45d3-a0ca-f902fbdde4d0@github.com>
Message-ID: <YFUxD8d9bVLtQVHlIumzT2SoV_91tIwY_PNFKby5PmM=.6d865eda-b937-42ba-847e-edfbfb817d15@github.com>

> Also cleaning up a little bit. There were some assumptions around the default XY chart that should be put in code etc.

Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:

 - More space for Linux, resizable and grabbing existing space
 - Spotless
 - Cleanup. Ensuring that the axis is responsible for bounds.
 - 8400: Add more show options for JMX Console graphs

-------------

Changes: https://git.openjdk.org/jmc/pull/652/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=652&range=03
  Stats: 881 lines in 15 files changed: 699 ins; 55 del; 127 mod
  Patch: https://git.openjdk.org/jmc/pull/652.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/652/head:pull/652

PR: https://git.openjdk.org/jmc/pull/652

From hirt at openjdk.org  Fri Jul 18 12:58:09 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 18 Jul 2025 12:58:09 GMT
Subject: RFR: 8416: Better Eclipse classpath entry defaults
Message-ID: <_84pkBLLi2d3IOiXlpJBFC35TIwzTQOWeMTn0wEShBU=.b5d49c9c-f95f-4530-b0f6-7220a31d533d@github.com>

Should be pom derived.

-------------

Commit messages:
 - Removing explicit runtime versions
 - 8614: Better classpath defaults

Changes: https://git.openjdk.org/jmc/pull/663/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=663&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8416
  Stats: 1896 lines in 130 files changed: 1605 ins; 1 del; 290 mod
  Patch: https://git.openjdk.org/jmc/pull/663.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/663/head:pull/663

PR: https://git.openjdk.org/jmc/pull/663

From schaturvedi at openjdk.org  Fri Jul 18 12:58:10 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Fri, 18 Jul 2025 12:58:10 GMT
Subject: RFR: 8416: Better Eclipse classpath entry defaults
In-Reply-To: <_84pkBLLi2d3IOiXlpJBFC35TIwzTQOWeMTn0wEShBU=.b5d49c9c-f95f-4530-b0f6-7220a31d533d@github.com>
References: <_84pkBLLi2d3IOiXlpJBFC35TIwzTQOWeMTn0wEShBU=.b5d49c9c-f95f-4530-b0f6-7220a31d533d@github.com>
Message-ID: <c8p8ZEvfvIU46p_-Xgd64eadqpG5fdoru8Mpld6Ltd0=.7c42e153-6082-451b-a37e-e2ff468727f9@github.com>

On Wed, 9 Jul 2025 11:48:30 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Should be pom derived.

application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/.classpath line 3:

> 1: <?xml version="1.0" encoding="UTF-8"?>
> 2: <classpath>
> 3: 	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>

Any specific reason why are we hard coding 21 here?

application/tests/org.openjdk.jmc.rjmx.services.jfr.test/.classpath line 3:

> 1: <?xml version="1.0" encoding="UTF-8"?>
> 2: <classpath>
> 3: 	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>

Any specific reason why are we hard coding 21 here?

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/663#discussion_r2195034466
PR Review Comment: https://git.openjdk.org/jmc/pull/663#discussion_r2195024121

From vpurnam at openjdk.org  Fri Jul 18 12:58:09 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Fri, 18 Jul 2025 12:58:09 GMT
Subject: RFR: 8416: Better Eclipse classpath entry defaults
In-Reply-To: <_84pkBLLi2d3IOiXlpJBFC35TIwzTQOWeMTn0wEShBU=.b5d49c9c-f95f-4530-b0f6-7220a31d533d@github.com>
References: <_84pkBLLi2d3IOiXlpJBFC35TIwzTQOWeMTn0wEShBU=.b5d49c9c-f95f-4530-b0f6-7220a31d533d@github.com>
Message-ID: <BAdGFNQxcm6mNuFcugF4h5a5UbcdZ1qYnVEbeejdDWo=.b5ecea37-aa94-4786-9a78-f9a7ccd0982e@github.com>

On Wed, 9 Jul 2025 11:48:30 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Should be pom derived.

Commit message should be 8416 instead of 8614. (For auto closer of JBS ticket)

-------------

PR Review: https://git.openjdk.org/jmc/pull/663#pullrequestreview-3031921995

From hirt at openjdk.org  Fri Jul 18 12:58:10 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 18 Jul 2025 12:58:10 GMT
Subject: RFR: 8416: Better Eclipse classpath entry defaults
In-Reply-To: <c8p8ZEvfvIU46p_-Xgd64eadqpG5fdoru8Mpld6Ltd0=.7c42e153-6082-451b-a37e-e2ff468727f9@github.com>
References: <_84pkBLLi2d3IOiXlpJBFC35TIwzTQOWeMTn0wEShBU=.b5d49c9c-f95f-4530-b0f6-7220a31d533d@github.com>
 <c8p8ZEvfvIU46p_-Xgd64eadqpG5fdoru8Mpld6Ltd0=.7c42e153-6082-451b-a37e-e2ff468727f9@github.com>
Message-ID: <SNQzJA8wsqVp2dXoK7s2qm2x7_T1awoPHtzIKPXpWO0=.8e9b514f-98d7-4493-87d7-9624b6149378@github.com>

On Wed, 9 Jul 2025 13:26:34 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Should be pom derived.
>
> application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/.classpath line 3:
> 
>> 1: <?xml version="1.0" encoding="UTF-8"?>
>> 2: <classpath>
>> 3: 	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>
> 
> Any specific reason why are we hard coding 21 here?

Nope. Good catch! I'll take another pass and ensure that this is properly done for all classpath files.

> application/tests/org.openjdk.jmc.rjmx.services.jfr.test/.classpath line 3:
> 
>> 1: <?xml version="1.0" encoding="UTF-8"?>
>> 2: <classpath>
>> 3: 	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>
> 
> Any specific reason why are we hard coding 21 here?

Nope, good catch!

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/663#discussion_r2208748789
PR Review Comment: https://git.openjdk.org/jmc/pull/663#discussion_r2208749023

From hirt at openjdk.org  Fri Jul 18 13:09:42 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 18 Jul 2025 13:09:42 GMT
Subject: RFR: 8416: Better Eclipse classpath entry defaults [v2]
In-Reply-To: <_84pkBLLi2d3IOiXlpJBFC35TIwzTQOWeMTn0wEShBU=.b5d49c9c-f95f-4530-b0f6-7220a31d533d@github.com>
References: <_84pkBLLi2d3IOiXlpJBFC35TIwzTQOWeMTn0wEShBU=.b5d49c9c-f95f-4530-b0f6-7220a31d533d@github.com>
Message-ID: <09g_mIpeLi9opw1TEAQZgeLWfYR6RE88bF6U26LJ3GE=.143fa9eb-cc2c-40ce-9fb8-fc86757f1c14@github.com>

> Should be pom derived.

Marcus Hirt has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:

 - Removing explicit runtime versions
 - 8416: Better classpath defaults

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/663/files
  - new: https://git.openjdk.org/jmc/pull/663/files/9f94fc4a..154d4bed

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=663&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=663&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/663.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/663/head:pull/663

PR: https://git.openjdk.org/jmc/pull/663

From vpurnam at openjdk.org  Fri Jul 18 13:09:43 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Fri, 18 Jul 2025 13:09:43 GMT
Subject: RFR: 8416: Better Eclipse classpath entry defaults [v2]
In-Reply-To: <09g_mIpeLi9opw1TEAQZgeLWfYR6RE88bF6U26LJ3GE=.143fa9eb-cc2c-40ce-9fb8-fc86757f1c14@github.com>
References: <_84pkBLLi2d3IOiXlpJBFC35TIwzTQOWeMTn0wEShBU=.b5d49c9c-f95f-4530-b0f6-7220a31d533d@github.com>
 <09g_mIpeLi9opw1TEAQZgeLWfYR6RE88bF6U26LJ3GE=.143fa9eb-cc2c-40ce-9fb8-fc86757f1c14@github.com>
Message-ID: <Vy4w09bgevLJ8Ayjf4sKe7OEXR4BgjUnsKy370RX_t0=.d026cd2e-6cb3-4060-b341-45bd4716f503@github.com>

On Fri, 18 Jul 2025 13:06:25 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Should be pom derived.
>
> Marcus Hirt has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
> 
>  - Removing explicit runtime versions
>  - 8416: Better classpath defaults

Looks good to me.

-------------

Marked as reviewed by vpurnam (Reviewer).

PR Review: https://git.openjdk.org/jmc/pull/663#pullrequestreview-3033487676

From hirt at openjdk.org  Fri Jul 18 13:27:55 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 18 Jul 2025 13:27:55 GMT
Subject: Integrated: 8416: Better Eclipse classpath entry defaults
In-Reply-To: <_84pkBLLi2d3IOiXlpJBFC35TIwzTQOWeMTn0wEShBU=.b5d49c9c-f95f-4530-b0f6-7220a31d533d@github.com>
References: <_84pkBLLi2d3IOiXlpJBFC35TIwzTQOWeMTn0wEShBU=.b5d49c9c-f95f-4530-b0f6-7220a31d533d@github.com>
Message-ID: <rqh0taS4KqCu4JRpGbpBdVUtt07clWTFPfiMpQsbFgg=.eefe8cc6-5495-4a37-aec4-d6d781e1827b@github.com>

On Wed, 9 Jul 2025 11:48:30 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Should be pom derived.

This pull request has now been integrated.

Changeset: c8e8a136
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/c8e8a136cf396a26fa69e34c7816689ad4b1e1e0
Stats:     1896 lines in 130 files changed: 1605 ins; 1 del; 290 mod

8416: Better Eclipse classpath entry defaults

Reviewed-by: vpurnam

-------------

PR: https://git.openjdk.org/jmc/pull/663

From duke at openjdk.org  Fri Jul 18 17:22:37 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 18 Jul 2025 17:22:37 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy [v4]
In-Reply-To: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
Message-ID: <GQafZmHregOXqkGQSvuc3ZBx9-crOiT3Op4uPfFxxDA=.e7dea4c5-3136-498a-b20c-fe114c0c6241@github.com>

> JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.
> 
> Testing connectivity:
> - [x]  Docker desktop kubernetes 
> - [x]  Azure AKS
> - [x]  Amazon EKS
> - [x]  Google GKE
> 
> Other things observed:
> 
> - [x] * Option to install agent should be disabled (debug difference with jolokia) - ***see below****
> - [x] * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
> - [x] * SLF4J(W): No SLF4J providers were found. ***OK for now, can investigate more later***
> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
> - [x] Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-8237: Upgrade jolokia 2.2.2 -> 2.2.9

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/576/files
  - new: https://git.openjdk.org/jmc/pull/576/files/690bbbb7..e90f6156

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=576&range=03
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=576&range=02-03

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jmc/pull/576.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/576/head:pull/576

PR: https://git.openjdk.org/jmc/pull/576

From schaturvedi at openjdk.org  Fri Jul 18 18:13:26 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Fri, 18 Jul 2025 18:13:26 GMT
Subject: RFR: 6203: Add ZGC allocation stall rule [v2]
In-Reply-To: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
References: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
Message-ID: <_uEgMMsrbFtEKE3HMVprd-i8AnEOlOayDjAkheSRj20=.d37866c0-7cb2-4250-ad4a-fc91edabd1f7@github.com>

> This enhancement is to add new rule for ZGC Allocation Stall events.
> 
> The default configuration:
>  
> <img width="946" alt="image" src="https://github.com/user-attachments/assets/0d39ae26-fdc4-49e3-a0ed-fb7f7da8f709" />
> 
> Here are few screenshots for reference:
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/e7efe1e2-d6b3-4a05-8ea6-1bf2e8b8c15f" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/a3d3862f-96d2-4292-947f-4562c7f9f3d3" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/9616eea6-bce8-4395-a846-db343fe349f2" />
> 
> <img width="341" alt="image" src="https://github.com/user-attachments/assets/376a100e-ac05-48fe-a9c3-754923c3d79e" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/cfa7c5f1-08f0-44b4-a49d-28504439a631" />
> 
> Ignored
> 
> <img width="352" alt="image" src="https://github.com/user-attachments/assets/3c00c22e-e64d-46b0-8b64-ed653ed1fc4b" />
> 
> If we change default configuration as below:
> 
> <img width="367" alt="image" src="https://github.com/user-attachments/assets/8da64985-8446-44b8-bfb4-696a726b5255" />
> 
> <img width="350" alt="image" src="https://github.com/user-attachments/assets/ad89f02e-39b4-4df4-aae7-43cec9cc9a91" />
> 
> <img width="347" alt="image" src="https://github.com/user-attachments/assets/b3ec1081-26dd-4391-9e0f-0b4c64a7e3c1" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/106a7c3e-aaaf-495a-8c6f-281c96371e6e" />

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Updated the rule as per new metric allocation stall rate

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/664/files
  - new: https://git.openjdk.org/jmc/pull/664/files/2d959553..e6c3ab81

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=664&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=664&range=00-01

  Stats: 32 lines in 3 files changed: 19 ins; 0 del; 13 mod
  Patch: https://git.openjdk.org/jmc/pull/664.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/664/head:pull/664

PR: https://git.openjdk.org/jmc/pull/664

From schaturvedi at openjdk.org  Fri Jul 18 18:16:49 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Fri, 18 Jul 2025 18:16:49 GMT
Subject: RFR: 6203: Add ZGC allocation stall rule [v2]
In-Reply-To: <_uEgMMsrbFtEKE3HMVprd-i8AnEOlOayDjAkheSRj20=.d37866c0-7cb2-4250-ad4a-fc91edabd1f7@github.com>
References: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
 <_uEgMMsrbFtEKE3HMVprd-i8AnEOlOayDjAkheSRj20=.d37866c0-7cb2-4250-ad4a-fc91edabd1f7@github.com>
Message-ID: <aRR5fAPzUFN-VCk5lg0lJ208Xq8E8A7iAexNgigcMuA=.4a5b9be9-77f6-4f8d-b588-b679a89dc40f@github.com>

On Fri, 18 Jul 2025 18:13:26 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This enhancement is to add new rule for ZGC Allocation Stall events.
>> 
>> The default configuration:
>>  
>> <img width="946" alt="image" src="https://github.com/user-attachments/assets/0d39ae26-fdc4-49e3-a0ed-fb7f7da8f709" />
>> 
>> Here are few screenshots for reference:
>> 
>> <img width="344" alt="image" src="https://github.com/user-attachments/assets/e7efe1e2-d6b3-4a05-8ea6-1bf2e8b8c15f" />
>> 
>> <img width="353" alt="image" src="https://github.com/user-attachments/assets/a3d3862f-96d2-4292-947f-4562c7f9f3d3" />
>> 
>> <img width="344" alt="image" src="https://github.com/user-attachments/assets/9616eea6-bce8-4395-a846-db343fe349f2" />
>> 
>> <img width="341" alt="image" src="https://github.com/user-attachments/assets/376a100e-ac05-48fe-a9c3-754923c3d79e" />
>> 
>> <img width="353" alt="image" src="https://github.com/user-attachments/assets/cfa7c5f1-08f0-44b4-a49d-28504439a631" />
>> 
>> Ignored
>> 
>> <img width="352" alt="image" src="https://github.com/user-attachments/assets/3c00c22e-e64d-46b0-8b64-ed653ed1fc4b" />
>> 
>> If we change default configuration as below:
>> 
>> <img width="367" alt="image" src="https://github.com/user-attachments/assets/8da64985-8446-44b8-bfb4-696a726b5255" />
>> 
>> <img width="350" alt="image" src="https://github.com/user-attachments/assets/ad89f02e-39b4-4df4-aae7-43cec9cc9a91" />
>> 
>> <img width="347" alt="image" src="https://github.com/user-attachments/assets/b3ec1081-26dd-4391-9e0f-0b4c64a7e3c1" />
>> 
>> <img width="344" alt="image" src="https://github.com/user-attachments/assets/106a7c3e-aaaf-495a-8c6f-281c96371e6e" />
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated the rule as per new metric allocation stall rate

The new commit has the text update suggested by @jpbempel and the metric to calculate score is changed from allocation stall events count to stall rate. Also, I have added stall rate as part of rule result along with allocation stall count, total stall duration and maximum stall duration.

Here are the fresh screenshots:

<img width="617" height="489" alt="image" src="https://github.com/user-attachments/assets/681acef8-c13c-47df-988e-be6edec29032" />

<img width="344" height="224" alt="image" src="https://github.com/user-attachments/assets/d268029f-8161-4ed9-a716-681bd9fe99fd" />

<img width="353" height="223" alt="image" src="https://github.com/user-attachments/assets/9fad0538-ca6b-4265-9990-f1f9e9fcd5de" />

<img width="347" height="221" alt="image" src="https://github.com/user-attachments/assets/1f6c2bd1-87d4-411b-9f1c-489620cc2d68" />

<img width="347" height="221" alt="image" src="https://github.com/user-attachments/assets/e0dd209e-db01-418a-9d24-f95dacac1503" />

<img width="341" height="218" alt="image" src="https://github.com/user-attachments/assets/86435716-b774-4641-8d54-3d1254e0fddf" />

I will create a follow up enhancement to create a new rule for maximum stall duration metric.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/664#issuecomment-3090281834

From schaturvedi at openjdk.org  Sat Jul 19 08:12:25 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sat, 19 Jul 2025 08:12:25 GMT
Subject: RFR: 6203: Add ZGC allocation stall rule [v3]
In-Reply-To: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
References: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
Message-ID: <JAcLpUiFOVhyI70pJlnsJ4IdPnxdRwd9Bk6kEXECTQk=.5c540390-4c80-4d68-b5bf-e33aaf5fb925@github.com>

> This enhancement is to add new rule for ZGC Allocation Stall events.
> 
> The default configuration:
>  
> <img width="946" alt="image" src="https://github.com/user-attachments/assets/0d39ae26-fdc4-49e3-a0ed-fb7f7da8f709" />
> 
> Here are few screenshots for reference:
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/e7efe1e2-d6b3-4a05-8ea6-1bf2e8b8c15f" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/a3d3862f-96d2-4292-947f-4562c7f9f3d3" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/9616eea6-bce8-4395-a846-db343fe349f2" />
> 
> <img width="341" alt="image" src="https://github.com/user-attachments/assets/376a100e-ac05-48fe-a9c3-754923c3d79e" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/cfa7c5f1-08f0-44b4-a49d-28504439a631" />
> 
> Ignored
> 
> <img width="352" alt="image" src="https://github.com/user-attachments/assets/3c00c22e-e64d-46b0-8b64-ed653ed1fc4b" />
> 
> If we change default configuration as below:
> 
> <img width="367" alt="image" src="https://github.com/user-attachments/assets/8da64985-8446-44b8-bfb4-696a726b5255" />
> 
> <img width="350" alt="image" src="https://github.com/user-attachments/assets/ad89f02e-39b4-4df4-aae7-43cec9cc9a91" />
> 
> <img width="347" alt="image" src="https://github.com/user-attachments/assets/b3ec1081-26dd-4391-9e0f-0b4c64a7e3c1" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/106a7c3e-aaaf-495a-8c6f-281c96371e6e" />

Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - Resolving merge conflict
 - Updated the rule as per new metric allocation stall rate
 - 6203: Add ZGC allocation stall rule

-------------

Changes: https://git.openjdk.org/jmc/pull/664/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=664&range=02
  Stats: 326 lines in 11 files changed: 322 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jmc/pull/664.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/664/head:pull/664

PR: https://git.openjdk.org/jmc/pull/664

From schaturvedi at openjdk.org  Sat Jul 19 15:36:44 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sat, 19 Jul 2025 15:36:44 GMT
Subject: RFR: 8421: Missing Eclipse classpath entry defaults
Message-ID: <0RDveYymMsRyxZkuuUs6s8BZpyg8xzBeHoQDlXTGEjs=.789c5eb6-429e-4e5f-a9b9-8dcbd400e36b@github.com>

Updating few missed classpath files as part of this PR.

-------------

Commit messages:
 - 8421: Missing Eclipse classpath entry defaults

Changes: https://git.openjdk.org/jmc/pull/667/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=667&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8421
  Stats: 55 lines in 6 files changed: 42 ins; 3 del; 10 mod
  Patch: https://git.openjdk.org/jmc/pull/667.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/667/head:pull/667

PR: https://git.openjdk.org/jmc/pull/667

From vpurnam at openjdk.org  Mon Jul 21 05:59:46 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Mon, 21 Jul 2025 05:59:46 GMT
Subject: RFR: 8421: Missing Eclipse classpath entry defaults
In-Reply-To: <0RDveYymMsRyxZkuuUs6s8BZpyg8xzBeHoQDlXTGEjs=.789c5eb6-429e-4e5f-a9b9-8dcbd400e36b@github.com>
References: <0RDveYymMsRyxZkuuUs6s8BZpyg8xzBeHoQDlXTGEjs=.789c5eb6-429e-4e5f-a9b9-8dcbd400e36b@github.com>
Message-ID: <BykV_7QpXueFNbKt3tqbaTA4_T7KkJygXqrY1b5HsRk=.79a42b51-42cf-4242-a447-067a208f8253@github.com>

On Sat, 19 Jul 2025 15:31:35 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Updating few missed classpath files as part of this PR.

LGTM

-------------

Marked as reviewed by vpurnam (Reviewer).

PR Review: https://git.openjdk.org/jmc/pull/667#pullrequestreview-3036637186

From schaturvedi at openjdk.org  Mon Jul 21 05:59:46 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Mon, 21 Jul 2025 05:59:46 GMT
Subject: Integrated: 8421: Missing Eclipse classpath entry defaults
In-Reply-To: <0RDveYymMsRyxZkuuUs6s8BZpyg8xzBeHoQDlXTGEjs=.789c5eb6-429e-4e5f-a9b9-8dcbd400e36b@github.com>
References: <0RDveYymMsRyxZkuuUs6s8BZpyg8xzBeHoQDlXTGEjs=.789c5eb6-429e-4e5f-a9b9-8dcbd400e36b@github.com>
Message-ID: <semYwldHvTwqJWWp1yMvoz6OExb4MfBZmBa6PoMAMN4=.279f0b5c-828b-4a6e-a0cb-33fedb2afe7b@github.com>

On Sat, 19 Jul 2025 15:31:35 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Updating few missed classpath files as part of this PR.

This pull request has now been integrated.

Changeset: 06297dcc
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/06297dcc338985c0aefd360e49cddf536efd7635
Stats:     55 lines in 6 files changed: 42 ins; 3 del; 10 mod

8421: Missing Eclipse classpath entry defaults

Reviewed-by: vpurnam

-------------

PR: https://git.openjdk.org/jmc/pull/667

From aptmac at openjdk.org  Mon Jul 21 14:38:51 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Mon, 21 Jul 2025 14:38:51 GMT
Subject: RFR: 8400: Add more show options for JMX Console graphs [v4]
In-Reply-To: <YFUxD8d9bVLtQVHlIumzT2SoV_91tIwY_PNFKby5PmM=.6d865eda-b937-42ba-847e-edfbfb817d15@github.com>
References: <PlUXb8yV51V5BufXknA-MuDQLCR47tOXQXPUZU4Zo1Q=.af52bece-24ae-45d3-a0ca-f902fbdde4d0@github.com>
 <YFUxD8d9bVLtQVHlIumzT2SoV_91tIwY_PNFKby5PmM=.6d865eda-b937-42ba-847e-edfbfb817d15@github.com>
Message-ID: <TayBDaqRXd2n1WNfq9KeQg9IXCxEM44cpsz1Z8PmHWM=.ea0b3bb2-7085-498e-9f8d-42c9e3add20d@github.com>

On Thu, 17 Jul 2025 21:24:07 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also cleaning up a little bit. There were some assumptions around the default XY chart that should be put in code etc.
>
> Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - More space for Linux, resizable and grabbing existing space
>  - Spotless
>  - Cleanup. Ensuring that the axis is responsible for bounds.
>  - 8400: Add more show options for JMX Console graphs

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/652#pullrequestreview-3038434711

From hirt at openjdk.org  Mon Jul 21 14:47:49 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 21 Jul 2025 14:47:49 GMT
Subject: Integrated: 8400: Add more show options for JMX Console graphs
In-Reply-To: <PlUXb8yV51V5BufXknA-MuDQLCR47tOXQXPUZU4Zo1Q=.af52bece-24ae-45d3-a0ca-f902fbdde4d0@github.com>
References: <PlUXb8yV51V5BufXknA-MuDQLCR47tOXQXPUZU4Zo1Q=.af52bece-24ae-45d3-a0ca-f902fbdde4d0@github.com>
Message-ID: <QJ0KHs5t_kkzgxo_ajey6OdNUJHK6Y84POTI_eHPphA=.67f2915b-8a1a-4da7-a584-f09c08209381@github.com>

On Sat, 31 May 2025 22:27:45 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also cleaning up a little bit. There were some assumptions around the default XY chart that should be put in code etc.

This pull request has now been integrated.

Changeset: 22e4459c
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/22e4459c4e1e6410efcfa10061ffd3e14fdd3307
Stats:     881 lines in 15 files changed: 699 ins; 55 del; 127 mod

8400: Add more show options for JMX Console graphs

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/652

From marcus at hirt.se  Mon Jul 21 21:02:54 2025
From: marcus at hirt.se (Marcus Hirt)
Date: Mon, 21 Jul 2025 23:02:54 +0200
Subject: Requesting a Slack Channel Invite!
In-Reply-To: <CAAC8vjXfg4BoqQ9MT9knHCF0q-QnFXji3qdSN3Y4dE3Lhb55qQ@mail.gmail.com>
References: <CAAC8vjXfg4BoqQ9MT9knHCF0q-QnFXji3qdSN3Y4dE3Lhb55qQ@mail.gmail.com>
Message-ID: <046401dbfa82$d3c9c5b0$7b5d5110$@hirt.se>

Hi Joe,

Sorry for the late response. Your message got stuck in bounce processing. Invite to the slack sent! :)

Kind regards,

Marcus 

 

From: jmc-dev <jmc-dev-retn at openjdk.org> On Behalf Of Joe Lane
Sent: Saturday, 31 May 2025 19:27
To: jmc-dev at openjdk.java.net
Subject: Requesting a Slack Channel Invite!

 

Hello there!

 

I'm interested in learning more about JMC, JFRs, and possibly contributing. 

 

I'm using these tools on a daily basis and as a user (and possible contributor) I'm interested in enhancing the ecosystem.

 

Thanks,

Joe Lane

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jmc-dev/attachments/20250721/ade6800f/attachment.htm>

From duke at openjdk.org  Sun Jul 27 18:39:35 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Sun, 27 Jul 2025 18:39:35 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility 3rd
 party artefact
Message-ID: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>

The Jolokia test plugin requires awaitility

-------------

Commit messages:
 - JMC-8425: Ensure awaitlity is available as a 3rd party plugin

Changes: https://git.openjdk.org/jmc/pull/668/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=668&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8425
  Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/668.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/668/head:pull/668

PR: https://git.openjdk.org/jmc/pull/668

From duke at openjdk.org  Tue Jul 29 10:57:16 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Tue, 29 Jul 2025 10:57:16 GMT
Subject: RFR: 8365: Jolokia - Additional support for security mechanisms
 related to SSL / authentication, discovery restrictions
Message-ID: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>

Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https.

-------------

Commit messages:
 - JMC-8365: Make secure button updating null safe
 - JMC-8365: Actually reflect require secure connection back in wizard
 - JMC-8369: revert JmcJolokiaPlugin.java
 - JMC-8365: Remove premature change
 - JMC-8365: Fixed spots
 - JMC-8365: Add option to require secure connection and give hint in error connection if it fails

Changes: https://git.openjdk.org/jmc/pull/665/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=665&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8365
  Stats: 67 lines in 12 files changed: 56 ins; 1 del; 10 mod
  Patch: https://git.openjdk.org/jmc/pull/665.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/665/head:pull/665

PR: https://git.openjdk.org/jmc/pull/665

From duke at openjdk.org  Tue Jul 29 10:57:17 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Tue, 29 Jul 2025 10:57:17 GMT
Subject: RFR: 8365: Jolokia - Additional support for security mechanisms
 related to SSL / authentication, discovery restrictions
In-Reply-To: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
References: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
Message-ID: <y83RGt7Ad-qxWALAfoH0YSPRLUJaFSlodkrMkgCW00I=.047330cd-5713-44cb-ad5b-379c27498e03@github.com>

On Sat, 12 Jul 2025 14:59:27 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https.

application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ConnectionWizardPage.java line 420:

> 418: 
> 419: 		fieldStack = new Composite(inner, SWT.NONE);
> 420: 		fieldStack.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, false, 2, 1));

Appearance: 
<img width="720" height="434" alt="image" src="https://github.com/user-attachments/assets/f4a6c9ed-1c75-4771-ad39-7a2f26ed8608" />

application/org.openjdk.jmc.console.ui/src/main/java/org/openjdk/jmc/console/ui/editor/internal/ConsoleEditor.java line 126:

> 124: 				// FIXME: Show stacktrace? (Need to show our own ExceptionDialog in that case, or maybe create our own DetailsAreaProvider, see WorkbenchStatusDialogManager.setDetailsAreaProvider)
> 125: 				return new Status(IStatus.ERROR, ConsolePlugin.PLUGIN_ID, IStatus.ERROR,
> 126: 						NLS.bind(e.getLocalizedMessage(), getEditorInput().getName(), e.getMessage()),

Apparently all the more detailed error message is in this method on the exception class

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaPlugin.java line 78:

> 76: 		JolokiaServiceManager serviceManager = JolokiaServiceManagerFactory.createJolokiaServiceManager(configuration,
> 77: 				new JulLogHandler(PLUGIN_ID), new AllowAllRestrictor(),
> 78: 				logHandler -> new TreeSet<ServerDetector>(Arrays.asList(ServerDetector.FALLBACK)));

Unrelated compiltion erro

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2202733282
PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2202735387
PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2202736056

From duke at openjdk.org  Tue Jul 29 10:57:17 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Tue, 29 Jul 2025 10:57:17 GMT
Subject: RFR: 8365: Jolokia - Additional support for security mechanisms
 related to SSL / authentication, discovery restrictions
In-Reply-To: <y83RGt7Ad-qxWALAfoH0YSPRLUJaFSlodkrMkgCW00I=.047330cd-5713-44cb-ad5b-379c27498e03@github.com>
References: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
 <y83RGt7Ad-qxWALAfoH0YSPRLUJaFSlodkrMkgCW00I=.047330cd-5713-44cb-ad5b-379c27498e03@github.com>
Message-ID: <LMw7_3fu-pEQCjkw44kSOWj7dOiOBGfo6ZANmJyq9S8=.8d2dd518-94b2-4fec-9bf4-8a51cf4146cc@github.com>

On Sat, 12 Jul 2025 15:01:40 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https.
>
> application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaPlugin.java line 78:
> 
>> 76: 		JolokiaServiceManager serviceManager = JolokiaServiceManagerFactory.createJolokiaServiceManager(configuration,
>> 77: 				new JulLogHandler(PLUGIN_ID), new AllowAllRestrictor(),
>> 78: 				logHandler -> new TreeSet<ServerDetector>(Arrays.asList(ServerDetector.FALLBACK)));
> 
> Unrelated compiltion erro

Reverted this to separate concerns

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2210860544

From duke at openjdk.org  Tue Jul 29 11:06:20 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Tue, 29 Jul 2025 11:06:20 GMT
Subject: RFR: 8365: Jolokia - Additional support for security mechanisms
 related to SSL / authentication, discovery restrictions [v2]
In-Reply-To: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
References: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
Message-ID: <wWZaj_gSGprKIDdgzepaPJN4EdEApl0huyIFNaLHQDE=.79778435-5ccc-4e51-a9ea-e0bec2938af5@github.com>

> Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https.

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-8365: Fix spots

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/665/files
  - new: https://git.openjdk.org/jmc/pull/665/files/59d62080..3e59aae4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=665&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=665&range=00-01

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/665.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/665/head:pull/665

PR: https://git.openjdk.org/jmc/pull/665

From duke at openjdk.org  Tue Jul 29 11:21:02 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Tue, 29 Jul 2025 11:21:02 GMT
Subject: RFR: 8365: Jolokia - Additional support for security mechanisms
 related to SSL / authentication, discovery restrictions [v3]
In-Reply-To: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
References: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
Message-ID: <VWwNSR6gx0BHT4JH3Nfw5gNpxjoN9w0k0ADTF5EAVnk=.abf0bcdc-2abd-4451-94b7-abb8e9b2cae3@github.com>

> Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https.

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-8365: Make secure button updating null safe

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/665/files
  - new: https://git.openjdk.org/jmc/pull/665/files/3e59aae4..161f0d33

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=665&range=02
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=665&range=01-02

  Stats: 7 lines in 1 file changed: 3 ins; 4 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/665.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/665/head:pull/665

PR: https://git.openjdk.org/jmc/pull/665

From vpurnam at openjdk.org  Tue Jul 29 15:38:03 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Tue, 29 Jul 2025 15:38:03 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility
 3rd party artefact
In-Reply-To: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
Message-ID: <mAvX1zr22rt8GI-5CPCMeHffO-oauLZuhFXKenzZi1Y=.87d0021c-7335-4125-bada-56e65df601fa@github.com>

On Sun, 27 Jul 2025 17:44:53 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> The Jolokia test plugin requires awaitility

Hi @skarsaune, this plugin needs to be added to all target platforms as well under local p2 repository.

-------------

PR Review: https://git.openjdk.org/jmc/pull/668#pullrequestreview-3068126023