From duke at openjdk.org  Tue Jul  1 09:59:47 2025
From: duke at openjdk.org (duke)
Date: Tue, 1 Jul 2025 09:59:47 GMT
Subject: RFR: 8396: OptionsCheckRule has doesn't recognize
 HeapDumpOnOutOfMemoryError
In-Reply-To: <LZQBLBC3GmXV94tQHfpheeSskB7I3GjpVMj-Of4rBzk=.bc3f20a9-f3d7-4229-b8c0-bccadbb82d72@github.com>
References: <LZQBLBC3GmXV94tQHfpheeSskB7I3GjpVMj-Of4rBzk=.bc3f20a9-f3d7-4229-b8c0-bccadbb82d72@github.com>
Message-ID: <3Mhb8iQPubiVTerG3HML5A7Ygffu9huMhjWF-MVlHtM=.4f617085-129e-45db-8586-fc886ad87e1f@github.com>

On Thu, 1 May 2025 10:12:32 GMT, Ivo Anjo <duke at openjdk.org> wrote:

> I noticed that `HeapDumpOnOutOfMemoryError` was showing up as an undocumented rule, and that seemed a bit surprising.
> 
> On a closer look, it's even documented on the exact link https://docs.oracle.com/javase/8/docs/technotes/tools/windows/java.html used as the source for the `JAVA_8_DOCUMENTED_XX`.
> 
> I googled and I don't think this option ever had another name, so it looks like a copy-paste accident or something like that?
> 
> I've submitted the needed docs for the OCA so I'm opening the PR for now and hopefully that will all be in good shape soon.

@ivoanjo 
Your change (at version b5b46c862a92f14c57eee593e2f3d6647b427d32) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/646#issuecomment-3023108820

From duke at openjdk.org  Wed Jul  2 17:07:46 2025
From: duke at openjdk.org (Ivo Anjo)
Date: Wed, 2 Jul 2025 17:07:46 GMT
Subject: Integrated: 8396: OptionsCheckRule has doesn't recognize
 HeapDumpOnOutOfMemoryError
In-Reply-To: <LZQBLBC3GmXV94tQHfpheeSskB7I3GjpVMj-Of4rBzk=.bc3f20a9-f3d7-4229-b8c0-bccadbb82d72@github.com>
References: <LZQBLBC3GmXV94tQHfpheeSskB7I3GjpVMj-Of4rBzk=.bc3f20a9-f3d7-4229-b8c0-bccadbb82d72@github.com>
Message-ID: <wjLStqKvkrhPuRXjqbbEUN1rwxRTrjpJZHZIx0NGyqA=.b3e0069f-0e18-40ab-b919-e1da9f20c42e@github.com>

On Thu, 1 May 2025 10:12:32 GMT, Ivo Anjo <duke at openjdk.org> wrote:

> I noticed that `HeapDumpOnOutOfMemoryError` was showing up as an undocumented rule, and that seemed a bit surprising.
> 
> On a closer look, it's even documented on the exact link https://docs.oracle.com/javase/8/docs/technotes/tools/windows/java.html used as the source for the `JAVA_8_DOCUMENTED_XX`.
> 
> I googled and I don't think this option ever had another name, so it looks like a copy-paste accident or something like that?
> 
> I've submitted the needed docs for the OCA so I'm opening the PR for now and hopefully that will all be in good shape soon.

This pull request has now been integrated.

Changeset: dd6fd901
Author:    Ivo Anjo <ivo.anjo at datadoghq.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/dd6fd901e3ee4fdd766a2b4dfe43bcc1388fbf2a
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8396: OptionsCheckRule has doesn't recognize HeapDumpOnOutOfMemoryError

Reviewed-by: hdafgard, hirt

-------------

PR: https://git.openjdk.org/jmc/pull/646

From hirt at openjdk.org  Thu Jul  3 19:02:28 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 3 Jul 2025 19:02:28 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames
Message-ID: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>

Alternative solution.

-------------

Commit messages:
 - Always get specific test resources by name
 - Forgotten properties file
 - Cleanup and fix
 - Copyright
 - Copyright
 - Better variant, with tests
 - Slightly better variant
 - 8371: Hidden Frames, first attempt

Changes: https://git.openjdk.org/jmc/pull/657/files
  Webrev: Webrev is not available because diff is too large
  Issue: https://bugs.openjdk.org/browse/JMC-8371
  Stats: 2179085 lines in 70 files changed: 2178515 ins; 504 del; 66 mod
  Patch: https://git.openjdk.org/jmc/pull/657.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/657/head:pull/657

PR: https://git.openjdk.org/jmc/pull/657

From schaturvedi at openjdk.org  Thu Jul  3 19:02:28 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 3 Jul 2025 19:02:28 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames
In-Reply-To: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
References: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
Message-ID: <938MOIMfHNlfjQztKU8wKeF-YEaLq4JpuENEf9SbuD4=.70d2723e-1502-4ffa-9770-919b31898c86@github.com>

On Sat, 28 Jun 2025 20:23:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Alternative solution.

I have experimented with this code. 

1. I am not able to build it completely as there are test failures. I had to skip tests in order to build it successfully.
2. It seems message.properties change is missed thats why the text is not rendered properly. Attaching screenshot here:
 <img width="678" alt="JMCPreferenceScreen" src="https://github.com/user-attachments/assets/496543f0-60a9-42cd-bc68-e8e5a5fec25a" />

3. I have tested Stacktrace view (For Method Profiling Screen) and Automated Analysis Page (For a JFR which has 2 rules (Allocation class and Allocation Thread) showing hidden frames as part of their results). They worked perfectly fine with checkbox - checked and unchecked (tried changing the preference on the fly also).

Overall the code changes looks good to me. But I am not very sure about it effects (or side effects) at all other places. We would need a thorough sanity testing to avoid any regression.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/657#issuecomment-3026798702

From hirt at openjdk.org  Thu Jul  3 19:02:28 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 3 Jul 2025 19:02:28 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames
In-Reply-To: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
References: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
Message-ID: <JVxmGmPny8sat9-GtOdth-ZEMVaYuxBm4UXbyiWtUhE=.75e6e0a1-17bd-42e8-80cc-aba1f5aaf3dc@github.com>

On Sat, 28 Jun 2025 20:23:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Alternative solution.

This is very strange - the Mac tests fail on starting the p2 server. Everything passes on Linux and Windows. It is seemingly unrelated to my changes, as I haven't changed any pom files. @viragpurnam, do you have any idea?

Error: ] Some problems were encountered while processing the POMs:
Error:  'version' must be a constant version but is '${revision}${changelist}'. @ line 41, column 11
 @ 
Error:  The build could not read 1 project -> [Help 1]
Error:    
Error:    The project org.openjdk.jmc:external-dependencies:${revision}${changelist} (/Users/runner/work/jmc/jmc/releng/third-party/pom.xml) has 1 error
Error:      'version' must be a constant version but is '${revision}${changelist}'. @ line 41, column 11
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
Error: Process completed with exit code 1.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/657#issuecomment-3033216568

From hirt at openjdk.org  Thu Jul  3 20:38:22 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 3 Jul 2025 20:38:22 GMT
Subject: RFR: 8409: Create 9.1.1 release notes
Message-ID: <UwDnpi3tyzUEfYxGVg6Dwn1L-YmUdYCZN4bNTzb1qf4=.bc20fab4-7631-4f19-8803-d227760a10a2@github.com>

Release notes for the micro release.

-------------

Commit messages:
 - 8409: 9.1.1 Release Notes

Changes: https://git.openjdk.org/jmc/pull/658/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=658&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8409
  Stats: 43 lines in 8 files changed: 41 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/658.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/658/head:pull/658

PR: https://git.openjdk.org/jmc/pull/658

From vpurnam at openjdk.org  Fri Jul  4 07:49:24 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Fri, 4 Jul 2025 07:49:24 GMT
Subject: RFR: 8410: Update version for 9.1.1 release
Message-ID: <miTDP7w0AtEeTJeV0TVtKAtrlAynBChqIM0YXThHuFo=.836653bd-44b4-4f4d-bd88-25196ed55616@github.com>

Updated version from 9.1.0 to 9.1.1 for JMC micro release.

-------------

Commit messages:
 - 8410: hardcoded version in pom
 - 8410: Update version for 9.1.1 release

Changes: https://git.openjdk.org/jmc/pull/659/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=659&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8410
  Stats: 217 lines in 152 files changed: 0 ins; 0 del; 217 mod
  Patch: https://git.openjdk.org/jmc/pull/659.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/659/head:pull/659

PR: https://git.openjdk.org/jmc/pull/659

From hirt at openjdk.org  Fri Jul  4 08:02:47 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 4 Jul 2025 08:02:47 GMT
Subject: RFR: 8410: Update version for 9.1.1 release
In-Reply-To: <miTDP7w0AtEeTJeV0TVtKAtrlAynBChqIM0YXThHuFo=.836653bd-44b4-4f4d-bd88-25196ed55616@github.com>
References: <miTDP7w0AtEeTJeV0TVtKAtrlAynBChqIM0YXThHuFo=.836653bd-44b4-4f4d-bd88-25196ed55616@github.com>
Message-ID: <zFBrLhtp0wHcVpd_SFxvAw0uBHAfYWpvKllO7VSKvCA=.170bdb23-45ec-464f-a07a-cdc6459c5b43@github.com>

On Fri, 4 Jul 2025 07:44:14 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> Updated version from 9.1.0 to 9.1.1 for JMC micro release.

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/659#pullrequestreview-2986010035

From vpurnam at openjdk.org  Fri Jul  4 08:10:47 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Fri, 4 Jul 2025 08:10:47 GMT
Subject: Integrated: 8410: Update version for 9.1.1 release
In-Reply-To: <miTDP7w0AtEeTJeV0TVtKAtrlAynBChqIM0YXThHuFo=.836653bd-44b4-4f4d-bd88-25196ed55616@github.com>
References: <miTDP7w0AtEeTJeV0TVtKAtrlAynBChqIM0YXThHuFo=.836653bd-44b4-4f4d-bd88-25196ed55616@github.com>
Message-ID: <hD6blUJnqmdhcq1aZvY9Kl7cZt6_v8dFr-5vZ_SnReU=.6778f7b7-ce86-4ec4-ab7a-1198d9a2526b@github.com>

On Fri, 4 Jul 2025 07:44:14 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> Updated version from 9.1.0 to 9.1.1 for JMC micro release.

This pull request has now been integrated.

Changeset: 5d9978f0
Author:    Virag Purnam <vpurnam at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/5d9978f0741be601ed08db62d36b8f1658f264c4
Stats:     217 lines in 152 files changed: 0 ins; 0 del; 217 mod

8410: Update version for 9.1.1 release

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/659

From hirt at openjdk.org  Fri Jul  4 08:12:46 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 4 Jul 2025 08:12:46 GMT
Subject: RFR: 8409: Create 9.1.1 release notes
In-Reply-To: <UwDnpi3tyzUEfYxGVg6Dwn1L-YmUdYCZN4bNTzb1qf4=.bc20fab4-7631-4f19-8803-d227760a10a2@github.com>
References: <UwDnpi3tyzUEfYxGVg6Dwn1L-YmUdYCZN4bNTzb1qf4=.bc20fab4-7631-4f19-8803-d227760a10a2@github.com>
Message-ID: <sE50jdoZwgs0QMrW8yjt3-FEJNl6SaQ-uzFunH_Ug5Q=.ea564e15-60f7-4f93-8628-caab1f9f39ce@github.com>

On Thu, 3 Jul 2025 20:33:39 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Release notes for the micro release.

The failure is the same as in #657, which is clearly unrelated. I think it is fine to accept PRs that has this error, but which passes on both Windows and Ubuntu until we've solved it. Interim solution suggested by @viragpurnam is to hard code the version in the third party POM.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/658#issuecomment-3034921084

From hirt at openjdk.org  Fri Jul  4 08:17:46 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 4 Jul 2025 08:17:46 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames
In-Reply-To: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
References: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
Message-ID: <HgXSmDe9NMZUhr5DjfDGLUnmflmE_ekAb3BQtjTziNs=.c162ada0-87b4-4f91-89a0-051e296b7fc7@github.com>

On Sat, 28 Jun 2025 20:23:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Alternative solution.

With #658 it is clear that the failure is CI-related, and unrelated to this change.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/657#issuecomment-3034932102

From vpurnam at openjdk.org  Fri Jul  4 08:18:45 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Fri, 4 Jul 2025 08:18:45 GMT
Subject: RFR: 8409: Create 9.1.1 release notes
In-Reply-To: <UwDnpi3tyzUEfYxGVg6Dwn1L-YmUdYCZN4bNTzb1qf4=.bc20fab4-7631-4f19-8803-d227760a10a2@github.com>
References: <UwDnpi3tyzUEfYxGVg6Dwn1L-YmUdYCZN4bNTzb1qf4=.bc20fab4-7631-4f19-8803-d227760a10a2@github.com>
Message-ID: <1s7UB9VAmQDTS7jEQ-CXvcB1fjv-HKtpScCEr7xawcU=.78bc9fee-edd8-4e11-a815-b47d329b5a47@github.com>

On Thu, 3 Jul 2025 20:33:39 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Release notes for the micro release.

Looks good.

-------------

Marked as reviewed by vpurnam (Reviewer).

PR Review: https://git.openjdk.org/jmc/pull/658#pullrequestreview-2986048365

From hirt at openjdk.org  Fri Jul  4 13:30:45 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 4 Jul 2025 13:30:45 GMT
Subject: Integrated: 8409: Create 9.1.1 release notes
In-Reply-To: <UwDnpi3tyzUEfYxGVg6Dwn1L-YmUdYCZN4bNTzb1qf4=.bc20fab4-7631-4f19-8803-d227760a10a2@github.com>
References: <UwDnpi3tyzUEfYxGVg6Dwn1L-YmUdYCZN4bNTzb1qf4=.bc20fab4-7631-4f19-8803-d227760a10a2@github.com>
Message-ID: <N9ttjo9OxUGAmh8Ns_SHpHK8YRhIYH5-7ufZpEU37ro=.cea5d497-485d-494b-93ba-f5a03cdff04b@github.com>

On Thu, 3 Jul 2025 20:33:39 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Release notes for the micro release.

This pull request has now been integrated.

Changeset: 3d521484
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/3d5214841c2a78f85f64a234031239a3335f1257
Stats:     43 lines in 8 files changed: 41 ins; 0 del; 2 mod

8409: Create 9.1.1 release notes

Reviewed-by: vpurnam

-------------

PR: https://git.openjdk.org/jmc/pull/658

From duke at openjdk.org  Fri Jul  4 14:18:31 2025
From: duke at openjdk.org (duke)
Date: Fri, 4 Jul 2025 14:18:31 GMT
Subject: git: openjdk/jmc: Added tag 9.1.1-rc for changeset 3d521484
Message-ID: <b64e275f-f74d-49ab-9584-613557217220@openjdk.org>

Tagged by: thegreystone <marcus at hirt.se>
Date:      2025-07-04 16:17:11 +0000

Release candidate for JMC 9.1.1
Changeset: 3d521484
Author:    Marcus Hirt <hirt at openjdk.org>
Date:      2025-07-04 13:28:06 +0000
URL:       https://git.openjdk.org/jmc/commit/3d5214841c2a78f85f64a234031239a3335f1257


From aptmac at openjdk.org  Fri Jul  4 17:06:44 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 4 Jul 2025 17:06:44 GMT
Subject: RFR: 8400: Add more show options for JMX Console graphs [v2]
In-Reply-To: <e-PbNrq0v1duCCPuj97L5YtLn6j2haQCvKXPXdahzMA=.f3ba6e96-634f-4248-88ae-0c19ab20a9f8@github.com>
References: <PlUXb8yV51V5BufXknA-MuDQLCR47tOXQXPUZU4Zo1Q=.af52bece-24ae-45d3-a0ca-f902fbdde4d0@github.com>
 <e-PbNrq0v1duCCPuj97L5YtLn6j2haQCvKXPXdahzMA=.f3ba6e96-634f-4248-88ae-0c19ab20a9f8@github.com>
Message-ID: <eAUoPe8GE_gmYNlqUK2JU3FQnxW93oArH3ikUfdkjXY=.4554b1af-6a92-4e4a-90d6-57fc0f9b3b52@github.com>

On Sat, 31 May 2025 22:41:10 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also cleaning up a little bit. There were some assumptions around the default XY chart that should be put in code etc.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Spotless

application/org.openjdk.jmc.greychart.ui/src/main/java/org/openjdk/jmc/greychart/ui/views/ChartMenuBuilder.java line 469:

> 467: 			getShell().setText(Messages.CustomTimeRangeDialog_TITLE);
> 468: 			Control contents = super.createContents(parent);
> 469: 			contents.getShell().setSize(450, 300);

Gave this a try on my Linux machine, and the controls get cut-off horizontally a bit early. It will need another 100px on the width. 

![Screenshot From 2025-07-04 12-06-43](https://github.com/user-attachments/assets/aeed48d6-a7f9-47da-9b45-316e4f41a937)

An alternative could be to allow these dialogs to be resized. To do so, the `isResizable()` on the dialog class can be overriden as follows:

@Override
protected boolean isResizable() {
	return true;
}

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/652#discussion_r2185797626

From hirt at openjdk.org  Mon Jul  7 14:48:58 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 7 Jul 2025 14:48:58 GMT
Subject: RFR: 8415: Spotless error in the main branch
Message-ID: <W4aU_AlDR3YST5J9XV92gteUTlxqmF2McbY1djemkp4=.c840bcfb-6ba9-46f0-9207-684de21b84f8@github.com>

A spotless error snuck in with a recent commit. This is fixing it. Note that the strange Mac CI problem is still there, so I am also hard coding the version in the third-party pom until we have a proper fix.

-------------

Commit messages:
 - Fixing Mac CI problem
 - Fixing spotless problem

Changes: https://git.openjdk.org/jmc/pull/661/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=661&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8415
  Stats: 17 lines in 2 files changed: 0 ins; 0 del; 17 mod
  Patch: https://git.openjdk.org/jmc/pull/661.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/661/head:pull/661

PR: https://git.openjdk.org/jmc/pull/661

From aptmac at openjdk.org  Mon Jul  7 15:11:47 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Mon, 7 Jul 2025 15:11:47 GMT
Subject: RFR: 8415: Spotless error in the main branch
In-Reply-To: <W4aU_AlDR3YST5J9XV92gteUTlxqmF2McbY1djemkp4=.c840bcfb-6ba9-46f0-9207-684de21b84f8@github.com>
References: <W4aU_AlDR3YST5J9XV92gteUTlxqmF2McbY1djemkp4=.c840bcfb-6ba9-46f0-9207-684de21b84f8@github.com>
Message-ID: <U75QAbM46MR_cV--wcUOLrib8pEKiH5bYcm-ZsiQB6A=.ffb1acf9-309a-4cbe-8db7-14c58e1805b0@github.com>

On Mon, 7 Jul 2025 14:43:39 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> A spotless error snuck in with a recent commit. This is fixing it. Note that the strange Mac CI problem is still there, so I am also hard coding the version in the third-party pom until we have a proper fix.

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/661#pullrequestreview-2994287438

From schaturvedi at openjdk.org  Mon Jul  7 18:35:47 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Mon, 7 Jul 2025 18:35:47 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames
In-Reply-To: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
References: <x_3OvEn_UbOyP4FOkvWj1sIq_9JWZs1anOvvKtR1JY0=.120069f5-577a-4d0d-8904-168af81cc00a@github.com>
Message-ID: <3Ok6VlVNRehjLh0D_09e9OenYvTRPX3b656EtamRM2k=.39ac4ff9-7695-48e2-844c-9de73dc29c6a@github.com>

On Sat, 28 Jun 2025 20:23:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Alternative solution.

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/StructTypes.java line 779:

> 777: 		}
> 778: 	}
> 779: 

Minor nit : one extra line here. However no other change in this file.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/657#discussion_r2190790092