RFR: 8371: Stacktrace should hide hidden frames
Suchita Chaturvedi
schaturvedi at openjdk.org
Thu Jul 3 19:02:28 UTC 2025
On Sat, 28 Jun 2025 20:23:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
> Alternative solution.
I have experimented with this code.
1. I am not able to build it completely as there are test failures. I had to skip tests in order to build it successfully.
2. It seems message.properties change is missed thats why the text is not rendered properly. Attaching screenshot here:
<img width="678" alt="JMCPreferenceScreen" src="https://github.com/user-attachments/assets/496543f0-60a9-42cd-bc68-e8e5a5fec25a" />
3. I have tested Stacktrace view (For Method Profiling Screen) and Automated Analysis Page (For a JFR which has 2 rules (Allocation class and Allocation Thread) showing hidden frames as part of their results). They worked perfectly fine with checkbox - checked and unchecked (tried changing the preference on the fly also).
Overall the code changes looks good to me. But I am not very sure about it effects (or side effects) at all other places. We would need a thorough sanity testing to avoid any regression.
-------------
PR Comment: https://git.openjdk.org/jmc/pull/657#issuecomment-3026798702
More information about the jmc-dev
mailing list