RFR: 8400: Add more show options for JMX Console graphs [v2]
Alex Macdonald
aptmac at openjdk.org
Fri Jul 4 17:06:44 UTC 2025
On Sat, 31 May 2025 22:41:10 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> Also cleaning up a little bit. There were some assumptions around the default XY chart that should be put in code etc.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>
> Spotless
application/org.openjdk.jmc.greychart.ui/src/main/java/org/openjdk/jmc/greychart/ui/views/ChartMenuBuilder.java line 469:
> 467: getShell().setText(Messages.CustomTimeRangeDialog_TITLE);
> 468: Control contents = super.createContents(parent);
> 469: contents.getShell().setSize(450, 300);
Gave this a try on my Linux machine, and the controls get cut-off horizontally a bit early. It will need another 100px on the width.

An alternative could be to allow these dialogs to be resized. To do so, the `isResizable()` on the dialog class can be overriden as follows:
@Override
protected boolean isResizable() {
return true;
}
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/652#discussion_r2185797626
More information about the jmc-dev
mailing list