RFR: 8416: Better Eclipse classpath entry defaults

Marcus Hirt hirt at openjdk.org
Fri Jul 18 12:58:10 UTC 2025


On Wed, 9 Jul 2025 13:26:34 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Should be pom derived.
>
> application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/.classpath line 3:
> 
>> 1: <?xml version="1.0" encoding="UTF-8"?>
>> 2: <classpath>
>> 3: 	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>
> 
> Any specific reason why are we hard coding 21 here?

Nope. Good catch! I'll take another pass and ensure that this is properly done for all classpath files.

> application/tests/org.openjdk.jmc.rjmx.services.jfr.test/.classpath line 3:
> 
>> 1: <?xml version="1.0" encoding="UTF-8"?>
>> 2: <classpath>
>> 3: 	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>
> 
> Any specific reason why are we hard coding 21 here?

Nope, good catch!

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/663#discussion_r2208748789
PR Review Comment: https://git.openjdk.org/jmc/pull/663#discussion_r2208749023


More information about the jmc-dev mailing list