RFR: 8365: Jolokia - Additional support for security mechanisms related to SSL / authentication, discovery restrictions

Martin Skarsaune duke at openjdk.org
Tue Jul 29 10:57:17 UTC 2025


On Sat, 12 Jul 2025 14:59:27 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https.

application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ConnectionWizardPage.java line 420:

> 418: 
> 419: 		fieldStack = new Composite(inner, SWT.NONE);
> 420: 		fieldStack.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, false, 2, 1));

Appearance: 
<img width="720" height="434" alt="image" src="https://github.com/user-attachments/assets/f4a6c9ed-1c75-4771-ad39-7a2f26ed8608" />

application/org.openjdk.jmc.console.ui/src/main/java/org/openjdk/jmc/console/ui/editor/internal/ConsoleEditor.java line 126:

> 124: 				// FIXME: Show stacktrace? (Need to show our own ExceptionDialog in that case, or maybe create our own DetailsAreaProvider, see WorkbenchStatusDialogManager.setDetailsAreaProvider)
> 125: 				return new Status(IStatus.ERROR, ConsolePlugin.PLUGIN_ID, IStatus.ERROR,
> 126: 						NLS.bind(e.getLocalizedMessage(), getEditorInput().getName(), e.getMessage()),

Apparently all the more detailed error message is in this method on the exception class

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaPlugin.java line 78:

> 76: 		JolokiaServiceManager serviceManager = JolokiaServiceManagerFactory.createJolokiaServiceManager(configuration,
> 77: 				new JulLogHandler(PLUGIN_ID), new AllowAllRestrictor(),
> 78: 				logHandler -> new TreeSet<ServerDetector>(Arrays.asList(ServerDetector.FALLBACK)));

Unrelated compiltion erro

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2202733282
PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2202735387
PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2202736056


More information about the jmc-dev mailing list