From hirt at openjdk.org  Sat Jun  7 23:03:34 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Sat, 7 Jun 2025 23:03:34 GMT
Subject: RFR: 8389: JMC must stop using finalizers
Message-ID: <kePAFiohqOw5Xn_ChpCDYgE_798kkKBcWiomidrsIRk=.91119299-90fb-4471-8400-afb8ec8b62a8@github.com>

Also fixing some shutdown behaviour.

-------------

Commit messages:
 - Cleanup
 - 8389: Getting rid of finalizers, also minor fixes

Changes: https://git.openjdk.org/jmc/pull/653/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=653&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8389
  Stats: 138 lines in 5 files changed: 100 ins; 20 del; 18 mod
  Patch: https://git.openjdk.org/jmc/pull/653.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/653/head:pull/653

PR: https://git.openjdk.org/jmc/pull/653

From schaturvedi at openjdk.org  Sun Jun  8 18:38:31 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sun, 8 Jun 2025 18:38:31 GMT
Subject: RFR: 5705: Explain metaspace in rule results
Message-ID: <0MdGBnvoKaMj5OyJU6irphKDcXmeQMVSKAdNfAvqTUo=.ef8ba5f0-1285-4fc8-9745-11749626b989@github.com>

This enhancement updates MetaspaceOomRule and IncreasingMetaspaceLiveSetRule with the proper explanation and relevant real time values which were missing.

-------------

Commit messages:
 - 5705: Explain metaspace in rule results

Changes: https://git.openjdk.org/jmc/pull/654/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=654&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-5705
  Stats: 44 lines in 6 files changed: 18 ins; 1 del; 25 mod
  Patch: https://git.openjdk.org/jmc/pull/654.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/654/head:pull/654

PR: https://git.openjdk.org/jmc/pull/654

From headius at openjdk.org  Sat Jun 14 13:38:33 2025
From: headius at openjdk.org (Charles Nutter)
Date: Sat, 14 Jun 2025 13:38:33 GMT
Subject: RFR: 8371: Stacktrace should hide hidden frames [v2]
In-Reply-To: <zwZUXIU-_LWmwHZlqjzKBXnPHxnDTlRNiNUz3OX2in0=.df89bdb5-7077-4139-b64b-180596284375@github.com>
References: <M5DHZ4xosLSMZnPb7jpkjqChkRXMPVXboyGCSZm3aPM=.31fcc88e-afe2-432e-bf2a-1781b202c886@github.com>
 <zwZUXIU-_LWmwHZlqjzKBXnPHxnDTlRNiNUz3OX2in0=.df89bdb5-7077-4139-b64b-180596284375@github.com>
Message-ID: <5z-GNEe4zlZBW6XJ55k8A0S3I7QXaWDbxvzKu9E1Gmc=.15371688-b8b4-4dbb-9d21-5c3a3587a170@github.com>

On Fri, 11 Apr 2025 10:51:28 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> JFR tool is hiding all the hidden frames. But in JMC, Stacktrace view is still showing lot of hidden methods which is not required from the users point of view. Hence, we will be hiding all the hidden frames as part of this enhancement.
>> 
>> Also, we have updated some test cases also in order to get rid of hidden frames which were expected by the test cases.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed ArrayList and replaced FOR-loop implementation with Streams

Just a note, async-profiler has this feature and it seems to work well there. I am not sure whether it is something they do in the native binding or if it's something they do to post-process, but it helps unify multiple "essentially identical" stacks when they differ only by LambdaForm frames, which is critical for profiling heavy invokedynamic-using libraries and languages (like JRuby).

I'll try to circle back to this and help.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/632#issuecomment-2972767663

From hdafgard at openjdk.org  Sat Jun 14 14:55:35 2025
From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Sat, 14 Jun 2025 14:55:35 GMT
Subject: RFR: 5705: Explain metaspace in rule results
In-Reply-To: <0MdGBnvoKaMj5OyJU6irphKDcXmeQMVSKAdNfAvqTUo=.ef8ba5f0-1285-4fc8-9745-11749626b989@github.com>
References: <0MdGBnvoKaMj5OyJU6irphKDcXmeQMVSKAdNfAvqTUo=.ef8ba5f0-1285-4fc8-9745-11749626b989@github.com>
Message-ID: <APFgqwgVuvZL2MFgVDUEVzWtXWV45WWJ71iTaXnZ_zE=.27bdeec0-09fb-4f7d-8caf-4a249bec54ca@github.com>

On Sun, 8 Jun 2025 18:34:07 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This enhancement updates MetaspaceOomRule and IncreasingMetaspaceLiveSetRule with the proper explanation and relevant real time values which were missing.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 523:

> 521: ManyRunningProcessesRule_INFO_LIMIT_LONG=The number of simultaneous processes needed to trigger an info notice
> 522: MetaspaceOomRuleFactory_RULE_NAME=Metaspace Out of Memory
> 523: MetaspaceOomRuleFactory_TEXT_CAUSE=Java class metadata is allocated in native memory (metaspace). When the amount of native memory needed for a class metadata exceeds MaxMetaSpaceSize, a java.lang.OutOfMemoryError exception with a detail MetaSpace is thrown. The amount of metaspace that can be used for class metadata is limited by the parameter MaxMetaSpaceSize, which is specified on the command line.

It should be MaxMetaspaceSize, not MaxMetaSpaceSize.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 524:

> 522: MetaspaceOomRuleFactory_RULE_NAME=Metaspace Out of Memory
> 523: MetaspaceOomRuleFactory_TEXT_CAUSE=Java class metadata is allocated in native memory (metaspace). When the amount of native memory needed for a class metadata exceeds MaxMetaSpaceSize, a java.lang.OutOfMemoryError exception with a detail MetaSpace is thrown. The amount of metaspace that can be used for class metadata is limited by the parameter MaxMetaSpaceSize, which is specified on the command line.
> 524: MetaspaceOomRuleFactory_TEXT_ACTION=If MaxMetaSpaceSize, has been set on the command-line, increase its value. MetaSpace is allocated from the same address spaces as the Java heap. Reducing the size of the Java heap will make more space available for MetaSpace.

Not a blocker, but I think it'd be nice if we checked the flag events (if available). We can say both what the current value is, and if it was set on the command line adjust the text. Something like "MaxMetaspaceSize was set to {maxMetaspaceSize} on the command line, increasing this value may help resolve the error."

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/654#discussion_r2146973008
PR Review Comment: https://git.openjdk.org/jmc/pull/654#discussion_r2146972412

From schaturvedi at openjdk.org  Sat Jun 14 18:35:46 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sat, 14 Jun 2025 18:35:46 GMT
Subject: RFR: 5705: Explain metaspace in rule results [v2]
In-Reply-To: <0MdGBnvoKaMj5OyJU6irphKDcXmeQMVSKAdNfAvqTUo=.ef8ba5f0-1285-4fc8-9745-11749626b989@github.com>
References: <0MdGBnvoKaMj5OyJU6irphKDcXmeQMVSKAdNfAvqTUo=.ef8ba5f0-1285-4fc8-9745-11749626b989@github.com>
Message-ID: <mfiV2TfsOQDvPqkoy0T764lq7G4BkLDWS0n51SDSJ28=.1b922281-faa0-4ebd-93e7-47a9b675a2af@github.com>

> This enhancement updates MetaspaceOomRule and IncreasingMetaspaceLiveSetRule with the proper explanation and relevant real time values which were missing.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Implemented review comments

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/654/files
  - new: https://git.openjdk.org/jmc/pull/654/files/f7765bc2..26ba259d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=654&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=654&range=00-01

  Stats: 40 lines in 7 files changed: 22 ins; 0 del; 18 mod
  Patch: https://git.openjdk.org/jmc/pull/654.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/654/head:pull/654

PR: https://git.openjdk.org/jmc/pull/654

From hdafgard at openjdk.org  Wed Jun 18 13:25:37 2025
From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Wed, 18 Jun 2025 13:25:37 GMT
Subject: RFR: 5705: Explain metaspace in rule results [v2]
In-Reply-To: <mfiV2TfsOQDvPqkoy0T764lq7G4BkLDWS0n51SDSJ28=.1b922281-faa0-4ebd-93e7-47a9b675a2af@github.com>
References: <0MdGBnvoKaMj5OyJU6irphKDcXmeQMVSKAdNfAvqTUo=.ef8ba5f0-1285-4fc8-9745-11749626b989@github.com>
 <mfiV2TfsOQDvPqkoy0T764lq7G4BkLDWS0n51SDSJ28=.1b922281-faa0-4ebd-93e7-47a9b675a2af@github.com>
Message-ID: <zzygcKrSD1_OtsoAZAiJ6Myr_DjAoY_GEmsjSNa6Mig=.2d862846-ae0b-431a-ba01-c854c9db4697@github.com>

On Sat, 14 Jun 2025 18:35:46 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This enhancement updates MetaspaceOomRule and IncreasingMetaspaceLiveSetRule with the proper explanation and relevant real time values which were missing.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/MetaspaceOomRule.java line 102:

> 100: 						.addResult(OOM_EVENTS, oomCount).build();
> 101: 			}
> 102: 

This would be cleaner if you only place the `.addResult(MAX_METASPACE_SIZE, maxMetaspaceSize)` line inside the if-block.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 523:

> 521: ManyRunningProcessesRule_INFO_LIMIT_LONG=The number of simultaneous processes needed to trigger an info notice
> 522: MetaspaceOomRuleFactory_RULE_NAME=Metaspace Out of Memory
> 523: MetaspaceOomRuleFactory_TEXT_CAUSE=Java class metadata is allocated in native memory (metaspace). When the amount of native memory needed for a class metadata exceeds MaxMetaspaceSize, a java.lang.OutOfMemoryError exception with a detail MetaSpace is thrown. The amount of metaspace that can be used for class metadata is limited by the parameter MaxMetaspaceSize, which is specified on the command line.

It should be Metaspace instead of MetaSpace here as well.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/654#discussion_r2147123990
PR Review Comment: https://git.openjdk.org/jmc/pull/654#discussion_r2154598362

From schaturvedi at openjdk.org  Wed Jun 18 13:48:35 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Wed, 18 Jun 2025 13:48:35 GMT
Subject: RFR: 5705: Explain metaspace in rule results [v2]
In-Reply-To: <zzygcKrSD1_OtsoAZAiJ6Myr_DjAoY_GEmsjSNa6Mig=.2d862846-ae0b-431a-ba01-c854c9db4697@github.com>
References: <0MdGBnvoKaMj5OyJU6irphKDcXmeQMVSKAdNfAvqTUo=.ef8ba5f0-1285-4fc8-9745-11749626b989@github.com>
 <mfiV2TfsOQDvPqkoy0T764lq7G4BkLDWS0n51SDSJ28=.1b922281-faa0-4ebd-93e7-47a9b675a2af@github.com>
 <zzygcKrSD1_OtsoAZAiJ6Myr_DjAoY_GEmsjSNa6Mig=.2d862846-ae0b-431a-ba01-c854c9db4697@github.com>
Message-ID: <Fzn_U_3XQYbtk2NXq3IARpUEa9cPhtdq5-0vO_wCaZE=.7d931213-2afe-4736-94dd-177dadfab2d7@github.com>

On Sat, 14 Jun 2025 18:38:02 GMT, Henrik Dafg?rd <hdafgard at openjdk.org> wrote:

>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implemented review comments
>
> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/MetaspaceOomRule.java line 102:
> 
>> 100: 						.addResult(OOM_EVENTS, oomCount).build();
>> 101: 			}
>> 102: 
> 
> This would be cleaner if you only place the `.addResult(MAX_METASPACE_SIZE, maxMetaspaceSize)` line inside the if-block.

I have placed it in IF block only. Else block doesn't have it.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/654#discussion_r2154656650

From schaturvedi at openjdk.org  Wed Jun 18 14:49:18 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Wed, 18 Jun 2025 14:49:18 GMT
Subject: RFR: 5705: Explain metaspace in rule results [v3]
In-Reply-To: <0MdGBnvoKaMj5OyJU6irphKDcXmeQMVSKAdNfAvqTUo=.ef8ba5f0-1285-4fc8-9745-11749626b989@github.com>
References: <0MdGBnvoKaMj5OyJU6irphKDcXmeQMVSKAdNfAvqTUo=.ef8ba5f0-1285-4fc8-9745-11749626b989@github.com>
Message-ID: <BzsM6MEtpkRJSHaoCaZgQggBgGaIf07KKu6h72vqVUA=.4ba5d2d0-3967-46cf-a46a-c5c7ce8a5d37@github.com>

> This enhancement updates MetaspaceOomRule and IncreasingMetaspaceLiveSetRule with the proper explanation and relevant real time values which were missing.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Updated IF-ELSE block and Metaspace case sensitive spelling

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/654/files
  - new: https://git.openjdk.org/jmc/pull/654/files/26ba259d..26daa9e1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=654&range=02
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=654&range=01-02

  Stats: 33 lines in 3 files changed: 9 ins; 9 del; 15 mod
  Patch: https://git.openjdk.org/jmc/pull/654.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/654/head:pull/654

PR: https://git.openjdk.org/jmc/pull/654

From schaturvedi at openjdk.org  Wed Jun 18 14:49:18 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Wed, 18 Jun 2025 14:49:18 GMT
Subject: RFR: 5705: Explain metaspace in rule results [v2]
In-Reply-To: <zzygcKrSD1_OtsoAZAiJ6Myr_DjAoY_GEmsjSNa6Mig=.2d862846-ae0b-431a-ba01-c854c9db4697@github.com>
References: <0MdGBnvoKaMj5OyJU6irphKDcXmeQMVSKAdNfAvqTUo=.ef8ba5f0-1285-4fc8-9745-11749626b989@github.com>
 <mfiV2TfsOQDvPqkoy0T764lq7G4BkLDWS0n51SDSJ28=.1b922281-faa0-4ebd-93e7-47a9b675a2af@github.com>
 <zzygcKrSD1_OtsoAZAiJ6Myr_DjAoY_GEmsjSNa6Mig=.2d862846-ae0b-431a-ba01-c854c9db4697@github.com>
Message-ID: <bNSpDBAhLFKGJ6BsLsipbKMNjpl60DqgVx2mHuVqxW4=.59cd5010-d061-42ed-a4f9-257edd4d04b2@github.com>

On Sat, 14 Jun 2025 18:38:02 GMT, Henrik Dafg?rd <hdafgard at openjdk.org> wrote:

>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implemented review comments
>
> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/MetaspaceOomRule.java line 102:
> 
>> 100: 						.addResult(OOM_EVENTS, oomCount).build();
>> 101: 			}
>> 102: 
> 
> This would be cleaner if you only place the `.addResult(MAX_METASPACE_SIZE, maxMetaspaceSize)` line inside the if-block.

@Gunde I have updated the condition as per our discussion on slack.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/654#discussion_r2154807289

From hdafgard at openjdk.org  Thu Jun 19 15:51:35 2025
From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Thu, 19 Jun 2025 15:51:35 GMT
Subject: RFR: 5705: Explain metaspace in rule results [v3]
In-Reply-To: <BzsM6MEtpkRJSHaoCaZgQggBgGaIf07KKu6h72vqVUA=.4ba5d2d0-3967-46cf-a46a-c5c7ce8a5d37@github.com>
References: <0MdGBnvoKaMj5OyJU6irphKDcXmeQMVSKAdNfAvqTUo=.ef8ba5f0-1285-4fc8-9745-11749626b989@github.com>
 <BzsM6MEtpkRJSHaoCaZgQggBgGaIf07KKu6h72vqVUA=.4ba5d2d0-3967-46cf-a46a-c5c7ce8a5d37@github.com>
Message-ID: <dIw8NiGOE2eGPIvAqt3g66OJpyWcYS0vxnQrlsITBrg=.f2965bbc-1669-4021-b35e-78d2964d4312@github.com>

On Wed, 18 Jun 2025 14:49:18 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This enhancement updates MetaspaceOomRule and IncreasingMetaspaceLiveSetRule with the proper explanation and relevant real time values which were missing.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated IF-ELSE block and Metaspace case sensitive spelling

Marked as reviewed by hdafgard (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/654#pullrequestreview-2943504806

From schaturvedi at openjdk.org  Fri Jun 20 10:59:38 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Fri, 20 Jun 2025 10:59:38 GMT
Subject: Integrated: 5705: Explain metaspace in rule results
In-Reply-To: <0MdGBnvoKaMj5OyJU6irphKDcXmeQMVSKAdNfAvqTUo=.ef8ba5f0-1285-4fc8-9745-11749626b989@github.com>
References: <0MdGBnvoKaMj5OyJU6irphKDcXmeQMVSKAdNfAvqTUo=.ef8ba5f0-1285-4fc8-9745-11749626b989@github.com>
Message-ID: <kKWQtON0S7fRY6dAwMQURfZyXLFtTVwy9zuuaVgJhlI=.06790984-b369-4308-b565-35926f0fdf88@github.com>

On Sun, 8 Jun 2025 18:34:07 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This enhancement updates MetaspaceOomRule and IncreasingMetaspaceLiveSetRule with the proper explanation and relevant real time values which were missing.

This pull request has now been integrated.

Changeset: f1b63e0a
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/f1b63e0aeef0252218db03a88ca69c9d7fe5823a
Stats:     69 lines in 9 files changed: 40 ins; 1 del; 28 mod

5705: Explain metaspace in rule results

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.org/jmc/pull/654

From vpurnam at openjdk.org  Tue Jun 24 11:59:21 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Tue, 24 Jun 2025 11:59:21 GMT
Subject: RFR: 8404: Update to Eclipse 2025-06
Message-ID: <0z7TVXDEcO1YwwdVcq_CS2ogQ2ism4S4uxtywPyf_5U=.9456a0d3-2d5e-47a1-8456-ddff569ab50e@github.com>

Eclipse platform updated to 2025-06
Jetty version to 12.0.21 (Eclipse uses 12.0.21)
ASM version to 9.8 (Eclipse uses 9.8)

-------------

Commit messages:
 - 8404: Update to Eclipse 2025-06

Changes: https://git.openjdk.org/jmc/pull/655/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=655&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8404
  Stats: 160 lines in 10 files changed: 120 ins; 0 del; 40 mod
  Patch: https://git.openjdk.org/jmc/pull/655.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/655/head:pull/655

PR: https://git.openjdk.org/jmc/pull/655

From vpurnam at openjdk.org  Tue Jun 24 12:02:56 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Tue, 24 Jun 2025 12:02:56 GMT
Subject: RFR: 8404: Update to Eclipse 2025-06
Message-ID: <al_aidmlOZDMOl6UBSsxA9G-Mz7f7Gy3WUwQvhVy_SM=.511abb7b-47b7-47df-b8f4-9d0ce5dd5e64@github.com>

Eclipse platform updated to 2025-06
Jetty version to 12.0.21 (Eclipse uses 12.0.21)
ASM version to 9.8 (Eclipse uses 9.8)

-------------

Commit messages:
 - 8404: Update to Eclipse 2025-06
 - CherryPick JMC-8349
 - CherryPick
 - 8349: JMC Copyright year and some http links require update

Changes: https://git.openjdk.org/jmc/pull/656/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=656&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8404
  Stats: 8478 lines in 3513 files changed: 219 ins; 116 del; 8143 mod
  Patch: https://git.openjdk.org/jmc/pull/656.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/656/head:pull/656

PR: https://git.openjdk.org/jmc/pull/656

From vpurnam at openjdk.org  Tue Jun 24 12:16:18 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Tue, 24 Jun 2025 12:16:18 GMT
Subject: RFR: 8404: Update to Eclipse 2025-06 [v2]
In-Reply-To: <al_aidmlOZDMOl6UBSsxA9G-Mz7f7Gy3WUwQvhVy_SM=.511abb7b-47b7-47df-b8f4-9d0ce5dd5e64@github.com>
References: <al_aidmlOZDMOl6UBSsxA9G-Mz7f7Gy3WUwQvhVy_SM=.511abb7b-47b7-47df-b8f4-9d0ce5dd5e64@github.com>
Message-ID: <buedrTBd2rye5b_TxlkM9NbByrddEODzDGOkx5eGbt8=.f8532da6-e80c-4a20-b023-1206e2cff7d3@github.com>

> Eclipse platform updated to 2025-06
> Jetty version to 12.0.21 (Eclipse uses 12.0.21)
> ASM version to 9.8 (Eclipse uses 9.8)

Virag Purnam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:

 - Merge jmc9
 - 8404: Update to Eclipse 2025-06
 - CherryPick JMC-8349
 - CherryPick
 - 8349: JMC Copyright year and some http links require update
   
   Reviewed-by: vpurnam

-------------

Changes: https://git.openjdk.org/jmc/pull/656/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=656&range=01
  Stats: 452 lines in 28 files changed: 219 ins; 183 del; 50 mod
  Patch: https://git.openjdk.org/jmc/pull/656.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/656/head:pull/656

PR: https://git.openjdk.org/jmc/pull/656

From aptmac at openjdk.org  Tue Jun 24 14:21:44 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 24 Jun 2025 14:21:44 GMT
Subject: RFR: 8404: Update to Eclipse 2025-06 [v2]
In-Reply-To: <buedrTBd2rye5b_TxlkM9NbByrddEODzDGOkx5eGbt8=.f8532da6-e80c-4a20-b023-1206e2cff7d3@github.com>
References: <al_aidmlOZDMOl6UBSsxA9G-Mz7f7Gy3WUwQvhVy_SM=.511abb7b-47b7-47df-b8f4-9d0ce5dd5e64@github.com>
 <buedrTBd2rye5b_TxlkM9NbByrddEODzDGOkx5eGbt8=.f8532da6-e80c-4a20-b023-1206e2cff7d3@github.com>
Message-ID: <XOWC_3ax2WaWj-KdwZHJ40TavO03sN3HFlpvHFE3koE=.99027098-2cb6-4ce4-b3a5-537f57911c6f@github.com>

On Tue, 24 Jun 2025 12:16:18 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

>> Eclipse platform updated to 2025-06
>> Jetty version to 12.0.21 (Eclipse uses 12.0.21)
>> ASM version to 9.8 (Eclipse uses 9.8)
>
> Virag Purnam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge jmc9
>  - 8404: Update to Eclipse 2025-06
>  - CherryPick JMC-8349
>  - CherryPick
>  - 8349: JMC Copyright year and some http links require update
>    
>    Reviewed-by: vpurnam

Just a couple of formatting nits to do with indents, but looks to work well on Windows so far

releng/platform-definitions/platform-definition-2025-03/platform-definition-2025-03.target line 85:

> 83:             <unit id="org.eclipse.ui.net" version="1.5.400.v20240413-1529"/>
> 84:             <unit id="org.eclipse.equinox.p2.director.app" version="1.3.600.v20250129-0527"/>
> 85: 	    <unit id="org.eclipse.ui.themes" version="1.2.2700.v20250122-1423"/>

Looks like there's some indenting issues around here

releng/platform-definitions/platform-definition-2025-06/platform-definition-2025-06.target line 85:

> 83:             <unit id="org.eclipse.ui.net" version="1.5.400.v20240413-1529"/>
> 84:             <unit id="org.eclipse.equinox.p2.director.app" version="1.3.700.v20250513-0835"/>
> 85: 	    <unit id="org.eclipse.ui.themes" version="1.2.2800.v20250516-0925"/>

Needs an extra indent

-------------

PR Review: https://git.openjdk.org/jmc/pull/656#pullrequestreview-2954085487
PR Review Comment: https://git.openjdk.org/jmc/pull/656#discussion_r2164155592
PR Review Comment: https://git.openjdk.org/jmc/pull/656#discussion_r2164156539

From aptmac at openjdk.org  Tue Jun 24 14:23:39 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 24 Jun 2025 14:23:39 GMT
Subject: RFR: 8404: Update to Eclipse 2025-06
In-Reply-To: <0z7TVXDEcO1YwwdVcq_CS2ogQ2ism4S4uxtywPyf_5U=.9456a0d3-2d5e-47a1-8456-ddff569ab50e@github.com>
References: <0z7TVXDEcO1YwwdVcq_CS2ogQ2ism4S4uxtywPyf_5U=.9456a0d3-2d5e-47a1-8456-ddff569ab50e@github.com>
Message-ID: <7b29M75Z33lMIz0Q9Ap4aeCGqA4EOVMqzyDoNoT5IoI=.f86e2531-46df-413c-9fb6-6bb3001d0534@github.com>

On Tue, 24 Jun 2025 11:54:03 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> Eclipse platform updated to 2025-06
> Jetty version to 12.0.21 (Eclipse uses 12.0.21)
> ASM version to 9.8 (Eclipse uses 9.8)

Looks good, works well on Windows. There's just one minor indenting issue

releng/platform-definitions/platform-definition-2025-06/platform-definition-2025-06.target line 85:

> 83:             <unit id="org.eclipse.ui.net" version="1.5.400.v20240413-1529"/>
> 84:             <unit id="org.eclipse.equinox.p2.director.app" version="1.3.700.v20250513-0835"/>
> 85: 	    <unit id="org.eclipse.ui.themes" version="1.2.2800.v20250516-0925"/>

Same indenting issue as the other PR

-------------

PR Review: https://git.openjdk.org/jmc/pull/655#pullrequestreview-2954094772
PR Review Comment: https://git.openjdk.org/jmc/pull/655#discussion_r2164161504

From vpurnam at openjdk.org  Tue Jun 24 14:29:49 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Tue, 24 Jun 2025 14:29:49 GMT
Subject: RFR: 8404: Update to Eclipse 2025-06 [v3]
In-Reply-To: <al_aidmlOZDMOl6UBSsxA9G-Mz7f7Gy3WUwQvhVy_SM=.511abb7b-47b7-47df-b8f4-9d0ce5dd5e64@github.com>
References: <al_aidmlOZDMOl6UBSsxA9G-Mz7f7Gy3WUwQvhVy_SM=.511abb7b-47b7-47df-b8f4-9d0ce5dd5e64@github.com>
Message-ID: <PSy1m8KvfiPT3PqsajRNL6Jq5fwCscZro-6Sp5AajSk=.2cf47844-014e-468a-b972-3934023aecc9@github.com>

> Eclipse platform updated to 2025-06
> Jetty version to 12.0.21 (Eclipse uses 12.0.21)
> ASM version to 9.8 (Eclipse uses 9.8)

Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:

  fixed review comments

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/656/files
  - new: https://git.openjdk.org/jmc/pull/656/files/23866af1..85422692

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=656&range=02
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=656&range=01-02

  Stats: 6 lines in 3 files changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jmc/pull/656.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/656/head:pull/656

PR: https://git.openjdk.org/jmc/pull/656

From vpurnam at openjdk.org  Tue Jun 24 15:55:43 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Tue, 24 Jun 2025 15:55:43 GMT
Subject: RFR: 8404: Update to Eclipse 2025-06 [v2]
In-Reply-To: <XOWC_3ax2WaWj-KdwZHJ40TavO03sN3HFlpvHFE3koE=.99027098-2cb6-4ce4-b3a5-537f57911c6f@github.com>
References: <al_aidmlOZDMOl6UBSsxA9G-Mz7f7Gy3WUwQvhVy_SM=.511abb7b-47b7-47df-b8f4-9d0ce5dd5e64@github.com>
 <buedrTBd2rye5b_TxlkM9NbByrddEODzDGOkx5eGbt8=.f8532da6-e80c-4a20-b023-1206e2cff7d3@github.com>
 <XOWC_3ax2WaWj-KdwZHJ40TavO03sN3HFlpvHFE3koE=.99027098-2cb6-4ce4-b3a5-537f57911c6f@github.com>
Message-ID: <laV6BYs-FrLPYnp2L8zaWHxHYkpWdGbvd2yGw3SXllM=.3d94a86d-53af-465b-b377-c52922f73328@github.com>

On Tue, 24 Jun 2025 14:17:28 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Virag Purnam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Merge jmc9
>>  - 8404: Update to Eclipse 2025-06
>>  - CherryPick JMC-8349
>>  - CherryPick
>>  - 8349: JMC Copyright year and some http links require update
>>    
>>    Reviewed-by: vpurnam
>
> releng/platform-definitions/platform-definition-2025-03/platform-definition-2025-03.target line 85:
> 
>> 83:             <unit id="org.eclipse.ui.net" version="1.5.400.v20240413-1529"/>
>> 84:             <unit id="org.eclipse.equinox.p2.director.app" version="1.3.600.v20250129-0527"/>
>> 85: 	    <unit id="org.eclipse.ui.themes" version="1.2.2700.v20250122-1423"/>
> 
> Looks like there's some indenting issues around here

Thanks @aptmac, I have fixed this. Could you please check.

> releng/platform-definitions/platform-definition-2025-06/platform-definition-2025-06.target line 85:
> 
>> 83:             <unit id="org.eclipse.ui.net" version="1.5.400.v20240413-1529"/>
>> 84:             <unit id="org.eclipse.equinox.p2.director.app" version="1.3.700.v20250513-0835"/>
>> 85: 	    <unit id="org.eclipse.ui.themes" version="1.2.2800.v20250516-0925"/>
> 
> Needs an extra indent

Fixed this as well.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/656#discussion_r2164378357
PR Review Comment: https://git.openjdk.org/jmc/pull/656#discussion_r2164379042

From aptmac at openjdk.org  Tue Jun 24 15:59:39 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 24 Jun 2025 15:59:39 GMT
Subject: RFR: 8404: Update to Eclipse 2025-06 [v3]
In-Reply-To: <PSy1m8KvfiPT3PqsajRNL6Jq5fwCscZro-6Sp5AajSk=.2cf47844-014e-468a-b972-3934023aecc9@github.com>
References: <al_aidmlOZDMOl6UBSsxA9G-Mz7f7Gy3WUwQvhVy_SM=.511abb7b-47b7-47df-b8f4-9d0ce5dd5e64@github.com>
 <PSy1m8KvfiPT3PqsajRNL6Jq5fwCscZro-6Sp5AajSk=.2cf47844-014e-468a-b972-3934023aecc9@github.com>
Message-ID: <roe9DQR8CTxRknlHkNrTI5F_h9bjiBTp7k2UdZrTVBU=.5c1d454d-5151-4560-ab1c-2e98f820c71d@github.com>

On Tue, 24 Jun 2025 14:29:49 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

>> Eclipse platform updated to 2025-06
>> Jetty version to 12.0.21 (Eclipse uses 12.0.21)
>> ASM version to 9.8 (Eclipse uses 9.8)
>
> Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed review comments

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/656#pullrequestreview-2954464844

From vpurnam at openjdk.org  Tue Jun 24 16:10:53 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Tue, 24 Jun 2025 16:10:53 GMT
Subject: RFR: 8404: Update to Eclipse 2025-06 [v2]
In-Reply-To: <0z7TVXDEcO1YwwdVcq_CS2ogQ2ism4S4uxtywPyf_5U=.9456a0d3-2d5e-47a1-8456-ddff569ab50e@github.com>
References: <0z7TVXDEcO1YwwdVcq_CS2ogQ2ism4S4uxtywPyf_5U=.9456a0d3-2d5e-47a1-8456-ddff569ab50e@github.com>
Message-ID: <Ut8RkLWf-G54573VE5LnJ8mlv9f04zpmarcOG---l8w=.48651871-6058-432d-ba4b-af25ecd4dcdd@github.com>

> Eclipse platform updated to 2025-06
> Jetty version to 12.0.21 (Eclipse uses 12.0.21)
> ASM version to 9.8 (Eclipse uses 9.8)

Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:

  fixed indenting issues

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/655/files
  - new: https://git.openjdk.org/jmc/pull/655/files/5a3e2e00..e464a82b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=655&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=655&range=00-01

  Stats: 6 lines in 3 files changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jmc/pull/655.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/655/head:pull/655

PR: https://git.openjdk.org/jmc/pull/655

From aptmac at openjdk.org  Tue Jun 24 16:10:53 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 24 Jun 2025 16:10:53 GMT
Subject: RFR: 8404: Update to Eclipse 2025-06 [v2]
In-Reply-To: <Ut8RkLWf-G54573VE5LnJ8mlv9f04zpmarcOG---l8w=.48651871-6058-432d-ba4b-af25ecd4dcdd@github.com>
References: <0z7TVXDEcO1YwwdVcq_CS2ogQ2ism4S4uxtywPyf_5U=.9456a0d3-2d5e-47a1-8456-ddff569ab50e@github.com>
 <Ut8RkLWf-G54573VE5LnJ8mlv9f04zpmarcOG---l8w=.48651871-6058-432d-ba4b-af25ecd4dcdd@github.com>
Message-ID: <pirDsuUlIjMXpPqKNqoOH7gSFyMfT8IMOCWghTCTyWQ=.636c3994-608a-4f0b-813b-250c2630dd63@github.com>

On Tue, 24 Jun 2025 16:07:56 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

>> Eclipse platform updated to 2025-06
>> Jetty version to 12.0.21 (Eclipse uses 12.0.21)
>> ASM version to 9.8 (Eclipse uses 9.8)
>
> Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed indenting issues

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/655#pullrequestreview-2954503546

From vpurnam at openjdk.org  Tue Jun 24 16:10:54 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Tue, 24 Jun 2025 16:10:54 GMT
Subject: RFR: 8404: Update to Eclipse 2025-06 [v2]
In-Reply-To: <7b29M75Z33lMIz0Q9Ap4aeCGqA4EOVMqzyDoNoT5IoI=.f86e2531-46df-413c-9fb6-6bb3001d0534@github.com>
References: <0z7TVXDEcO1YwwdVcq_CS2ogQ2ism4S4uxtywPyf_5U=.9456a0d3-2d5e-47a1-8456-ddff569ab50e@github.com>
 <7b29M75Z33lMIz0Q9Ap4aeCGqA4EOVMqzyDoNoT5IoI=.f86e2531-46df-413c-9fb6-6bb3001d0534@github.com>
Message-ID: <4gkEGxaCvfp5tRrKH-JNsq1urA6dBpC0XTsTKrkZKDQ=.563dfc84-c7d9-4451-8d02-8118e56b9edc@github.com>

On Tue, 24 Jun 2025 14:20:05 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed indenting issues
>
> releng/platform-definitions/platform-definition-2025-06/platform-definition-2025-06.target line 85:
> 
>> 83:             <unit id="org.eclipse.ui.net" version="1.5.400.v20240413-1529"/>
>> 84:             <unit id="org.eclipse.equinox.p2.director.app" version="1.3.700.v20250513-0835"/>
>> 85: 	    <unit id="org.eclipse.ui.themes" version="1.2.2800.v20250516-0925"/>
> 
> Same indenting issue as the other PR

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/655#discussion_r2164411221