RFR: 5705: Explain metaspace in rule results [v2]
Suchita Chaturvedi
schaturvedi at openjdk.org
Wed Jun 18 13:48:35 UTC 2025
On Sat, 14 Jun 2025 18:38:02 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:
>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Implemented review comments
>
> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/MetaspaceOomRule.java line 102:
>
>> 100: .addResult(OOM_EVENTS, oomCount).build();
>> 101: }
>> 102:
>
> This would be cleaner if you only place the `.addResult(MAX_METASPACE_SIZE, maxMetaspaceSize)` line inside the if-block.
I have placed it in IF block only. Else block doesn't have it.
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/654#discussion_r2154656650
More information about the jmc-dev
mailing list