RFR: 8404: Update to Eclipse 2025-06 [v2]
Alex Macdonald
aptmac at openjdk.org
Tue Jun 24 14:21:44 UTC 2025
On Tue, 24 Jun 2025 12:16:18 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:
>> Eclipse platform updated to 2025-06
>> Jetty version to 12.0.21 (Eclipse uses 12.0.21)
>> ASM version to 9.8 (Eclipse uses 9.8)
>
> Virag Purnam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>
> - Merge jmc9
> - 8404: Update to Eclipse 2025-06
> - CherryPick JMC-8349
> - CherryPick
> - 8349: JMC Copyright year and some http links require update
>
> Reviewed-by: vpurnam
Just a couple of formatting nits to do with indents, but looks to work well on Windows so far
releng/platform-definitions/platform-definition-2025-03/platform-definition-2025-03.target line 85:
> 83: <unit id="org.eclipse.ui.net" version="1.5.400.v20240413-1529"/>
> 84: <unit id="org.eclipse.equinox.p2.director.app" version="1.3.600.v20250129-0527"/>
> 85: <unit id="org.eclipse.ui.themes" version="1.2.2700.v20250122-1423"/>
Looks like there's some indenting issues around here
releng/platform-definitions/platform-definition-2025-06/platform-definition-2025-06.target line 85:
> 83: <unit id="org.eclipse.ui.net" version="1.5.400.v20240413-1529"/>
> 84: <unit id="org.eclipse.equinox.p2.director.app" version="1.3.700.v20250513-0835"/>
> 85: <unit id="org.eclipse.ui.themes" version="1.2.2800.v20250516-0925"/>
Needs an extra indent
-------------
PR Review: https://git.openjdk.org/jmc/pull/656#pullrequestreview-2954085487
PR Review Comment: https://git.openjdk.org/jmc/pull/656#discussion_r2164155592
PR Review Comment: https://git.openjdk.org/jmc/pull/656#discussion_r2164156539
More information about the jmc-dev
mailing list