From duke at openjdk.org Thu Mar 13 22:19:08 2025 From: duke at openjdk.org (Martin Skarsaune) Date: Thu, 13 Mar 2025 22:19:08 GMT Subject: RFR: 8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment. Message-ID: <8Py5DvGtFsKLcMb2NDEU5bDopeckWBR0KeKdA_y62rY=.4e0a95d5-d5f8-4d0e-8065-572584db8ac1@github.com> 8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment. ------------- Commit messages: - JMC-8366: Display warning to only use Jolokia discovery in a trusted environment Changes: https://git.openjdk.org/jmc/pull/631/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=631&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8366 Stats: 14 lines in 3 files changed: 10 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/631.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/631/head:pull/631 PR: https://git.openjdk.org/jmc/pull/631 From duke at openjdk.org Thu Mar 13 22:19:08 2025 From: duke at openjdk.org (Martin Skarsaune) Date: Thu, 13 Mar 2025 22:19:08 GMT Subject: RFR: 8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment. In-Reply-To: <8Py5DvGtFsKLcMb2NDEU5bDopeckWBR0KeKdA_y62rY=.4e0a95d5-d5f8-4d0e-8065-572584db8ac1@github.com> References: <8Py5DvGtFsKLcMb2NDEU5bDopeckWBR0KeKdA_y62rY=.4e0a95d5-d5f8-4d0e-8065-572584db8ac1@github.com> Message-ID: On Thu, 13 Mar 2025 22:09:33 GMT, Martin Skarsaune wrote: > 8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment. cc: @viragpurnam ------------- PR Comment: https://git.openjdk.org/jmc/pull/631#issuecomment-2722803575 From duke at openjdk.org Thu Mar 13 22:22:19 2025 From: duke at openjdk.org (Martin Skarsaune) Date: Thu, 13 Mar 2025 22:22:19 GMT Subject: RFR: 8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment. [v2] In-Reply-To: <8Py5DvGtFsKLcMb2NDEU5bDopeckWBR0KeKdA_y62rY=.4e0a95d5-d5f8-4d0e-8065-572584db8ac1@github.com> References: <8Py5DvGtFsKLcMb2NDEU5bDopeckWBR0KeKdA_y62rY=.4e0a95d5-d5f8-4d0e-8065-572584db8ac1@github.com> Message-ID: > 8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment. Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: JMC-8366: Fix spotless violations ------------- Changes: - all: https://git.openjdk.org/jmc/pull/631/files - new: https://git.openjdk.org/jmc/pull/631/files/6993fa22..1a802195 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=631&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=631&range=00-01 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/631.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/631/head:pull/631 PR: https://git.openjdk.org/jmc/pull/631 From duke at openjdk.org Fri Mar 14 21:35:01 2025 From: duke at openjdk.org (duke) Date: Fri, 14 Mar 2025 21:35:01 GMT Subject: Withdrawn: 8336: Socket Read rule should filter jfr recordings In-Reply-To: <7eW1MjuxoeA5Cm_F9MrDDV0ZSQgQzVlMK2eFO5dGXMg=.c4f14f16-e2f5-4822-aa09-b09b3030dc3f@github.com> References: <7eW1MjuxoeA5Cm_F9MrDDV0ZSQgQzVlMK2eFO5dGXMg=.c4f14f16-e2f5-4822-aa09-b09b3030dc3f@github.com> Message-ID: <9Mt7IHoOR3M8ciQvX8fxb4sYwKtLiM1PVn1lGowUanE=.2470803e-4dc4-428a-95f1-0ed33a38ba9e@github.com> On Fri, 17 Jan 2025 15:07:18 GMT, Marcus Hirt wrote: > Also filtering /proc/self/smap as that is also a very "serviceability tool" thing to do. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jmc/pull/624 From duke at openjdk.org Mon Mar 17 09:38:52 2025 From: duke at openjdk.org (Martin Skarsaune) Date: Mon, 17 Mar 2025 09:38:52 GMT Subject: RFR: 8364: Fix JULONG handling to set stackdepth value In-Reply-To: References: Message-ID: On Tue, 4 Mar 2025 09:48:09 GMT, H?lios GILLES wrote: >> Fix JULONG handling to set stackdepth value >> >> --------- >> ### Progress >> - [ ] Commit message must refer to an issue >> - [ ] Change must be properly reviewed (1 review required, with at least 1 [Committer](https://openjdk.org/bylaws#committer)) >> >> ### Error >>  ?? The pull request body must not be empty. >> >> ### Reviewing >>
Using git >> >> Checkout this PR locally: \ >> `$ git fetch https://git.openjdk.org/jmc.git pull/630/head:pull/630` \ >> `$ git checkout pull/630` >> >> Update a local copy of the PR: \ >> `$ git checkout pull/630` \ >> `$ git pull https://git.openjdk.org/jmc.git pull/630/head` >> >>
>>
Using Skara CLI tools >> >> Checkout this PR locally: \ >> `$ git pr checkout 630` >> >> View PR using the GUI difftool: \ >> `$ git pr show -t 630` >> >>
>>
Using diff file >> >> Download this PR as a diff file: \ >> https://git.openjdk.org/jmc/pull/630.diff >> >>
> > @skarsaune Could you create an issue for that ? @RoiSoleil : Hmm, could you provide some context? I have very limited experience in this area. > Yes sorry ... > > Without the patch i'm unable to modifiy this value and so modify the stackdepth of my JVM : > > https://i.ibb.co/dw1qNnw3/2025-03-06-15-39-51-JDK-Mission-Control.png I see @RoiSoleil . Perhaps someone more experienced, such as @aptmac or @thegreystone are better suited to categorize and create an issue for it? Thanks ------------- PR Comment: https://git.openjdk.org/jmc/pull/630#issuecomment-2704021504 PR Comment: https://git.openjdk.org/jmc/pull/630#issuecomment-2704077715 From duke at openjdk.org Mon Mar 17 09:38:51 2025 From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES) Date: Mon, 17 Mar 2025 09:38:51 GMT Subject: RFR: 8364: Fix JULONG handling to set stackdepth value Message-ID: Fix JULONG handling to set stackdepth value --------- ### Progress - [ ] Commit message must refer to an issue - [ ] Change must be properly reviewed (1 review required, with at least 1 [Committer](https://openjdk.org/bylaws#committer)) ### Error  ?? The pull request body must not be empty. ### Reviewing
Using git Checkout this PR locally: \ `$ git fetch https://git.openjdk.org/jmc.git pull/630/head:pull/630` \ `$ git checkout pull/630` Update a local copy of the PR: \ `$ git checkout pull/630` \ `$ git pull https://git.openjdk.org/jmc.git pull/630/head`
Using Skara CLI tools Checkout this PR locally: \ `$ git pr checkout 630` View PR using the GUI difftool: \ `$ git pr show -t 630`
Using diff file Download this PR as a diff file: \ https://git.openjdk.org/jmc/pull/630.diff
------------- Commit messages: - Fix JULONG handling to set stackdepth value Changes: https://git.openjdk.org/jmc/pull/630/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=630&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8364 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/630.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/630/head:pull/630 PR: https://git.openjdk.org/jmc/pull/630 From duke at openjdk.org Mon Mar 17 09:38:51 2025 From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES) Date: Mon, 17 Mar 2025 09:38:51 GMT Subject: RFR: 8364: Fix JULONG handling to set stackdepth value In-Reply-To: References: Message-ID: On Mon, 3 Mar 2025 13:31:39 GMT, H?lios GILLES wrote: > Fix JULONG handling to set stackdepth value > > --------- > ### Progress > - [ ] Commit message must refer to an issue > - [ ] Change must be properly reviewed (1 review required, with at least 1 [Committer](https://openjdk.org/bylaws#committer)) > > ### Error >  ?? The pull request body must not be empty. > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.org/jmc.git pull/630/head:pull/630` \ > `$ git checkout pull/630` > > Update a local copy of the PR: \ > `$ git checkout pull/630` \ > `$ git pull https://git.openjdk.org/jmc.git pull/630/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 630` > > View PR using the GUI difftool: \ > `$ git pr show -t 630` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.org/jmc/pull/630.diff > >
@skarsaune Could you create an issue for that ? Yes sorry ... Without the patch i'm unable to modifiy this value and so modify the stackdepth of my JVM : https://i.ibb.co/dw1qNnw3/2025-03-06-15-39-51-JDK-Mission-Control.png ------------- PR Comment: https://git.openjdk.org/jmc/pull/630#issuecomment-2696865682 PR Comment: https://git.openjdk.org/jmc/pull/630#issuecomment-2704062875 From aptmac at openjdk.org Mon Mar 17 09:38:52 2025 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 17 Mar 2025 09:38:52 GMT Subject: RFR: 8364: Fix JULONG handling to set stackdepth value In-Reply-To: References: Message-ID: <4yrXbqGDa9WZAjXYgqiSkKQInGDBXzIetlqKNAKeX7g=.302fa2bf-f0f9-45fc-8fc0-5e3f1ee1b0ec@github.com> On Thu, 6 Mar 2025 14:47:34 GMT, H?lios GILLES wrote: >> Fix JULONG handling to set stackdepth value >> >> --------- >> ### Progress >> - [ ] Commit message must refer to an issue >> - [ ] Change must be properly reviewed (1 review required, with at least 1 [Committer](https://openjdk.org/bylaws#committer)) >> >> ### Error >>  ?? The pull request body must not be empty. >> >> ### Reviewing >>
Using git >> >> Checkout this PR locally: \ >> `$ git fetch https://git.openjdk.org/jmc.git pull/630/head:pull/630` \ >> `$ git checkout pull/630` >> >> Update a local copy of the PR: \ >> `$ git checkout pull/630` \ >> `$ git pull https://git.openjdk.org/jmc.git pull/630/head` >> >>
>>
Using Skara CLI tools >> >> Checkout this PR locally: \ >> `$ git pr checkout 630` >> >> View PR using the GUI difftool: \ >> `$ git pr show -t 630` >> >>
>>
Using diff file >> >> Download this PR as a diff file: \ >> https://git.openjdk.org/jmc/pull/630.diff >> >>
> > Yes sorry ... > > Without the patch i'm unable to modifiy this value and so modify the stackdepth of my JVM : > > https://i.ibb.co/dw1qNnw3/2025-03-06-15-39-51-JDK-Mission-Control.png @RoiSoleil I've opened up a jira ticket you can use: https://bugs.openjdk.org/browse/JMC-8364 If you add the `8364: ` to the front of the PR title then the Skara bot should be able to sync up with the ticket ------------- PR Comment: https://git.openjdk.org/jmc/pull/630#issuecomment-2704135227 From duke at openjdk.org Mon Mar 17 09:43:57 2025 From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES) Date: Mon, 17 Mar 2025 09:43:57 GMT Subject: RFR: 8364: Fix JULONG handling to set stackdepth value [v2] In-Reply-To: References: Message-ID: > Fix JULONG handling to set stackdepth value > > --------- > ### Progress > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed (1 review required, with at least 1 [Committer](https://openjdk.org/bylaws#committer)) > > ### Error >  ?? The pull request body must not be empty. > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.org/jmc.git pull/630/head:pull/630` \ > `$ git checkout pull/630` > > Update a local copy of the PR: \ > `$ git checkout pull/630` \ > `$ git pull https://git.openjdk.org/jmc.git pull/630/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 630` > > View PR using the GUI difftool: \ > `$ git pr show -t 630` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.org/jmc/pull/630.diff > >
H?lios GILLES has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8364: Fix JULONG handling to set stackdepth value ------------- Changes: - all: https://git.openjdk.org/jmc/pull/630/files - new: https://git.openjdk.org/jmc/pull/630/files/227a49e5..7e0535cf Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=630&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=630&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/630.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/630/head:pull/630 PR: https://git.openjdk.org/jmc/pull/630 From duke at openjdk.org Mon Mar 17 09:43:58 2025 From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES) Date: Mon, 17 Mar 2025 09:43:58 GMT Subject: RFR: 8364: Fix JULONG handling to set stackdepth value In-Reply-To: <4yrXbqGDa9WZAjXYgqiSkKQInGDBXzIetlqKNAKeX7g=.302fa2bf-f0f9-45fc-8fc0-5e3f1ee1b0ec@github.com> References: <4yrXbqGDa9WZAjXYgqiSkKQInGDBXzIetlqKNAKeX7g=.302fa2bf-f0f9-45fc-8fc0-5e3f1ee1b0ec@github.com> Message-ID: <-q6ozJfYCJxDfeOD1pHgHh1hdmND0VJXjwwKIOfLZtg=.039329ee-1d6b-428d-81ef-8afdc2078431@github.com> On Thu, 6 Mar 2025 15:12:59 GMT, Alex Macdonald wrote: >> Yes sorry ... >> >> Without the patch i'm unable to modifiy this value and so modify the stackdepth of my JVM : >> >> https://i.ibb.co/dw1qNnw3/2025-03-06-15-39-51-JDK-Mission-Control.png > > @RoiSoleil I've opened up a jira ticket you can use: https://bugs.openjdk.org/browse/JMC-8364 > > If you add the `8364: ` to the front of the PR title then the Skara bot should be able to sync up with the ticket @aptmac done ------------- PR Comment: https://git.openjdk.org/jmc/pull/630#issuecomment-2728805563 From aptmac at openjdk.org Mon Mar 17 13:20:00 2025 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 17 Mar 2025 13:20:00 GMT Subject: RFR: 8364: Fix JULONG handling to set stackdepth value [v2] In-Reply-To: References: Message-ID: On Mon, 17 Mar 2025 09:43:57 GMT, H?lios GILLES wrote: >> Fix JULONG handling to set stackdepth value >> >> --------- >> ### Progress >> - [x] Commit message must refer to an issue >> - [ ] Change must be properly reviewed (1 review required, with at least 1 [Committer](https://openjdk.org/bylaws#committer)) >> >> ### Error >>  ?? The pull request body must not be empty. >> >> ### Reviewing >>
Using git >> >> Checkout this PR locally: \ >> `$ git fetch https://git.openjdk.org/jmc.git pull/630/head:pull/630` \ >> `$ git checkout pull/630` >> >> Update a local copy of the PR: \ >> `$ git checkout pull/630` \ >> `$ git pull https://git.openjdk.org/jmc.git pull/630/head` >> >>
>>
Using Skara CLI tools >> >> Checkout this PR locally: \ >> `$ git pr checkout 630` >> >> View PR using the GUI difftool: \ >> `$ git pr show -t 630` >> >>
>>
Using diff file >> >> Download this PR as a diff file: \ >> https://git.openjdk.org/jmc/pull/630.diff >> >>
> > H?lios GILLES has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8364: Fix JULONG handling to set stackdepth value Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/630#pullrequestreview-2690463365 From duke at openjdk.org Tue Mar 18 00:48:16 2025 From: duke at openjdk.org (duke) Date: Tue, 18 Mar 2025 00:48:16 GMT Subject: Withdrawn: 8297: Update OptionsCheckRule for new JDK releases In-Reply-To: References: Message-ID: On Sat, 18 Jan 2025 14:04:34 GMT, Hendrik Schick wrote: > New cli-options were added for JDK release 22, 23 based on the official release notes (removed part and deprecated path) > https://www.oracle.com/java/technologies/javase/22-relnote-issues.html > https://www.oracle.com/java/technologies/javase/23-relnote-issues.html > > I also updated existing depcrecated options in the array based on > this file in the jdk https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/arguments.cpp#L516 which is regularly updated, i switched between git tags to find earlier options when they were part of the array. I did this to jdk10, but not before jdk version 10 for everything i could find. I can also update the arguments, which were obsoleted in jdk9. > > Any feedback appreciated, thank you. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jmc/pull/625 From duke at openjdk.org Tue Mar 18 09:00:17 2025 From: duke at openjdk.org (duke) Date: Tue, 18 Mar 2025 09:00:17 GMT Subject: RFR: 8364: Fix JULONG handling to set stackdepth value [v2] In-Reply-To: References: Message-ID: On Mon, 17 Mar 2025 09:43:57 GMT, H?lios GILLES wrote: >> Fix JULONG handling to set stackdepth value >> >> --------- >> ### Progress >> - [x] Commit message must refer to an issue >> - [ ] Change must be properly reviewed (1 review required, with at least 1 [Committer](https://openjdk.org/bylaws#committer)) >> >> ### Error >>  ?? The pull request body must not be empty. >> >> ### Reviewing >>
Using git >> >> Checkout this PR locally: \ >> `$ git fetch https://git.openjdk.org/jmc.git pull/630/head:pull/630` \ >> `$ git checkout pull/630` >> >> Update a local copy of the PR: \ >> `$ git checkout pull/630` \ >> `$ git pull https://git.openjdk.org/jmc.git pull/630/head` >> >>
>>
Using Skara CLI tools >> >> Checkout this PR locally: \ >> `$ git pr checkout 630` >> >> View PR using the GUI difftool: \ >> `$ git pr show -t 630` >> >>
>>
Using diff file >> >> Download this PR as a diff file: \ >> https://git.openjdk.org/jmc/pull/630.diff >> >>
> > H?lios GILLES has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8364: Fix JULONG handling to set stackdepth value @RoiSoleil Your change (at version 7e0535cf0aa3f14e7f8bb1e63b9195084135710d) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jmc/pull/630#issuecomment-2732177871 From duke at openjdk.org Tue Mar 18 09:00:18 2025 From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES) Date: Tue, 18 Mar 2025 09:00:18 GMT Subject: RFR: 8364: Fix JULONG handling to set stackdepth value In-Reply-To: <4yrXbqGDa9WZAjXYgqiSkKQInGDBXzIetlqKNAKeX7g=.302fa2bf-f0f9-45fc-8fc0-5e3f1ee1b0ec@github.com> References: <4yrXbqGDa9WZAjXYgqiSkKQInGDBXzIetlqKNAKeX7g=.302fa2bf-f0f9-45fc-8fc0-5e3f1ee1b0ec@github.com> Message-ID: On Thu, 6 Mar 2025 15:12:59 GMT, Alex Macdonald wrote: >> Yes sorry ... >> >> Without the patch i'm unable to modifiy this value and so modify the stackdepth of my JVM : >> >> https://i.ibb.co/dw1qNnw3/2025-03-06-15-39-51-JDK-Mission-Control.png > > @RoiSoleil I've opened up a jira ticket you can use: https://bugs.openjdk.org/browse/JMC-8364 > > If you add the `8364: ` to the front of the PR title then the Skara bot should be able to sync up with the ticket @aptmac could you sponsor ? ------------- PR Comment: https://git.openjdk.org/jmc/pull/630#issuecomment-2732181210 From duke at openjdk.org Tue Mar 18 13:29:26 2025 From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES) Date: Tue, 18 Mar 2025 13:29:26 GMT Subject: Integrated: 8364: Fix JULONG handling to set stackdepth value In-Reply-To: References: Message-ID: On Mon, 3 Mar 2025 13:31:39 GMT, H?lios GILLES wrote: > Fix JULONG handling to set stackdepth value > > --------- > ### Progress > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed (1 review required, with at least 1 [Committer](https://openjdk.org/bylaws#committer)) > > ### Error >  ?? The pull request body must not be empty. > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.org/jmc.git pull/630/head:pull/630` \ > `$ git checkout pull/630` > > Update a local copy of the PR: \ > `$ git checkout pull/630` \ > `$ git pull https://git.openjdk.org/jmc.git pull/630/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 630` > > View PR using the GUI difftool: \ > `$ git pr show -t 630` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.org/jmc/pull/630.diff > >
This pull request has now been integrated. Changeset: 23fb4f2a Author: H?lios GILLES Committer: Alex Macdonald URL: https://git.openjdk.org/jmc/commit/23fb4f2adc0afab0f008781a8c38ef4332f7744a Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8364: Fix JULONG handling to set stackdepth value Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/630 From schaturvedi at openjdk.org Tue Mar 25 19:32:00 2025 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Tue, 25 Mar 2025 19:32:00 GMT Subject: RFR: 8371: Stacktrace should hide hidden frames Message-ID: JFR tool is hiding all the hidden frames. But in JMC, Stacktrace view is still showing lot of hidden methods which is not required from the users point of view. Hence, we will be hiding all the hidden frames as part of this enhancement. Also, we have updated some test cases also in order to get rid of hidden frames which were expected by the test cases. ------------- Commit messages: - 8371: Stacktrace should hide hidden frames Changes: https://git.openjdk.org/jmc/pull/632/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=632&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8371 Stats: 210 lines in 3 files changed: 64 ins; 141 del; 5 mod Patch: https://git.openjdk.org/jmc/pull/632.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/632/head:pull/632 PR: https://git.openjdk.org/jmc/pull/632 From egahlin at openjdk.org Tue Mar 25 20:37:27 2025 From: egahlin at openjdk.org (Erik Gahlin) Date: Tue, 25 Mar 2025 20:37:27 GMT Subject: RFR: 8371: Stacktrace should hide hidden frames In-Reply-To: References: Message-ID: On Tue, 25 Mar 2025 19:27:30 GMT, Suchita Chaturvedi wrote: > JFR tool is hiding all the hidden frames. But in JMC, Stacktrace view is still showing lot of hidden methods which is not required from the users point of view. Hence, we will be hiding all the hidden frames as part of this enhancement. > > Also, we have updated some test cases also in order to get rid of hidden frames which were expected by the test cases. - Shouldn't this be something you enable/disable in a preferences dialog? - Allocating an ArrayList every time a frame is requested seems unnecessary. - What about the time complexity of iterating through a stack trace? Isn't this now O(n^2) instead of O(n)? ------------- PR Comment: https://git.openjdk.org/jmc/pull/632#issuecomment-2752451834 From duke at openjdk.org Wed Mar 26 05:28:32 2025 From: duke at openjdk.org (Hendrik Schick) Date: Wed, 26 Mar 2025 05:28:32 GMT Subject: RFR: 8297: update OptionsCheckRule jvm arguments Message-ID: New cli-options were added for JDK release 22, 23 based on the official release notes (removed part and deprecated path) https://www.oracle.com/java/technologies/javase/22-relnote-issues.html https://www.oracle.com/java/technologies/javase/23-relnote-issues.html I also updated existing depcrecated options in the array based on this file in the jdk https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/arguments.cpp#L516 which is regularly updated, i switched between git tags to find earlier options when they were part of the array. I did this to jdk10, but not before jdk version 10 for everything i could find. I can also update the arguments, which were obsoleted in jdk9. this pr was already approved previously by @Gunde; the pr was closed due to inactivity. ------------- Commit messages: - 8297: update OptionsCheckRule jvm arguments Changes: https://git.openjdk.org/jmc/pull/633/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=633&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8297 Stats: 66 lines in 3 files changed: 30 ins; 0 del; 36 mod Patch: https://git.openjdk.org/jmc/pull/633.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/633/head:pull/633 PR: https://git.openjdk.org/jmc/pull/633 From hirt at openjdk.org Wed Mar 26 14:03:22 2025 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 26 Mar 2025 14:03:22 GMT Subject: RFR: 8297: update OptionsCheckRule jvm arguments In-Reply-To: References: Message-ID: On Wed, 26 Mar 2025 05:25:19 GMT, Hendrik Schick wrote: > New cli-options were added for JDK release 22, 23 based on the official release notes (removed part and deprecated path) > https://www.oracle.com/java/technologies/javase/22-relnote-issues.html > https://www.oracle.com/java/technologies/javase/23-relnote-issues.html > > I also updated existing depcrecated options in the array based on > this file in the jdk https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/arguments.cpp#L516 which is regularly updated, i switched between git tags to find earlier options when they were part of the array. I did this to jdk10, but not before jdk version 10 for everything i could find. I can also update the arguments, which were obsoleted in jdk9. > > > this pr was already approved previously by @Gunde; the pr was closed due to inactivity. Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/633#pullrequestreview-2717314353 From hirt at openjdk.org Wed Mar 26 14:06:29 2025 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 26 Mar 2025 14:06:29 GMT Subject: Integrated: 8358: Create release notes for JMC 9.1.0 In-Reply-To: References: Message-ID: On Tue, 11 Feb 2025 21:05:49 GMT, Marcus Hirt wrote: > Release notes and images for JMC 9.1.0. This pull request has now been integrated. Changeset: a7826cd5 Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/a7826cd55a060c3ebb3784481b09e94e662fc225 Stats: 212 lines in 25 files changed: 210 ins; 0 del; 2 mod 8358: Create release notes for JMC 9.1.0 Reviewed-by: vpurnam ------------- PR: https://git.openjdk.org/jmc/pull/629 From duke at openjdk.org Thu Mar 27 14:54:35 2025 From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES) Date: Thu, 27 Mar 2025 14:54:35 GMT Subject: RFR: 8372: Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO Message-ID: Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO https://ibb.co/mrBQpYbQ ------------- Commit messages: - 8372: Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO Changes: https://git.openjdk.org/jmc/pull/634/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=634&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8372 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/634.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/634/head:pull/634 PR: https://git.openjdk.org/jmc/pull/634 From duke at openjdk.org Thu Mar 27 14:54:35 2025 From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES) Date: Thu, 27 Mar 2025 14:54:35 GMT Subject: RFR: 8372: Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO In-Reply-To: References: Message-ID: On Thu, 27 Mar 2025 13:36:46 GMT, H?lios GILLES wrote: > Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO > > https://ibb.co/mrBQpYbQ @aptmac How do i create a ticket in JIRA ? ------------- PR Comment: https://git.openjdk.org/jmc/pull/634#issuecomment-2758105849 From aptmac at openjdk.org Thu Mar 27 14:54:35 2025 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 27 Mar 2025 14:54:35 GMT Subject: RFR: 8372: Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO In-Reply-To: References: Message-ID: On Thu, 27 Mar 2025 13:45:22 GMT, H?lios GILLES wrote: >> Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO >> >> https://ibb.co/mrBQpYbQ > > @aptmac How do i create a ticket in JIRA ? @RoiSoleil you'll need to have at least author status on an OpenJDK project in order to create tickets, which you should be eligible for after your second commit. In the meantime, I've opened a ticket you can use: https://bugs.openjdk.org/browse/JMC-8372 ------------- PR Comment: https://git.openjdk.org/jmc/pull/634#issuecomment-2758171026 From duke at openjdk.org Fri Mar 28 07:48:41 2025 From: duke at openjdk.org (=?UTF-8?B?SMOpbGlvcw==?= GILLES) Date: Fri, 28 Mar 2025 07:48:41 GMT Subject: RFR: 8372: Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO In-Reply-To: References: Message-ID: On Thu, 27 Mar 2025 14:02:10 GMT, Alex Macdonald wrote: >> @aptmac How do i create a ticket in JIRA ? > > @RoiSoleil you'll need to have at least author status on an OpenJDK project in order to create tickets, which you should be eligible for after your second commit. > > In the meantime, I've opened a ticket you can use: https://bugs.openjdk.org/browse/JMC-8372 @aptmac Thx for the ticket ;) Could you review the change ? ------------- PR Comment: https://git.openjdk.org/jmc/pull/634#issuecomment-2760464305 From hirt at openjdk.org Sat Mar 29 18:45:25 2025 From: hirt at openjdk.org (Marcus Hirt) Date: Sat, 29 Mar 2025 18:45:25 GMT Subject: RFR: 8297: Update OptionsCheckRule for new JDK releases In-Reply-To: References: Message-ID: On Wed, 26 Mar 2025 05:25:19 GMT, Hendrik Schick wrote: > New cli-options were added for JDK release 22, 23 based on the official release notes (removed part and deprecated path) > https://www.oracle.com/java/technologies/javase/22-relnote-issues.html > https://www.oracle.com/java/technologies/javase/23-relnote-issues.html > > I also updated existing depcrecated options in the array based on > this file in the jdk https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/arguments.cpp#L516 which is regularly updated, i switched between git tags to find earlier options when they were part of the array. I did this to jdk10, but not before jdk version 10 for everything i could find. I can also update the arguments, which were obsoleted in jdk9. > > > this pr was already approved previously by @Gunde; the pr was closed due to inactivity. Thank you for your contribution Hendrik! ------------- PR Comment: https://git.openjdk.org/jmc/pull/633#issuecomment-2764040859 From duke at openjdk.org Sat Mar 29 18:45:26 2025 From: duke at openjdk.org (Hendrik Schick) Date: Sat, 29 Mar 2025 18:45:26 GMT Subject: Integrated: 8297: Update OptionsCheckRule for new JDK releases In-Reply-To: References: Message-ID: On Wed, 26 Mar 2025 05:25:19 GMT, Hendrik Schick wrote: > New cli-options were added for JDK release 22, 23 based on the official release notes (removed part and deprecated path) > https://www.oracle.com/java/technologies/javase/22-relnote-issues.html > https://www.oracle.com/java/technologies/javase/23-relnote-issues.html > > I also updated existing depcrecated options in the array based on > this file in the jdk https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/arguments.cpp#L516 which is regularly updated, i switched between git tags to find earlier options when they were part of the array. I did this to jdk10, but not before jdk version 10 for everything i could find. I can also update the arguments, which were obsoleted in jdk9. > > > this pr was already approved previously by @Gunde; the pr was closed due to inactivity. This pull request has now been integrated. Changeset: ec909fb0 Author: Hendrik Schick Committer: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/ec909fb04a14ead1a705af1c15bcd047fa728339 Stats: 66 lines in 3 files changed: 30 ins; 0 del; 36 mod 8297: Update OptionsCheckRule for new JDK releases Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/633