From hirt at openjdk.org  Thu May  1 20:34:26 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 1 May 2025 20:34:26 GMT
Subject: RFR: 8392: Memory view on MacOS keeps reverting to aggregate trace
 list
Message-ID: <GeVYp9b8JbLrFsmsN7onFtAUHaBS1qCNf8mz6V-q22E=.f1044c3b-55e4-4b26-8057-fac10cab37da@github.com>

Annoying issue.

-------------

Commit messages:
 - Tracking and making the future cancellable for model updates
 - 8392: Fixing listener effect race by having one listener

Changes: https://git.openjdk.org/jmc/pull/647/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=647&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8392
  Stats: 23 lines in 2 files changed: 16 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jmc/pull/647.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/647/head:pull/647

PR: https://git.openjdk.org/jmc/pull/647

From headius at openjdk.org  Thu May  1 21:32:53 2025
From: headius at openjdk.org (Charles Nutter)
Date: Thu, 1 May 2025 21:32:53 GMT
Subject: RFR: 8392: Memory view on MacOS keeps reverting to aggregate trace
 list
In-Reply-To: <GeVYp9b8JbLrFsmsN7onFtAUHaBS1qCNf8mz6V-q22E=.f1044c3b-55e4-4b26-8057-fac10cab37da@github.com>
References: <GeVYp9b8JbLrFsmsN7onFtAUHaBS1qCNf8mz6V-q22E=.f1044c3b-55e4-4b26-8057-fac10cab37da@github.com>
Message-ID: <E6HjJY-J55ImNAHW9mAKgROW1ZDeA9SgrFh0m5pKqZI=.1889c0d7-b244-4c12-aa0c-530f8f571710@github.com>

On Thu, 1 May 2025 20:29:43 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Annoying issue.

Makes sense. ?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/647#issuecomment-2845823574

From schaturvedi at openjdk.org  Sun May  4 09:23:29 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sun, 4 May 2025 09:23:29 GMT
Subject: RFR: 8385: Upgrade hashing algorithm [v2]
In-Reply-To: <MzYZu9QbK6VUFUgDHTjhZmqiwqr6CvgPOATLupIO1yY=.6e8d60c3-8a22-401d-b4d7-9a53180b45b4@github.com>
References: <MzYZu9QbK6VUFUgDHTjhZmqiwqr6CvgPOATLupIO1yY=.6e8d60c3-8a22-401d-b4d7-9a53180b45b4@github.com>
Message-ID: <JcWuB4XEjybFJe5WwMF9ZcKrldMuU8wWpDpbutBvkoQ=.bdeeab8e-fa7a-416f-a558-458de35dd498@github.com>

> Upgrading hashing algorithm as part of this PR.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Updated the name of hashing algorithm

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/641/files
  - new: https://git.openjdk.org/jmc/pull/641/files/523db613..7f906dd8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=641&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=641&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/641.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/641/head:pull/641

PR: https://git.openjdk.org/jmc/pull/641

From schaturvedi at openjdk.org  Sun May  4 10:02:50 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sun, 4 May 2025 10:02:50 GMT
Subject: RFR: 8385: Upgrade hashing algorithm
In-Reply-To: <2uKj5HitnFi0ZTtBnbzuqkepffw_bs_PS3RZjGYH8yU=.18d9f29d-b44f-4d92-b955-725ebe7004db@github.com>
References: <MzYZu9QbK6VUFUgDHTjhZmqiwqr6CvgPOATLupIO1yY=.6e8d60c3-8a22-401d-b4d7-9a53180b45b4@github.com>
 <2uKj5HitnFi0ZTtBnbzuqkepffw_bs_PS3RZjGYH8yU=.18d9f29d-b44f-4d92-b955-725ebe7004db@github.com>
Message-ID: <grC5VsnlKk9-CTnIUBnuRlbOYK3I7zEzSKBNdUcj4QM=.eef0e846-a3c5-4a77-8c67-54408167d67c@github.com>

On Fri, 25 Apr 2025 16:45:44 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

> I lack context on this, but what about older HmacSHA1 backward compat.

As per my understanding, this will be called on the initialization of UIPlugin. So when, user will install new version of JMC (i.e. 10) the algorithm will be initialized to latest one instead of the older one. The older passwords saved for previous release will anyways be null and void and will not be applicable for new release. Hence backward compatibility is not required here.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/641#issuecomment-2849120259

From vpurnam at openjdk.org  Tue May  6 10:40:30 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Tue, 6 May 2025 10:40:30 GMT
Subject: RFR: 8395: Thread ID is not properly visible on hover for Mac
Message-ID: <Uxl-3Y82hq_MqGIz_Onygek4uhRk3adwF_vHjXakDbQ=.49eddd81-0c93-47d4-8f63-8fd08eda7d61@github.com>

In MAC, thread ID is not visible when user hover on thread name. 
Disabled the text wrap to fix the issue.

**Issue:**
<img width="1401" alt="8395_Bug" src="https://github.com/user-attachments/assets/e1c34a23-195e-4cd0-b1ec-c37f0b512b89" />

**Fix:**
<img width="1420" alt="8395_Fix" src="https://github.com/user-attachments/assets/8994ee05-2066-4d79-bfb0-cc1b8d0dc46c" />

-------------

Commit messages:
 - 8395: Thread ID is not properly visible on hover for Mac

Changes: https://git.openjdk.org/jmc/pull/648/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=648&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8395
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/648.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/648/head:pull/648

PR: https://git.openjdk.org/jmc/pull/648

From hirt at openjdk.org  Wed May  7 17:11:25 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 7 May 2025 17:11:25 GMT
Subject: RFR: 8395: Thread ID is not properly visible on hover for Mac
In-Reply-To: <Uxl-3Y82hq_MqGIz_Onygek4uhRk3adwF_vHjXakDbQ=.49eddd81-0c93-47d4-8f63-8fd08eda7d61@github.com>
References: <Uxl-3Y82hq_MqGIz_Onygek4uhRk3adwF_vHjXakDbQ=.49eddd81-0c93-47d4-8f63-8fd08eda7d61@github.com>
Message-ID: <rzmlXrsi32f5yDBYN-FfgluzxzaHAnFt8xai3j6edFc=.a85c93da-b54d-4c45-903f-f992e5923605@github.com>

On Tue, 6 May 2025 10:36:29 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> In MAC, thread ID is not visible when user hover on thread name. 
> Disabled the text wrap to fix the issue.
> 
> **Issue:**
> <img width="1401" alt="8395_Bug" src="https://github.com/user-attachments/assets/e1c34a23-195e-4cd0-b1ec-c37f0b512b89" />
> 
> **Fix:**
> <img width="1420" alt="8395_Fix" src="https://github.com/user-attachments/assets/8994ee05-2066-4d79-bfb0-cc1b8d0dc46c" />

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/648#pullrequestreview-2822558393

From vpurnam at openjdk.org  Thu May  8 04:37:57 2025
From: vpurnam at openjdk.org (Virag Purnam)
Date: Thu, 8 May 2025 04:37:57 GMT
Subject: Integrated: 8395: Thread ID is not properly visible on hover for Mac
In-Reply-To: <Uxl-3Y82hq_MqGIz_Onygek4uhRk3adwF_vHjXakDbQ=.49eddd81-0c93-47d4-8f63-8fd08eda7d61@github.com>
References: <Uxl-3Y82hq_MqGIz_Onygek4uhRk3adwF_vHjXakDbQ=.49eddd81-0c93-47d4-8f63-8fd08eda7d61@github.com>
Message-ID: <N68SIsvqG1r53IkFyGY3_5cdZbVNRxXsKQd48aI-FdM=.0675c599-b14a-4487-95a2-09d282299397@github.com>

On Tue, 6 May 2025 10:36:29 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> In MAC, thread ID is not visible when user hover on thread name. 
> Disabled the text wrap to fix the issue.
> 
> **Issue:**
> <img width="1401" alt="8395_Bug" src="https://github.com/user-attachments/assets/e1c34a23-195e-4cd0-b1ec-c37f0b512b89" />
> 
> **Fix:**
> <img width="1420" alt="8395_Fix" src="https://github.com/user-attachments/assets/8994ee05-2066-4d79-bfb0-cc1b8d0dc46c" />

This pull request has now been integrated.

Changeset: 62574d87
Author:    Virag Purnam <vpurnam at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/62574d874b7c30b8080c083aa1ac27441fa04241
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8395: Thread ID is not properly visible on hover for Mac

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/648

From hdafgard at openjdk.org  Tue May 13 16:30:57 2025
From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Tue, 13 May 2025 16:30:57 GMT
Subject: RFR: 8392: Memory view on MacOS keeps reverting to aggregate trace
 list
In-Reply-To: <GeVYp9b8JbLrFsmsN7onFtAUHaBS1qCNf8mz6V-q22E=.f1044c3b-55e4-4b26-8057-fac10cab37da@github.com>
References: <GeVYp9b8JbLrFsmsN7onFtAUHaBS1qCNf8mz6V-q22E=.f1044c3b-55e4-4b26-8057-fac10cab37da@github.com>
Message-ID: <IbhW5WQCWXXWu2maF1Y7eG3B7-C7stix4Fp99B6f4zk=.4aee9602-62b9-421e-b1eb-1305f089ec41@github.com>

On Thu, 1 May 2025 20:29:43 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Annoying issue.

Marked as reviewed by hdafgard (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/647#pullrequestreview-2837432532

From hirt at openjdk.org  Tue May 13 21:39:58 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 13 May 2025 21:39:58 GMT
Subject: Integrated: 8392: Memory view on MacOS keeps reverting to aggregate
 trace list
In-Reply-To: <GeVYp9b8JbLrFsmsN7onFtAUHaBS1qCNf8mz6V-q22E=.f1044c3b-55e4-4b26-8057-fac10cab37da@github.com>
References: <GeVYp9b8JbLrFsmsN7onFtAUHaBS1qCNf8mz6V-q22E=.f1044c3b-55e4-4b26-8057-fac10cab37da@github.com>
Message-ID: <hEgezeu4oo5oGFQ4p95x7oY3ZVAPo-dQZgJkR9SKiXc=.b0416557-3b1c-46c3-9472-67199dfc86ed@github.com>

On Thu, 1 May 2025 20:29:43 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Annoying issue.

This pull request has now been integrated.

Changeset: db49d805
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/db49d80568fa7bf6f94320c542bb75625069dd26
Stats:     23 lines in 2 files changed: 16 ins; 0 del; 7 mod

8392: Memory view on MacOS keeps reverting to aggregate trace list

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.org/jmc/pull/647

From hirt at openjdk.org  Mon May 19 20:02:32 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 19 May 2025 20:02:32 GMT
Subject: RFR: 8394: Views should not be named view
Message-ID: <K4jujp1MEmPNYWBeP-vT--RkEb3ZT5jE_t8EH_d7dRo=.a3b87061-02d2-4f16-a4b0-c33625aaf3e2@github.com>

Generally speaking I know of only one view in Eclipse named *View - the Progress View, and that one should probably be renamed too.

-------------

Commit messages:
 - 8394: Views should not be named view

Changes: https://git.openjdk.org/jmc/pull/649/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=649&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8394
  Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jmc/pull/649.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/649/head:pull/649

PR: https://git.openjdk.org/jmc/pull/649

From hirt at openjdk.org  Mon May 19 23:54:09 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 19 May 2025 23:54:09 GMT
Subject: RFR: 8399: Fixing the IOPage tests
Message-ID: <VPOkzQ7kGgg3sOeI1N3BcOYbrDAXXb1Q45IqGKsMJU0=.accd7199-5ea6-4647-8380-cf0b35420b8f@github.com>

[JMC-8370](https://bugs.openjdk.org/browse/JMC-8370) introduced an additional percentile, which now makes the UI tests fail.

-------------

Commit messages:
 - 8399: Fixing the SocketIOPage tests

Changes: https://git.openjdk.org/jmc/pull/650/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=650&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8399
  Stats: 7 lines in 3 files changed: 2 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jmc/pull/650.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/650/head:pull/650

PR: https://git.openjdk.org/jmc/pull/650

From erik.gahlin at oracle.com  Wed May 21 16:05:46 2025
From: erik.gahlin at oracle.com (Erik Gahlin)
Date: Wed, 21 May 2025 16:05:46 +0000
Subject: New throttle setting
Message-ID: <DS7PR10MB5118881855DC2C425773111D9D9EA@DS7PR10MB5118.namprd10.prod.outlook.com>

Hello,

I'm planning to add rate-limited sampling to Java events. It will work similarly to the JVM event jdk.ObjectAllocationSample today. Hopefully, it will make it into JDK 25. I mention this because it may have an impact on JMC. The following events will get a new setting called "throttle", where a rate can be specified.

 - jdk.SocketRead
 - jdk.SocketWrite
 - jdk.FileRead
 - jdk.FileWrite
 - jdk.JavaExceptionThrow

The filtering will happen after the threshold setting has been applied. The purpose of the new setting is to have more events enabled by default. The threshold for I/O events today is 20 ms, which is rather high to avoid high CPU usage and buffers being flooded in pathological applications.

It may be possible to set the threshold to 0 ms for I/O events when rate-limited sampling is in use in the default configuration, but I'm worried about regressions, so the current plan is to set the threshold to 1 ms and throttle to 300/s. For the profile configuration, the threshold will be set to 0 ms and the rate increased to 600/s.

The jdk.JavaErrorThrow event will continue to work as before.

Long-term, the plan is to sample exceptions per allocation site and remove jdk.JavaErrorThrow. The implementation is more complicated, but  I think this will be an improvement for now.

For JDK 25, the plan is to add control options for method timing and tracing, as part of JEP 520: JFR Method Timing & Tracing. I noticed that the new options will fill the recording wizard, so not all options are visible. The dialog is too small. If we get throttling for I/O and exceptions into JDK 25, the exception combobox and I/O threshold text box can be removed, so it will be fine without any code changes to JMC.

If you have questions, please let me know, either here or on the JMC Slack channel.

Thanks,
Erik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jmc-dev/attachments/20250521/c1def745/attachment.htm>

From hdafgard at openjdk.org  Wed May 21 17:21:00 2025
From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Wed, 21 May 2025 17:21:00 GMT
Subject: RFR: 8394: Views should not be named view
In-Reply-To: <K4jujp1MEmPNYWBeP-vT--RkEb3ZT5jE_t8EH_d7dRo=.a3b87061-02d2-4f16-a4b0-c33625aaf3e2@github.com>
References: <K4jujp1MEmPNYWBeP-vT--RkEb3ZT5jE_t8EH_d7dRo=.a3b87061-02d2-4f16-a4b0-c33625aaf3e2@github.com>
Message-ID: <JjcHZ1NSpOTi-S5ZmJYyJ-_p4l4Z3aLP79O7Wdp4AZo=.55ca4896-44cb-421b-9298-4f6394f58912@github.com>

On Mon, 19 May 2025 19:58:12 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Generally speaking I know of only one view in Eclipse named *View - the Progress View, and that one should probably be renamed too.

Marked as reviewed by hdafgard (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/649#pullrequestreview-2858574923

From hdafgard at openjdk.org  Wed May 21 17:22:00 2025
From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Wed, 21 May 2025 17:22:00 GMT
Subject: RFR: 8399: Fixing the IOPage tests
In-Reply-To: <VPOkzQ7kGgg3sOeI1N3BcOYbrDAXXb1Q45IqGKsMJU0=.accd7199-5ea6-4647-8380-cf0b35420b8f@github.com>
References: <VPOkzQ7kGgg3sOeI1N3BcOYbrDAXXb1Q45IqGKsMJU0=.accd7199-5ea6-4647-8380-cf0b35420b8f@github.com>
Message-ID: <0mfX2rao9n1HmD3EBWHXfJTks58xLH0EwpZV49aa_zc=.650c2304-3351-44bc-af7f-0c4ed3eb51a0@github.com>

On Mon, 19 May 2025 23:50:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> [JMC-8370](https://bugs.openjdk.org/browse/JMC-8370) introduced an additional percentile, which now makes the UI tests fail.

Marked as reviewed by hdafgard (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/650#pullrequestreview-2858575782

From hirt at openjdk.org  Wed May 21 17:39:57 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 21 May 2025 17:39:57 GMT
Subject: Integrated: 8394: Views should not be named view
In-Reply-To: <K4jujp1MEmPNYWBeP-vT--RkEb3ZT5jE_t8EH_d7dRo=.a3b87061-02d2-4f16-a4b0-c33625aaf3e2@github.com>
References: <K4jujp1MEmPNYWBeP-vT--RkEb3ZT5jE_t8EH_d7dRo=.a3b87061-02d2-4f16-a4b0-c33625aaf3e2@github.com>
Message-ID: <wnNCtCf-uTt5-UoTMSxItTUgKsYn9RJvcm0yRfIDAdQ=.bed4da79-0b89-48e9-9cdd-cd4bd7ac63d8@github.com>

On Mon, 19 May 2025 19:58:12 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Generally speaking I know of only one view in Eclipse named *View - the Progress View, and that one should probably be renamed too.

This pull request has now been integrated.

Changeset: a0c39bc4
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/a0c39bc4c144f3ad0f4756eeb1de896bb749961f
Stats:     3 lines in 3 files changed: 0 ins; 0 del; 3 mod

8394: Views should not be named view

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.org/jmc/pull/649

From schaturvedi at openjdk.org  Wed May 21 17:43:57 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Wed, 21 May 2025 17:43:57 GMT
Subject: Integrated: 8385: Upgrade hashing algorithm
In-Reply-To: <MzYZu9QbK6VUFUgDHTjhZmqiwqr6CvgPOATLupIO1yY=.6e8d60c3-8a22-401d-b4d7-9a53180b45b4@github.com>
References: <MzYZu9QbK6VUFUgDHTjhZmqiwqr6CvgPOATLupIO1yY=.6e8d60c3-8a22-401d-b4d7-9a53180b45b4@github.com>
Message-ID: <7HsVqbnPozT6ZqaayicGrjHE0aWCSL8qeREefuIss8w=.3a97d778-be29-44bf-bb58-6a241a228d8f@github.com>

On Mon, 21 Apr 2025 10:18:49 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Upgrading hashing algorithm as part of this PR.

This pull request has now been integrated.

Changeset: e2005f3a
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/e2005f3a0f006f94ff80390944e81d78d9a4e2bc
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8385: Upgrade hashing algorithm

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/641

From hirt at openjdk.org  Wed May 21 17:43:57 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 21 May 2025 17:43:57 GMT
Subject: RFR: 8385: Upgrade hashing algorithm [v2]
In-Reply-To: <JcWuB4XEjybFJe5WwMF9ZcKrldMuU8wWpDpbutBvkoQ=.bdeeab8e-fa7a-416f-a558-458de35dd498@github.com>
References: <MzYZu9QbK6VUFUgDHTjhZmqiwqr6CvgPOATLupIO1yY=.6e8d60c3-8a22-401d-b4d7-9a53180b45b4@github.com>
 <JcWuB4XEjybFJe5WwMF9ZcKrldMuU8wWpDpbutBvkoQ=.bdeeab8e-fa7a-416f-a558-458de35dd498@github.com>
Message-ID: <B3wOvsqpnkGuKYFZes_VBT7o83ruOfJ2evnMTWVtkgk=.f0177624-532b-45a3-8828-949b26281eaa@github.com>

On Sun, 4 May 2025 09:23:29 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Upgrading hashing algorithm as part of this PR.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated the name of hashing algorithm

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/641#pullrequestreview-2858624723

From marcus at hirt.se  Thu May 22 10:10:44 2025
From: marcus at hirt.se (Marcus Hirt)
Date: Thu, 22 May 2025 12:10:44 +0200
Subject: New throttle setting
In-Reply-To: <DS7PR10MB5118881855DC2C425773111D9D9EA@DS7PR10MB5118.namprd10.prod.outlook.com>
References: <DS7PR10MB5118881855DC2C425773111D9D9EA@DS7PR10MB5118.namprd10.prod.outlook.com>
Message-ID: <293601dbcb01$c7c7d690$575783b0$@hirt.se>

Hi Erik,

Thanks for the update!

One thing that is making the jdk.ObjectAllocationSample event particularly useful is that there is information about the distance between the samples  (the amount of memory allocated), meaning that there is a weight associated with each sample, helping to properly gauge the contribution associated with that sample relative other samples. Is there a plan to do extend these throttled events in a similar fashion? For example, JavaExceptionThrow could indicate the number of exceptions since the last sampled event, and the I/O events could report the number of bytes read/written since the previous sample. 

Also, do you have a sense of when we?ll know whether this will land in JDK 25? Since JDK 25 is targeted for September (if I remember correctly), and JMC 10 isn?t expected until October 2026 (https://wiki.openjdk.org/display/jmc/Releases), we may want to consider planning for an additional JMC 9.x if there is work required to support the changes in JDK 25.

Kind regards,
Marcus

--- 
From: jmc-dev <jmc-dev-retn at openjdk.org> On Behalf Of Erik Gahlin
Sent: Wednesday, 21 May 2025 18:06
To: jmc-dev at openjdk.org
Subject: New throttle setting

Hello,

I'm planning to add rate-limited sampling to Java events. It will work similarly to the JVM event jdk.ObjectAllocationSample today. Hopefully, it will make it into JDK 25. I mention this because it may have an impact on JMC. The following events will get a new setting called "throttle", where a rate can be specified.

 - jdk.SocketRead
 - jdk.SocketWrite
 - jdk.FileRead
 - jdk.FileWrite
 - jdk.JavaExceptionThrow

The filtering will happen after the threshold setting has been applied. The purpose of the new setting is to have more events enabled by default. The threshold for I/O events today is 20 ms, which is rather high to avoid high CPU usage and buffers being flooded in pathological applications.

It may be possible to set the threshold to 0 ms for I/O events when rate-limited sampling is in use in the default configuration, but I'm worried about regressions, so the current plan is to set the threshold to 1 ms and throttle to 300/s. For the profile configuration, the threshold will be set to 0 ms and the rate increased to 600/s.

The jdk.JavaErrorThrow event will continue to work as before.

Long-term, the plan is to sample exceptions per allocation site and remove jdk.JavaErrorThrow. The implementation is more complicated, but  I think this will be an improvement for now.

For JDK 25, the plan is to add control options for method timing and tracing, as part of JEP 520: JFR Method Timing & Tracing. I noticed that the new options will fill the recording wizard, so not all options are visible. The dialog is too small. If we get throttling for I/O and exceptions into JDK 25, the exception combobox and I/O threshold text box can be removed, so it will be fine without any code changes to JMC.

If you have questions, please let me know, either here or on the JMC Slack channel.

Thanks,
Erik



From hirt at openjdk.org  Thu May 22 20:14:59 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 22 May 2025 20:14:59 GMT
Subject: Integrated: 8399: IOPageTest fails
In-Reply-To: <VPOkzQ7kGgg3sOeI1N3BcOYbrDAXXb1Q45IqGKsMJU0=.accd7199-5ea6-4647-8380-cf0b35420b8f@github.com>
References: <VPOkzQ7kGgg3sOeI1N3BcOYbrDAXXb1Q45IqGKsMJU0=.accd7199-5ea6-4647-8380-cf0b35420b8f@github.com>
Message-ID: <Ikb3KWR-25aQ5ZRFigzN_io0PZ-Dm__FvAaj24mq5Fw=.de9a41b5-2271-4f09-9f8e-2e09419a75ad@github.com>

On Mon, 19 May 2025 23:50:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> [JMC-8370](https://bugs.openjdk.org/browse/JMC-8370) introduced an additional percentile, which now makes the UI tests fail.

This pull request has now been integrated.

Changeset: ce1b0677
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/ce1b06774583b916554ae9bf1d6366012a362119
Stats:     7 lines in 3 files changed: 2 ins; 0 del; 5 mod

8399: IOPageTest fails

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.org/jmc/pull/650

From schaturvedi at openjdk.org  Sun May 25 15:33:28 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sun, 25 May 2025 15:33:28 GMT
Subject: RFR: 8401: Remove weak cipher usages in JMC Secure Store
Message-ID: <B72lwctx1B4g6-bLeji3DqdYyP_1J7ngdrbmqflGzvA=.5cc9ee7f-1257-477b-b278-9d1ade7dc839@github.com>

Using stronger cipher algorithms and getting rid of weak cipher algorithms.

-------------

Commit messages:
 - 8401: Remove weak cipher usages in JMC Secure Store

Changes: https://git.openjdk.org/jmc/pull/651/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=651&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8401
  Stats: 110 lines in 2 files changed: 79 ins; 26 del; 5 mod
  Patch: https://git.openjdk.org/jmc/pull/651.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/651/head:pull/651

PR: https://git.openjdk.org/jmc/pull/651

From hirt at openjdk.org  Tue May 27 14:04:57 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 27 May 2025 14:04:57 GMT
Subject: RFR: 8401: Remove weak cipher usages in JMC Secure Store
In-Reply-To: <B72lwctx1B4g6-bLeji3DqdYyP_1J7ngdrbmqflGzvA=.5cc9ee7f-1257-477b-b278-9d1ade7dc839@github.com>
References: <B72lwctx1B4g6-bLeji3DqdYyP_1J7ngdrbmqflGzvA=.5cc9ee7f-1257-477b-b278-9d1ade7dc839@github.com>
Message-ID: <eW3DBeoiE0Yj4Nmj-l09wp_fDh3yjCPrm-lLoIkRM4M=.f823be87-3185-4b28-8ae2-9a54304860ec@github.com>

On Sun, 25 May 2025 15:28:37 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Using stronger cipher algorithms and getting rid of weak cipher algorithms.

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/651#pullrequestreview-2871225521

From schaturvedi at openjdk.org  Thu May 29 11:33:57 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 29 May 2025 11:33:57 GMT
Subject: Integrated: 8401: Remove weak cipher usages in JMC Secure Store
In-Reply-To: <B72lwctx1B4g6-bLeji3DqdYyP_1J7ngdrbmqflGzvA=.5cc9ee7f-1257-477b-b278-9d1ade7dc839@github.com>
References: <B72lwctx1B4g6-bLeji3DqdYyP_1J7ngdrbmqflGzvA=.5cc9ee7f-1257-477b-b278-9d1ade7dc839@github.com>
Message-ID: <yTH-EvckSu3tZXdVfKMS7KkrTxoDgl7X2FCN2Xl-D7Q=.86ebb09d-c7a0-4897-bbe3-64cde50d8ad2@github.com>

On Sun, 25 May 2025 15:28:37 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Using stronger cipher algorithms and getting rid of weak cipher algorithms.

This pull request has now been integrated.

Changeset: 2458719d
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/2458719dcc9bc11e94fb21226f6e5e0f1bdab740
Stats:     110 lines in 2 files changed: 79 ins; 26 del; 5 mod

8401: Remove weak cipher usages in JMC Secure Store

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/651

From hirt at openjdk.org  Sat May 31 22:31:34 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Sat, 31 May 2025 22:31:34 GMT
Subject: RFR: 8400: Add more show options for JMX Console graphs
Message-ID: <PlUXb8yV51V5BufXknA-MuDQLCR47tOXQXPUZU4Zo1Q=.af52bece-24ae-45d3-a0ca-f902fbdde4d0@github.com>

Also cleaning up a little bit. There were some assumptions around the default XY chart that should be put in code etc.

-------------

Commit messages:
 - Cleanup. Ensuring that the axis is responsible for bounds.
 - 8400: Add more show options for JMX Console graphs

Changes: https://git.openjdk.org/jmc/pull/652/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=652&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8400
  Stats: 874 lines in 15 files changed: 692 ins; 55 del; 127 mod
  Patch: https://git.openjdk.org/jmc/pull/652.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/652/head:pull/652

PR: https://git.openjdk.org/jmc/pull/652

From hirt at openjdk.org  Sat May 31 22:41:10 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Sat, 31 May 2025 22:41:10 GMT
Subject: RFR: 8400: Add more show options for JMX Console graphs [v2]
In-Reply-To: <PlUXb8yV51V5BufXknA-MuDQLCR47tOXQXPUZU4Zo1Q=.af52bece-24ae-45d3-a0ca-f902fbdde4d0@github.com>
References: <PlUXb8yV51V5BufXknA-MuDQLCR47tOXQXPUZU4Zo1Q=.af52bece-24ae-45d3-a0ca-f902fbdde4d0@github.com>
Message-ID: <e-PbNrq0v1duCCPuj97L5YtLn6j2haQCvKXPXdahzMA=.f3ba6e96-634f-4248-88ae-0c19ab20a9f8@github.com>

> Also cleaning up a little bit. There were some assumptions around the default XY chart that should be put in code etc.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Spotless

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/652/files
  - new: https://git.openjdk.org/jmc/pull/652/files/83fa46d6..8cb62f9b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=652&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=652&range=00-01

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/652.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/652/head:pull/652

PR: https://git.openjdk.org/jmc/pull/652

From jplane.tech at gmail.com  Sat May 31 17:27:18 2025
From: jplane.tech at gmail.com (Joe Lane)
Date: Sat, 31 May 2025 17:27:18 -0000
Subject: Requesting a Slack Channel Invite!
Message-ID: <CAAC8vjXfg4BoqQ9MT9knHCF0q-QnFXji3qdSN3Y4dE3Lhb55qQ@mail.gmail.com>

Hello there!

I'm interested in learning more about JMC, JFRs, and possibly contributing.

I'm using these tools on a daily basis and as a user (and possible
contributor) I'm interested in enhancing the ecosystem.

Thanks,
Joe Lane
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jmc-dev/attachments/20250531/28c94ebc/attachment.htm>