From aharmaz at openjdk.org  Fri Nov  7 14:05:10 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Fri, 7 Nov 2025 14:05:10 GMT
Subject: RFR: 8469: Should make rules and page heading accessible through
 keyboard in JFR overview page
Message-ID: <nrSc_wDUvgMPzFmKmPfmINq7-chpVBOvPBM0-lMAyQI=.32fbeb18-3c21-408c-9583-e9be1144efcc@github.com>

This PR makes it possible to reach JFR result pages and expand / collapse rule text on the JFR result overview using keyboard enter and tab keys.

<img width="1067" height="480" alt="focused-rule" src="https://github.com/user-attachments/assets/df38672e-4882-420a-8e45-f7f3f33349cd" />

<img width="1067" height="480" alt="expanded-rule-using-enter-key" src="https://github.com/user-attachments/assets/ec45e75b-48f6-424b-a8e7-7bc5b34bae0e" />

-------------

Commit messages:
 - 8469: Should make rules and page heading accessible through keyboard in JFR overview page

Changes: https://git.openjdk.org/jmc/pull/683/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=683&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8469
  Stats: 17 lines in 3 files changed: 15 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/683.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/683/head:pull/683

PR: https://git.openjdk.org/jmc/pull/683

From aharmaz at openjdk.org  Mon Nov 10 08:58:55 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Mon, 10 Nov 2025 08:58:55 GMT
Subject: RFR: 8470: Unresolved placeholders shown in JFR result overview's
 table mode
Message-ID: <c7zl7XGwAV724GtPPo9Nnj-sxiZI5qcLs4fD5BCd-4E=.9d8cc377-745e-4c71-b255-6a0b3b2a4aa9@github.com>

This PR populates the summary, explanation, and solution fields of a rule displayed in the result overview table with the actual evaluated values.

The following screenshots show the state before and after the change.

<img width="1106" height="220" alt="unmapped-placeholders" src="https://github.com/user-attachments/assets/af4faee4-4e97-456a-b4a7-3e51fdc5e6a6" />

<img width="1085" height="206" alt="resolved placeholders" src="https://github.com/user-attachments/assets/3df6354a-39de-44c0-8a8d-5aa0e8687f0f" />

-------------

Commit messages:
 - 8470: Unresolved placeholders shown in JFR result overview's table mode

Changes: https://git.openjdk.org/jmc/pull/684/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=684&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8470
  Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jmc/pull/684.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/684/head:pull/684

PR: https://git.openjdk.org/jmc/pull/684

From aharmaz at openjdk.org  Wed Nov 12 09:42:55 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Wed, 12 Nov 2025 09:42:55 GMT
Subject: RFR: 8335: Duplicate values in tooltip for RSS and RSS (Peak) in
 memory tab
Message-ID: <JXskYDGb2Rz7V7jKfhF3cP9TJBb5F2zez7AGkaA3MOA=.a65d86c5-19e0-4293-81f2-81991022190b@github.com>

This PR makes sure, we do not add attributes twice to the same renderer on the memory page

The issue : 
- The supplier used for merging events was having a side effect (calls to methods adding attributes to the same renderer) 
- The supplier was consumed twice leading to the side effect being executed twice and that is mainly what causes the tooltip to contain duplicated attributes on the memory page 

The following screenshots respectively show the tooltips before and after the change

<img width="1082" height="375" alt="tooltip-before" src="https://github.com/user-attachments/assets/824b883d-6941-4100-9d90-54bb4e184aaa" />

<img width="1308" height="277" alt="tooltip-fixed" src="https://github.com/user-attachments/assets/505cdcf3-1d70-4c6d-a195-325614e405d0" />

-------------

Commit messages:
 - 8335: Duplicate values in tooltip for RSS and RSS (Peak) in memory tab

Changes: https://git.openjdk.org/jmc/pull/685/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=685&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8335
  Stats: 6 lines in 1 file changed: 4 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/685.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/685/head:pull/685

PR: https://git.openjdk.org/jmc/pull/685

From schaturvedi at openjdk.org  Mon Nov 17 10:27:36 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Mon, 17 Nov 2025 10:27:36 GMT
Subject: Withdrawn: 5561: Support for Crypto Events in JMC
In-Reply-To: <mV2RVfDpwqgDwadhDAShlmS4Z0-M14GXiFftir_KV_Y=.14235a7c-f673-4443-9997-aeb5292d1a8b@github.com>
References: <mV2RVfDpwqgDwadhDAShlmS4Z0-M14GXiFftir_KV_Y=.14235a7c-f673-4443-9997-aeb5292d1a8b@github.com>
Message-ID: <RB5IfmV_eQqucaTA80KEqkEonbomEFD-H91Wieus-tU=.5a7dd621-144f-4ab1-adf6-83a2401d2e7a@github.com>

On Wed, 22 Oct 2025 15:33:50 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR enhances the JMC UI for adding new information related to crypto events: specifically X509CertificateEvent.
> 
> This PR adds a new rule with respect to X509CertificateEvent which provides alert related to expired/expiring certificates and weak signature algorithms or weak key length or key type. The rule gives a basic overview, however complete details are provided as part of a new screen - Security.
> 
> Attaching the screenshots here for better reference:
> 
> <img width="356" height="61" alt="image" src="https://github.com/user-attachments/assets/97395a02-9626-4bc8-933c-a11d3f8157bd" />
> 
> <img width="959" height="505" alt="image" src="https://github.com/user-attachments/assets/9d8a74f0-0302-4e72-8933-2b58dfe9ba42" />

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jmc/pull/680

From schaturvedi at openjdk.org  Mon Nov 17 10:51:13 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Mon, 17 Nov 2025 10:51:13 GMT
Subject: RFR: 5561: Support for Crypto Events in JMC
Message-ID: <L3Wlpr7zk0rQE9qSVzkTehMZtHUwr141I2ZFjOF0060=.7ceacbf6-67d0-462d-a35e-7d135046ec42@github.com>

This PR enhances the JMC UI for adding new information related to crypto events: specifically X509CertificateEvent.

This PR adds a new rule with respect to X509CertificateEvent which provides alert related to expired/expiring certificates and weak signature algorithms or weak key length or key type. The rule gives a basic overview of all the certificate ids which needs action or attention, however complete details are provided as part of a new screen - Security.

Attaching the screenshots here for better reference:

Rule Page:

<img width="362" height="373" alt="image" src="https://github.com/user-attachments/assets/4707e6b2-76be-4b1e-9f32-c6139851d86c" />

Security Screen Page:

<img width="959" height="385" alt="image" src="https://github.com/user-attachments/assets/5026e2b7-2754-47bc-a42d-5672f9f087d7" />

-------------

Commit messages:
 - 5561: Support for Crypto Events in JMC

Changes: https://git.openjdk.org/jmc/pull/686/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=686&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-5561
  Stats: 1353 lines in 31 files changed: 1353 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/686.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/686/head:pull/686

PR: https://git.openjdk.org/jmc/pull/686

From hdafgard at openjdk.org  Thu Nov 20 15:39:31 2025
From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Thu, 20 Nov 2025 15:39:31 GMT
Subject: RFR: 8335: Duplicate values in tooltip for RSS and RSS (Peak) in
 memory tab
In-Reply-To: <JXskYDGb2Rz7V7jKfhF3cP9TJBb5F2zez7AGkaA3MOA=.a65d86c5-19e0-4293-81f2-81991022190b@github.com>
References: <JXskYDGb2Rz7V7jKfhF3cP9TJBb5F2zez7AGkaA3MOA=.a65d86c5-19e0-4293-81f2-81991022190b@github.com>
Message-ID: <rFzx7Let_kT-85jWKKdctQzRmh4ht5javegY7ExeeJ8=.a5ea4421-9fb6-4ea8-8c4a-b59b80c4a8a3@github.com>

On Wed, 12 Nov 2025 09:38:16 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR makes sure, we do not add attributes twice to the same renderer on the memory page
> 
> The issue : 
> - The supplier used for merging events was having a side effect (calls to methods adding attributes to the same renderer) 
> - The supplier was consumed twice leading to the side effect being executed twice and that is mainly what causes the tooltip to contain duplicated attributes on the memory page 
> 
> The following screenshots respectively show the tooltips before and after the change
> 
> <img width="1082" height="375" alt="tooltip-before" src="https://github.com/user-attachments/assets/824b883d-6941-4100-9d90-54bb4e184aaa" />
> 
> <img width="1308" height="277" alt="tooltip-fixed" src="https://github.com/user-attachments/assets/505cdcf3-1d70-4c6d-a195-325614e405d0" />

Marked as reviewed by hdafgard (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/685#pullrequestreview-3488521490

From hdafgard at openjdk.org  Thu Nov 20 15:42:13 2025
From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Thu, 20 Nov 2025 15:42:13 GMT
Subject: RFR: 8470: Unresolved placeholders shown in JFR result overview's
 table mode
In-Reply-To: <c7zl7XGwAV724GtPPo9Nnj-sxiZI5qcLs4fD5BCd-4E=.9d8cc377-745e-4c71-b255-6a0b3b2a4aa9@github.com>
References: <c7zl7XGwAV724GtPPo9Nnj-sxiZI5qcLs4fD5BCd-4E=.9d8cc377-745e-4c71-b255-6a0b3b2a4aa9@github.com>
Message-ID: <oo_Z-oxpJw9SiD0DO9_6NBJh5nVwnQOrZl_DW9dPS9c=.4f52c100-fb03-4f46-8bda-e79c4c4321c9@github.com>

On Mon, 10 Nov 2025 08:51:46 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR populates the summary, explanation, and solution fields of a rule displayed in the result overview table with the actual evaluated values.
> 
> The following screenshots show the state before and after the change.
> 
> <img width="1106" height="220" alt="unmapped-placeholders" src="https://github.com/user-attachments/assets/af4faee4-4e97-456a-b4a7-3e51fdc5e6a6" />
> 
> <img width="1085" height="206" alt="resolved placeholders" src="https://github.com/user-attachments/assets/3df6354a-39de-44c0-8a8d-5aa0e8687f0f" />

Marked as reviewed by hdafgard (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/684#pullrequestreview-3488526925

From duke at openjdk.org  Mon Nov 24 11:12:01 2025
From: duke at openjdk.org (duke)
Date: Mon, 24 Nov 2025 11:12:01 GMT
Subject: RFR: 8470: Unresolved placeholders shown in JFR result overview's
 table mode
In-Reply-To: <c7zl7XGwAV724GtPPo9Nnj-sxiZI5qcLs4fD5BCd-4E=.9d8cc377-745e-4c71-b255-6a0b3b2a4aa9@github.com>
References: <c7zl7XGwAV724GtPPo9Nnj-sxiZI5qcLs4fD5BCd-4E=.9d8cc377-745e-4c71-b255-6a0b3b2a4aa9@github.com>
Message-ID: <Yu8PTzWWB4UqNPDOLz0P5JN99oDWCgJOJReDJvt1vz0=.b3ebce18-b381-43bc-a48f-7c36bcb2195b@github.com>

On Mon, 10 Nov 2025 08:51:46 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR populates the summary, explanation, and solution fields of a rule displayed in the result overview table with the actual evaluated values.
> 
> The following screenshots show the state before and after the change.
> 
> <img width="1106" height="220" alt="unmapped-placeholders" src="https://github.com/user-attachments/assets/af4faee4-4e97-456a-b4a7-3e51fdc5e6a6" />
> 
> <img width="1085" height="206" alt="resolved placeholders" src="https://github.com/user-attachments/assets/3df6354a-39de-44c0-8a8d-5aa0e8687f0f" />

@aymane-harmaz 
Your change (at version 580b35f4760628f2795d50ee44e6186aea7d04cc) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/684#issuecomment-3570205557

From duke at openjdk.org  Mon Nov 24 11:12:10 2025
From: duke at openjdk.org (duke)
Date: Mon, 24 Nov 2025 11:12:10 GMT
Subject: RFR: 8335: Duplicate values in tooltip for RSS and RSS (Peak) in
 memory tab
In-Reply-To: <JXskYDGb2Rz7V7jKfhF3cP9TJBb5F2zez7AGkaA3MOA=.a65d86c5-19e0-4293-81f2-81991022190b@github.com>
References: <JXskYDGb2Rz7V7jKfhF3cP9TJBb5F2zez7AGkaA3MOA=.a65d86c5-19e0-4293-81f2-81991022190b@github.com>
Message-ID: <4vw_0cvAOmbxhDWOdK_aIzaY3dfHA3x0qX_Ut2S7BHg=.1961814e-2232-4c3a-b148-eb5928934313@github.com>

On Wed, 12 Nov 2025 09:38:16 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR makes sure, we do not add attributes twice to the same renderer on the memory page
> 
> The issue : 
> - The supplier used for merging events was having a side effect (calls to methods adding attributes to the same renderer) 
> - The supplier was consumed twice leading to the side effect being executed twice and that is mainly what causes the tooltip to contain duplicated attributes on the memory page 
> 
> The following screenshots respectively show the tooltips before and after the change
> 
> <img width="1082" height="375" alt="tooltip-before" src="https://github.com/user-attachments/assets/824b883d-6941-4100-9d90-54bb4e184aaa" />
> 
> <img width="1308" height="277" alt="tooltip-fixed" src="https://github.com/user-attachments/assets/505cdcf3-1d70-4c6d-a195-325614e405d0" />

@aymane-harmaz 
Your change (at version 97a7f2ce82b358c30b9700d4df92bb79325d92b3) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/685#issuecomment-3570204390

From aharmaz at openjdk.org  Mon Nov 24 17:36:31 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Mon, 24 Nov 2025 17:36:31 GMT
Subject: RFR: 6832: Should allow plotting line charts for all quantities
Message-ID: <iOjydd_VWy1O-7YOp24id9trousaAKK_WzY0lzVbmT8=.2e2acd01-b1c9-4237-82e7-2f6341f32438@github.com>

This PR makes sure line charts cover all the events across multiple IItemIterables, and makes it possible for linear quantities to be represented as line charts on custom pages.

-------------

Commit messages:
 - 6832: Should allow plotting line charts for all quantities

Changes: https://git.openjdk.org/jmc/pull/688/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=688&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-6832
  Stats: 34 lines in 3 files changed: 3 ins; 13 del; 18 mod
  Patch: https://git.openjdk.org/jmc/pull/688.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/688/head:pull/688

PR: https://git.openjdk.org/jmc/pull/688

From aharmaz at openjdk.org  Thu Nov 27 17:18:40 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Thu, 27 Nov 2025 17:18:40 GMT
Subject: RFR: 8473: JMC silently connects to its own runtime if target runtime
 does not include management modules
Message-ID: <LokbsxrQooo3HVCCJv9lBLShdxBbbKc36qOE4ZZyYd4=.cde5b7e4-31a7-446d-965d-c74d5fe50167@github.com>

This PR addresses the fallback behavior executed when the target jvm runtime does not contain management modules.

Instead of connecting to the jvm running JMC without informing the user, we explicitly tell the user what went wrong by letting the error propagate 

The next screenshots show the new error messages for each feature when target jvm runtime does not contain management modules

JMX Console :
<img width="534" height="419" alt="jmx-console" src="https://github.com/user-attachments/assets/57c92ba9-75a3-4383-a545-19ba1749bc35" />


Flight recording : 
<img width="534" height="419" alt="flight-recording" src="https://github.com/user-attachments/assets/65235113-6780-433f-a449-8d80e93de9f1" />


Dump Heap : 
<img width="595" height="150" alt="dump-heap" src="https://github.com/user-attachments/assets/ba11bd57-9cd5-4f51-bb0d-5c2e8c1942db" />


JMC agent : 
<img width="595" height="373" alt="jmc-agent" src="https://github.com/user-attachments/assets/9adcac52-4325-41c5-be4c-c29f3b9880ac" />



Control the remote jmx agent feature was behaving correctly on the right jvm process but in case of an error the root case was not clearly communicated to the user :
<img width="595" height="373" alt="previous-control-jmx-console" src="https://github.com/user-attachments/assets/859d2bb2-93f4-4e3c-8c70-61084e385d8e" />

In this PR the error message for controlling the remote jmx agent is explicitly displayed :
<img width="972" height="502" alt="control-jmx-agent" src="https://github.com/user-attachments/assets/e0e6f88a-99f8-43a4-80a7-95e7babbee5d" />

-------------

Commit messages:
 - 8473: JMC silently connects to its own runtime if target runtime does not include management modules

Changes: https://git.openjdk.org/jmc/pull/689/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=689&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8473
  Stats: 12 lines in 3 files changed: 0 ins; 3 del; 9 mod
  Patch: https://git.openjdk.org/jmc/pull/689.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/689/head:pull/689

PR: https://git.openjdk.org/jmc/pull/689