RFR: 8335: Duplicate values in tooltip for RSS and RSS (Peak) in memory tab
Henrik Dafgård
hdafgard at openjdk.org
Thu Nov 20 15:39:31 UTC 2025
On Wed, 12 Nov 2025 09:38:16 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:
> This PR makes sure, we do not add attributes twice to the same renderer on the memory page
>
> The issue :
> - The supplier used for merging events was having a side effect (calls to methods adding attributes to the same renderer)
> - The supplier was consumed twice leading to the side effect being executed twice and that is mainly what causes the tooltip to contain duplicated attributes on the memory page
>
> The following screenshots respectively show the tooltips before and after the change
>
> <img width="1082" height="375" alt="tooltip-before" src="https://github.com/user-attachments/assets/824b883d-6941-4100-9d90-54bb4e184aaa" />
>
> <img width="1308" height="277" alt="tooltip-fixed" src="https://github.com/user-attachments/assets/505cdcf3-1d70-4c6d-a195-325614e405d0" />
Marked as reviewed by hdafgard (Reviewer).
-------------
PR Review: https://git.openjdk.org/jmc/pull/685#pullrequestreview-3488521490
More information about the jmc-dev
mailing list